Get Closest Unit 3D v1.0.0

[Moderator]

23:06, 26th Nov 2013
Maker: You should have a trigger that returns the closest unit
and is stripped of anything extra

 

[Kazeon]

I was wondering about "how the hell can I get the closest unit" and after my brain grows a little bigger and I find the way, I just want to share it

 

[Maker]

You should have a trigger named GetClosestUnit and it should have nothing extra in int. Also, you are using map header so the system is GUI/JASS. You could get rid of the map header function.

 

[Kazeon]

first, I'm not really sure this is a system, this is actually more like a tutorials

I think I will just leave that header functions

well, I found a silly mistake. The system still counts dead units.

Updated, however, this system will stay at v1.0.0 for now..

 

[Maker]

first, I'm not really sure this is a system, this is actually more like a tutorials

Then delete it and post it here

 

[Kazeon]

I won't, there is one submission rule that I can't fulfill. it's "make a nice thread". this still can be categorized as system I think.

the map is like hanky's dynamic indexing, it gives some example how to do a correct indexing. this system do the same, it gives some examples how to get closest unit(s)

I think I will just make a function that returns the closest unit so that user can easily calls it.. but I need to learn some first..

 

[T. D. W.]

This definitely belongs in a tutorial, beside i didn't see it yet,many coders already did it, but i think it is not so acceptable in this section ~~ no offense

 

[Kazeon]

you know what? I do think so

 

[T. D. W.]

Lol, ok xD
And just a tip:
A tutorial doesn't need to be extraordinary, by this i mean, be colorful, full of screenshots, really neat and so on.. It can be just readable, and organized, it is acceptable with that

 

[Kazeon]

yeah, the question is, how can I make a good tutorial about something that I don't really master it?

 

[T. D. W.]

Oh
I'll help you if you want, i will look at the code and review it, the big review version xD (explanation: i sometimes review a big one if i have time and not lazy, the result is somehow the review of jakezinc, and sometimes i just don't feel like it and the result is, a small review )

 

[Kazeon]

no need. beside, I will stop uploading junk here and get back to my main project I will just delete this one, tomorrow..

 

[Xonok]

For the group order part, I'm working on something.

Also, dunno about 3D, but in 2D I've made a quite simple function for getting closest unit.

function ClosestUnitLoop takes nothing returns nothing
        local unit u = GetEnumUnit()
        local real x = GetUnitX(u) - ExtraX
        local real y = GetUnitY(u) - ExtraY
        local real r = SquareRoot(x * x + y * y)
        if r < ExtraReal then
            set ExtraReal = r
            set ExtraUnit = u
        endif
        set u = null
    endfunction
function GetClosestUnitOfGroup takes group g,real x,real y returns unit
        set ExtraReal = 100000
        set ExtraX = x
        set ExtraY = y
        call ForGroup(g, function ClosestUnitLoop)
        return ExtraUnit
endfunction

The function is a part of my ExtraFunctions library, which I haven't published though.

 

[Kazeon]

yours is 3D already because it uses phytagoras.. I'm trying to make a function too so that user can easily calls it and get the result.

 

[Xonok]

yours is 3D already because it uses phytagoras.. I'm trying to make a function too so that user can easily calls it and get the result.

My function uses unit X/Y. If I made the user have to provide those too, then it could also be used for 3D, but not in the current state.

 

[Maker]

Xonok, you could ditch the Squareroot and you could keep everything in one function.

 

[Kazeon]

well, 3D or not, it's not important to make a movement group, and I think using 2D is the best..

 

[T. D. W.]

WOW, it lags when it is triggered (like 1/2 of the times)

 

[Xonok]

Xonok, you could ditch the Squareroot and you could keep everything in one function.

I don't understand the math behind this entirely, so the question is how to ditch squareroot.
Also, having a subfunction seemed quite necessary, as I would not be able to use ForGroup without it.
Although I'm now thinking it might actually be possible with a FirstOfGroup loop.

well, 3D or not, it's not important to make a movement group, and I think using 2D is the best..

When you are looking for the closest unit you are always dealing with a group. That's can't really be avoided imo, so not having one actually can hamper performance(perhaps you have tons of units that you don't want to count in?)

 

[chobibo]

EDIT: Wow a lot of replies! This was for Xonok

        local real z = GetUnitHeight(u)
        local real r = SquareRoot(x*x + y*y + z*z)

 

[Maker]

I don't understand the math behind this entirely, so the question is how to ditch squareroot.

SquareRoot(a) > SquareRoot(b) works the same as a > b since the values are always >= 0.

If SquareRoot(9) > SquareRoot(4) then... versus If 9 > 4... both the same.

Although I'm now thinking it might actually be possible with a FirstOfGroup loop.

Yeah, use First of group loop.

 

[Xonok]

EDIT: Wow a lot of replies! This was for Xonok

        local real z = GetUnitHeight(u)
        local real r = SquareRoot(x*x + y*y + z*z)

Hmm, seems so logical to me now. Yet, I wouldn't have figured this out on my own.

I'll add this as an option, possibly a separate function.

EDIT:
For the sake of simplicity I also added wrappers to take a unit instead of coordinates.

    function ClosestUnitLoop takes nothing returns nothing
        local unit u = GetEnumUnit()
        local real x = GetUnitX(u) - ExtraX
        local real y = GetUnitY(u) - ExtraY
        local real r = SquareRoot(x * x + y * y)
        if r < ExtraReal then
            set ExtraReal = r
            set ExtraUnit = u
        endif
        set u = null
    endfunction
    
    function ClosestUnitLoopZ takes nothing returns nothing
        local unit u = GetEnumUnit()
        local real x = GetUnitX(u) - ExtraX
        local real y = GetUnitY(u) - ExtraY
        local real z
        local real r
        local location l = Location(x,y)
        set z = GetLocationZ(l)
        call RemoveLocation(l)
        set l = null
        set r = SquareRoot(x * x + y * y + z * z)
        if r < ExtraReal then
            set ExtraReal = r
            set ExtraUnit = u
        endif
        set u = null
    endfunction
    function GetClosestUnitOfGroup takes group g,real x,real y returns unit
        set ExtraReal = 100000
        set ExtraX = x
        set ExtraY = y
        call ForGroup(g, function ClosestUnitLoop)
        return ExtraUnit
    endfunction
    
    function GetClosestUnitOfGroupEx takes group g,unit u returns unit
        set ExtraReal = 100000
        set ExtraX = GetUnitX(u)
        set ExtraY = GetUnitY(u)
        call ForGroup(g, function ClosestUnitLoop)
        return ExtraUnit
    endfunction
    
    function GetClosestUnitOfGroupZ takes group g,real x,real y,real z returns unit
        set ExtraReal = 100000
        set ExtraX = x
        set ExtraY = y
        set ExtraZ = z
        call ForGroup(g, function ClosestUnitLoopZ)
        return ExtraUnit
    endfunction
    
    function GetClosestUnitOfGroupZEx takes group g,unit u returns unit
        local location l
        set ExtraReal = 100000
        set ExtraX = GetUnitX(u)
        set ExtraY = GetUnitY(u)
        set l = Location(ExtraX,ExtraY)
        set ExtraZ = GetLocationZ(l)
        call RemoveLocation(l)
        set l = null
        call ForGroup(g, function ClosestUnitLoopZ)
        return ExtraUnit
    endfunction

 

[chobibo]

I actually used that when Flame Phoenix (the guy who wrote a tutorial here) asked some help to make his 3d Chain Missile System.

Use the firstOfGroup loop if you will discard the group containing the unit list, but if you don't want to discard the group, use ForGroup instead, or better, make 2 versions.

@ Thread Starter: Sorry for hijacking your thread dude hehehe, gonna look at the map too.

 

[Kazeon]

Actually, I have made the function, but it's pretty simple, I'm pretty sure it will got rejected

 

[Crigges]

So this resource is realy bad, first of all this is fake 3D or how you would explain this:

The trigger/function is horrible slow due to bad coding and writing in GUI.

Overall 1/5, because this is not real 3D and for 2D the native GroupEnumUnitsInGroup() is around 100 times faster. And even a real 3D function, which is much harder to write could be much more efficient.

 

[Kazeon]

I have updated it, but I haven't uploaded it yet.. terrain z differences is calculated now..
I think the trigger can't be better since it's GUI..