Damage Engine 5.A.0.0

[ssbbssc2]

I guess its easier to just code your own bash, that will work without any restrictions.

as all other spells and item effects

 

[Bribe]

as all other spells and item effects

It gives the user more flexibility and control.

It occurs to me as well that a Bash might not be properly detected if used subsequently by a unit who already has the Bash debuff.

 

[13lack_Ro$e]

Is this possible with this new update to have a Boolean : IsDamageCleave (like the Boolean IsDamageSpell) so we can detect if the damage is a result of cleave or direct attack?

 

[Spacebuns]

I don't think so, you can't detect damage from a certain spell unless that spell is unique to the damage source, and Cleaving Attack has the same attack type with the main attack.

 

[ssbbssc2]

thats why u need custom cleave
look for 31 page of this thread

Maybe he wants a cleave ability that can deal more damage based on a stat ? (for example)
@ssbbssc2
When a unit takes damage
If attacker has your cleave ability
Deal x damage to
And here comes the "hard" part.
You have to select all units in let's say 200 range ? (range of your hero)
After that you have to check which units from that group are in the sight of the attacker (you do that by checking angle).

Download here

i slightlly modified his cleave, and have boolean IsDamageCleave
in my map, that damage can't be crit, for example

 

[looking_for_help]

as all other spells and item effects

Depends on what one wants to achieve. Just filtering spell/physical can be done reliable, so if thats the usecase there is no need to recode every spell.

It also depends on the map. I have used damage amount based filters which can work perfectly fine if your map design allows them (which is of course not always possible).

 

[Atirak]

since you've updated this and i've been currently using the old version of your damage engine in my map. So how can I use/update the damage engine in my map while making any errors? Should I copy-paste the triggers?

 

[ssbbssc2]

just copy code of the dmg engine and paste it

 

[Bribe]

There's currently an undeclared local issue when copying into a new map. If you're familiar with JASS you can delete that line if it's unused, or just add the ability.

I'll fix it next week.

 

[Atirak]

There's currently an undeclared local issue when copying into a new map. If you're familiar with JASS you can delete that line if it's unused, or just add the ability.

I'll fix it next week.

So its it safe to just copy the trigger and replace the old damage engine with the new one? Won't it create any harm?

 

[Bribe]

So its it safe to just copy the trigger and replace the old damage engine with the new one? Won't it create any harm?

No, that's the way I do it when I replace it in my maps.

 

[Bribe]

Provided a light update to fix a couple of minor things.

 

[Rheiko]

Hey @Bribe , I got a recursion error when using the system and I did try to turn off the trigger before dealing damage and turn it back on when finished. But it still happens sometimes. The damaged units get instant death. What should I do?

 

[Bribe]

Well you've got another trigger in your map which might cause it. If you're using the latest Damage Engine then it's definitely another of your triggers. Care to share your map?

 

[Rheiko]

I've just realized I was actually using v3.6. I'll try the latest version and see if the problem still exist.
The problem occured when this trigger fired.

• Shadow Blade
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • (Level of Shadow Blade for DamageEventSource) Greater than 0
  • Actions
    • Set TempPoint = (Position of DamageEventSource)
    • Set TempPoint2 = (Position of DamageEventTarget)
    • For each (Integer A) from 1 to (Level of Shadow Blade for DamageEventSource), do (Actions)
      • Loop - Actions
        • Set TempPoint3 = (TempPoint2 offset by ((Real((Integer A))) x 100.00) towards (Angle from TempPoint to TempPoint2) degrees)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 128.00 of TempPoint3) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Picked unit) Not equal to DamageEventTarget
                • ((Picked unit) is alive) Equal to True
                • ((Picked unit) belongs to an enemy of (Owner of DamageEventSource)) Equal to True
              • Then - Actions
                • Trigger - Turn off (This trigger)
                • Unit - Cause DamageEventSource to damage (Picked unit), dealing DamageEventAmount damage of attack type Hero and damage type Normal
                • Trigger - Turn on (This trigger)
                • Special Effect - Create a special effect attached to the chest of (Picked unit) using Abilities\Spells\Undead\CarrionSwarm\CarrionSwarmDamage.mdl
                • Special Effect - Destroy (Last created special effect)
              • Else - Actions
        • Custom script: call RemoveLocation(udg_TempPoint3)
    • Custom script: call RemoveLocation(udg_TempPoint)
    • Custom script: call RemoveLocation(udg_TempPoint2)

Care to share your map?

Sure, I'll pm you the map later.

Edit: There's no problem with the latest version so far. If another problem occurs, I will send the map.

 

[SpasMaster]

Hello. I am experiencing 2 problems in my map that I suspect are related to the Damage Engine. Or rather, I am almost 100% sure one of them is, I am not sure if the second one is as well.

First Problem

So, I have a type of Murloc in the map called "Toxic Gill". When this murloc dies, it is supposed to damage nearby enemies (in this case, the players). However, instead of dealing damage, it sometimes heals them. It is not yet clear to me when and how exactly, but based on my observations, ~85% of the time it heals instead of properly dealing damage.
Here are some important notes:

• Heroes do get properly damaged by the same Dummy unit called "Player Damager" in other triggers just fine.
• Using the same damage parameters (Attack Type - Spells; Damage Type - Normal) in other triggers has not proven problematic.
• In general, the system works just fine for anything and everything except in this scenario.

Here is the trigger:

Hidden

[trigger=""]
Toxic Explosion
Events
Unit - A unit Dies
Conditions
(Unit-type of (Dying unit)) Equal to Mur'gul Toxic-Gill
Actions
Set Generic_Point = (Position of (Dying unit))
Set Generic_Group = (Units within 225.00 of Generic_Point matching (((Owner of (Matching unit)) Equal to Player 1 (Red)) or (((Owner of (Matching unit)) Equal to Player 2 (Blue)) or ((Owner of (Matching unit)) Equal to Player 3 (Teal)))))
Unit Group - Pick every unit in Generic_Group and do (Actions)
Loop - Actions
Unit - Cause Player Damager 0344 <gen> to damage (Picked unit), dealing (90.00 + (0.08 x (Max life of (Picked unit)))) damage of attack type Spells and damage type Normal
Special Effect - Create a special effect at Generic_Point using Objects\Spawnmodels\Demon\DemonLargeDeathExplode\DemonLargeDeathExplode.mdl
Special Effect - Destroy (Last created special effect)
Custom script: call DestroyGroup(udg_Generic_Group)
Custom script: call RemoveLocation(udg_Generic_Point)
[/trigger]

Second Problem

Before I even go into this, I want to say that I am not sure it's even the Damage Engine being problematic here, but since people have suggested it might be, I come here to look for clues. This one might even be somehow related to the first problem? I dunno.

I will not go into details about it here, since I already made a thread with all necessary information here.

Thanks in advance!

 

[ZiBitheWand3r3r]

I susspect "(Max life of (Picked unit)"
I personally had problems with calculating "SomeReal * MaxLife of unit" using DDS many months ago. There's custom function to get Unit's max life in LFH's DDS for example, but I'm not sure how it works here, in Bribe's DDS.

 

[mr po]

Maybe some of the AOE victims have spell reduction that messed up with the system.

 

[Bribe]

I susspect "(Max life of (Picked unit)"
I personally had problems with calculating "SomeReal * MaxLife of unit" using DDS many months ago. There's custom function to get Unit's max life in LFH's DDS for example, but I'm not sure how it works here, in Bribe's DDS.

It's not needed to add a custom Max life function because the max life ability is removed almost instantly. However, in case there is some fuckery going on, he can run the trigger Clear Damage Event (checking conditions) before picking all units.

If that fixes the issue, please let me know and I'll add something to damage engine to fix it up.

 

[NEL]

nice, i found something that i need for my awesum map :v

 

[SpasMaster]

If that fixes the issue, please let me know and I'll add something to damage engine to fix it up.

Unfortunately, it did not.

I updated the trigger as instructed:

Hidden

[trigger=""]
Toxic Explosion
Events
Unit - A unit Dies
Conditions
(Unit-type of (Dying unit)) Equal to Mur'gul Toxic-Gill
Actions
Set Generic_Point = (Position of (Dying unit))
Set Generic_Group = (Units within 225.00 of Generic_Point matching (((Owner of (Matching unit)) Equal to Player 1 (Red)) or (((Owner of (Matching unit)) Equal to Player 2 (Blue)) or ((Owner of (Matching unit)) Equal to Player 3 (Teal)))))
Trigger - Run ClearDamageEvent (checking conditions)
Unit Group - Pick every unit in Generic_Group and do (Actions)
Loop - Actions
Unit - Cause Player Damager 0344 <gen> to damage (Picked unit), dealing (90.00 + (0.08 x (Max life of (Picked unit)))) damage of attack type Spells and damage type Normal
Special Effect - Create a special effect at Generic_Point using Objects\Spawnmodels\Demon\DemonLargeDeathExplode\DemonLargeDeathExplode.mdl
Special Effect - Destroy (Last created special effect)
Custom script: call DestroyGroup(udg_Generic_Group)
Custom script: call RemoveLocation(udg_Generic_Point)
[/trigger]

The bug kept occuring. Here is a video made by one of my players that showcases our test of the bug. We spawn the Toxic Gills with a command and have them fight a Grunt who has no abilities whatsoever. (And yes, the bug does happen to heroes and other units as well). You can clearly see how sometimes the Grunt takes damage and sometimes he is healed:

 

[Bribe]

My recommendation is to debug the Damage amount to check if it's postive or negative before the damage is even applied. If it's consistent, then there's an issue with one of the modifiers which might be flipping it around via a damage event modifier.

 

[pick-a-chew]

I have seen this problem a few times myself, and after about ~40 minutes of testing, it's not due to DamageEventModifier events themselves, but dealing damage during these events.

@SpasMaster I do not know the abilities/spells your heroes have in that footage, and i do not know the trigger architecture of your map and how widespread your DDS useage is, BUT it is likely that it is your abilities causing problems. I messed around with the DDS test map and came back with the following:

• I copied your on-death trigger and made Ghouls "explode" when they die. The damage was dealt through a farm NPC (or "Player Damager") and not the ghouls themselves.
  
• There's a normal Naga Sea Witch; she has no abilities whatsoever. None of the triggers on that map will cause her to do extra damage at anytime.
• She has a 100% chance to proc a damaging exploding death, meaning the area-damage-upon-death trigger works flawlessly (for her damage).
  
• There's a custom blademaster on the map. He has 3 abilities:
  • A modified Acid Bomb that has a DamageModifierEvent trigger to cause it to deal 100 damage when a target takes Spell Damage, has the Acid Bomb Debuff and the damage event source is a Blademaster. It ALWAYS causes the area-damage-upon-death to heal targets.
  • A modified Finger of Death spell that does no damage itself, but is triggered to deal 10.0x the Caster's strength to the target. It ALWAYS causes the area-damage-upon-death to heal targets if it kills a Ghoul.
  • A custom "Chance on Attack to deal Damage" ability that's DDS based. In the trigger, there's a 30% chance for the Blademaster to deal 100 spell damage to his target when he does physical damage. When this bonus damage kills a Ghoul, it will cause the area damage to instead heal (surprise). IF a ghoul dies by normal damage (e.g. just a regular attack), the area damage happens as intended.

From what i tested, i can say that the problem seems to arise when the "Player Damager" attempts to deal triggered damage at the same time as something else, such as an active or passive Hero ability.

I thought this was a sound explanation, but then realised it makes no sense... you can always deal multiple instances of triggered damage at the same time across many triggers and it should work fine. So i checked made up situations of damage triggers firing off after various events (attacked, levels up, sells item) but i couldn't replicate the problem EXCEPT when a trigger deals damage when a unit dies (when that unit died from triggered damage).

So then i turned the DDS off completely, and obviously, everything worked.

I made a situation where there were no DDS triggers involved, just simple GUI stuff. When a Crypt Lord levels up, a Dreadlord will deal 500 damage to a random villager in some fences (1-shot). When a Villager dies, the Dreadlord does 500 damage to the Crypt Lord. If all DDS triggers are turned off except for Damage Engine, Damage Engine Config and Unit Indexer, the Crypt Lord will not take damage. If these are turned off, he does.

From my testing i would say that your problem cannot be fixed because the DDS has a problem with units dying, but adding a delay to the damage should fix it

 

[Spellbound]

Okay, I haven't really read through everything, but I saw mention of damaging when damage is detected or a spell is cast, etc. This may not solve the issue, but I consider it to be good practice:

Any damage dealt, unless specified, will return a udg_DamageType of zero. You need to check for that specific value in your conditions to prevent infinite loops and if you need to apply damage then, set udg_NextDamageType to something else (maybe create a custom one in Damage Engine Config called Code or Triggered or something like that that you will use for all your triggered damage), deal the damage, then run Trigger - Run ClearDamageEvent (checking conditions).

Additionally, it would be good if you would have only 1 DamageModifierEvent trigger in your map that check for the different parameters that then runs the corresponding trigger. There can sometimes be conflict with two multiple DamageModifierEvents that do two different things, or one may inadvertently activate the other, etc, etc.

 

[Somebassoon]

Im having trouble getting the explosive damage to work on unit attacks, it only works on spell damage. In addition, certain units such as zombies dont explode.

 

[Bribe]

You'll need to let me know what you're on about with that.

 

[Spacebuns]

Will you update the damage engine once 1.29 goes official?

 

[Bribe]

What's 1.29? Haven't heard any news.

(but yes any updates to WC3 which break compatibility will be met with updated resources from me overnight).

Edit - holy shit. Just read the patch notes. This system is going to get quite a bit less complex. I'll update a few other systems of mine too.

 

[SpasMaster]

Unfortunately, judging by the PTR for 1.29, there are a ton of bugs.
Related to your Damage Engine, so far I noticed two things in my map Sunken City:

1) Very soon into the game many effects based off the Damage Engine stop working. Still haven't had the time to test in detail, but for example I had a summoned unit with an ability that states: "Attacks drain mana to deal additional damage". This is done with the Damage Engine and stops working 2 mins into the game. Needless to say, I've had no such issues on the live patch.
2) Floating Text messages appear to act very weirdly and are not centered properly. This could have to do with UI issues.

Generally, my experience on the PTR has been very bug heavy with various issues, but the two I mentioned above are the only ones I noticed so far that could be result of the new patch breaking the Damage Engine in one way or another.

I will be making a bug report post in the patch thread with screenshots and everything, once I gather all bugs I can find and will mention you with those that I, personally, have suspicions could be affecting the Damage Engine.

 

[Bribe]

Thanks. I look forward to testing this stuff out once the patch is live. I won't mess around with the test realm though.

 

[ssbbssc2]

we are talking about PTR29 on xgm aswell, and a lot of mapmakers are still using 26a due to bugs and some changes in order id's numbers

 

[Kakerate]

No reason for any map not to support 1.29, order IDs can be fixed. 1.26 may still have a couple cornercase benefits over live, but that will quickly change.

 

[SnooBvip]

this is ART !

 

[hemmedo]

@Bribe How can I manipulate spell damage output by a spell's ranks? I did it by giving different buffs to each rank and checking them one by one but I wonder if there's a better way?

 

[Bribe]

@Bribe How can I manipulate spell damage output by a spell's ranks? I did it by giving different buffs to each rank and checking them one by one but I wonder if there's a better way?

No way to differentiate the source ability of spell damage without a buff.

 

[hemmedo]

So me using a 3 different buffs for each rank is the correct way to do this?

 

[Bribe]

So me using a 3 different buffs for each rank is the correct way to do this?

Oh you mean spell level? You can just check the spell level of the damage event source. You just need one buff per spell type and the rest you can figure out with booleans.

 

[Bribe]

Users of 1.29 please use the following JASS script replacement as a stop-gap solution to the issue with additional players. Please keep in mind this is not using the new SetEventDamage native yet, and that (for some reason) the AOE and Enhanced damage are not working with 1.29:

//TESH.scrollpos=0
//TESH.alwaysfold=0
//===========================================================================
// Damage Engine lets you detect, amplify, block or nullify damage. It even
// lets you detect if the damage was physical or from a spell. Just reference
// DamageEventAmount/Source/Target or the boolean IsDamageSpell, to get the
// necessary damage event data.
//
// - Detect damage: use the event "DamageEvent Equal to 1.00"
// - To change damage before it's dealt: use the event "DamageModifierEvent Equal to 1.00"
// - Detect damage after it was applied, use the event "AfterDamageEvent Equal to 1.00"
// - Detect spell damage: use the condition "IsDamageSpell Equal to True"
// - Detect zero-damage: use the event "DamageEvent Equal to 2.00" (an AfterDamageEvent will not fire for this)
//
// You can specify the DamageEventType before dealing triggered damage. To prevent an already-improbable error, I recommend running the trigger "ClearDamageEvent (Checking Conditions)" after dealing triggered damage from within a damage event:
// - Set NextDamageType = DamageTypeWhatever
// - Unit - Cause...
// - Trigger - Run ClearDamageEvent (Checking Conditions)
//
// You can modify the DamageEventAmount and the DamageEventType from a "DamageModifierEvent Equal to 1.00" trigger.
// - If the amount is modified to negative, it will count as a heal.
// - If the amount is set to 0, no damage will be dealt.
//
// If you need to reference the original in-game damage, use the variable "DamageEventPrevAmt".
// 
//===========================================================================
// Programming note about "integer i" and "udg_DmgEvRecursionN": integer i
// ranges from -1 upwards. "udg_DmgEvRecursionN" ranges from 0 upwards.
// "integer i" is always 1 less than "udg_DmgEvRecursionN"
// 
function DmgEvResetVars takes nothing returns nothing
    local integer i = udg_DmgEvRecursionN - 2
    set udg_DmgEvRecursionN = i + 1
    if i >= 0 then
        set udg_DamageEventPrevAmt  = udg_LastDmgPrevAmount[i]
        set udg_DamageEventAmount   = udg_LastDmgValue[i]
        set udg_DamageEventSource   = udg_LastDmgSource[i]
        set udg_DamageEventTarget   = udg_LastDmgTarget[i]
        set udg_IsDamageSpell       = udg_LastDmgWasSpell[i]
        set udg_DamageEventType     = udg_LastDmgPrevType[i]
    endif
endfunction
function CheckDamagedLifeEvent takes boolean clear returns nothing
    if clear then
        set udg_NextDamageOverride = false
        set udg_NextDamageType = 0
    endif
    if udg_DmgEvTrig != null then
        call DestroyTrigger(udg_DmgEvTrig)
        set udg_DmgEvTrig = null
        if udg_IsDamageSpell then
            call SetWidgetLife(udg_DamageEventTarget, RMaxBJ(udg_LastDamageHP, 0.41))
            if udg_LastDamageHP <= 0.405 then
                if udg_DamageEventType < 0 then
                    call SetUnitExploded(udg_DamageEventTarget, true)
                endif
                //Kill the unit
                call DisableTrigger(udg_DamageEventTrigger)
                call UnitDamageTarget(udg_DamageEventSource, udg_DamageEventTarget, -999, false, false, null, DAMAGE_TYPE_UNIVERSAL, null)
                call EnableTrigger(udg_DamageEventTrigger)
            endif
        elseif GetUnitAbilityLevel(udg_DamageEventTarget, udg_DamageBlockingAbility) > 0 then
            call UnitRemoveAbility(udg_DamageEventTarget, udg_DamageBlockingAbility)
            call SetWidgetLife(udg_DamageEventTarget, udg_LastDamageHP)
        endif
        if udg_DamageEventAmount != 0.00 and not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_AfterDamageEvent = 0.00
            set udg_AfterDamageEvent = 1.00
            set udg_AfterDamageEvent = 0.00
        endif
        call DmgEvResetVars()
    endif
endfunction
    
function DmgEvOnAOEEnd takes nothing returns nothing
    if udg_DamageEventAOE > 1 then
        set udg_AOEDamageEvent = 0.00
        set udg_AOEDamageEvent = 1.00
        set udg_AOEDamageEvent = 0.00
        set udg_DamageEventAOE = 1
    endif
    set udg_DamageEventLevel = 1
    set udg_EnhancedDamageTarget = null
    call GroupClear(udg_DamageEventAOEGroup)
endfunction
    
function DmgEvOnExpire takes nothing returns nothing
    set udg_DmgEvStarted = false
    call CheckDamagedLifeEvent(true)
    //Reset things so they don't perpetuate for AoE/Level target detection
    call DmgEvOnAOEEnd()
    set udg_DamageEventTarget = null
    set udg_DamageEventSource = null
endfunction
function PreCheckDamagedLifeEvent takes nothing returns boolean
    call CheckDamagedLifeEvent(true)
    return false
endfunction
function OnUnitDamage takes nothing returns boolean
    local boolean override = udg_DamageEventOverride
    local integer i
    local integer e = udg_DamageEventLevel
    local integer a = udg_DamageEventAOE
    local string s
    local real prevAmount
    local real life
    local real prevLife
    local unit u
    local unit f
    call CheckDamagedLifeEvent(false) //in case the unit state event failed and the 0.00 second timer hasn't yet expired
    set i = udg_DmgEvRecursionN - 1 //Had to be moved here due to false recursion tracking
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        set u                       = udg_DamageEventTarget
        set f                       = udg_DamageEventSource
    elseif i < 16 then
        set udg_LastDmgPrevAmount[i]= udg_DamageEventPrevAmt
        set udg_LastDmgValue[i]     = udg_DamageEventAmount
        set udg_LastDmgSource[i]    = udg_DamageEventSource
        set udg_LastDmgTarget[i]    = udg_DamageEventTarget
        set udg_LastDmgWasSpell[i]  = udg_IsDamageSpell
        set udg_LastDmgPrevType[i]  = udg_DamageEventType
    else
        set s = "WARNING: Recursion error when dealing damage! Make sure when you deal damage from within a DamageEvent trigger, do it like this:\n\n"
        set s = s + "Trigger - Turn off (This Trigger)\n"
        set s = s + "Unit - Cause...\n"
        set s = s + "Trigger - Turn on (This Trigger)"
        
        //Delete the next couple of lines to disable the in-game recursion crash warnings
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(GetLocalPlayer(), 0.00, 0.00, 999.00, s)
        return false
    endif
    set udg_DmgEvRecursionN     = i + 2
    set prevAmount              = GetEventDamage()
    set udg_DamageEventTarget   = GetTriggerUnit()
    set udg_DamageEventSource   = GetEventDamageSource()
    
    set udg_DamageEventAmount   = prevAmount
    
    set udg_DamageEventType     = udg_NextDamageType
    set udg_NextDamageType      = 0
    set udg_DamageEventOverride = udg_NextDamageOverride
    set udg_NextDamageOverride  = false
    
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        if udg_DamageEventType == 0 then
            if f == udg_DamageEventSource then
                //Source has damaged more than once
                if IsUnitInGroup(udg_DamageEventTarget, udg_DamageEventAOEGroup) then
                    //Added 5 August 2017 to improve tracking of enhanced damage against, say, Pulverize
                    set udg_DamageEventLevel = udg_DamageEventLevel + 1
                    set udg_EnhancedDamageTarget = udg_DamageEventTarget
                else
                    //Multiple targets hit by this source - flag as AOE
                    set udg_DamageEventAOE = udg_DamageEventAOE + 1
                endif
            else
                //New damage source - unflag everything
                set u = udg_DamageEventSource
                set udg_DamageEventSource = f
                call DmgEvOnAOEEnd()
                set udg_DamageEventSource = u
            endif
            call GroupAddUnit(udg_DamageEventAOEGroup, udg_DamageEventTarget)
        endif
        if not udg_DmgEvStarted then
            set udg_DmgEvStarted = true
            call TimerStart(udg_DmgEvTimer, 0.00, false, function DmgEvOnExpire)
        endif
    endif
    
    if prevAmount == 0.00 then
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEventPrevAmt = 0.00
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 2.00
            set udg_DamageEvent = 0.00
        endif
        call DmgEvResetVars()
    else
        set u = udg_DamageEventTarget
        set udg_IsDamageSpell = prevAmount < 0.00
        if udg_IsDamageSpell then
            set prevAmount = -udg_DamageEventAmount
            set life = 1.00
            if IsUnitType(u, UNIT_TYPE_ETHEREAL) and not IsUnitType(u, UNIT_TYPE_HERO) then
                set life = life*udg_DAMAGE_FACTOR_ETHEREAL //1.67
            endif
            if GetUnitAbilityLevel(u, 'Aegr') > 0 then
                set life = life*udg_DAMAGE_FACTOR_ELUNES //0.80
            endif
            if udg_DmgEvBracers != 0 and IsUnitType(u, UNIT_TYPE_HERO) then
                //Inline of UnitHasItemOfTypeBJ without the potential handle ID leak.
                set i = 6
                loop
                    set i = i - 1
                    if GetItemTypeId(UnitItemInSlot(u, i)) == udg_DmgEvBracers then
                        set life = life*udg_DAMAGE_FACTOR_BRACERS //0.67
                        exitwhen true
                    endif
                    exitwhen i == 0
                endloop
            endif
            set udg_DamageEventAmount = prevAmount*life
        endif
        set udg_DamageEventPrevAmt = prevAmount
        set udg_DamageModifierEvent = 0.00
        if not udg_DamageEventOverride then
            set udg_DamageModifierEvent = 1.00
            if not udg_DamageEventOverride then
                set udg_DamageModifierEvent = 2.00
                set udg_DamageModifierEvent = 3.00
            endif
        endif
        set udg_DamageEventOverride = override
        if udg_DamageEventAmount > 0.00 then
            set udg_DamageModifierEvent = 4.00
        endif
        set udg_DamageModifierEvent = 0.00
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 1.00
            set udg_DamageEvent = 0.00
        endif
        call CheckDamagedLifeEvent(true) //in case the unit state event failed from a recursive damage event
        
        //All events have run and the damage amount is finalized.
        set life = GetWidgetLife(u)
        set udg_DmgEvTrig = CreateTrigger()
        call TriggerAddCondition(udg_DmgEvTrig, Filter(function PreCheckDamagedLifeEvent))
        if not udg_IsDamageSpell then
            if udg_DamageEventAmount != prevAmount then
                set life = life + prevAmount - udg_DamageEventAmount
                if GetUnitState(u, UNIT_STATE_MAX_LIFE) < life then
                    set udg_LastDamageHP = life - prevAmount
                    call UnitAddAbility(u, udg_DamageBlockingAbility)
                endif
                call SetWidgetLife(u, RMaxBJ(life, 0.42))
            endif
            call TriggerRegisterUnitStateEvent(udg_DmgEvTrig, u, UNIT_STATE_LIFE, LESS_THAN, RMaxBJ(0.41, life - prevAmount/2.00))
        else
            set udg_LastDamageHP = GetUnitState(u, UNIT_STATE_MAX_LIFE)
            set prevLife = life
            if life + prevAmount*0.75 > udg_LastDamageHP then
                set life = RMaxBJ(udg_LastDamageHP - prevAmount/2.00, 1.00)
                call SetWidgetLife(u, life)
                set life = (life + udg_LastDamageHP)/2.00
            else
                set life = life + prevAmount*0.50
            endif
            set udg_LastDamageHP = prevLife - (prevAmount - (prevAmount - udg_DamageEventAmount))
            call TriggerRegisterUnitStateEvent(udg_DmgEvTrig, u, UNIT_STATE_LIFE, GREATER_THAN, life)
        endif
    endif
    set u = null
    set f = null
    return false
endfunction
function CreateDmgEvTrg takes nothing returns nothing
    set udg_DamageEventTrigger = CreateTrigger()
    call TriggerAddCondition(udg_DamageEventTrigger, Filter(function OnUnitDamage))
endfunction
function SetupDmgEv takes nothing returns boolean
    local integer i = udg_UDex
    local unit u
    if udg_UnitIndexEvent == 1.00 then
        set u = udg_UDexUnits[i]
        if GetUnitAbilityLevel(u, 'Aloc') == 0 and TriggerEvaluate(gg_trg_Damage_Engine_Config) then
            set udg_UnitDamageRegistered[i] = true
            call TriggerRegisterUnitEvent(udg_DamageEventTrigger, u, EVENT_UNIT_DAMAGED)
            call UnitAddAbility(u, udg_SpellDamageAbility)
            call UnitMakeAbilityPermanent(u, true, udg_SpellDamageAbility)
        endif
        set u = null
    else
        set udg_HideDamageFrom[i] = false
        if udg_UnitDamageRegistered[i] then
            set udg_UnitDamageRegistered[i] = false
            set udg_DamageEventsWasted = udg_DamageEventsWasted + 1
            if udg_DamageEventsWasted == 32 then //After 32 registered units have been removed...
                set udg_DamageEventsWasted = 0
                
                //Rebuild the mass EVENT_UNIT_DAMAGED trigger:
                call DestroyTrigger(udg_DamageEventTrigger)
                call CreateDmgEvTrg()
                set i = udg_UDexNext[0]
                loop
                    exitwhen i == 0
                    if udg_UnitDamageRegistered[i] then
                        call TriggerRegisterUnitEvent(udg_DamageEventTrigger, udg_UDexUnits[i], EVENT_UNIT_DAMAGED)
                    endif
                    set i = udg_UDexNext[i]
                endloop
            endif
        endif
    endif
    return false
endfunction
    
//===========================================================================
function InitTrig_Damage_Engine takes nothing returns nothing
    local unit u = CreateUnit(Player(bj_PLAYER_NEUTRAL_EXTRA), 'uloc', 0, 0, 0)
    local integer i = bj_MAX_PLAYERS //Fixed in 3.8
    
    //Create this trigger with UnitIndexEvents in order add and remove units
    //as they are created or removed.
    local trigger t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 1.00)
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 2.00)
    call TriggerAddCondition(t, Filter(function SetupDmgEv))
    set t = null
    
    //Run the configuration trigger to set all configurables:
    if gg_trg_Damage_Engine_Config == null then
        //It's possible this InitTrig_ function ran first, in which case use ExecuteFunc.
        call ExecuteFunc("Trig_Damage_Engine_Config_Actions")
    else
        call TriggerExecute(gg_trg_Damage_Engine_Config)
    endif
    
    //Create trigger for storing all EVENT_UNIT_DAMAGED events.
    call CreateDmgEvTrg()
    
    //Create GUI-friendly trigger for cleaning up after UnitDamageTarget.
    set udg_ClearDamageEvent = CreateTrigger()
    call TriggerAddCondition(udg_ClearDamageEvent, Filter(function PreCheckDamagedLifeEvent))
    
    //Disable SpellDamageAbility for every player.
    loop
        set i = i - 1
        call SetPlayerAbilityAvailable(Player(i), udg_SpellDamageAbility, false)
        exitwhen i == 0
    endloop
    
    //Preload abilities.
    call UnitAddAbility(u, udg_DamageBlockingAbility)
    call UnitAddAbility(u, udg_SpellDamageAbility)
    call RemoveUnit(u)
    set u = null
endfunction

 

[Spacebuns]

heh I'm gonna stick with 1.27 anyway. I expect it will take at least a year for 1.29 to be stable and issue-free.

 

[Bribe]

The above script is compatible (tested) between both versions.

 

[kellym0]

so, does this engine support negative or positive changes in health less then or equal to +1/-1 yet?

as in, if a units regeneration is 1 health, or a units damage is 1 damage, does it still not register that? last I remembered it didn't. but it has been a while.

in a map with smaller numbers, it kind of matters. it did to me any way.

regardless its nice to see updates to it even after all these years.

 

[Bribe]

so, does this engine support negative or positive changes in health less then or equal to +1/-1 yet?

as in, if a units regeneration is 1 health, or a units damage is 1 damage, does it still not register that? last I remembered it didn't. but it has been a while.

in a map with smaller numbers, it kind of matters. it did to me any way.

regardless its nice to see updates to it even after all these years.

Does WarCraft 3 detect the original damage? If so, then yes this system would understand what to do. I'm not 100% sure I understand the issue you are describing.

 

[kellym0]

ah don't worry about it, long ago implementing this exact system (but in like 2015?/2016?) I found it did not show floating text (at that time) for negative -1 regeneration, which was simpler to me to use instead of any kind of self damaging aura or damage spell, it simply showed nothing. but you could watch the health go down 1 per second, in the portrait ui area, it just never made any floating text to see. when increased to 2 damage, little red 2's and green 2's would appear, and you could watch the health go down in the portrait ui area, but it would never show any number lower then that. (2)

I asked trigger editors everywhere why this system's floating text didn't work for negative 1 regeneration, but no body really knew why. I never really solved it.

but now floating text is built into sc2, its so awesome.

any way, I was just curious for nostalgia reasons as to if that bug had been fixed yet.

 

[Bribe]

The only plausible explanation I have to what you've identified is that WC3 doesn't trigger a damage event for such small fluctuations in regeneration. But why use a Damage Event plus regeneration to achieve thay when you can just trigger the regeneration and equally the floating text value?

 

[MyPad]

@Bribe

I think the flaws of Runed Bracers can be resolved if you just modify the Defend ability in the Unit Event trigger such that the damage absorbed is negative for spells.

 

[Bribe]

@Bribe

I think the flaws of Runed Bracers can be resolved if you just modify the Defend ability in the Unit Event trigger such that the damage absorbed is negative for spells.

That would be worse and would not fix runed bracers at all.

 

[MyPad]

@Bribe

I think the flaws of Runed Bracers can be resolved if you just modify the Defend ability in the Unit Event trigger such that the damage absorbed is negative for spells.

I forgot to say, try defend ability without the runed bracers ability.

 

[Bribe]

The issue is unchanged. Defend would have the same effect, because it flips the damage negative. Then Runed Bracers or another Defend or Elunes Grace screws it back to defaults.

 

[MyPad]

Ahh, but that is the reason why I suggested using the Defend ability. Unlike Runed Bracers, which causes spell damage reduction to not stack, the Defend ability permits said behavior.

Suppose one carries a Runed bracers item. With the runed bracers ability, the damage reduction will have to be triggered. With defend ability, the damage reduction will be handled by the game.

The restrictions of having Runed Bracers ability as the spell detector ability are such that one will have to trigger all spell damage reduction. With Defend ability, the only restriction is not to have another ability that flips the damage back to being positive.

 

[Bribe]

It requires the Defend ability to be enabled which screws with any other Defend that's in use. Also multiple Runed Bracers don't stack with each other so the best solution is to trigger spell damage reduction that one wants stacked.