Damage Engine 5.A.0.0

[Jaizix]

You're probably on an older version. The recent updates fixed that issue.

Hi Bribe,
I'm on 3.8.0.0 of the damage engine and 1.4.0.0 of the indexer

 

[Bribe]

Hi Bribe,
I'm on 3.8.0.0 of the damage engine and 1.4.0.0 of the indexer

I've re-uploaded the map. The actual resource is still forwards- and backwards-compatible, but for those who want a fully 1.29+ resource, find it attached to this post.

The attachment in that post is Damage Engine 4.0 where I changed the way the indexing is done. I should upgrade the OV with it too at some point this week.

But if you're on 1.29+ the attached wil solve that issue.

 

[Jaizix]

The attachment in that post is Damage Engine 4.0 where I changed the way the indexing is done. I should upgrade the OV with it too at some point this week.

But if you're on 1.29+ the attached wil solve that issue.

Hi Bribe,

Thanks, sorry I missed that post!

 

[Titanhex]

Hey I'm struggling to figure this out. Tried disabling a few different triggers but that just seemed to disable damage altogether.

How do you disable damage the damage detection to prevent a damage call from being registered by the damage detection engine?

I want to make it so that if a unit damages causes damage to a target, the damage chains to another target.
Problem is that damage is detected by the engine, and chains again, causing infinite chaining.
How do I make it so the second damage done, caused by a UnitDamageTarget call, is not registered by the engine?

 

[HellvsHeaven]

• DamageEvent
  • Events
  • Conditions
  • Actions
    • Trigger - Turn off DamageEventTrigger
    • Unit - Cause (Triggering unit) to damage (Triggering unit), dealing 500.00 damage of attack type Spells and damage type Normal
    • Trigger - Turn on DamageEventTrigger

 

[Titanhex]

Tried that but all damage dealt to targets was 0 from the damage source while the trigger was disabled.

 

[Bribe]

The right way is to turn off (This trigger).

 

[ZeroGravity]

Does anyone know why my damage detection trigger causes a bit of lag when it happens? This is my trigger though.

 

[Devalut]

Having issue Detecting triggered Spell damage's "DamageEventPrevAmt"
It simply comes up zero

Actually it doesn't even seem to be affected by "DamageEventType"


Start with Damage Modifier Event = 4.00 then reducing the dmgeventamt = 0.00
And then a second trigger picking up DamageEvent 1.00 displays "(-) + DamageEventPrevAmt" as a floating text.

EDIT: Hold on, second test on a different map is working... FALSE ALARM

 

[Bribe]

That's when the Robo Mode Tinker attacks a building right? I'm pretty sure the EnhancedDamage functionality should identify that, as that's how other augmented attacks work like Cleave. But I'll test it out.

 

[Bribe]

I've just tested it with the Goblin Tinker and in Robo Mode he deals the exact same damage to buildings as he does in Goblin Mode. Did Blizzard break the ability?

 

[Bribe]

Yeah it would be nice if you can show me.

My level 10 Robo was dealing 20 damage to the castle and was dealing 20 damage in normal form too, so if you have a demo map showing it even working in the first place that should be solid.

 

[maddeem]

@Bribe Lmao when I recreated the issue in your demo map it works fine. All on my end; apologies for wasting your time.

Also demolish does still work, gotta make sure your target is applicable under the data field Targets Allowed.

 

[ZeroGravity]

I have several of this kind of trigger but it causes lag. Can anyone help me with this? The longer game goes, the more lag it gets. Is there anything I should change or do? ;(

 

[Bribe]

You're probably in need of updating your DAMAGE ENGINE. Older versions had an issue sometimes with that.

Otherwise, you may be getting recursion elsewhere.

 

[Devalut]

Bribe, with the new action/native to set max hp would you be able to ditch the health ability?

 

[Bribe]

Bribe, with the new action/native to set max hp would you be able to ditch the health ability?

Just use Damage Engine 4.0 if you want the new natives. It's on one of the previous pages.

I've re-uploaded the map. The actual resource is still forwards- and backwards-compatible, but for those who want a fully 1.29+ resource, find it attached to this post.

 

[Devalut]

"4.0"

 

[Karr123]

I was playing with your stuff, so I made something that makes a unit get the hp back that was dealt to him.

• Untitled Trigger 001
  • Events
    • Game - AfterDamageEvent becomes Equal to 1.00
  • Conditions
  • Actions
    • Unit - Set life of DamageEventTarget to ((Life of DamageEventTarget) + DamageEventAmount)

if it hits him more than his hit points can take, technically he still gets the hit points back, but he is dead..

So if I were then to put nearby units into a group, the dead guy's corpse is put in the group too, even if I explicitly say that the unit that goes into the Unit Group must be alive.

• ... and (((Matching unit) is alive) Equal to True as (Key Unit Group) of FS in hhashtable

I don't know if it was known before and it probably isn't related to your engine at all but I still wanted to point that out, glad I found out what it was in the end.

 

[pick-a-chew]

I was playing with your stuff, so I made something that makes a unit get the hp back that was dealt to him.

• Untitled Trigger 001
  • Events
    • Game - AfterDamageEvent becomes Equal to 1.00
  • Conditions
  • Actions
    • Unit - Set life of DamageEventTarget to ((Life of DamageEventTarget) + DamageEventAmount)

if it hits him more than his hit points can take, technically he still gets the hit points back, but he is dead..

So if I were then to put nearby units into a group, the dead guy's corpse is put in the group too, even if I explicitly say that the unit that goes into the Unit Group must be alive.

• ... and (((Matching unit) is alive) Equal to True as (Key Unit Group) of FS in hhashtable

I don't know if it was known before and it probably isn't related to your engine at all but I still wanted to point that out, glad I found out what it was in the end.

That's because AfterDamageEvent is applied AFTER the damage has been applied, meaning if your unit takes a hit larger than its health pool, it dies, and then you give him hit points back. Dead units still have hit points, and the boolean "is unit alive?" simply checks if the unit's heath is lower than 0.405 (lower than this signals the unit is dead). To prevent that issue, don't set the health of dead units higher than 0.405 (i.e. never heal a dead unit). IIRC bribe even has a heal system you could use to make sure you avoid this kind of error.

 

[Bribe]

That's because AfterDamageEvent is applied AFTER the damage has been applied, meaning if your unit takes a hit larger than its health pool, it dies, and then you give him hit points back. Dead units still have hit points, and the boolean "is unit alive?" simply checks if the unit's heath is lower than 0.405 (lower than this signals the unit is dead). To prevent that issue, don't set the health of dead units higher than 0.405 (i.e. never heal a dead unit). IIRC bribe even has a heal system you could use to make sure you avoid this kind of error.

Yep. Functionally, he would achieve the same but bug-free effect by setting the damage to 0 from a modifier event.

 

[Kakerate]

In trying to debug why my damageevent function is not working, i added a line to print the damage of each event. I keep seeing damage events with values of 0, is there some internal flagging that marks these as not damage instances, or do all wc3 damageevents pass through?

 

[Pyrogasm]

Look at the demo map for the system. Do 0 values show up there? If not then you can probably look for a filter LFH included to ignore those zeroes. Probably just do whatever they did.

 

[Kakerate]

Debugging on the test map is useful. However, the bug im having is that a value gets stuck in the damage engine, and its not getting updated from new damage instances.

 

[Bribe]

Debugging on the test map is useful. However, the bug im having is that a value gets stuck in the damage engine, and its not getting updated from new damage instances.

I'd be willing to debug your map for you if you send it to me.

 

[TimeForAChange]

Recommended: Unlike in PDD, do not remove the Spell Damage Reduction ability from your Runed Bracers. Instead, modify the spell damage ability (in Object Editor, go to spells tab, then to special from the left column, then under items change Spell Damage Reduction's Damage Reduction) to 1.67 instead of .33. The test map has this implemented already. If you are switching from PDD and already had that ability removed, just implement the cross-compatibility PDD script I included below.

My map has many different items to reduce Spell Damage by different amounts. Can this system work with things like "greater/lesser runed bracers"?

 

[Bribe]

My map has many different items to reduce Spell Damage by different amounts. Can this system work with things like "greater/lesser runed bracers"?

Yes but you have to change their values in Object Editor to 2.00 - percentage of reduction.

 

[TimeForAChange]

Yes but you have to change their values in Object Editor to 2.00 - percentage of reduction.

Ok I see. This means that the Damage Engine will read the value of the skill. How will it stack if a unit has multiple items like this? Take the best one?


How about mana shield? How can I have custom versions if the object editor fields are all set to 0?

THanks

 

[Bribe]

Ok I see. This means that the Damage Engine will read the value of the skill. How will it stack if a unit has multiple items like this? Take the best one?


How about mana shield? How can I have custom versions if the object editor fields are all set to 0?

THanks

It takes the most recently added ability or item

 

[Oljin]

Really nice system! Works perfectly! very well programmed, thanks a lot! i have it impemented in my map.

 

[A]mun]

Hm let's say i'm using:
"Unit - Cause DamageEventSource to damage DamageEventTarget, dealing temp_real_dmg damage of attack type Normal and damage type Normal"
to deal damage (i'm deliberately avoiding SetDamageEventAmount since that does not calculate armor reduction?!).

How can i prevent this damage from firing another damage event?

I wish SetDamageEventAmount would take armor classes into account. Or am i missing something?

 

[Bribe]

Hm let's say i'm using:
"Unit - Cause DamageEventSource to damage DamageEventTarget, dealing temp_real_dmg damage of attack type Normal and damage type Normal"
to deal damage (i'm deliberately avoiding SetDamageEventAmount since that does not calculate armor reduction?!).

How can i prevent this damage from firing another damage event?

I wish SetDamageEventAmount would take armor classes into account. Or am i missing something?

The original damage amount, if it is physical, is already applied with armor reduction.

If you use a scaling calculation like damage x 1.25, there won't be an issue just setting the amount.

Otherwise, if you are using patch 1.29 or higher, you can use the target unit's armor to calculate the differential yourself.

 

[TimeForAChange]

Having a lot of trouble now in trying to get this to work in my map. I was using GDD previously without a problem. After importing this system, things work unless they involve Neutral Hostile or Neutral Passive units.

The heroes in my map begin as neutral passive and then are given to the selecting player. Even after switching the unit to the new, controlling player, I cannot detect damage events against the hero. Anyone have an idea? I'm guessing this is related to the unit indexer but I don't see any obvious problem.

 

[A]mun]

^ can't confirm, can you post the trigger

 

[Bribe]

Update your unit Indexer, that will fix that issue.

 

[hemmedo]

I have two questions about all of this...
-Can I still use the spells that was made with pre-4.0 version of damage engine with the new 4.0 version without any changes need to be made on the spell? I'm on 1.30 or something.
-Can I detect only the attacked target and not also the ones that are close to them since splash attacks triggers dds nonetheless?

edit:yep, all of my spellpack that was made with legacy unit indexer and damage engine are broken with these new versions on 1.30
@Bribe

 

[Bribe]

I have two questions about all of this...
-Can I still use the spells that was made with pre-4.0 version of damage engine with the new 4.0 version without any changes need to be made on the spell? I'm on 1.30 or something.
-Can I detect only the attacked target and not also the ones that are close to them since splash attacks triggers dds nonetheless?

edit:yep, all of my spellpack that was made with legacy unit indexer and damage engine are broken with these new versions on 1.30
@Bribe

The 4.0 stuff has all the same API, so is backwards compatible in that sense. But you need to update the Unit Event system to the one in this map and not just Damage Engine.

 

[hemmedo]

updated both, still buggy.

what kind of change did you make on unit indexer anyway?

 

[Bribe]

updated both, still buggy.

what kind of change did you make on unit indexer anyway?

Max players was 15, now it's set to the BJ. Not sure why your implementation is buggy, but these scripts are not buggy on 1.30 if you imported them correctly and are using them correctly in your triggers.

 

[hemmedo]

I keep looking and looking...nope still couldn't see why it broke the spell:\
spell just gets triggered constantly back to back....its a passive spell that works like the bash spell....caster's basic attacks have a chance to trigger some effect kind of spell. Well it works but the problem is once its procced, effect keeps running back to back on other targets.

Could you check the spell's code yourself Bribe? it uses in total of 3 libraries, your indexer, dds, and line segment enum system.

// !WROUGHT CHAOS CODE!

constant function WRC_EType takes nothing returns integer
    return 'BTLF' // Expiration Type: Generic
endfunction

constant function WRC_ETime takes nothing returns real
    return 1.5 // Expiration Time
endfunction

constant function WRC_AT takes nothing returns attacktype
    return ATTACK_TYPE_MAGIC // Attack Type
endfunction

constant function WRC_DT takes nothing returns damagetype
    return DAMAGE_TYPE_MAGIC // Damage Type
endfunction

constant function WRC_WT takes nothing returns weapontype
    return WEAPON_TYPE_WHOKNOWS // Weapon Type
endfunction

function WRC_UnitAlive takes unit u returns boolean
    return not IsUnitType(u,UNIT_TYPE_DEAD) and GetUnitTypeId(u)!=0
endfunction

function WRC_Filter takes unit u , player p returns boolean
    return WRC_UnitAlive(u) and IsUnitEnemy(u,p) and not IsUnitType(u,UNIT_TYPE_STRUCTURE) and not IsUnitType(u,UNIT_TYPE_MAGIC_IMMUNE) or udg_WRC_FilterImmune and not IsUnitType(u,UNIT_TYPE_FLYING)
endfunction

function WRC_EnumUnits takes nothing returns boolean
    call GroupAddUnit(udg_WRC_EnumGroup,GetFilterUnit())
    set udg_WRC_EnumCache=udg_WRC_EnumCache+1
    return false
endfunction

function WRC_EnumLimitUnitInRange takes group g , unit u , real r , integer limit , player source returns nothing
    local unit p
    local real random
    set udg_WRC_EnumCache = 0
    call GroupClear(g)
    call GroupEnumUnitsInRange(g,GetUnitX(u),GetUnitY(u),r,Filter(function WRC_EnumUnits))
    if udg_WRC_EnumCache==0 then
        return
    endif
    set random = (I2R(limit)/I2R(udg_WRC_EnumCache))
    loop
        set p = FirstOfGroup(udg_WRC_EnumGroup)
        exitwhen limit==0 or p==null
        set udg_WRC_EnumCache=udg_WRC_EnumCache-1
        if GetRandomReal(0,1)<=random or udg_WRC_EnumCache<=limit and p!=u and WRC_Filter(p,source) then
            call GroupAddUnit(g,p)
            set limit=limit-1
        endif
        call GroupRemoveUnit(udg_WRC_EnumGroup,p)
    endloop
    call GroupClear(udg_WRC_EnumGroup)
endfunction

function WRC_Loop takes nothing returns nothing

    local real x
    local real y
    local real x2
    local real y2
    local unit d
    local unit p
    local unit p2
    local group inCounted
    local group inSegment
    local unit u = GetEnumUnit()
    local integer ID = GetUnitUserData(u)

    if udg_WRC_DurationCache[ID]>=udg_WRC_Duration[udg_WRC_Level[ID]] or not WRC_UnitAlive(u) then
        set inCounted = CreateGroup()
        set x = GetUnitX(u)
        set y = GetUnitY(u)
        call WRC_EnumLimitUnitInRange(inCounted,u,udg_WRC_Radius[udg_WRC_Level[ID]],udg_WRC_Amount[udg_WRC_Level[ID]],udg_WRC_SourcePlayer[ID])
        loop
            set p = FirstOfGroup(inCounted)
            exitwhen p == null
            if WRC_UnitAlive(p) then
            set x2 = GetUnitX(p)
            set y2 = GetUnitY(p)

            if udg_WRC_LaserEnable then
                set d = CreateUnit(udg_WRC_SourcePlayer[ID],udg_WRC_LaserType,x,y,Atan2(y2-y,x2-x)*bj_RADTODEG)
                call SetUnitScale(d,udg_WRC_LaserSize[udg_WRC_Level[ID]],0,0)
                call UnitApplyTimedLife(d,WRC_EType(),WRC_ETime())
                set d = null
            endif

            set inSegment = CreateGroup()
            call LSE_GroupEnumUnitsInRangeOfSegment(inSegment,x,y,x+udg_WRC_Radius[udg_WRC_Level[ID]]*Cos(Atan2(y2-y,x2-x)),y+udg_WRC_Radius[udg_WRC_Level[ID]]*Sin(Atan2(y2-y,x2-x)),udg_WRC_LineWidth[udg_WRC_Level[ID]])
            loop
                set p2 = FirstOfGroup(inSegment)
                exitwhen p2 == null
                if WRC_Filter(p2,udg_WRC_SourcePlayer[ID]) and p2!=u and p2!=p then
                    call DestroyEffect(AddSpecialEffectTarget(udg_WRC_Effect[2],p2,udg_WRC_EffectAttach[2]))
                    set udg_DamageEventType = 1
                    call UnitDamageTarget(udg_WRC_Source[ID],p2,udg_WRC_LineDamage[udg_WRC_Level[ID]],false,false,WRC_AT(),WRC_DT(),WRC_WT())
                endif
                call GroupRemoveUnit(inSegment,p2)
            endloop
            call DestroyGroup(inSegment)
            set inSegment = null
            endif
        call DestroyEffect(AddSpecialEffectTarget(udg_WRC_Effect[2],p,udg_WRC_EffectAttach[2]))
        set udg_DamageEventType = 1
        call UnitDamageTarget(udg_WRC_Source[ID],p,udg_WRC_LineDamage[udg_WRC_Level[ID]],false,false,WRC_AT(),WRC_DT(),WRC_WT())
        call GroupRemoveUnit(inCounted,p)
        endloop

        call DestroyEffect(AddSpecialEffectTarget(udg_WRC_Effect[2],u,udg_WRC_EffectAttach[2]))
        set udg_DamageEventType = 1
        call UnitDamageTarget(udg_WRC_Source[ID],u,udg_WRC_LineDamage[udg_WRC_Level[ID]],false,false,WRC_AT(),WRC_DT(),WRC_WT())

        call DestroyGroup(inCounted)
        set inCounted = null
        call DestroyEffect(udg_WRC_EffectHandler[ID])

        call GroupRemoveUnit(udg_WRC_Group,u)
        set udg_WRC_Instance=udg_WRC_Instance-1
        if udg_WRC_Instance==0 then
            call PauseTimer(udg_WRC_Timer)
        endif
    else
        set udg_WRC_DurationCache[ID] = udg_WRC_DurationCache[ID]+udg_WRC_LoopInterval
    endif
    set u = null
endfunction



function WRC_Iterate takes nothing returns nothing
    call ForGroup(udg_WRC_Group,function WRC_Loop)
endfunction

function WRC_Execution takes nothing returns boolean

    local unit u
    local integer ID
    local integer i = GetUnitAbilityLevel(udg_DamageEventSource,udg_WRC_Ability)

    if WRC_Filter(udg_DamageEventTarget,GetOwningPlayer(udg_DamageEventSource)) and udg_DamageEventType==0 and i>0 and GetRandomInt(0,100)<=udg_WRC_Chance[i] and not IsUnitInGroup(udg_DamageEventTarget,udg_WRC_Group) then

        set u = udg_DamageEventTarget
        set ID = GetUnitUserData(u)

        call DestroyEffect(AddSpecialEffectTarget(udg_WRC_Effect[1],u,udg_WRC_EffectAttach[1]))

        set udg_WRC_DurationCache[ID] = 0
        set udg_WRC_Source[ID]  = udg_DamageEventSource
        set udg_WRC_Level [ID]  = i
        set udg_WRC_EffectHandler[ID] = AddSpecialEffectTarget(udg_WRC_Effect[0],u,udg_WRC_EffectAttach[0])
        set udg_WRC_SourcePlayer [ID] = GetOwningPlayer(udg_WRC_Source[ID])

        call GroupAddUnit(udg_WRC_Group,u)
        set udg_WRC_Instance=udg_WRC_Instance+1

        if udg_WRC_Instance==1 then
            call TimerStart(udg_WRC_Timer,udg_WRC_LoopInterval,true,function WRC_Iterate)
        endif
        set u = null
    endif
    return false
endfunction



function InitTrig_Wrought_Chaos_Core takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterVariableEvent(t,"udg_DamageEvent",EQUAL,1)
    call TriggerAddCondition(t,Condition(function WRC_Execution))
endfunction
// !END WROUGHT CHAOS CODE!

 

[DiabeticWulf]

Hi, I've been using Bribe's DDS a few years ago when it probably couldn't tell difference between basic attack damage and spell damage.

I'm looking for solution to differentiate damage between unit basic attack and its in game Spiked Barricades/ any poison ability. Am I able to achieve that or some of these with the system?

 

[Bribe]

Hi, I've been using Bribe's DDS a few years ago when it probably couldn't tell difference between basic attack damage and spell damage.

I'm looking for solution to differentiate damage between unit basic attack and its in game Spiked Barricades/ any poison ability. Am I able to achieve that or some of these with the system?

Not unless you're playing in the PTR version. I am going to rewrite Damage Engine so thay GUI users will have access to the events.

 

[Devalut]

Bribe you damn saint

 

[Rahko]

Sorry, if this has been asked already (going through 40 pages of comments would take some time...), but with another DDS I liked using negative damage for heals and positive was obviously for normal damage. With this Damage Engine, though, it seems as the engine automatically turns all negative damage to positive (like a condition DamageEventAmount less than 0 never returns true). It's fine with triggered damage, since I can use the NextDamageType, but some abilities would be so much easier to turn into healing spells by just turning their damage to negative value, instead of triggering every healing spell.

So, is there some other handy way to catch healing with this system? I tried to play around with the Explosive damage thing, because I thought that could have something to do with this problem, but couldn't figure anything out. Is there a way to turn that off and use negative values as heals instead?

 

[Bribe]

Sorry, if this has been asked already (going through 40 pages of comments would take some time...), but with another DDS I liked using negative damage for heals and positive was obviously for normal damage. With this Damage Engine, though, it seems as the engine automatically turns all negative damage to positive (like a condition DamageEventAmount less than 0 never returns true). It's fine with triggered damage, since I can use the NextDamageType, but some abilities would be so much easier to turn into healing spells by just turning their damage to negative value, instead of triggering every healing spell.

So, is there some other handy way to catch healing with this system? I tried to play around with the Explosive damage thing, because I thought that could have something to do with this problem, but couldn't figure anything out. Is there a way to turn that off and use negative values as heals instead?

Coming with the next patch all that weird damage reversal stuff is done away with because I can detect damage types without that ability.

 

[Spellbound]

Coming with the next patch all that weird damage reversal stuff is done away with because I can detect damage types without that ability.

D'you mean when 1.31 comes out of PTR or are you talking post-1.31? (If so, how do you detect magic damage in 1.31?)

 

[_Guhun_]

D'you mean when 1.31 comes out of PTR or are you talking post-1.31? (If so, how do you detect magic damage in 1.31?)

They introduced natives that allow you to detect Attack Type and Damage Type of damage events (and even set them).

 

[Devalut]

@_Guhun_
What an exciting time we live in~

 

[Spellbound]

Hmm, I know we have those but it doesn't seem like they would work very well for spell damage detection. I guess you could always detect what's not DAMAGE_TYPE_NORMAL to be spell damage, but it seems it would perhaps fail on things like Cleaving Attack that returns DAMAGE_TYPE_ENHANCED on non-primary targets.

 

[_Guhun_]

Hmm, I know we have those but it doesn't seem like they would work very well for spell damage detection. I guess you could always detect what's not DAMAGE_TYPE_NORMAL to be spell damage, but it seems it would perhaps fail on things like Cleaving Attack that returns DAMAGE_TYPE_ENHANCED on non-primary targets.

The new natives offer a few advantages (you can detect more things, like Spiked Barricades damage, and differenciate more stuff using DAMAGE_TYPE). Even if there are a few edge cases where there is ambiguity, the same can be said for the current detection method. Illusions with Elune's Grace will consider spell damage as normal damage, same for units with Berserk and a negative multiplier. In those situations, you would trigger the abilities instead. The same can be said for Cleaving Attack.

I haven't been able to test the PTR this past week, so I don't know about this, but I'll toss a few ideas. Isn't the attack type of the Cleaving Attack damage the same as the attacking unit? Spells use ATTACK_TYPE_NORMAL, so as long as the attacking unit does not have that attack type, you should be able to differenciate Cleaving Attack from spells. Are there any actual spells that use DAMAGE_TYPE_ENHANCED? That looks like a damage type that would only trigger from things that enhance attacks, since it does not even affect ethereal units.

Quick Edit: Sure, you could use the new natives to differenciate damage and still use the current methods of detecting spell damage, since they are not incompatible. But you would not be able to know if the damage was spell damage in the new "Damaging" event that happens before damage is reduced (unless that damage is already reduced by the magic reduction ability? That seems to defeat the purpose of the event).

Quick Edit 2: I forgot that units the deal "Normal" damage actually use ATTACK_TYPE_MELEE. So there would be no way for the unit with Cleaving Attack to have ATTACK_TYPE_NORMAL. I have also tested in 1.30.4, and units that have Magic damage and cleave WILL cleave into Ethereal units, which leads me to believe the ATTACK_TYPE for the secondary targets is the attack type of the unit itself.