• πŸ† Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. πŸ”—Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

Damage Engine 5.A.0.0

Author(s)
Bribe (Creator and maintainer)
Tags
GUI / Triggers, JASS, Lua, vJASS, Pack, System, Template, Open Source, Reforged, No Target, Passive / Aura, Target Ground, Target Object
Size
182.85 KB
Rating

(98 ratings)

Downloads
11020
Created
Aug 5, 2011
Updated
Jul 23, 2023
Resources
2
State
Approved
This bundle is marked as director's cut. It exceeds all expectations and excels in every regard.
View usage Statistics Legacy download
  • Like
  • Love
  • Wow
Reactions: CaChep, stalkerfox, zxcvbffg and 96 others
Damage Engine

Three GUI Damage systems for the community of The Hive,
Seven vJass Damage systems for the JASS-heads on their pedestals high,
Nine competing Damage systems, doomed to die,
One for Bribe on his dark throne
In the Land of the Hive where the Workshop lies.
One Damage Engine to rule them all, One Damage Engine to find them,
One Damage Engine to bring them all and in cross-compatibility unite them.

Whether you're looking for a simple DDS (Damage Detection System), need to modify damage or even if you want a complex network of damage pre-and post-processing, this resource is for you. Damage Engine is the most adapted DDS in existence to take full advantage of the new damage detection natives, and is constantly evaluated and scrutinized by both the community and myself for performance improvements, bug fixes and new features alike.

What started with humble beginnings to bring a Unit Indexer-based version of DDS to GUI users to improve on the previous standard (at the time it was Weep's GDDS) would eventually evolve to incorporate other aspects of damage systems out there. @looking_for_help had identified an extremely useful technique with negative spell resistance being used to detect spell damage, and for a time his Physical Damage Detection system became the new standard. It wouldn't be until much later when Damage Engine would resurface and use the same technique in order to be more useful for the community.

Fast forward to 2020, and you'll find not only that cross-compatibility with Weep's and LFH's systems are incorporated, but the most popular DDS systems in existence - even vJass ones - are fully supported via stripped-down API wrappers. All of the functionality of prior DDS systems has been infused into Damage Engine 5.7, and as such the transition to a "one size fits all" DDS is complete. I hope you find this to be useful, and I also hope that it will help you in developing your map to be more dynamic what than you had previously thought possible.

Features

Legacy Code & Requirements

How it works

How to install/upgrade

Video Guides

FAQs

Thanks


  • Damage Type, Attack Type, Weapon Type, Armor Type and Defense Type detection and modification to alter/understand the fundamentals of WarCraft 3's damage processing;
  • Access to the view and change the damage amount before and/or after reduction by armor, armor type and shields.
  • Fully cross-compatible with every major DDS - vJass and GUI alike.
  • Correctly distribute/negate Spirit Link damage.
  • Differentiate between Ranged, Melee, Spell or other types of attack.
  • Does not require any Object Editor data nor Unit Indexer.
  • As of 5.4, it is now completely recursion-proof.
  • Other features:
    • Damage Blocking, reducing, amplifying and/or conversion to healing
    • Does not require you to know nor use Jass NewGen Pack nor any custom script
    • Custom DamageType association available to be set before and/or during damage event
    • Detect when multiple targets were hit simultaneously via DamageEventAOE > 1.
    • Detect when the same unit was hit simultaneously by the same source via DamageEventLevel > 1.
  • Detect damage: use the event "OnDamageEventEqual to <any value>". You have access to the following variables for reference:
    • DamageEventSource - the unit dealing the damage
    • DamageEventTarget - the unit receiving the damage
    • DamageEventAmount - the amount of damage the unit will receive
    • DamageEventPrevAmt - the amount of damage prior to being modified by the game engine.
    • DamageEventAttackT - the attack type (Chaos, Spells, Pierce, etc.)
    • DamageEventDamageT - the damage type - for comprehensive info, click here.
    • DamageEventWeaponT - the weapon type determines if an attack plays some kind of sound on attack (ie. Metal Heavy Bash). It is always NONE for spells and almost always NONE for ranged attacks.
    • DamageEventArmorT - the armor type (Flesh, Stone, Ethereal, etc.)
    • DamageEventDefenseT - the defense type (Hero, Fortified, Unarmored, etc.)
    • DamageEventArmorPierced - if DAMAGE_TYPE_NORMAL, how much armor was set to be ignored by the user.
    • IsDamageSpell, IsDamageRanged, IsDamageMelee - determine the source category of damage dealt.
    • IsDamageCode - Determine if the damage was dealt natively or by the user. This can give incorrect readings if the user has not identified to Damage Engine that it is code damage. Therefore I recommend setting NextDamageType prior to dealing damage.
    • DamageEventType - An integer identifier that can be referenced by you for whatever extra differentiation you need. You can also create your own special damage types and add them to the definitions in the Damage Event Config trigger. If you the unit should explode on death by that damage, use a damage type integer less than 0. If you want the damage to ignore all modifications, use DamageTypePure.
  • To change damage before it's processed by the WarCraft 3 engine: use the event "PreDamageEvent Becomes Equal to <any value>". Whether you just want to use one monolithic trigger for all damage modification like I do in the demo map, or use the different modifier events here, is up to you.
  • To interact with damage after it's been factored for armor and resistances, use "ArmorDamageEvent Becomes Equal to <any value>". This is typically useful for custom shields. If you fully block or absorb DamageEventAmount (setting it to 0 or less), this event doesn't run.
  • To set the DamageEventType before dealing triggered Damage, use:
    - Set NextDamageType = DamageTypeWhatever
    - Unit - Cause...
  • You can modify the following variables from a "PreDamageEvent" trigger:
    • DamageEventAmount
    • DamageEventAttackT/DamageT/WeaponT/ArmorT/DefenseT
    • DamageEventArmorPierced
    • DamageEventType
    • DamageEventOverride - You can set this if you want to remind yourself not to modify the damage further. If you use the UNKOWN damage type from a Unit - Damage Target native or set "NextDamageType = DamageTypePure" before that function, damage modification is skipped.
  • To catch a unit the moment before it would die from damage, use LethalDamageEvent Becomes Equal to 1.00. Instead of modifying the DamageEventAmount here, modify LethalDamageHP to let the system know how much life to keep the unit alive with. Or you can just reference that LethalDamageHP value in order to know how much "overkill" damage was dealt.
  • To catch a unit as soon as the damage is applied against its Hit Points, use AfterDamageEvent Equal to 1.00.
  • Usage of the "<Event> becomes EQUAL to <value>" can be extrapolated as per the below:
    • EQUAL works as it always has - will run for any damage.
    • NOT EQUAL only runs for code damage.
    • LESS THAN only runs for damage from attacks but not coded attacks.
    • LESS THAN OR EQUAL only runs for melee attacks but not coded attacks.
    • GREATER THAN OR EQUAL only runs for ranged attacks but not coded attacks.
    • GREATER THAN only runs for Spell damage but not coded spell damage.

  • Damage Engine 5 and higher requires the latest Warcraft 3 patch (currently 1.32).
  • For people who did not update their game to Reforged / have not updated to Reforged yet. Alternatively, adding the below JASS script to the top of the DamageEngine library SHOULD enable it to work too:

    JASS: 
    function BlzGetEventIsAttack takes nothing returns boolean
     return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
endfunction
  • I have created a Pastebin for all information pertaining to Damage Engine 3.8, including the link to download it, via: Damage Engine 3.8.0.0 | HIVE.
  • As of 20 June 2020, JNGP users who are still on WarCraft 3 1.26 can benefit from Damage Engine 3A, which integrates many of the design choices added in various stages of Damage Engine 5. This is a special update which only requires the JASS script be replaced (no new GUI variables added). Can be found here: Damage Engine 3A.0.0.0 and 3.8.0.0 | HIVE

1
Unit attacks or casts a spell. The pure damage is assessed at this point - damage dice, evasion, critical strike. There is currently no event to affect or modify these at source.
β†’ β†’
2
The projectile or weapon hits the target unit
β†’ β†’
3
EVENT_UNIT_DAMAGING is fired before any modifications to the damage are made.
β†’ ↓
↓ ←
6
User changes to DamageEventAmount and/or to DamageEventDamageT/AttackT/WeaponT are saved into the WC3 engine.
← ←
5
If any recursive damage is detected from any of those events, it is postponed and the current damage will continue first.
← ←
4
Damage Engine deploys the PreDamageEvent
7
WarCraft 3 processes the user damage.
β†’ β†’
8
WarCraft 3 then distributes the user damage into Spirit Link (before armor)
β†’ β†’
9
WarCraft 3 runs any interrupting events, such as spirit link or defensive damage like Thorns Aura
β†’ ↓
↓ ←
12
The EVENT_UNIT_DAMAGED event runs. This is the original event we have always had access to. Damage Engine will either keep using the original variables from the DAMAGING event, or if there was Spirit Link/defensive damage it will freshly retrieve the event values from WC3 and only retain DamageEventPrevAmt.
← ←
11
Once any potential recursive WarCraft 3 damage is processed, the armor/mana shield modifications to the damage are performed.
← ←
10
If such events such as Spirit Link were detected, they fire their own EVENT_UNIT_DAMAGING & EVENT_UNIT_DAMAGED, and DamageEngine processes it along the way for the user.
13
If the damage is above zero, ArmorDamageEvent will run. If any recursive damage is detected, it is postponed.
β†’ β†’
14
The user can make modification to the damage here with the after-damage amount.
β†’ β†’
15
The user can access DamageEventPrevAmount if they want to know the damage amount before user changes/WarCraft 3 changes.
β†’ ↓
↓ ←
18
The user can specify whether or not to change LethalDamageHP in order to stop the unit from dying.
← ←
17
If the damage is still above zero, check if the damage is lethal. If so, run LethalDamageEvent 1.00. If any recursive damage is detected, it is postponed.
← ←
16
If the user wants the value that DamageEngine used to have with DamageEventPrevAmt (after WarCraft 3 processing but before user changes) they multiply DamageEventPrevAmt x DamageScalingWC3.
19
Once all modification is done, run OnDamageEvent. If any recursive damage is detected, it is postponed.
β†’ β†’
20
After a new damage instance is detected, or the 0.00 timer expires, run AfterDamageEvent. If any recursive damage is detected, it is postponed.
β†’ β†’
21
Run all potential recursive Unit - Damage Target function calls in chronological order (first in, first out).
√

How to install Damage Engine:
  1. Use WarCraft 3 Version 1.32
  2. If you're upgrading from 3.8 or prior, please delete the entire "Damage Engine" category from your map.
  3. Copy & Paste the Damage Engine category from the attached map to your own map.
How do I upgrade to the latest Damage Engine?
- Depending on the complexity, you'll either need to re-copy the Damage Engine category or just the Damage Engine script. Generally, you can use this as a guide:

  • Damage Engine _._._.x - only requires copying of the JASS script
  • Damage Engine _._.x._ - generally only needs copying of the JASS script, but read the patch notes in case there are changes you may want to make to your own code in order to utilize the changes.
  • Damage Engine _.x._._ - delete your current Damage Engine category or manually add the missing variables to your Variable Editor, and update your JASS script.
  • Damage Engine x._._._ - this occurs very infrequently. Typically requires changes to the way Damage Engine needs to be installed and used.

Notes about upgrading from Damage Engine 4.0 or prior:
  • Revert any custom Object Editor changes made (such as Life Drain reversal, Spell Damage Reduction inversion, etc).
  • You can safely delete the custom spells "Spell Damage Detection" and "Cheat Death Ability"
  • You can delete the Unit Indexer trigger if you do not use it or would prefer to use a different indexer.
  • You should delete any "Mana Shield fix" or "Finger of Death fix" you may have imported, as well as revert any Object Editor data that was required to make it work, as these are no longer needed.
  • !!!DEPRECATED FEATURE!!! As of 5.4, do not bother to take any recursive damage mitigation - Damage Engine will now handle all of that for you!
  • !!!DEPRECATED FEATURE!!! Do not use "ClearDamageEvent" - it does nothing. Just delete it.
  • !!!DEPRECATED FEATURE!!! Do not use "NextDamageOverride" - set NextDamageType = DamageTypePure instead.
  • !!!CHANGED FEATURE!!! If the system detects code damage and the user did not specify it as any particular DamageEvenType, the system will assign it DamageTypeCode automatically.
  • !!!CHANGED FEATURE!!! DamageModifierEvent 1.00-3.00 now run prior to armor reduction. This enables the user to modify the damage before armor and resistance changes are applied - also before Mana Shield and Anti-Magic shell kick in, so no more need for special triggers.


  • Q: Why am I getting a bunch of 'trigger was disabled' errors when I save my map?
  • A: This issue is not unique to Damage Engine, but to all vJass resources. Blizzard has taken the very confusing decision to make JassHelper 'disabled' by default, meaning that every new map that uses a vJass resource has to manually enable JassHelper. Please see this thread if you want to know where to find the Enable JassHelper option.
    .
  • Q: How can I detect when a unit gets damaged?
  • A: Create a trigger with the event: "Game - Value of Real Variable <DamageEvent> becomes Equal to 1.00".
    • Use the following custom variables to reference the event responses:
      • DamageEventSource - the unit dealing the damage
      • DamageEventTarget - the unit getting damaged
      • DamageEventAmount - how much damage is being dealt
      • DamageEventAttackT - which attack type was used by DamageEventSource to damage DamageEventTarget
      • DamageEventDamageT - which damage type was used to damage the target (ie. UNIVERSAL for ultimate damage, or NORMAL for damage that gets reduced by armor).
      • DamageEventDefenseT - which defense type does the target unit have (ie. Hero, Fortified, Unarmored).
      • DamageEventArmorT - which armor type does the target unit have (ie. Flesh, Ethereal, Stone).
      • DamageEventPrevAmt - what the value of the damage was before being modified by armor, ethereal/item bonuses or user changes.
        .
  • Q: How do I modify the damage that is dealt to a unit?
  • A: Create a trigger with the event: "Game - Value of Real Variable <PreDamageEvent> becomes Equal to <any value>".
    • You can change the following variables to affect the damage that will be dealt:
      • DamageEventAmount - how much damage will be dealt (before armor reductions)
      • DamageEventAttackT - which attack type will be used by DamageEventSource to damage DamageEventTarget
      • DamageEventDamageT - which damage type will be used to damage the target.
      • DamageEventDefenseT - which defense type should the target unit have during this attack.
      • DamageEventArmorT - which armor type should the target unit have during this attack.
      • DamageEventArmorPierced - how much armor value to ignore when dealing this damage (applies to DAMAGE_TYPE_NORMAL only, otherwise all armor is ignored).
        .

  • Q: How do I deal Pure damage to a unit (bypassing armor/skipping user modification)?
  • A: Use the following actions:
    • Set NextDamageType = DamageTypePure
    • Unit - Cause Source to damage Target for Amount using attack type Spells and damage type Universal
      .

  • Q: How do I protect against recursive damage?
  • A: Damage Engine 5.4 and above is completely recursion-proof, using vJass hooks to detect registered Damage Event triggers.
    .

  • Q: I've been using <insert Damage system here>. Can I use those with Damage Engine?
  • A: Better - Damage Engine has integrated cross-compatibility with all other approved Damage systems and even the major ones from outside of Hiveworkhop.
    .

  • Q: Can I cause an attack to 'Miss' its target?
  • A: Kind of. Ranged attacks will still explode on the target, and on-hit effects will still apply, but you can do the following:
    • Use the event "PreDamageEvent becomes Equal to 1.00"
    • Use the following actions:
      • Set DamageEventAmount = 0.00
      • Set DamageEventArmorT = ARMOR_TYPE_NONE
      • Set DamageEventWeaponT = WEAPON_TYPE_NONE
    • Setting the weapon type and armor type to none like the above will stop any on-hit sounds from playing. When the Peasant attacks in the demo map, this is the trick I'm using. Instead of saying "MISSED!" I have the Floating Text saying "FAIL!" because - again - it's not exactly a "miss".

Thank you to Blizzard for continuing to work on this amazing game to give us awesome new natives that have the best possible control over incoming damage. Damage Engine brings that power to GUI. Also, a very special thank you to @KILLCIDE for getting me motivated to start up the 5.0 project in the first place.

Thank you to the users of this system who have helped me mold this project into the stable, powerful form it is in today!

For versions 3.8 and prior:

Thank you @looking_for_help for finding the spell damage detection method used in Damage Engine 3 - it was the greatest find since the undefend bug.

Thanks to Jesus4Lyf and @Nestharus for building the inspiration that originally led me to create DamageEngine.

Thank you Wietlol and looking_for_help for challenging me on this project to integrate solutions to problems I had not been made aware of, such as the importance of an After-Damage Event.

Thanks to @Spellbound for several crucial bug reports.


Damage Engine Config

Damage Engine vJass

Damage Engine Lua

Changelog


  • Damage Engine Config
    • Events
      • Map initialization
      • Game - DamageModifierEvent becomes Greater than 0.00
      • Game - LethalDamageEvent becomes Less than or equal to 0.00
      • Game - DamageEvent becomes Not equal to 0.00
      • Game - AfterDamageEvent becomes Less than 0.00
      • Game - AOEDamageEvent becomes Greater than or equal to 0.00
      • Game - SourceDamageEvent becomes Equal to 0.00
      • Game - PreDamageEvent becomes Equal to 0.00
      • Game - ArmorDamageEvent becomes Equal to 0.00
      • Game - ZeroDamageEvent becomes Equal to 0.00
    • Conditions
    • Actions
      • -------- You can add extra classifications here if you want to differentiate between your triggered damage --------
      • -------- Use DamageTypeExplosive (or any negative value damage type) if you want a unit killed by that damage to explode --------
      • -------- - --------
      • -------- The pre-defined type Code might be set by Damage Engine if Unit - Damage Target is detected and the user didn't define a type of their own. --------
      • -------- "Pure" is especially important because it overrides both the Damage Engine as well as WarCraft 3 damage modification. --------
      • -------- I therefore gave the user "Explosive Pure" in case one wants to combine the functionality of the two. --------
      • -------- - --------
      • Set VariableSet DamageTypePureExplosive = -2
      • Set VariableSet DamageTypeExplosive = -1
      • Set VariableSet DamageTypeCode = 1
      • Set VariableSet DamageTypePure = 2
      • -------- - --------
      • Set VariableSet DamageTypeHeal = 3
      • Set VariableSet DamageTypeBlocked = 4
      • Set VariableSet DamageTypeReduced = 5
      • -------- - --------
      • Set VariableSet DamageTypeCriticalStrike = 6
      • -------- - --------
      • Custom script: call DamageEngine_DebugStr()

BribeFromTheHive/DamageEngine

Lua 1.0.2.3 - Fixed to match adjustment made in vJass version 5.4.2.3.
Lua 1.0.2.2 - Fixed to match adjustment made in vJass version 5.4.2.2.
Lua 1.0.2.1 - Fixed to match adjustment made in vJass version 5.4.2.1.
Lua 1.0.2.0 - Added support for Lua Fast Triggers ([Lua] Ridiculously Fast Triggers). Fixed an issue where the AfterDamageEvent wasn't always timed the correct way like it was in the JASS verion.
Lua 1.0.1.0 - Fixed encapsulation issue and recursion issue with DamageEngine_inception. Now hooks UnitDamageTarget.
Lua 1.0.0.0 - Release based on Damage Engine 5.4.2.0

5.9.0.0 - Added the following clearer event names to make things less confusing for new users:
  • PreDamageEvent - can be used in place of DamageModifierEvent pre-armor modification
  • ArmorDamageEvent - can be used in place of DamageModifierEvent post-armor modification
  • OnDamageEvent - can be used instead of a non-zero DamageEvent
  • ZeroDamageEvent - can be used instead of a zero damage DamageEvent
  • SourceDamageEvent - runs at the same time as AOEDamageEvent, but doesn't need to hit multiple units.
Added "DamageFilterRunChance" - odds for the trigger to BE run (works inversely to DamageFilterFailChance).
Shortened the Configuration trigger so that it focuses primarily on what the user can modify.
Organized all variables into categories to help users better understand what does what.
Installation or updating from a previous version will require re-copying the entire Damage Engine folder.
Updated the demo map's text tag production to include a new custom update for ArcingTextTag, thanks to @Ugabunda and @Kusanagi Kuro.
Side note - the Demo Map's triggers have been heavily cleaned up and will now no longer cause crashes when being imported into a new map.
5.8.0.0 -
  • Added a new functionality to the AOEDamageEvent, which allows it to fire even when only one unit is hit, if the AOEDamageEvent is registered as "Not Equal" instead of "Equal to". This is useful in a very specific scenario where an AfterDamageEvent may not be able to be relied upon to properly deallocate data from a running instance that needs to be able to function when multiple units are hit, but also needs to not fail when only one unit is hit.
  • Added additional filters for GUI users to avoid using trigger conditions in even more scenarios:
    • DamageFilterSource/TargetI (has item)
    • DamageFilterSource/TargetA (has ability)
    • DamageFilterSource/TargetC (has a certain classification, like hero or Tauren)
    • DamageFilterFailChance - odds for the trigger to not be run (ideal for critical strike or evasion)
  • Provided a way for GUI to un-register a Damage Event by setting "RemoveDamageEvent" to true from within their trigger's actions.
  • Moved the CreateTimer/CreateTrigger/CreateGroup calls that had been included in the globals block down to the onInit block as per request of @Ricola3D
  • Minor performance improvements thanks to @BLOKKADE
5.7.1.2 - Fixed an issue with armor penetration sometimes bugging out.
5.7.1.1 - Fixed an issue with the eventFilter not retaining its value during an AOE event. Fixed an issue with eventFilter when USE_MELEE_RANGE was set to false. Both issues reported by @lolreported
5.7.1.0 -
I have fixed several potential points of failure reported by multiple users that stopped Damage Engine from working for the rest of the game. In any case there should no longer be ANY SITUATION where Damage Engine just "stops working", even in ways I can't predict. The most likely issue was with DamageScalingWC3/User having possible 0-division errors.​
​
Fixed the "configured" issue reported by @lolreported where manual configuration didn't work unless the damage and attack type checks were initialized tto -1.​
​
In addition to these fixed bugs, I have added several more static ifs so that advanced users have more control over getting rid of features they might not care about.​

5.7.0.3 - Fixed the issue reported by @KitsuneTailsPrower wherein the DamageInterface extension wasn't working. This needed to be fixed both in the Damage Engine source as well as the DamageInterface plugin itself.
5.7.0.2 - Fixed the issue reported by @Wazzz where the armor reduction wasn't taken into consideration. Actually there was a much bigger flaw that I had overlooked that was prompting this.
5.7.0.1 - Improved the logic of the 0 damage event.
5.7.0.0:

  • Usage of the "DamageEvent becomes EQUAL to 1.00" now can be extrapolated further than ever before:
    • EQUAL works as it always has.
    • NOT EQUAL only runs for code damage.
    • LESS THAN only runs for damage from attacks.
    • LESS THAN OR EQUAL only runs for melee attacks.
    • GREATER THAN OR EQUAL only runs for ranged attacks.
    • GREATER THAN only runs for Spell damage.
  • Fully adapted Damage Engine to work with every other major DDS
  • Rewrote the internal script to use vJass structs: Damage and DamageTrigger.
  • Changed some of the vJass API. You can find the API listed in the Damage Engine trigger. Notably:
    • I removed UnitDamageTargetEx. You can replace this with Damage.apply.
      • The reason for this change is because of cross-compatibility. Rising Dusk's IDDS uses a different set of parameters for this function, so I removed it from my library to allow this to work seamlessly.
    • TriggerRegisterDamageEvent -> TriggerRegisterDamageEngine
    • RegisterDamageEvent -> RegisterDamageEngine
      • The reason for the above two changes is, like for UnitDamageTargetEx, because Rising Dusk's IDDS uses them. I don't want to make the same mistake I did with Table's API and preferred to walk back my API choices before things got out of hand again.
  • Various performance tweaks, bug fixes and re-commenting of variables.
  • Recursive damage is now processed more intelligently and possibly be more performance-friendly.
  • Adapted the cross-compatibility libraries for Weep and LFH's systems to use textmacros to insert themselves into Damage Engine (this might have been in the 5.6 update, but these two updates were both tailored to achieve similar goals).
5.6.2.0 - Fixed a bug with Damage modification and laid groundwork for a bunch of optional vJass compatibility addons.
5.6.1.0 - Patchwork on Melee/Ranged detection, recursion tracking. Also added the ability to modify damage from a DamageEvent to make it easier on beginners.
5.6.0.1 - Fixed an issue where the DamageEventType for recursive damage that used NextDamageType would always default to DamageTypeCode.
5.6.0.0
Rewrote a significant amount of the internal code so that struct and GUI syntax both work - and are synchronized with each other. vJass-exclusive users can disable the GUI synchronization if they don't use any GUI damage events in their maps.​
​
Four new variables must be added to your variable editor:​
  • boolean NextDamageIsAttack
  • boolean NextDamageIsMelee
  • boolean NextDamageIsRanged
  • integer NextDamageWeaponT
​
Struct syntax should not need too much introduction - Damage.index is the triggering event ID, and the syntax is Damage.index.amount/source/target/etc. To initialize a JASS damage event, use:​
JASS: 
function RegisterDamageEvent takes code c, string eventName, real value returns nothing
​
The string is simplified: "Modifier", "" (for simple DamageEvent), "After", "Lethal", "AOE"​
​
Finally, a neat QOL improvement is that I have assigned weight to each of the events. When registering an event, you can include numbers different than 1, 2, 3 or 4 (for modification) or just the plain "1" for the others. Now you can set your own sequencing and use 1.5, 3.14 or even -1 to give an even more extreme priority to something. Lower numbers run first, higher ones last.​
5.5.0.0 - Added support for the new native BlzGetEventIsAttack via "IsDamageAttack". Also updated the Config trigger to make importing a bit easier
5.4.2.3 - Fixed a mis-flag of the IsDamageSpell value when not being actual spell damage.
5.4.2.2 - Actually fixed the Cold Arrows issue (division by 0.00001 or something ...somehow... either way, it is fixed).
5.4.2.1 - A fix which should hopefully quell the recent reports of damage events failing in complex situations involving Cold Arrows.
5.4.2.0 - A ton of fixes to repair the issues plaguing Sunken City and anyone else who might be pushing this engine well beyond what I imagined it would be used for. Also added a couple of variables intended to be used to ricochet damage: CONVERTED_ATTACK_TYPE and CONVERTED_DAMAGE_TYPE. Check the demo map for how they can be used in a Unit - Damage Target action.
5.4.1.0 - The "Inception" update. Advanced users can interact with Damage Engine via custom script to set DamageEvent_inception = true to allow their damage to potentially go recursive (to a fixed extent).
5.4.0.1 - Hotfixed that modifiers 2 and 3 weren't running.
5.4.0.0 - By using an innovative approach of hooking TriggerRegisterVariableEvent, I've permanently eliminated all risks of recursion in the engine.
5.3.0.1 - Fixed unexpected behavior with DamageTypePure when it is affected by Anti-Magic Shell or Mana Shield. DamageTypePure now no longer ignores DamageScalingWC3.
5.3.0.0 - Fixed an issue with AfterDamageEvent sometimes being delayed. Added DamageScalingUser to track the ratio of user modified damage, as well as DamageEventArmorPierced which allows the user to define how much armor to ignore when working with DAMAGE_TYPE_NORMAL.
5.2.0.1 - Fixed an issue where with the final unit in a Spirit Link chain or the retaliating damage of Thorns/Carapace would not deploy an AfterDamageEvent. Also fixed an issue where AfterDamageEvent would still fire from DAMAGE_TYPE_UNKNOWN if it was greater than 0. Simply copy over the JASS from this post in order to update your own implementation.
5.2.0.0

  • Now features DamageEventArmorT and DamageEventDefenseT, which pull from the target unit's Object Editor data in order to allow you more complete access to detect and even MODIFY those defenses. Changes must be made in a DamageModifierEvent, and they are reverted as soon as armor is calculated.
  • Re-introduced AfterDamageEvent, which is the moment after the unit's life is changed, but before any recursive damage has run.

5.1.3.1 - Bug fixes and performance improvements. No, really. Fixed an issue with the DAMAGED event running even though it was turned off (who would've guessed that?)
5.1.3.0 - Engine re-tooling to improve accuracy and get Spirit Link/Defensive damage out of hardcoded mode - it will now work even in circumstances I haven't tested for (in case those weren't the only issues). Also fixed the Is Unit Moving resource.
5.1.2.1 - Fixed an issue with Spiked Carapace and Thorns Aura where the melee attacker would not get recorded correctly. This required the same fix as I needed to apply for the initial target in a spirit link chain.
5.1.2.0 - Tweaked recursion and fixed a few bugs. Re-introduced the zero damage event now that patch 1.31.1 brought it back.
5.1.1.1 - Minor tweak to Spirit Link in rare situation.
5.1.1.0 - Fixed issues related to Spirit Link. Now works intuitively as expected.
5.1.0.0 - Crazy improvements - check out the details in "How to upgrade from Damage Engine 4.0 or earlier" and "How to use Damage Engine 5.1"
5.0.0.0 - Oh man. Where do I even start?
  • You can now set/compare DamageEventDamageT, DamageEventAttackT or DamageEventWeaponT
  • No longer needs Unit Indexer nor any custom Object Editor data nor modifications.
  • Requires WarCraft 3 1.31 or higher.
  • Changed vanilla JASS code to vJass to clean up a lot of things such as making certain variables private.
  • Look for more details in "How to upgrade from Damage Engine 4.0 or earlier"

4.0.0.0 - Never officially released, but was the first iteration which used SetEventDamage.
For 3.8.0.0 and prior, see: Damage Engine 3.8.0.0 | HIVE


Cross-Compatibility:

BribeFromTheHive/DamageEngine

Keywords:unit indexer, damage detection, damage event, weep, nestharus, looking_for_help, EVENT_PLAYER_UNIT_DAMAGED, damage engine, spell, physical, EVENT_PLAYER_UNIT_DAMAGED, attacktype, damagetype, weapontype, armortype, defensetype, BlzSetEventDamage
Previews
Contents

Damage Engine Demo Map (Map)

Author
Bribe
Filename
Damage Engine 5.A.0.0.w3x
Suggested players
1
Players
1
Required game
Warcraft 3: Reforged
Recommended version
1.36
Dimensions
52x52 (64x64)
Size
100.38 KB
Uploaded
May 29, 2019
Updated
Jul 23, 2023
Map Info View Resources In Use Preview Triggers Download

Lua Damage Engine 2.0.0.0 (Map)

Author
Bribe
Filename
Lua Damage Engine 2.0.w3x
Suggested players
1
Players
1
Required game
Warcraft 3: Reforged
Recommended version
1.32
Dimensions
52x52 (64x64)
Size
82.47 KB
Uploaded
Jul 5, 2019
Updated
May 1, 2022
Map Info View Resources In Use Preview Triggers Download
Reviews
23:20, 11th Jan 2015, BPower Criticism: On the one hand Damage Engine offers extremely high utility to every spell, system and map maker independent of the coding style ( GUI, JASS, vJass, .... ) on the other hand it's very easy to import and...
Read full review...

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
I have updated to 5.1.2.0 after reviewing my code and running more obscure tests.

Apart from a few bug fixes and some recursion QoL changes, this version brings back the "DamageEvent Becomes Equal to 2.00" behavior which runs when zero damage is dealt.

I had removed it because Blizzard made it so that it was instead dealing 1 damage in many cases - but now that they've fixed it in patch 1.31.1 I have brought the feature back myself.

The demo map has been slightly improved in that you can type "report" to start displaying in-depth damage analysis per instance.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
@SpasMaster made a list of all the variables that got canned (see attached).

To upgrade, delete the Damage Engine and Config triggers, then copy over the entire Damage Engine category into your map.

Devalut said:
Here's a test map:

- Press ESC for all 100 peasants to shoot 1 damage fireballs at the caster, the caster is healed to max on ESC press, note the damage build up from the text (works only if you are selecting the unit being damaged.)

- Standing still you can take 100 damage, move to the right erratically and you will reduce the damage.

Make sure you have the blood mage selected before you hit ESC to see the damage buildup.


(ignore the carrion swarm spell! I forgot to remove it!)
Click to expand...

After testing, here's what I've found: WarCraft 3 applies the buff only once per instant, so when projectiles hit simultaneously nothing happens. However, if you change the conditions to remove the buff check but to include:

DamageEventLevel Greater than 1
DamageEventDamageT Equal to DAMAGE_TYPE_FIRE the event will then deploy 100 times. It just can't be specific to that buff, otherwise as soon as you remove it then the other buff checkers will fail.
 

Attachments

  • 3.8-5.1_UnusedVariables.txt
    444 bytes · Views: 34
Last edited:

HenrkIII

HenrkIII

HenrkIII

Level 2
Joined
Apr 17, 2017
Messages
22
Hey there @Bribe any updates regarding the sudden lag (MAssive Memory Leak) when units die on the map I attached? I recently checked the updated version of the Damage System with your Unit Event 2.5.2.0 and still the same problems. Thanks for the time.
 
Last edited:

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
HenrkIII said:
Hey there @Bribe any updates regarding the sudden lag (MAssive Memory Leak) when units die on the map I attached? I recently checked the updated version of the Damage System with your Unit Event 2.5.2.0 and still the same problems. Thanks for the time.
Click to expand...

Hi again @HenrkIII. Unfortunately, the latest Damage Engine update didn't leave me much time to get into testing both of your maps, so I only got to @Devalut's map thus far.

I will look into your map on the train on the way home - but be advised that yours is a Unit Event-specific issue and how the Undefend order is interacting with something (probably an infinite loop somewhere which lags and then crashes the thread).

ALSO, the long-awaited video where I walk through the full script in Damage Engine and talk about what it does can be found below:

 
Last edited:

HenrkIII

HenrkIII

HenrkIII

Level 2
Joined
Apr 17, 2017
Messages
22
Hi again @HenrkIII. Unfortunately, the latest Damage Engine update didn't leave me much time to get into testing both of your maps, so I only got to @Devalut's map thus far.

I will look into your map on the train on the way home - but be advised that yours is a Unit Event-specific issue and how the Undefend order is interacting with something (probably an infinite loop somewhere which lags and then crashes the thread).
Click to expand...

Hello @Bribe. No worries, I'll wait for your analysis of what's going on. I agree that it is a Unit Event-specific issue as I tried both instance where I have the Unit Event enabled and disabled to see if its the main reason and we are both correct. Its just that I don't know what to do hehehe!

Anyways, have a safe trip home.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Devalut said:
@Bribe the firebolt spell is just a model change on acid bomb, will damageeventT_Fire still work?
(Does this refer to the sound the damage makes?)
Click to expand...
That is using a different damage type. If you add this to your trigger, you can find out the damage type dealt:

Game - text message: DamageTypeDebugStr[DamageEventDamageT]
 
Last edited:

Rahko

Rahko

Rahko

Level 9
Joined
Jul 30, 2018
Messages
445
The DamageModifierEvent now takes the value before armor and armor type reductions, but is there a way to get the damage after armor and armor type changes but before custom damage modifiers?

For example: I have neglected high ground miss chance by reducing the damage 20% instead, and also decided to increase the damage by 10% if the attacker is on higher ground. However, now the high ground 10% boost looks like a lot bigger change than the 20% decrease because the DamagePrevAmt takes the totally unmodified damage.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Sabe said:
The DamageModifierEvent now takes the value before armor and armor type reductions, but is there a way to get the damage after armor and armor type changes but before custom damage modifiers?

For example: I have neglected high ground miss chance by reducing the damage 20% instead, and also decided to increase the damage by 10% if the attacker is on higher ground. However, now the high ground 10% boost looks like a lot bigger change than the 20% decrease because the DamagePrevAmt takes the totally unmodified damage.
Click to expand...

There's a mathematical solution to it, but I'd need to see the part of your trigger(s) where this is happening.
 

Devalut

Devalut

Devalut

Level 24
Joined
Feb 9, 2009
Messages
1,787
From I tried earlier with it displaying what DamgeEventDamageT it came out to shadow_strike, but now with the report trigger from your test map it comes up with NORMAL & UNKNOWN.

I'll look into that orb effect to properly use projectiles.
 

Attachments

  • fireball spam test for bribe + V5.1.2.0.w3x
    72.9 KB · Views: 26

Tasyen

Tasyen

Tasyen

Level 35
Joined
Jul 18, 2010
Messages
2,201
From my tests which i did on the 1.31 ptr, acid bomb has a bunch of damage instances.
There was the buff/aggro damage (spell&unknown), wierd damage with some wierd number like 0.169 beeing Spell(normal)&normal while the dot damage was Spell & shadow strike.

If your map does not have undeads or demons, you might use death coil. It has an quite unique damage Type death, no active spell I tested uses that damage type, although I might have missed some damage spells.
 
Last edited:

Devalut

Devalut

Devalut

Level 24
Joined
Feb 9, 2009
Messages
1,787
@Tasyen
ooooh?
How interesting!

My main purpose for spamming projectiles is a healing missile that spawns when a unit dies, I noticed it was failing when there was more than one, and I do take advantage of undead classification so unfortunately I won't be able to use it.

I'm storing that nugget of info for later though!
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Damage types are really a new frontier. The only native hero that has 2 similar damage types from its spell, however, is the Tauren Chieftan. Both Shockwave and War Stomp deal Sonic I think (or both deal Force, can't remember which really).

I think the damage types originally were going to be used to classify diferent types of attacking projectiles, as well, but then got canned at some point.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Tasyen said:
Mountain king and Tauren chief both use sonic for both of their active damage spells. While bash is force as long it is not 100% Chance, with 100% it fuses with the main attack and becomes 1 damage instance.
Click to expand...
Thanks I forgot about the Mountain King.

I think I should make a list of all spells and their damage types. Like Holy Light is probably Magic for example. Maybe Death Pact is Death damage type?
 

Kakerate

Kakerate

Kakerate

Level 13
Joined
Oct 18, 2013
Messages
691
Are the felhound summons meant to be checked as a summon in the conditions? On my instance of WC3 damage doesn't appear to be 200%.
 

Kakerate

Kakerate

Kakerate

Level 13
Joined
Oct 18, 2013
Messages
691
Summoned with Archimonde's dark portal. Just realized these units aren't considered summons. I was just using the testmap, the need for those to be detected as summons is minimal.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Kakerate said:
Summoned with Archimonde's dark portal. Just realized these units aren't considered summons. I was just using the testmap, the need for those to be detected as summons is minimal.
Click to expand...
Hmm, that makes sense. They aren't really summons according to the spell lore anyway, because they're just teleported.
 

HenrkIII

HenrkIII

HenrkIII

Level 2
Joined
Apr 17, 2017
Messages
22
Hey there @Bribe. I think I manage to discover the main reason for the lag spikes. It appears that your Is Unit Moving System has something to do with it. I tried to turn it off and kill those banshees that only causes the lag when they die and low and behold, it no longer lags!

Anyways, thanks for making these wonderful systems. Keep up the hard work!
 

AutisticTenacity

AutisticTenacity

AutisticTenacity

Level 4
Joined
May 2, 2019
Messages
15
@Bribe
Been working on a GUI-friendly stacking shield system using your damage detection engine, and I ran into some issues (though a few were resolved in a recent update). But it still seems like some things aren't working as intended.

IsDamageMelee doesn't seem to work properly after dealing damage in a DamageModifierEvent == 4.00. The IsUnitType() + DamageType checks work properly, but the IsDamageMelee var appears to break entirely for what I'm assuming is the rest of the game.

I'd assume the same goes for a few other vars too, even after 5.1.2.0 changes to patch up oddities when dealing damage in the 4.00 modifier event. I haven't actually tested any other values though.

In the attached image, enabling the last line again will cause IsDamageMelee to break when a unit with a flame shield is attacked.
I've attached the map as well in case you wanted to take a look for yourself.
 

Attachments

  • World_Editor_MAfduRb8ao.png
    World_Editor_MAfduRb8ao.png
    42.9 KB · Views: 21
  • GUIShieldSystem.w3x
    70.6 KB · Views: 18

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
AutisticTenacity said:
@Bribe
Been working on a GUI-friendly stacking shield system using your damage detection engine, and I ran into some issues (though a few were resolved in a recent update). But it still seems like some things aren't working as intended.

IsDamageMelee doesn't seem to work properly after dealing damage in a DamageModifierEvent == 4.00. The IsUnitType() + DamageType checks work properly, but the IsDamageMelee var appears to break entirely for what I'm assuming is the rest of the game.

I'd assume the same goes for a few other vars too, even after 5.1.2.0 changes to patch up oddities when dealing damage in the 4.00 modifier event. I haven't actually tested any other values though.

In the attached image, enabling the last line again will cause IsDamageMelee to break when a unit with a flame shield is attacked.
I've attached the map as well in case you wanted to take a look for yourself.
Click to expand...


Try updating the JASS script to the one in the demo map, which is 5.1.2.1. I fixed up a few things regarding preservation of those variables. If not fixed, let me know and I'll investigate what's going on.

HenrkIII said:
Hey there @Bribe. I think I manage to discover the main reason for the lag spikes. It appears that your Is Unit Moving System has something to do with it. I tried to turn it off and kill those banshees that only causes the lag when they die and low and behold, it no longer lags!

Anyways, thanks for making these wonderful systems. Keep up the hard work!
Click to expand...

I think the cause of this may be due to the on-removal deallocation of moving units. I'll try to push for an update in the next few days.
 

HenrkIII

HenrkIII

HenrkIII

Level 2
Joined
Apr 17, 2017
Messages
22
I think the cause of this may be due to the on-removal deallocation of moving units. I'll try to push for an update in the next few days.
Click to expand...

That will be great! I'll wait for it but in the meantime, i'll develop my map with it turned off.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
It's worth informing everyone subscribing to this thread that @Tasyen and I have compiled a list of all damage-dealing WarCraft 3 spells and mapped them to the repective Damage Types. The thread is found here:

REPO in progress - mapping damage types to their abilities

DAMAGE_TYPE_MIND and DAMAGE_TYPE_DEMOLISH do not occur natively in any context; they were probably deprecated during the transition to Frozen Throne or during one of the subsequent balance patches.
 

AutisticTenacity

AutisticTenacity

AutisticTenacity

Level 4
Joined
May 2, 2019
Messages
15
@Bribe
Downloaded and updated the script to 5.1.2.1, still seems to be broken. Did some testing, and it looks like it breaks IsDamageMelee, and IsDamageRanged, while IsDamageSpell seems fine. To be sure, I also did the test on the demo map of 5.1.2.1, and got the same results.

Also, is the unitmoving detection broken in the demo? Didn't seem like ranged attacks were reduced, even before breaking the event stuff.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Update to 5.1.3.0 - In addition to the patch notes, this update allows IsDamageCode and IsDamageMelee/Ranged to coexist (previously the Melee/Ranged detection didn't work if Code damage was detected). This is thanks to @AutisticTenacity's report above which is the only reason I can think of for why it could've broken in his map.

Also due to @HenrkIII's detective work and Autistic's info, I've fixed the IsUnitMoving resource in the map. I won't update the IsUnitMoving resource in the database (yet).
 

HenrkIII

HenrkIII

HenrkIII

Level 2
Joined
Apr 17, 2017
Messages
22
Hello again! I just downloaded the new map and tested the issue regarding the IsUnitMoving bug and now it works like a charm! I will do further testing as I continue with my altered melee map.

+ rep for you @Bribe and also thanks for the rep. I just noticed recently. LOL!
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Update to 5.1.3.1 - Bug fixes and performance improvements. @SpasMaster this is the one. I feel it.

For those who missed it, this post will help you as a developer understand more about damage types and the in-game abilities that use them: REPO in progress - mapping damage types to their abilities

Sabe said:
The DamageModifierEvent now takes the value before armor and armor type reductions, but is there a way to get the damage after armor and armor type changes but before custom damage modifiers?

For example: I have neglected high ground miss chance by reducing the damage 20% instead, and also decided to increase the damage by 10% if the attacker is on higher ground. However, now the high ground 10% boost looks like a lot bigger change than the 20% decrease because the DamagePrevAmt takes the totally unmodified damage.
Click to expand...

In this update I re-added the DamageScalingWC3 variable. It's already in the variable category folks would've copied over, I had just never removed it. Now that it's back, you can do:

(DamageEventPrevAmt x DamageScalingWC3)

This will tell you what the original damage amount would've been calculated to.

HenrkIII said:
Hello again! I just downloaded the new map and tested the issue regarding the IsUnitMoving bug and now it works like a charm!
Click to expand...

Glad it's working now!

John Melvic said:
I think this is the most essential script of all time :p
Click to expand...

I'm glad you like it!
 
Last edited:

Rahko

Rahko

Rahko

Level 9
Joined
Jul 30, 2018
Messages
445
Bribe said:
In this update I re-added the DamageScalingWC3 variable. It's already in the variable category folks would've copied over, I had just never removed it. Now that it's back, you can do:

(DamageEventPrevAmt x DamageScalingWC3)

This will tell you what the original damage amount would've been calculated to.
Click to expand...

Awesome! I don't actually need that anymore, since I changed a lot of things in my map, but good to know still!

Anyway, I now encountered a bug. I'm not sure if it's Damage Engine related, but whenever I open a map with Damage Engine in it, the maps gets corrupted. The Damage Engine folder in the Trigger Editor is empty, yet when I try to make a new trigger with the name Damage Engine, it says that there already exists a trigger named like that (even though there doesn't, because the folder (at least seems) empty). And when I save the map, and then try to open it again, the World Editor crashes.

I just lost a bunch of work because of this and now I can't open any of the older versions because they will always get corrupted. Removing the (empty) Damage Engine folder before saving didn't fix this. Has anyone ran into this problem? Is it Damage Engine related, map related or a World Editor problem? I uploaded my map in case someone else could try if this happens to them.
 

Attachments

  • MercenaryMasters0.2.13 – kopio.w3x
    1.5 MB · Views: 23

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Sabe said:
Anyway, I now encountered a bug. I'm not sure if it's Damage Engine related, but whenever I open a map with Damage Engine in it, the maps gets corrupted. The Damage Engine folder in the Trigger Editor is empty, yet when I try to make a new trigger with the name Damage Engine, it says that there already exists a trigger named like that (even though there doesn't, because the folder (at least seems) empty). And when I save the map, and then try to open it again, the World Editor crashes.

I just lost a bunch of work because of this and now I can't open any of the older versions because they will always get corrupted. Removing the (empty) Damage Engine folder before saving didn't fix this. Has anyone ran into this problem? Is it Damage Engine related, map related or a World Editor problem? I uploaded my map in case someone else could try if this happens to them.
Click to expand...

Is your WarCraft 3 completely up to date (1.31)? Because that's the exact issue I was having with Damage Engine in the 1.30 PTR but Blizzard got it working in the 1.30 live release.

Anyway, the thing is that the names of the variables were retained, but the variables themselves were gone. So you couldn't replace them. One way around it is to export the triggers, then reimport them. This will allow you to copy it fresh..
 
Last edited:

Rahko

Rahko

Rahko

Level 9
Joined
Jul 30, 2018
Messages
445
Bribe said:
Is your WarCraft 3 completely up to date (1.31)? Because that's the exact issue I was having with Damage Engine in the 1.30 PTR but Blizzard got it working in the 1.30 live release.
Click to expand...

I am. Been playing in Battle Net and ran the repair just in case. And now it happened again when I took an old enough version, which was still using pre-5.0.0.0 Damage Engine. I imported the newest version, saved the map, opened it again and now the folder seems empty again and the map gets corrupted...

Edit: Actually, it now manages to open the map, even though the empty folder stays. Though, it think it might start to crash at any point, and I can't modify anything on the config anyway.

Edit 2: Yeah, after a second save, the map was corrupted xP

Edit 3: Strangely enough, doesn't seem to happen to my other map.
 
Last edited:

Devalut

Devalut

Devalut

Level 24
Joined
Feb 9, 2009
Messages
1,787
Bribe is it possible to add a DamageEvent"_"Amt that is stored like Prev but unlike Prev it's calculated after armor adjustments?

I want to show the Exact damage being blocked and I'm stuck on calculating all the armor types into a calculation.

(I.e. PeasantA dealing damage to PeasantB [w/ Shield] shows only "-5" when in reality the normal damage type is increased and dealing "-7")

So maybe "DamageEventNetAmt"
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Devalut said:
Bribe is it possible to add a DamageEvent"_"Amt that is stored like Prev but unlike Prev it's calculated after armor adjustments?

I want to show the Exact damage being blocked and I'm stuck on calculating all the armor types into a calculation.

(I.e. PeasantA dealing damage to PeasantB [w/ Shield] shows only "-5" when in reality the normal damage type is increased and dealing "-7")

So maybe "DamageEventNetAmt"
Click to expand...

I was wondering about this. For the sake of shields if it might be good to know, but I couldn't think of the right way to process jt. DamageEventAmount divided by DamageScalingWC3 might get you somewhere in the ballpark.
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Devalut said:
What does "DamageScalingWC3" refer to?
Click to expand...
After sleeping on it, it's not what you're looking for. But what it is, is the delta ratio between what changes were applied to the damage amount between the two events DAMAGING and DAMAGED.

In the mean time, what you could do is track the value yourself and just track the value changes of your own shield system.

I was actually wondering about something called BlockedDamageAmount, which could be set by the user so that it's known how much should actually be blocked.

Right now, the formula gets the differential between the shield damage and the damage amount, and sets the damage amount directly. To alter it would be quite nuts. Maybe I could develop a plugin system to handle the basics of shield development and process them for both the user and the system?
 

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
Sorry I read your post again and DamageScalingWC3 is what you want.

DamageEventPrevAmt x DamageScalingWC3 = the amount of non-user modified damage. It would only be wrong if the unit had Mana Shield or Anti Magic Shell turned on.

I should also mention this only works if it is applied from DamageModifier 4.00 or DamageEvent 1.00 events.
 
Last edited:

Bribe

Bribe

Bribe

Code Moderator
Level 50
Joined
Sep 26, 2009
Messages
9,468
I'm just gonna leave this here to show what a journey it has been to get Damage Engine set up with all the new mechanics:


1
Unit attacks or casts a spell		
β†’ β†’
		
2
The projectile or weapon hits the target unit		
β†’ β†’
		
3
EVENT_UNIT_DAMAGING is fired before any modifications to the damage are made.		
→ ↓


↓ ←
		
6
User changes to DamageEventAmount and/or to DamageEventDamageT/AttackT/WeaponT are saved into the WC3 engine.		
← ←

5
If any recursive damage is detected from any of those events, it is postponed and the current damage will continue first.		
← ←

4
Damage Engine deploys the DamageModifierEvents 1.00 through 3.00

7
WarCraft 3 processes the user damage.		
β†’ β†’
		
8
WarCraft 3 then distributes the processed damage into Spirit Link/Mana Shield, then applies armor type & amount		
β†’ β†’
		
9
WarCraft 3 runs any interrupting events, such as spirit link or defensive damage like Thorns Aura		
→ ↓


↓ ←
		
12
Damage Engine will either keep using the original variables with their values, or will recover the original damage values in the event of recursive Spirit Link/defensive retaliating damage.		
← ←

11
Once any potential recursive WarCraft 3 damage is processed, the EVENT_UNIT_DAMAGED event runs. This is the original event we always had access to.		
← ←

10
If such events such as Spirit Link were detected, they fire their own EVENT_UNIT_DAMAGING & EVENT_UNIT_DAMAGED, and DamageEngine processes it along the way for the user.

13
If the damage is above zero, DamageModifierEvent 4.00 will run. If any recursive damage is detected, it is postponed.		
β†’ β†’
		
14
The user can make modification to the damage here with the after-damage amount.		
β†’ β†’
		
15
The user can access DamageEventPrevAmount if they want to know the damage amount before user changes/WarCraft 3 changes.		
β†’ ↓


↓ ←
		
18
The user can specify whether or not to change LethalDamageHP in order to stop the unit from dying.		
← ←

17
If the damage is still above zero, check if the damage is lethal. If so, run LethalDamageEvent 1.00. If any recursive damage is detected, it is postponed.		
← ←

16
If the user wants the value that DamageEngine used to have with DamageEventPrevAmt (after WarCraft 3 processing but before user changes) they multiply DamageEventPrevAmt x DamageScalingWC3.

19
Once all modification is done, run DamageEvent 1.00. If any recursive damage is detected, it is postponed.		
β†’ β†’
		
20
Run all potential recursive Unit - Damage Target function calls in chronological order (first in, first out).		
β†’ β†’
		
21
After a 0.00 second timer expires, run the AOEDamageEvent (if multiple units were hit by the same source in the same instant).		
√

 
You must log in or register to reply here.

Similar threads

Dinodin
What do this error mean and how to solve it?
Replies
4
Views
195
Dinodin
Dinodin
aznricepuff
Damage Engine v0.A.2
2
Replies
76
Views
17K
Bloodbane7
Bloodbane7
Anachron
CustomWindow (v. 0.0.B)
Replies
6
Views
2K
Anachron
Anachron
tomv8
  • Locked
A Secret
Replies
3
Views
936
tomv8
tomv8
troylowyee
  • Locked
Bribe's Damage Engine Help
Replies
4
Views
2K
Bribe
Bribe
Top