Damage Engine 5.A.0.0

[Spellbound]

Well I haven't done extensive tests but Cleaving Attack does deal DAMAGE_TYPE_ENHANCED on non-primary targets, so it's definitely something to consider. It would have been easier had blizzard offered a boolean for physical and magical damage (I mean, they did it already with Runed Bracers, so why not just give us that function?), but Bribe sounds confident in his next update so I guess I'll wait and see.

Quick Edit: Sure, you could use the new natives to differenciate damage and still use the current methods of detecting spell damage, since they are not incompatible. But you would not be able to know if the damage was spell damage in the new "Damaging" event that happens before damage is reduced (unless that damage is already reduced by the magic reduction ability? That seems to defeat the purpose of the event).

I'd rather we got rid of the Runed Bracers workaround as soon as there's an alternative. If attacktype and damagetype detection offers that possibility, out with the bracers

Quick Edit 2: I forgot that units the deal "Normal" damage actually use ATTACK_TYPE_MELEE. So there would be no way for the unit with Cleaving Attack to have ATTACK_TYPE_NORMAL.

Even with ranged attacks?

 

[_Guhun_]

Even with ranged attacks?

I don't see why it would be different with ranged attacks :S

Also, I thought a bit about it, it might be that spells simply use ATTACK_TYPE_NORMAL, and the damage type does not matter? Maybe the magic reduction ability simply reduces damage of attacks with that attack type, and does not care about the damage type at all. I have just tested it, and it seems to be the case. No matter what damage type I use, Damage Engine detects damage of ATTACK_TYPE_NORMAL as spell damage.

 

[Spellbound]

Oh. Lol well, case solved then lol. I guess the name ATTACK_TYPE_MELEE threw me off.

 

[_Guhun_]

Yep, I just tested every attack type and damage type combination. The spell bracers were doing nothing more than reducing damage with ATTACK_TYPE_NORMAL. Case solved, indeed.

 

[Bribe]

This version of Damage Engine will go live once 1.31 does - it enables a lot of new features like:

- Differentiate between ranged and melee attacks
- Differentiate between native attack, damage and weapon types
- Get/Modify damage before it's reduced by armor
- Get/Modify damage after it's reduced by armor
- Catch the moment a unit is about to be killed and allow the user to set a minimum HP value for the unit to survive with (as opposed to just editing the damage)

Additional perks:
- No longer uses Unit Indexer
- No longer uses any Object Editor data (so you'll need to revert any changes made to Anti-Magic Shell, Mana Shield or Runed Bracers)
- For those that are upgrading from 3.8, it also no longer needs any modifications to any of the other object editor data like max life.

Let me know how it plays for you all. I've tested it very extensively and I'm confident this will fulfill almost all open Damage Engine requests I've gotten over the years.

 

[A]mun]

^ Does this mean that the default anti magic shield and mana shield work out of the box now?

And couldn't we already detect if a unit is a ranged/melee attacker via conditions?

Anyway, great update!

 

[_Guhun_]

And couldn't we already detect if a unit is a ranged/melee attacker via conditions?

Not the same as detecting wheter an attack is ranged or melee, if the unit is both a ranged attacker and a melee attacker.

 

[Bribe]

^ Does this mean that the default anti magic shield and mana shield work out of the box now?

And couldn't we already detect if a unit is a ranged/melee attacker via conditions?

Anyway, great update!

All Object Editor data can be left at their default values.

Like @_Guhun_ said, if a melee hero has its second attack index enabled, or a unit like a Gargoyle which has both enabled at all times, you'll want to know the difference.

 

[chopinski]

Detecting code damage would be nice

 

[lishi1608]

So glad to see the update after long! I was researching your 3.8 version yesterday and did some modifications. I was confused today at first: did I download the outdated version?

Could I ask for a change log please? so I don't have to compare line by line with my modified version. I changed the unit indexer to jass, and simplified it a little bit to better understand. If this doesn't change I would just copy the other scripts.

Following is my jass version indexer if anyone interested.

Thanks

function Trig_Unit_Indexer_Actions takes nothing returns nothing
    call ExecuteFunc("InitializeUnitIndexer")
endfunction
    
function ClearUnitIndex takes nothing returns nothing
    if ( GetUnitUserData(udg_UDexUnits[udg_UDex]) == 0 ) then
        set udg_UnitIndexLock[udg_UDex] = ( udg_UnitIndexLock[udg_UDex] - 1 )
        if ( udg_UnitIndexLock[udg_UDex] == 0 ) then
            set udg_UDexNext[udg_UDexPrev[udg_UDex]] = udg_UDexNext[udg_UDex]
            set udg_UDexPrev[udg_UDexNext[udg_UDex]] = udg_UDexPrev[udg_UDex]
            set udg_UDexPrev[udg_UDex] = 0
            set udg_UnitIndexEvent = 0.00
            set udg_UnitIndexEvent = 2.00
            set udg_UnitIndexEvent = 0.00
            set udg_UDexUnits[udg_UDex] = null
            set udg_UDexNext[udg_UDex] = udg_UDexRecycle
            set udg_UDexRecycle = udg_UDex
        endif
    endif
endfunction
    
function IndexUnit takes nothing returns boolean
    local integer pdex = udg_UDex
    local integer ndex
       
    // -
    // You can customize the following block - if conditions are false the (Matching unit) won't be indexed.
    // -
    if ( udg_UnitIndexerEnabled == true and GetUnitUserData(GetFilterUnit()) == 0 ) then
        set udg_UDexWasted = ( udg_UDexWasted + 1 )
        if ( udg_UDexWasted == 32 ) then
            set udg_UDexWasted = 0
            set udg_UDex = udg_UDexNext[0]
            loop
                exitwhen udg_UDex == 0
                set ndex = udg_UDexNext[udg_UDex]
                call ClearUnitIndex()
                set udg_UDex = ndex
            endloop
        else
        endif
        if ( udg_UDexRecycle == 0 ) then
            set udg_UDex = ( udg_UDexGen + 1 )
            set udg_UDexGen = udg_UDex
        else
            set udg_UDex = udg_UDexRecycle
            set udg_UDexRecycle = udg_UDexNext[udg_UDex]
        endif
        set udg_UDexUnits[udg_UDex] = GetFilterUnit()
        call SetUnitUserData( udg_UDexUnits[udg_UDex], udg_UDex )
        set udg_UDexPrev[udg_UDexNext[0]] = udg_UDex
        set udg_UDexNext[udg_UDex] = udg_UDexNext[0]
        set udg_UDexNext[0] = udg_UDex
        set udg_UnitIndexLock[udg_UDex] = 1
        set udg_UnitIndexEvent = 0.00
        set udg_UnitIndexEvent = 1.00
        set udg_UnitIndexEvent = 0.00
        set udg_UDex = pdex
    endif
    return false
endfunction
    
function InitializeUnitIndexer takes nothing returns nothing
    local integer i = bj_MAX_PLAYER_SLOTS
    local boolexpr b = Filter(function IndexUnit)
    local region re = CreateRegion()
    local trigger t = GetTriggeringTrigger()
    local rect r = GetWorldBounds()
    call RegionAddRect(re, r)
    call TriggerRegisterEnterRegion(t, re, b)
    call TriggerClearActions(t)
    call TriggerAddAction(t, function ClearUnitIndex)
    set udg_UnitIndexerEnabled = true
    loop
        set i = i - 1
        call GroupEnumUnitsOfPlayer(bj_lastCreatedGroup, Player(i), b)
        exitwhen i == 0
    endloop
    call RemoveRect(r)
    set re = null
    set r = null
    set t = null
    set b = null
    set udg_UnitIndexEvent = 3.00
    set udg_UnitIndexEvent = 0.00
endfunction

//===========================================================================
function InitTrig_Unit_Indexer takes nothing returns nothing
    set gg_trg_Unit_Indexer = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Unit_Indexer, function Trig_Unit_Indexer_Actions )
endfunction

 

[Darkfang]

Is there a function to deal reflect damage without a loop?

 

[Bribe]

Detecting code damage would be nice

The only way to possibly do this is if you set NextDamageType right before for each of the Unit - Damage Target natives you have. However, right now I don't have any provisions in the engine to identify for the user if that was even the case.

Can you please let me know what benefits this type of feature would otherwise have?

Is there a function to deal reflect damage without a loop?

Sorry, but what would you need a loop for? The system already knows how to deal with recursive damage, so the only thing I would advise doing is to turn off the trigger that deals the reflected damage, then issue the Unit - Damage Target order, then turn the trigger back on.

 

[chopinski]

Can you please let me know what benefits this type of feature would otherwise have?

its useful for conditional modifications, thats the only reason i picked PDD Damage Engine instead of yours. Lets say you want to modify an instance of damage dealt by code, instead of by an attack or a spell, is it possible right now? i think the only thing you should add is a custom UnitDamageTarget function that represents a coded damage instance and check for damege type in the OnDamage function before you change the value of the real variables that fire up the events. But honestly, since the addition of native damage event, specially for those who create triggers using Jass/vJass, damage engines are now trivial and only useful until generic detection comes to gui.

 

[Darkfang]

The advantage Is that if I have 2 units with damage reflection abilities there wont be am infinite loop that destroys the map, there are other ways I can fix it like a noloopgroup so Is no big deal. This system Is better, PDD causes devour to heal the devoured Unit and cannibalize to stop when damaged, also causes poison to always kill and so on. For what I have seen so dar your system has none of it so I will stay with it.

 

[Bribe]

its useful for conditional modifications, thats the only reason i picked PDD Damage Engine instead of yours. Lets say you want to modify an instance of damage dealt by code, instead of by an attack or a spell, is it possible right now? i think the only thing you should add is a custom UnitDamageTarget function that represents a coded damage instance and check for damege type in the OnDamage function before you change the value of the real variables that fire up the events. But honestly, since the addition of native damage event, specially for those who create triggers using Jass/vJass, damage engines are now trivial and only useful until generic detection comes to gui.

I agree the function could be added, but I think the easiest way is with NextDamageType before dealing damage. I will look into the options, but you've given me something to consider for the next release (which is coming soon).

I disagree that the engine is not needed - just that the complexity could be reduced. It is ultimately up to the mapmaker to assess how damage modification should be handled between systems. Damage Engine does a lot of analysis for the user to keep things simple, compatible and as intuitive as I can make it.

The advantage Is that if I have 2 units with damage reflection abilities there wont be an infinite loop that destroys the map, there are other ways I can fix it like a noloopgroup so is no big deal. This system Is better, PDD causes devour to heal the devoured Unit and cannibalize to stop when damaged, also causes poison to always kill and so on. For what I have seen so dar your system has none of it so I will stay with it.

In the next update the system will ignore DAMAGE_TYPE_UNKNOWN so you can use that as an alternative to disabling both triggers and then dealing the damage. I found that damage type to be only used in events where you don't want it to - such as when a unit gets hit by a debuff.

 

[Mech_Warrior]

Hey Bribe. Great system, I love it and it's very useful to me!

I have one problem with using it. I have some spells in the game that are not supposed to deal any damage. For some reason, those spells are causing the targeted unit to receive 1 Damage every time they're hit with it. This includes many single-target abilities, such as Soul Burn, Firebolt, and Web.

Any idea why this is happening? I'm using the most up to date version of this system, and the most up to date Warcraft III version as well.

Thanks!

 

[Wareditor]

@Mech_Warrior that's a 1.31 bug afaik.

 

[El Saif]

Hmm.. bribe, is this a map from ptr? because i had to re-save it to test the map. If i didn't re-save it it would unable to test.
And, this version is still give me recursion error when i test it still in the demo map. I'm not sure to implement it to my map. The 1.31 patch is still bugged so.

 

[Bribe]

Hmm.. bribe, is this a map from ptr? because i had to re-save it to test the map. If i didn't re-save it it would unable to test.
And, this version is still give me recursion error when i test it still in the demo map. I'm not sure to implement it to my map. The 1.31 patch is still bugged so.

Make sure you download the one without a title

 

[El Saif]

Make sure you download the one without a title

Oh yeah, i'm testing the one without the title. It's still gives me error while the Archimonde attack, he sometimes kill. It gives me error too while one or more units is damaging each other.
And for the testing problem, is that a problem with registry or what? what should i change in the registry editor?

 

[Cebi]

Hi, still learning the code, so I noticed that all summoned units cannot do damage to hero characters, in fact they heal those characters instead, so my infernal actually becomes useless when fighting a hero, is this supposed to be the case and if so, how can I change that? I understand that the water elemental specifically should heal the Archmage, but I feel like it being extended to all summon types and also against enemy heroes is a bit.... odd...

 

[Devalut]

You're using test triggers, the test map makes summoned units heal.

Remove set damage trigger

 

[Cebi]

You're using test triggers, the test map makes summoned units heal.

Remove set damage trigger

Ah ty, woopsie doopsie, still I like the idea of summoned units healing their owners, might have to look at the code and see what I can do with it.

 

[Bribe]

The release of 5.1 (and the documentation) is taking a bit longer than planned due to recursive mitigation measures. I've got the recursive damage in a queue now rather than a recursive method, but it is very challenging to get the execution order right as well as to preserve the variables. I've almost got it, but it's been taking up many hours of my time trying to debug it. The goal is to make it MUCH easier and less risky to deal damage from a damage event.

 

[Devalut]

I'm so pleased to see you working to make your system better and better.

 

[LimitingBounds]

Wonderful system. I use this on an inhouse map I have with my friends. Tho one minor observation.

If an unindexed unit deals damage, unindexed as in via the Turn Off/Turn On thing with the Unit Indexer that comes with the DDS, the damage dealt by it becomes nonlethal.
e.g. i have a Dummy unit that casts Fan of Knives on a target location. The Dummy, unindexed does deal damage enough to drop the affected nearby enemies to 1 but they are not killed.

 

[Bribe]

Wonderful system. I use this on an inhouse map I have with my friends. Tho one minor observation.

If an unindexed unit deals damage, unindexed as in via the Turn Off/Turn On thing with the Unit Indexer that comes with the DDS, the damage dealt by it becomes nonlethal.
e.g. i have a Dummy unit that casts Fan of Knives on a target location. The Dummy, unindexed does deal damage enough to drop the affected nearby enemies to 1 but they are not killed.

I presume you're on Damage Engine version 3.8? So the dummy unit who deals the damage I think is ignored in the system because he has Locust, but I'm not 100% sure. If you send me your map I can look into it and find out.

 

[wc3neverdies]

Extremely useful and easy to use, amazing

 

[pick-a-chew]

• !!!DEPRECATED FEATURE!!! Do not Turn off your trigger prior to dealing damage. Instead, Set DamageEventTrigger = (This trigger), then deal the damage. Alternatively, use DAMAGE_TYPE_UNKNOWN* from the Unit - Damage Target function.
  • * This will ignore the "DamageEvent Equal to 1.00" and only trigger "LethalDamageEvent Equal to 1.00" and "DamageModifierEvent Equal to 4.00".

Maybe I misunderstood this piece of advice, but i remodeled the way I use damage engine to match these new set of rules and the now the map crashes. This one in particular is what is causing my issues as I'm pretty sure the crashes are due to a recursion loop (trigger 1 causes damage, trigger 2 causes damage in response to trigger 1, trigger 1 causes damage in response to trigger 2 etc.). Obviously when I go back to the old way of turning off and on specific triggers I get the new recursion game message "WARNING: Recursion error...".

I have a feeling the issue wouldn't exist if I had one huge block code of damage engine triggers, but unfortunately due to the size of my project it is necessary for performance reasons to have an essential damage engine trigger and then multiple smaller destructible damage engine triggers which can be removed or turned off from the map during run-time.

Are you aware of such an issue?

 

[Bribe]

Maybe I misunderstood this piece of advice, but i remodeled the way I use damage engine to match these new set of rules and the now the map crashes. This one in particular is what is causing my issues as I'm pretty sure the crashes are due to a recursion loop (trigger 1 causes damage, trigger 2 causes damage in response to trigger 1, trigger 1 causes damage in response to trigger 2 etc.). Obviously when I go back to the old way of turning off and on specific triggers I get the new recursion game message "WARNING: Recursion error...".

I have a feeling the issue wouldn't exist if I had one huge block code of damage engine triggers, but unfortunately due to the size of my project it is necessary for performance reasons to have an essential damage engine trigger and then multiple smaller destructible damage engine triggers which can be removed or turned off from the map during run-time.

Are you aware of such an issue?

Sorry the documentation is prepared for the 5.1 release which isn't prepared itself yet. I will have it ready before Monday for sure. I've got Spirit Link working and now I'm running final tests and making some last minute adjustments to the way the spirit link damage is displayed (because WC3 screws up the values in the damage sequence).

 

[pick-a-chew]

Oh right probably should have noticed the 5.1.0.0 part . I'll just sit tight then! Thanks for the reply.

 

[Bribe]

5.1 has just launched.

Edit: Looks like Ralle updated the map parser. The one to download is the second of the two (the one that says it was just updated).

The demo map has been improved a bit thanks to Maker's awesome Arcing TextTag resource.

I have factored in every damage scenario I can think of - including recursive damage mitigation (now extremely easy an requires minimal effort for the user to prevent a crash) and how spirit link interacts with custom shields/modifications.

The two biggest issues, both of which are extremely minor but due to quirks in the game engine, are:

Spirit Link damage is displayed weirdly. The last unit in a chain gets the highest damage dealt to it (visually), even if it wasn't the actual damage recipient. The unit, when monitoring the HP, still only gets a fractional damage applied against it and that bigger amount still goes to the unit that got hit. Fixing this would require creating a complex Spirit Link modification table and handler. It can be done, but integrating such a monstrosity into this system is more than I care to take on. Actually, I just found out that the DAMAGING and DAMAGED events don't stay in sync for this event. I'll make an update in the next 24 hours to make sure everything has been re-tested and to make sure no damage is overlooked.

I'm also considering moving the ShieldDamageEvent into the DAMAGING event, because it occurs to me that shields should take effect before armor types are applied. The LethalDamageEvent should definitely fire after armor, however. I'm also going to move DamageEvent back into that trigger.

Critical Strike text tags just show the pure damage amount, before any user modifications and before any armor/resistances were set. There's no way to fix this without triggering all instances of critical strike (which is very easy to do with this system).

 

[HenrkIII]

Does this still needed either your Unit Indexer or Unit Event systems?

 

[Bribe]

Does this still needed either your Unit Indexer or Unit Event systems?

No, it requires nothing anymore. Patch 1.31 is truly next-level awesomeness, and Damage Engine is a testament to that.

 

[HenrkIII]

No, it requires nothing anymore. Patch 1.31 is truly next-level awesomeness, and Damage Engine is a testament to that.

Oh that's awesome however i encounter some sort of memory leak when a unit dies on my map. I have a version of your Unit Event System. I'm not sure what causes this. Can you help me out please?

I attached the map im working on. PS: the map I use is for testing purposes only. I would create my own in the future.

Edit: Try Killing any unit to see what I'm saying. TIA

 

[Bribe]

Oh that's awesome however i encounter some sort of memory leak when a unit dies on my map. I have a version of your Unit Event System. I'm not sure what causes this. Can you help me out please?

I attached the map im working on. PS: the map I use is for testing purposes only. I would create my own in the future.

Edit: Try Killing any unit to see what I'm saying. TIA

Without having yet opened your map, I can say I'm familiar with that bug and it was caused by old versions of Unit Event. Update it and see how it goes.

 

[HenrkIII]

Without having yet opened your map, I can say I'm familiar with that bug and it was caused by old versions of Unit Event. Update it and see how it goes.

the current version of the Unit Event im using is the most recent on the hive and that's v2.5.2.0

I'll double check it tomorrow and let you know.

 

[Bribe]

the current version of the Unit Event im using is the most recent on the hive and that's v2.5.2.0

I'll double check it tomorrow and let you know.

I'll look into it tomorrow.

In the meantime, I'm pleased to announce the hotfix to Spirit Link - Damage Engine 5.1.1.0 is here and it reconciles the DamageEventTarget mixup which caused me many hours of grief. Basically, the UNIT_DAMAGED event fires out of sequence for that one, so I had to reset the DamageEventX variables. This fixes it completely.

Now I don't believe anything short of more damage detection natives being added by Blizzard will cause DamageEngine to require further major updates. I'll mostly do optimizations and expand on the documentation at this point.

Please ask questions as they come to you.

 

[Devalut]

In case you missed it:

@Bribe
I recall posing this question to you in the past regarding spell detection, I think it was damage level? (I.e. enhanced attack / black arrow) but is there a simpler method to adding attribute damage to the method I posted?

Ex:
EVENT: detect 0 damage event
CON: source with lv1 custom fireball,
ACTION: remove custom buff_statbasedfireball deal X damage

Relying on buffs is rather fickle as if two over lap in rapid succession then the above method will be less accurate.

On another note, I noticed a strange interaction with attempting to make the carrion swarm stat based, the max damage seemed to limit the targets hit despite being 0 damage and default (300 Max damage), but i'm not sure if I was using 4.0.0.0 or earlier...

 

[Bribe]

In case you missed it:

@Bribe
I recall posing this question to you in the past regarding spell detection, I think it was damage level? (I.e. enhanced attack / black arrow) but is there a simpler method to adding attribute damage to the method I posted?

Ex:
EVENT: detect 0 damage event
CON: source with lv1 custom fireball,
ACTION: remove custom buff_statbasedfireball deal X damage

Relying on buffs is rather fickle as if two over lap in rapid succession then the above method will be less accurate.

On another note, I noticed a strange interaction with attempting to make the carrion swarm stat based, the max damage seemed to limit the targets hit despite being 0 damage and default (300 Max damage), but i'm not sure if I was using 4.0.0.0 or earlier...

I actually got rid of the zero damage event tbh. It's not included in the documentation though. But it does apply towards DamageEventLevel.

As far as Carrion goes, that sounds like an engine limitation of WC3.

 

[Devalut]

I actually got rid of the zero damage event tbh. It's not included in the documentation though. But it does apply towards DamageEventLevel.

As far as Carrion goes, that sounds like an engine limitation of WC3.

I did some more tests and I can't seem to repeat it...

Anywho is there a better way to detect specific hits?
i.e. better than this:

EVENT: detect 0 damage event
CON: source with lv1 custom fireball,
ACTION: remove custom buff_statbasedfireball deal X damage

 

[Bribe]

The condition there could just check if the target unit has that particular buff. I think it's a Boolean comparison.

 

[Devalut]

Yes ( i seemed to have missed putting that in my blurb trigger), however If they come under rapid succession it starts to become less accurate.

 

[Kakerate]

Thanks for touching up on Damage Event, Bribe.

!!!DEPRECATED FEATURE!!! Do not Turn off your trigger prior to dealing damage. Instead, Set DamageEventTrigger = (This trigger), then deal the damage. Alternatively, use DAMAGE_TYPE_UNKNOWN* from the Unit - Damage Target function.

Trying to think of the pros/cons of using Unknown damage. By quirk of how I wrote the damage handling in my map, nested instances of damage COULDNT proc effects related (heal on Spell Damage > 130) With the new rewrite, is nested damage handling like this possible now?

 

[Bribe]

Trying to think of the pros/cons of using Unknown damage. By quirk of how I wrote the damage handling in my map, nested instances of damage COULDNT proc effects related (heal on Spell Damage > 130) With the new rewrite, is nested damage handling like this possible now?

I'll need you to go more in-depth with this. I have a few different ideas in my head of what you're describing, but I would like to first get my understanding right.

Yes ( i seemed to have missed putting that in my blurb trigger), however If they come under rapid succession it starts to become less accurate.

I'm a bit clueless on this one as well. What is failing? The unit not having the buff? Maybe if you share a test scenario where I can reproduce that situation and see what's happening, I'll be able to figure out what's happening there.

 

[Devalut]

Maybe if you share a test scenario where I can reproduce that situation and see what's happening, I'll be able to figure out what's happening there.

Here's a test map:

- Press ESC for all 100 peasants to shoot 1 damage fireballs at the caster, the caster is healed to max on ESC press, note the damage build up from the text (works only if you are selecting the unit being damaged.)

- Standing still you can take 100 damage, move to the right erratically and you will reduce the damage.

Make sure you have the blood mage selected before you hit ESC to see the damage buildup.


(ignore the carrion swarm spell! I forgot to remove it!)

 

[Bribe]

@HenrkIII sorry I didn't get to your map yesterday. I was pretty exhausted.

I've downloaded both maps and will do some investigating today to see what I find.

 

[lolreported]

I'm currently using Damage Engine 3.8.0.0 and I modified it to allow the setup of multiple Spell Damage Reduction items as the version only supported and checked for the Runic Bracers item.
I also made the items Spell Damage Reduction stackable.

Note: I did not use the "Spell Damage Reduction"-ability for my items; I assigned a real value for each item-type in the config and made the following change in the OnUnitDamage function:

Code

function OnUnitDamage takes nothing returns boolean
    local boolean override = udg_DamageEventOverride
    local integer i
    local integer j = 0
    local integer e = udg_DamageEventLevel
    local integer a = udg_DamageEventAOE
    local string s
    local real prevAmount
    local real life
    local real prevLife
    local unit u
    local unit f
    call CheckDamagedLifeEvent(false) //in case the unit state event failed and the 0.00 second timer hasn't yet expired
    set i = udg_DmgEvRecursionN - 1 //Had to be moved here due to false recursion tracking
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        set u                       = udg_DamageEventTarget
        set f                       = udg_DamageEventSource
    elseif i < 16 then
        set udg_LastDmgPrevAmount[i]= udg_DamageEventPrevAmt
        set udg_LastDmgValue[i]     = udg_DamageEventAmount
        set udg_LastDmgSource[i]    = udg_DamageEventSource
        set udg_LastDmgTarget[i]    = udg_DamageEventTarget
        set udg_LastDmgWasSpell[i]  = udg_IsDamageSpell
        set udg_LastDmgPrevType[i]  = udg_DamageEventType
    else
        set s = "WARNING: Recursion error when dealing damage! Make sure when you deal damage from within a DamageEvent trigger, do it like this:\n\n"
        set s = s + "Trigger - Turn off (This Trigger)\n"
        set s = s + "Unit - Cause...\n"
        set s = s + "Trigger - Turn on (This Trigger)"
      
        //Delete the next couple of lines to disable the in-game recursion crash warnings
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(GetLocalPlayer(), 0.00, 0.00, 999.00, s)
        return false
    endif
    set udg_DmgEvRecursionN     = i + 2
    set prevAmount              = GetEventDamage()
    set udg_DamageEventTarget   = GetTriggerUnit()
    set udg_DamageEventSource   = GetEventDamageSource()
  
    set udg_DamageEventAmount   = prevAmount
  
    set udg_DamageEventType     = udg_NextDamageType
    set udg_NextDamageType      = 0
    set udg_DamageEventOverride = udg_NextDamageOverride
    set udg_NextDamageOverride  = false
  
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        if udg_DamageEventType == 0 then
            if f == udg_DamageEventSource then
                //Source has damaged more than once
                if IsUnitInGroup(udg_DamageEventTarget, udg_DamageEventAOEGroup) then
                    //Added 5 August 2017 to improve tracking of enhanced damage against, say, Pulverize
                    set udg_DamageEventLevel = udg_DamageEventLevel + 1
                    set udg_EnhancedDamageTarget = udg_DamageEventTarget
                else
                    //Multiple targets hit by this source - flag as AOE
                    set udg_DamageEventAOE = udg_DamageEventAOE + 1
                endif
            else
                //New damage source - unflag everything
                set u = udg_DamageEventSource
                set udg_DamageEventSource = f
                call DmgEvOnAOEEnd()
                set udg_DamageEventSource = u
            endif
            call GroupAddUnit(udg_DamageEventAOEGroup, udg_DamageEventTarget)
        endif
        if not udg_DmgEvStarted then
            set udg_DmgEvStarted = true
            call TimerStart(udg_DmgEvTimer, 0.00, false, function DmgEvOnExpire)
        endif
    endif
  
    if prevAmount == 0.00 then
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEventPrevAmt = 0.00
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 2.00
            set udg_DamageEvent = 0.00
        endif
        call DmgEvResetVars()
    else
        set u = udg_DamageEventTarget
        set udg_IsDamageSpell = prevAmount < 0.00
        if udg_IsDamageSpell then
            set prevAmount = -udg_DamageEventAmount
            set life = 1.00
            if IsUnitType(u, UNIT_TYPE_ETHEREAL) and not IsUnitType(u, UNIT_TYPE_HERO) then
                set life = life*udg_DAMAGE_FACTOR_ETHEREAL //1.67
            endif
            if GetUnitAbilityLevel(u, 'Aegr') > 0 then
                set life = life*udg_DAMAGE_FACTOR_ELUNES //0.80
            endif

//================ =============== =============== ===============
// ================= I added this part below =============== ===============
//================ =============== =============== ===============

            loop
                exitwhen(j > udg_DmgEvSpellResistItem_Max)

                if udg_DmgEvSpellResistItem_Type[j] != 0 and IsUnitType(u, UNIT_TYPE_HERO) then
                    //Inline of UnitHasItemOfTypeBJ without the potential handle ID leak.
                    set i = 6
                    loop
                        set i = i - 1
                        if GetItemTypeId(UnitItemInSlot(u, i)) == udg_DmgEvSpellResistItem_Type[j] then
                            set life = life*udg_DmgEvSpellResistItem_Amount[j]
                            //exitwhen true
                        endif
                        exitwhen i == 0
                    endloop
                endif
                set i = 0
                set j = j + 1
            endloop

//================ =============== =============== ===============
//================ =============== =============== ===============
//================ =============== =============== =============== 

            set udg_DamageEventAmount = prevAmount*life
        endif
        set udg_DamageEventPrevAmt = prevAmount
        set udg_DamageModifierEvent = 0.00
        if not udg_DamageEventOverride then
            set udg_DamageModifierEvent = 1.00
            if not udg_DamageEventOverride then
                set udg_DamageModifierEvent = 2.00
                set udg_DamageModifierEvent = 3.00
            endif
        endif
        set udg_DamageEventOverride = override
        if udg_DamageEventAmount > 0.00 then
            set udg_DamageModifierEvent = 4.00
        endif
        set udg_DamageModifierEvent = 0.00
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 1.00
            set udg_DamageEvent = 0.00
        endif
        call CheckDamagedLifeEvent(true) //in case the unit state event failed from a recursive damage event
      
        //All events have run and the damage amount is finalized.
        set life = GetWidgetLife(u)
        set udg_DmgEvTrig = CreateTrigger()
        call TriggerAddCondition(udg_DmgEvTrig, Filter(function PreCheckDamagedLifeEvent))
        if not udg_IsDamageSpell then
            if udg_DamageEventAmount != prevAmount then
                set life = life + prevAmount - udg_DamageEventAmount
                if GetUnitState(u, UNIT_STATE_MAX_LIFE) < life then
                    set udg_LastDamageHP = life - prevAmount
                    call UnitAddAbility(u, udg_DamageBlockingAbility)
                endif
                call SetWidgetLife(u, RMaxBJ(life, 0.42))
            endif
            call TriggerRegisterUnitStateEvent(udg_DmgEvTrig, u, UNIT_STATE_LIFE, LESS_THAN, RMaxBJ(0.41, life - prevAmount/2.00))
        else
            set udg_LastDamageHP = GetUnitState(u, UNIT_STATE_MAX_LIFE)
            set prevLife = life
            if life + prevAmount*0.75 > udg_LastDamageHP then
                set life = RMaxBJ(udg_LastDamageHP - prevAmount/2.00, 1.00)
                call SetWidgetLife(u, life)
                set life = (life + udg_LastDamageHP)/2.00
            else
                set life = life + prevAmount*0.50
            endif
            set udg_LastDamageHP = prevLife - (prevAmount - (prevAmount - udg_DamageEventAmount))
            call TriggerRegisterUnitStateEvent(udg_DmgEvTrig, u, UNIT_STATE_LIFE, GREATER_THAN, life)
        endif
    endif
    set u = null
    set f = null
    return false
endfunction

With Damage Engine 5.1.1.1 the Spell Damage Reduction config and functionality is removed and by default the "Spell Damage Reduction"-ability isn't stackable.

So when I update, I'm not sure how I would implement the previous behaviour (as the entire Damage Engine trigger appears to be changed)?


Keep up the great work!

 

[Bribe]

You would still use your Real Variable comparisons per item ID. The system removed the dependency on hacky Object Editor data, but did not remove the requirement for you to manually register stacking multiple different resistence items or other conditions.

So your code would stay roughly the same in the end.

 

[lolreported]

You would still use your Real Variable comparisons per item ID. The system removed the dependency on hacky Object Editor data, but did not remove the requirement for you to manually register stacking multiple different resistence items or other conditions.

So your code would stay roughly the same in the end.

I'm uncertain where to modify the code in the "Damage Engine"-trigger to replicate the previous behaviour.

However, I guess I could simply modify the damage in a DamageModifierEvent instead, not sure why I should complicate things.

Thanks for the quick reply!