- Joined
- May 26, 2009
- Messages
- 1,829
I skimmed over the code (will go over more in-depth at a later time, some quick things I noticed:
- You have duplicate code for "Custom script: call RemoveLocation( udg_point[1] )" when you recycle, it would need to be done regardless of the outcome of the IF statement so just use the lines once after the IF statement instead of duplicating the code and putting it in both the then and else actions
- Your variable names are too generic, please attach a meaningful prefix to them like "CavAtk_" or something similar, and make the names match their purpose "real" is too generic to understand the purpose of the variable
- Use an in-game screenshot, there's little to no reason for a spell to not use one
- Your trigger/folder names aren't appropriate "123" as a folder means nothing, and "Init" & "dead", etc. don't mean much either please name them appropriate to their purpose (Prefix also applies here)
- Spells should note have game message code inside them, remove this or put it in separate triggers in a different folder to differentiate them
- The same as above applies for test features
- You lack a proper configuration (this should be in the same location as your hashtable setup, rather than put inside the other triggers
- Your spell doesn't support multiple levels
- Why is temp_unit an array variable? from what I can tell there's no need
- Why do you need two hash tables? this could surely be done with 1 and reserve much less memory
- Your loop should be turned off when the ability isn't in use at all rather than being permanently on
For the time being this will be set to awaiting update due to the above points
- You have duplicate code for "Custom script: call RemoveLocation( udg_point[1] )" when you recycle, it would need to be done regardless of the outcome of the IF statement so just use the lines once after the IF statement instead of duplicating the code and putting it in both the then and else actions
- Your variable names are too generic, please attach a meaningful prefix to them like "CavAtk_" or something similar, and make the names match their purpose "real" is too generic to understand the purpose of the variable
- Use an in-game screenshot, there's little to no reason for a spell to not use one
- Your trigger/folder names aren't appropriate "123" as a folder means nothing, and "Init" & "dead", etc. don't mean much either please name them appropriate to their purpose (Prefix also applies here)
- Spells should note have game message code inside them, remove this or put it in separate triggers in a different folder to differentiate them
- The same as above applies for test features
- You lack a proper configuration (this should be in the same location as your hashtable setup, rather than put inside the other triggers
- Your spell doesn't support multiple levels
- Why is temp_unit an array variable? from what I can tell there's no need
- Why do you need two hash tables? this could surely be done with 1 and reserve much less memory
- Your loop should be turned off when the ability isn't in use at all rather than being permanently on
For the time being this will be set to awaiting update due to the above points