1. Are you planning to upload your awesome spell or system to Hive? Please review the rules here.
    Dismiss Notice
  2. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  3. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still havn't received your rank award? Then please contact the administration.
    Dismiss Notice
  4. We have recently started the 16th edition of the Mini Mapping Contest. The theme is mini RPG. Do check it out and have fun.
    Dismiss Notice
  5. Choose your ride to damnation in the 5th Special Effect Contest Poll.
    Dismiss Notice
  6. The winners of the 13th Techtree Contest have been announced!
    Dismiss Notice
  7. The 13th Music Contest Poll is up! Vote for the best tracks in this symphony of frost and flame.
    Dismiss Notice
  8. Race against the odds and Reforge, Don't Refund. The 14th Techtree Contest has begun!
    Dismiss Notice
  9. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

[vJASS] Charme and Fear Spellpack 1.00

Submitted by Majin
This bundle is marked as approved. It works and satisfies the submission rules.
This spellpack contains 5 and a half spells, they are all realeted with temporary changing ownership of a unit without using unit custom values.

the spellpack contains: Fear, Charm, Berserk, Confusion, Turn Undead and Mass Confusion (i did that just for the fun to see a bunch of units fighting each other).

Spells are easily customizable and it's possibile to make similar spells with the same ease (actually the code of these spells are very similar).

It uses Vexorian's Handle Timers Function and Captain Griffen's Attach Timer Function.

IT USES vJASS SYNTAX, SO IT REQUIRES JASS NEW GEN PACK TO BE MODIFIED

Since this is one of my first spells i've surely messed something up, so any comment is very appreciated.

ChangeLog

- 1.00
Final Release (hopefully)
Removed some leaks i missed when i made the map (shame on me)

- 0.91
Fixed Some Bugs (thanks to Deuterium for the tips)

- 0.9
First Release



Keywords:
fear, charm, charme, enchantress, vJASS, berserk, rage, player, change, change player, player changer, owner, change owner, Confusion, Undeads, turn u
Contents

Charge Spell (Map)

Reviews
Moderator
18:36, 21st Sep 2009 The_Reborn_Devil: Triggering looks nice and it's well documented. Leaks are also fixed now. Spells approved. I give these spells the rating useful.
  1. 18:36, 21st Sep 2009
    The_Reborn_Devil:

    Triggering looks nice and it's well documented. Leaks are also fixed now.

    Spells approved.
    I give these spells the rating useful.
     
  2. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    Yesterday when i completed the spell i was quite tired so i probably messed something up. Any comment or suggestion will be very appreciated :)
     
  3. Septimus

    Septimus

    Joined:
    May 3, 2008
    Messages:
    4,174
    Resources:
    49
    Packs:
    1
    Maps:
    35
    Spells:
    8
    Tutorials:
    5
    Resources:
    49
    Everything seems to be ok. But it would be better to let someone with more experience to judge it. :p
     
  4. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Deut's Brief Spell Review:

    Charme and Fear Spellpack 0.9
    [-]

    1. Although your library PlayerChanger uses the HandleTimers library, you didn't use the requires keyword in PlayerChanger.

    Thus,
    Code (vJASS):
    library PlayerChanger initializer Init


    Should be,
    Code (vJASS):
    library PlayerChanger initializer Init requires HandleTimers

    (I'm not sure if intializer comes before requires or vice versa)



    [+]

    2. Bugless and scripting is well done


    3. MUI


    4. Leakless


    5. Adjustable and user friendly


    6. Documented


    7. Some nice ideas



    [*]

    8. No big issue really, that's why it's not mentioned in the negative part, but you could replace this:
    Code (vJASS):
    call PlaySound( "Sound\\Interface\\Error.wav" )


    With:
    Code (vJASS):
        local sound s = CreateSound("Sound\\Interface\\Error.wav", false, false, true, 12700, 12700, "")
        call StartSound(s)
        call KillSoundWhenDone(s)
        set s = null




    [*]

    This is a well-done spell pack. I might not be a fan of the ideas myself, yet I won't deny the fact that they're nice and could be useful.
    I'd advice people to use such spells.


    Well, I liked most of the spells, except Turn Undead for it's a complicated one (well not complicated to use, but seems as if you've got 3 spells in one).

    I skimmed through the trigger, and it seemed all fine - yet I might have missed some stuff as I only "skimmed".

    Great job Majin!
     
    Last edited: Jul 23, 2009
  5. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    I surely missed the "requires" and been lucky that the compiler (interpreter or whatev) put the code of the Handletimers library before the PlayerChanger library, i will fix that now :) i know i often forget to put requires but usually i get some warning, this time the error made his way till here unnoticed :p

    Turn Undead is taken from a Role Playing Game called D&D (Dungeons and Dragons) so i took the idea from that (modified with some personal flavour and adapted to Warcraft mechanics).
    In D&D Turn Undead depends on the level difference between the undead and the caster, they get feared or killed (if you are a good caster), Frightened (cowering in fear) or "mind-controlled" (if you are an evil caster), and that's how the idea came out

    Thanks for your review :) Fixing that requires now
     
  6. Kwah

    Kwah

    Joined:
    May 9, 2007
    Messages:
    3,391
    Resources:
    8
    Icons:
    5
    Maps:
    1
    Tutorials:
    2
    Resources:
    8
    Saved, not just modified.
     
  7. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    Well, if you Modify it then you would probably want to save it, ergo...
     
  8. Kwah

    Kwah

    Joined:
    May 9, 2007
    Messages:
    3,391
    Resources:
    8
    Icons:
    5
    Maps:
    1
    Tutorials:
    2
    Resources:
    8
    It also can't be imported into different maps, which is the technical purpose of it's existence.
     
  9. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    sorry, what?
     
  10. FranzFerenc

    FranzFerenc

    Joined:
    Jul 23, 2009
    Messages:
    11
    Resources:
    0
    Resources:
    0
    Pls, I have to know how to export spells and use them...
    It's stupid use them only in their map.
    I can't understand how to do it...
     
  11. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Is this really worth mentioning and arguing upon? :p But yes you are right...
     
  12. Lambdadelta

    Lambdadelta

    Joined:
    Jul 6, 2009
    Messages:
    721
    Resources:
    1
    Maps:
    1
    Resources:
    1
    Umm..... I like the concept. But it didn't really interest me that much... lol... I'm a fan of eye-candy.
     
  13. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    I'm a fan of coding instead :wink:
     
  14. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Well, you can have eye-candy alongside with coding ;)
     
  15. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    Or you can have great coding and put some effects just as example then let the final user choose his eye-candy special effects ;)

    Also those aren't the kind of spells that would require a lot of special effects, don't you think so?
     
    Last edited: Jul 24, 2009
  16. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Well that's why as you see I didn't mention SFX in the review... 'cause you can't include much eye-candy...

    Yet, it usually is nice if the creator picks some great eye-candy by default... as a treat to the users ;)
     
  17. Majin

    Majin

    Joined:
    Mar 24, 2008
    Messages:
    181
    Resources:
    2
    Spells:
    2
    Resources:
    2
    Yeah, surely eye-candy attracts users, but i'm not the kind of person that would put too many effects on a spell (I like simplicity)...Altough, should i ever make some "epic" spell, i'll spend much more time on the effects :)

    By the Way, i've fixed both the requires on the library and the PlaySound function :)
     
  18. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Well I agree on the eye-candy part, I'm a fan of simplicity too...

    Ummm, if you fixed those than it's all well-done! GoodJob!
     
  19. FranzFerenc

    FranzFerenc

    Joined:
    Jul 23, 2009
    Messages:
    11
    Resources:
    0
    Resources:
    0
    Export spell etc

    @majin


    "It also can't be imported into different maps, which is the technical purpose of it's existence.

    sorry what?"
    -

    the spell

    I want to know it too. I've downloaded "jassnewgenpack5d" (right?) but I can't do it the same... I mean saving/import/export etc

    HEEEEEEEELLLLLLLLLLLLLPPPPPPPPPPPPPPPPPPPPPPP