The Twisted Pack ! [Rmx]

[Moderator]

13:36, 14th Jun 2010
Hanky:
Your spellpack looks fine enough for an approval. Just the index system of your spells is kinda ineffective and you could add some more documentation.

But well I think your spellpack is useful enough. So I'll approve it.

 

[Rmx]

Screen shot is OH ... bad .. try spells ingame ^^

 

[Yearight]

Nice I didn't really like the jump but the other were nice.

 

[Paladon]

It's very nice to see a new spellpack from you.
Maybe i should just check the section more often, i however did not see one from you for a while.
I like the general conception and execution, this flying height setting with a rate of 10000000 can be shortened to simply 0.
Still, i'm not sure whether you did or not, but it is very recommendable to add a Z-Detection to these bombs and missiles exploding on flying unit contact.

 

[Rmx]

Ohh thank you Paladon ^^ ... also Yearight ^^

 

[Just Fear]

I think 3rd magic needs just a dummy spell that change direction.
And i think it will be great if bomber really flyes from the sky, maybe set the hight to 500-600 then simply set it to 300 at 200-300 or something else.
And the spells are great!

 

[Lambdadelta]

Nice. I didn't spot any leaks. The only thing is:

CONFIGURABLES. Your code, being very big, is hard to configure without having to scan through the triggers and manually replacing.... eg. make another global for string effects, and damage, range, etc and place them in a init trigger.

 

[baassee]

gaahh not again

downloading ...

-Review 2.0-

- Napalm Bomber -

- First of all there seem to be some kind of bug there while cast, the dummy seems to have perm immo cause when the bird is in the air the units walk away from it cause of taking damage

- change heigght rate to 0

- skip casting unit, triggering is faster

- fix documentation!

wont review better, have to quit going on vacation again but it seems that you have to put some more time on these ones cause the docu sux badly and also you need to change some stuff cause it all aint good at all like random angles/range and such should be variablized else you know that I think this is some good stuff but still you might spend some time documentating?

good job

regards

an old friend

~baassee

 

[Rmx]

Uffff baassee .... could you document my spells :O ... i don't have alot of time to make documentation ... i wish i could ^^

Also i will update like i said it is beta patch.

 

[baassee]

haha have no time now to documentate your spells now but we'll see in the future

got it

 

[calex3]

spells are nice ...especially that seconds spell() ......but you don't have documentation!....it is harder to understand without it..... 4.9/5 ....fix and it will be 5/5

 

[Deuterium]

Actually nice idea, but one advice about the napalm bomb, either remove the "minimum range thing" (that usually pisses me off), or use a variable where the user can set minimum range (zero means none) and then in that case use the "SimError" system - it's in Jass, but you know enough to use SimError in a Custom Script, and in case you get stuck on something I can help.

 

[Rmx]

Thank you msaeed28 or seed for that comment ^^

 

[-Berz-]

Wow, I really like the dagger spell

I'm not really in the mood to write big things, but this is great spell pack =)

I would give it 5/5 but the jump has to many random effect, but still 5/5

 

[Rmx]

Thank you BerZekeR !!!!

 

[hell gate]

a very good spellpack but the unholy power can be easiliy done with locals and ^^ waits and the stormbolt ability and bloodlust.

 

[Rmx]

a very good spellpack but the unholy power can be easiliy done with locals and ^^ waits and the stormbolt ability and bloodlust.

Well bloodlust can't stack .. coz each missile gives 5% growth to the hero size..

Also WAITS omg see my SIG ...

locals ... hmm wonder how to do that .. well mine is MUI and that's what matter

Also really efficient ..

lol thnx for the comment

 

[hell gate]

• timed ability
  • events
  • conditions
  • actions
    • local integer AbilityID = udg_XXX
    • local unit u = udg_XX
    • wait X seconds
    • call UnitRemoveAbility( u , AbilityID )
    • set u = null

 

[Rmx]

LOL but i want it .. when the Missiles enter the HERO .. then i add the damage ..

It will be more difficult than your preview

 

[Aspard]

Fix the Hotkeys, they are wrong

 

[cedi]

Nice spells, but you know, I don't like GUI, so I wont use them .

cedi

 

[Dark_Dragon]

yeah gj RMX! nice spells GUI is fine for me but i wont use the spells xD i need models for my mode :S

 

[Deuterium]

• timed ability
  • events
  • conditions
  • actions
    • local integer AbilityID = udg_XXX
    • local unit u = udg_XX
    • wait X seconds
    • call UnitRemoveAbility( u , AbilityID )
    • set u = null

That wouldn't be MUI however... it's still using globals so the locals are senseless

 

[Dark_Dragon]

That wouldn't be MUI however... it's still using globals so the locals are senseless

nop its MUI, it does not matter do you assign value, global, function value... it matters is it local or global

globals
  integer I = 0
endglobals

function test takes nothing returns nothing
    local integer i = 0
    call Sleep(6)
    call IMsg(i) // displays 0
    set I = 7
    set i = I
    call Sleep(6)
    set I = 65536
    call IMsg(i) // displays 7
endfunction

however spells are fine, but well do it the way u like...

 

[Rmx]

Well thnx guys ... but there is only one new spell in that spellpack ... it was Unholy Power ... i just wanted to update it .. for you to see guys

Thnx all for the comments

 

[dragor89]

tnx i love it

 

[Deuterium]

nop its MUI, it does not matter do you assign value, global, function value... it matters is it local or global

globals
  integer I = 0
endglobals

function test takes nothing returns nothing
    local integer i = 0
    call Sleep(6)
    call IMsg(i) // displays 0
    set I = 7
    set i = I
    call Sleep(6)
    set I = 65536
    call IMsg(i) // displays 7
endfunction

however spells are fine, but well do it the way u like...

But DD, the example he gives is a using a Timer event, so the locals won't be shared like your example when you use wait, since they are local for one function instance.

So to make his example work, he'd have to set them to the globals every instance the timer runs, run two spells with different globals, bug.

Get my point?


EDIT:
Oops, I just noticed he uses a Wait instead of timers, meh... he says timed ability at the top of the trigger so that tricked me.

 

[Rmx]

Lol nice chat guys ... ..

 

[Aspard]

Are you against?

 

[Dark_Dragon]

But DD, the example he gives is a using a Timer event, so the locals won't be shared like your example when you use wait, since they are local for one function instance.

So to make his example work, he'd have to set them to the globals every instance the timer runs, run two spells with different globals, bug.

Get my point?


EDIT:
Oops, I just noticed he uses a Wait instead of timers, meh... he says timed ability at the top of the trigger so that tricked me.

well yeah its timed ability or for example timed effect... as you know in my libs there it DestroyEffectTimed its precious but uses timer not an wait.

thous it is possible to make timed effect without timer only by pointer function, for example...

private function EffTim takes effect e, real t returns nothing
    call Sleep(t)
    call DestroyEffect(e)
endfunction

function DestroyEffectTimed takes effect e, real dur returns nothing
    call EffTim.execute(e, dur)
endfunction

now this is better then my "precious one" if you for example destroy effect after 1 second and have for example 15 effects... then this one would be better, but my one is precious and it will exactly destroy effect in 1 sec or .01 secs if wanted while sleep cant handle that...

the only problem is destroy multiple effects timed at same time its just stupid to load an timer for every effect right? thats why DestroyClusterTimed was added

but yeah hope all is answerd now!
Greets all!
~DD

 

[Rmx]

Are you against?

No i'm not, more comments more pleasure