RainBow ARROW ! [RMX]

Moderator · Jul 28, 2011

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

Maker, 3rd Aug 2011, RainBow ARROW

Required changes:
Importing instructions are lacking. One needs to change the ability in the cast condition and dummy types in the cast trigger and in the depths of the looping trigger.
A separate configuration trigger would be nice, you could set the ability and dummy types there.
Set dummy to can't raise, does not decay so it disappears sooner from the game.
If the projectile speed is set higher than 32, this can fail:

(Distance between RA_Point[2] and RA_Point[3]) Less than or equal to 16.00

Optional changes:
Casting unit -> triggering unit
Add version number
You could create arrays for the effects you set in the cast trigger and initialize them in a separate trigger That way you could avoid the if/then/else snake.
You're doing these anyway regardless of

RA_Change[RA]: Special Effect - Destroy RA_SpecialEffect[RA]

Set RA_SpecialEffect[RA] = (Last created special effect)

The whole if then else could be avoided with arrays or using a hashtable.

Rmx · Jul 28, 2011

Sorry for the complex structure of the spell

Also you will understand why i can't picture everything when you try it out.

Like always .. [ GUI MUI LEAKLESS ]

Have fun and <3 lebanon

-Derp- · Jul 28, 2011

.03 is preferred over .02. It is more efficient and won't have a difference visually if you increase the speed to a proper amount.

Use set bj_wantDestroyGroup = true over setting the variable to a group. It is more efficient.

These can be move outside of the if/then/else block.

Set RA_CountDown[RA_Times] = 50
Set RA_Speed[RA_Times] = 30.00

You should set (Last created unit) to a variable and use the variable in this block:

Then - Actions
- Set RA_Point[5] = (Position of RA_Target[RA])
- Unit - Create 1 Dummy_For_Map for (Owner of RA_Hero[RA]) at RA_Point[5] facing Default building facing degrees
- Unit - Hide (Last created unit)
- Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
- If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  - If - Conditions
    - RA_Change[RA] Equal to 2
  - Then - Actions
    - Unit - Cause RA_Hero[RA] to damage RA_Target[RA], dealing 100.00 damage of attack type Spells and damage type Sonic
    - Unit - Add Dummy Water to (Last created unit)
    - Unit - Order (Last created unit) to Undead Banshee - Curse RA_Target[RA]
    - Special Effect - Create a special effect attached to the origin of RA_Target[RA] using Objects\Spawnmodels\Naga\NagaDeath\NagaDeath.mdl
    - Special Effect - Destroy (Last created special effect)
  - Else - Actions
    - Unit - Add Dummy Cripple to (Last created unit)
    - Unit - Order (Last created unit) to Undead Necromancer - Cripple RA_Target[RA]
    - Special Effect - Create a special effect attached to the origin of RA_Target[RA] using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
    - Special Effect - Destroy (Last created special effect)
- Custom script: call RemoveLocation(udg_RA_Point[5])

Casting Unit -> Triggering Unit

Unit - Create 1 Dummy_For_Map for (Owner of RA_Hero[RA_Times]) at RA_Point[0] facing RA_Angle[RA_Times] degrees
->
Unit - Create 1 Dummy_For_Map for (Triggering Player) at RA_Point[0] facing RA_Angle[RA_Times] degrees

For locations, you may re-use them. You don't have to increase the array [#] every time, because you're destroying them when they're no longer in use.

I liked the spell, it has a very chaotic feel to it.

aaron · Jul 28, 2011

good o'l RMX back to his old GUI tricks

-Derp- said:
.03 is preferred over .02. It is more efficient and won't have a difference visually if you increase the speed to a proper amount.

also, if i remember correctly .02 goes to .03 automatically.

You should set (Last created unit) to a variable and use the variable in this block:

that also has no purpose unless to prevent leaks, in which there is none in this case.

i do agree with you on the "casting to triggering unit".

still much <3 for RMX and best of luck to him.

(excuse me if i got anything wrong in my statements, its been a while)

Jay the Editor · Jul 28, 2011

It's not that cool as the Cosmic Twist and Water Spell Pack >< but still, I love it~

1- almost the same as what -Derp- has commented (0.03 instead 0.02 and triggering unit instead of casting unit)
2- array shouldn't be use unless it's needed. separate the RA_point to different variables

This spell will be better if there are better effects for some of the missile <3
Sorry if there are any mistakes in my opinion =) Good luck RMX! I always love ur spell <3

Rmx · Jul 28, 2011

-Derp- said:
.03 is preferred over .02. It is more efficient and won't have a difference visually if you increase the speed to a proper amount.

It changes automatically to 0.3

. if it doesn't .. well you could change it

.

Use set bj_wantDestroyGroup = true over setting the variable to a group. It is more efficient.

True but still the efficiency won't be a big difference .

These can be move outside of the if/then/else block.

Set RA_CountDown[RA_Times] = 50

Set RA_Speed[RA_Times] = 30.00

I use them in the loop trigger again for other things, so i need them

You should set (Last created unit) to a variable and use the variable in this block:

Then - Actions

Set RA_Point[5] = (Position of RA_Target[RA])

Unit - Create 1 Dummy_For_Map for (Owner of RA_Hero[RA]) at RA_Point[5] facing Default building facing degrees

Unit - Hide (Last created unit)

Unit - Add a 1.00 second Generic expiration timer to (Last created unit)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

RA_Change[RA] Equal to 2

Then - Actions

Unit - Cause RA_Hero[RA] to damage RA_Target[RA], dealing 100.00 damage of attack type Spells and damage type Sonic

Unit - Add Dummy Water to (Last created unit)

Unit - Order (Last created unit) to Undead Banshee - Curse RA_Target[RA]

Special Effect - Create a special effect attached to the origin of RA_Target[RA] using Objects\Spawnmodels\Naga\NagaDeath\NagaDeath.mdl

Special Effect - Destroy (Last created special effect)

Else - Actions

Unit - Add Dummy Cripple to (Last created unit)

Unit - Order (Last created unit) to Undead Necromancer - Cripple RA_Target[RA]

Special Effect - Create a special effect attached to the origin of RA_Target[RA] using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl

Special Effect - Destroy (Last created special effect)

Custom script: call RemoveLocation(udg_RA_Point[5])

It works 100% so no need to use the variable

Casting Unit -> Triggering Unit

Unit - Create 1 Dummy_For_Map for (Owner of RA_Hero[RA_Times]) at RA_Point[0] facing RA_Angle[RA_Times] degrees

->

Unit - Create 1 Dummy_For_Map for (Triggering Player) at RA_Point[0] facing RA_Angle[RA_Times] degrees

Ya ok

but it doesn't leak !!!

For locations, you may re-use them. You don't have to increase the array [#] every time, because you're destroying them when they're no longer in use.

Maybe i wanna use all the locations at the same time in the loop

lol

I liked the spell, it has a very chaotic feel to it.

Thank you for your comment, i really appreciate it

mckill2009 · Jul 28, 2011

First, the spell is pretty good...rating 4.5/5 coz of some minor changes...

Suggestions:
- You spam the Set RA_SpecialEffect[RA_Times] = (Last created special effect) and Set RA_SpecialEffect[RA] = (Last created special effect)

better is...

Set RA_SpecialEffect[RA_Times] = (Last created special effect)
-------- --------------------------------------------------------------------------------------------------------------- --------
-------- --------------------------------------------------------------------------------------------------------------- --------
Custom script: call RemoveLocation(udg_RA_Point[0])
Custom script: call RemoveLocation(udg_RA_Point[1])

- Arrays are slower than normal variables, so no need to array the RA_Point[]
- TriggerUnit and Trigger Player is faster...
- This and a-like is best to store in a real variable >>> (Distance between RA_Point[2] and RA_Point[3]) Less than or equal to 16.00
- Others already mentioned above

Rmx · Jul 28, 2011

First, the spell is pretty good...rating 4.5/5 coz of some minor changes...

Suggestions:
- You spam the Set RA_SpecialEffect[RA_Times] = (Last created special effect) and Set RA_SpecialEffect[RA] = (Last created special effect)

better is...
Set RA_SpecialEffect[RA_Times] = (Last created special effect)
-------- --------------------------------------------------------------------------------------------------------------- --------
-------- --------------------------------------------------------------------------------------------------------------- --------
Custom script: call RemoveLocation(udg_RA_Point[0])
Custom script: call RemoveLocation(udg_RA_Point[1])

- Arrays are slower than normal variables, so no need to array the RA_Point[]
- TriggerUnit and Trigger Player is faster...
- This and a-like is best to store in a real variable >>> (Distance between RA_Point[2] and RA_Point[3]) Less than or equal to 16.00
- Others already mentioned above

10x alot for the comment .. ill fix it soon

Magtheridon96 · Jul 28, 2011

<3 LEBANON!

Anyways, nice spell

One other thing, instead of an if/then/else for checking which sfx to create, you could
set the sfxes in an array and then create the sfx corresponding to the index in the array ^^
Doesn't that sound more efficient?

Rmx · Jul 28, 2011

<3 LEBANON!

Anyways, nice spell
One other thing, instead of an if/then/else for checking which sfx to create, you could
set the sfxes in an array and then create the sfx corresponding to the index in the array ^^
Doesn't that sound more efficient?

It's more complicated than that, i want to create for each different unit a special effect on it's position or want to change it's size ..

So it can't be done like this.

Magtheridon96 · Jul 28, 2011

Oh..
For that, you could use an array, but the index should be
[(Index Mod 6) + 1]

Rmx · Jul 28, 2011

Oh..
For that, you could use an array, but the index should be
[(Index Mod 6) + 1]

I'll think about it

Jazztastic · Jul 28, 2011

I wish that i could provide you all with a better image of the spell, but due to it's big effects, complex structure and complicated ability the spell could not be provided as an image. you have to test it in game.

True but still the efficiency won't be a big difference .

It works 100% so no need to use the variable

Casting Unit -> Triggering Unit

What. The. Fuck. If you have a long, big, effect spammy spell, shouldn't you focus on efficiency? And no, Casting Unit is not better than Triggering Unit. And a variable is better than Triggering Unit.

You also need to follow submission rules and provide a description of what the spell actually does. I'm not going to download it to test unless I find it interesting. View THW as an ad, you want to draw in people to download your spell by making it seem incredibly cool. If you don't even have a description . . . Well, you're not going to get as many downloads.

Rmx · Jul 28, 2011

What. The. Fuck. If you have a long, big, effect spammy spell, shouldn't you focus on efficiency? And no, Casting Unit is not better than Triggering Unit. And a variable is better than Triggering Unit.

You also need to follow submission rules and provide a description of what the spell actually does. I'm not going to download it to test unless I find it interesting. View THW as an ad, you want to draw in people to download your spell by making it seem incredibly cool. If you don't even have a description . . . Well, you're not going to get as many downloads.

I'm really sorry, plz forgive me, PLZzzz

If you don't find the spell interesting do not download it

Due to the fact that the description of the spell is like 100 lines ingame i cannot but it here lol

I would have to rewrite the whole description.

Also triggering and casting unit ... i made it triggering and gonna upload 2mrw the spell happy

it took me 1 minute... now it's 1000% more efficient looool.

Not interesting for you .. but for many people it is.

Magtheridon96 · Jul 28, 2011

If you don't even have a description . . . Well, you're not going to get as many downloads.

One of his resources has 7000 downloads btw

Jazztastic · Jul 28, 2011

Rmx said:
I'm really sorry, plz forgive me, PLZzzz

If you don't find the spell interesting do not download it
Due to the fact that the description of the spell is like 100 lines ingame i cannot but it here lol
I would have to rewrite the whole description.

Also triggering and casting unit ... i made it triggering and gonna upload 2mrw the spell happy it took me 1 minute... now it's 1000% more efficient looool.

Not interesting for you .. but for many people it is.

CnP exists for a reason, copying something from in-game is easy as hell. No you would not have to re-write the whole description. Good job on fixing a mistake that took 1 minute to fix, you should check over your spell before you submit it to avoid things like that. I didn't say it wasn't interesting, only reason I'm pulling teeth here to get a description is because I'm interested. No need for apssive aggressive bullshit here.

One of his resources has 7000 downloads btw

Wrong, he doesn't. Having a description is required by the resource submission rules.

Spells must have an in-game screenshot and an adequate description.

And imagine how many more downloads he would get if people had any idea what the spell did. Moreover, popular opinion doesn't mean it's any good, look at Call of Duty and Avatar (movie).

Magtheridon96 · Jul 28, 2011

Wrong, he doesn't. Having a description is required by the resource submission rules.

Okay Okay 6890 downloads >.>

Rmx · Jul 28, 2011

Okay Okay 6890 downloads >.>

lol really ! :O

Quote:
Originally Posted by Rmx View Post
I'm really sorry, plz forgive me, PLZzzz

If you don't find the spell interesting do not download it
Due to the fact that the description of the spell is like 100 lines ingame i cannot but it here lol
I would have to rewrite the whole description.

Also triggering and casting unit ... i made it triggering and gonna upload 2mrw the spell happy it took me 1 minute... now it's 1000% more efficient looool.

Not interesting for you .. but for many people it is.
CnP exists for a reason, copying something from in-game is easy as hell. No you would not have to re-write the whole description. Good job on fixing a mistake that took 1 minute to fix, you should check over your spell before you submit it to avoid things like that. I didn't say it wasn't interesting, only reason I'm pulling teeth here to get a description is because I'm interested. No need for apssive aggressive bullshit here.

Quote:
One of his resources has 7000 downloads btw
Wrong, he doesn't. Having a description is required by the resource submission rules.
Quote:
Spells must have an in-game screenshot and an adequate description.
And imagine how many more downloads he would get if people had any idea what the spell did. Moreover, popular opinion doesn't mean it's any good, look at Call of Duty and Avatar (movie).

OKAYYYY for all ..... i added the description and fixed EVERYTHING .. made everything more efficient

_________________________________________________________________________________________________________

Magtheridon96 · Jul 28, 2011

lol really ! :O

It was either one of your spell packs or cosmic twist

Jazztastic · Jul 29, 2011

This spell actually does look really cool. Nice description

mckill2009 · Jul 29, 2011

To make things even more efficient and remove those long trigger, it can be done like this...

put this in the Initialization trigger...

EDIT:

SFX is a string array variable...

JASS:

function Setup takes nothing returns boolean
    set udg_SFX[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_SFX[2] = "Abilities\\Spells\\NightElf\\SpiritOfVengeance\\SpiritOfVengeanceBirthMissile.mdl"
    set udg_SFX[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_SFX[4] = "Abilities\\Weapons\\IllidanMissile\\IllidanMissile.mdl"
    set udg_SFX[5] = "Abilities\\Weapons\\AncientProtectorMissile\\AncientProtectorMissile.mdl"
    set udg_SFX[6] = "Abilities\\Weapons\\KeeperGroveMissile\\KeeperGroveMissile.mdl"
    
    set udg_RA_String[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_RA_String[2] = "Abilities\\Spells\\Other\\CrushingWave\\CrushingWaveDamage.mdl"
    set udg_RA_String[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_RA_String[4] = "Abilities\\Spells\\Undead\\CarrionSwarm\\CarrionSwarmDamage.mdl"
    set udg_RA_String[5] = "Objects\\Spawnmodels\\Undead\\ImpaleTargetDust\\ImpaleTargetDust.mdl"
    set udg_RA_String[6] = "Abilities\\Spells\\NightElf\\MoonWell\\MoonWellCasterArt.mdl"
    return false
endfunction

function InitTrig_Setup takes nothing returns nothing
    local trigger t = CreateTrigger()          
    call TriggerRegisterTimerEvent(t, 0.01, false)
    call TriggerAddCondition(t, Condition(function Setup))
    set t = null
endfunction

Then...

RainBow Arrow On
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Rain-Bow Arrow
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - RA_Skip Equal to 0
    - Then - Actions
      - Trigger - Turn on RainBow Arrow Loop <gen>
    - Else - Actions
  - Set RA_Times = (RA_Times + 1)
  - Set RA_Skip = (RA_Skip + 1)
  - Set RA_Off[RA_Times] = True
  - Set RA_Earth[RA_Times] = False
  - Set RA_Fire[RA_Times] = False
  - Set RA_Nature[RA_Times] = False
  - -------- --------------------------------------------------------------------------------------------------------------- --------
  - Set RA_Hero[RA_Times] = (Casting unit)
  - Set RA_Target[RA_Times] = (Target unit of ability being cast)
  - Set RA_Point[0] = (Position of RA_Hero[RA_Times])
  - Set RA_Point[1] = (Position of RA_Target[RA_Times])
  - -------- --------------------------------------------------------------------------------------------------------------- --------
  - Set RA_Speed[RA_Times] = 11.50
  - Set RA_Angle[RA_Times] = (Angle from RA_Point[0] to RA_Point[1])
  - Set RA_Change[RA_Times] = (Random integer number between 1 and 6)
  - Set RA_CountDown[RA_Times] = 50
  - Set RA_Spam[RA_Times] = 0
  - -------- --------------------------------------------------------------------------------------------------------------- --------
  - Unit - Create 1 Dummy_For_Map for (Triggering player) at RA_Point[0] facing RA_Angle[RA_Times] degrees
  - Set RA_Dummy[RA_Times] = (Last created unit)
  - Custom script: set udg_RA_SpecialEffect[udg_RA_Times] = AddSpecialEffectTarget(udg_SFX[udg_RA_Times], udg_RA_Dummy[udg_RA_Times], "chest")
  - -------- --------------------------------------------------------------------------------------------------------------- --------
  - -------- --------------------------------------------------------------------------------------------------------------- --------
  - Custom script: call RemoveLocation(udg_RA_Point[0])
  - Custom script: call RemoveLocation(udg_RA_Point[1])

kellym0 · Jul 29, 2011

wow this spell is very nice. this looks delicous.

8.5/10

only thing, very hard to edit with no documentation! = (( so much reading!

your triggers are very beautyful.

Rmx · Jul 29, 2011

mckill2009

I'm in the progress of making it efficient using only GUI, so i'm gonna finish early i hope

But thank you very much for pointing out this technique

Kellym0

Thank YOU !

mckill2009 · Jul 29, 2011

No probs, just helping

...

Magtheridon96 · Jul 29, 2011

JASS:

function Setup takes nothing returns boolean
    set udg_SFX[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_SFX[2] = "Abilities\\Spells\\NightElf\\SpiritOfVengeance\\SpiritOfVengeanceBirthMissile.mdl"
    set udg_SFX[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_SFX[4] = "Abilities\\Weapons\\IllidanMissile\\IllidanMissile.mdl"
    set udg_SFX[5] = "Abilities\\Weapons\\AncientProtectorMissile\\AncientProtectorMissile.mdl"
    set udg_SFX[6] = "Abilities\\Weapons\\KeeperGroveMissile\\KeeperGroveMissile.mdl"
    
    set udg_RA_String[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_RA_String[2] = "Abilities\\Spells\\Other\\CrushingWave\\CrushingWaveDamage.mdl"
    set udg_RA_String[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_RA_String[4] = "Abilities\\Spells\\Undead\\CarrionSwarm\\CarrionSwarmDamage.mdl"
    set udg_RA_String[5] = "Objects\\Spawnmodels\\Undead\\ImpaleTargetDust\\ImpaleTargetDust.mdl"
    set udg_RA_String[6] = "Abilities\\Spells\\NightElf\\MoonWell\\MoonWellCasterArt.mdl"
    return false
endfunction

function InitTrig_Setup takes nothing returns nothing
    local trigger t = CreateTrigger()          
    call TriggerRegisterTimerEvent(t, 0.01, false)
    call TriggerAddCondition(t, Condition(function Setup))
    set t = null
endfunction

._.

->

JASS:

function InitTrig_SpellSetup takes nothing returns nothing
    set udg_SFX[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_SFX[2] = "Abilities\\Spells\\NightElf\\SpiritOfVengeance\\SpiritOfVengeanceBirthMissile.mdl"
    set udg_SFX[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_SFX[4] = "Abilities\\Weapons\\IllidanMissile\\IllidanMissile.mdl"
    set udg_SFX[5] = "Abilities\\Weapons\\AncientProtectorMissile\\AncientProtectorMissile.mdl"
    set udg_SFX[6] = "Abilities\\Weapons\\KeeperGroveMissile\\KeeperGroveMissile.mdl"
    
    set udg_RA_String[1] = "Abilities\\Weapons\\RedDragonBreath\\RedDragonMissile.mdl"
    set udg_RA_String[2] = "Abilities\\Spells\\Other\\CrushingWave\\CrushingWaveDamage.mdl"
    set udg_RA_String[3] = "Abilities\\Weapons\\FrostWyrmMissile\\FrostWyrmMissile.mdl"
    set udg_RA_String[4] = "Abilities\\Spells\\Undead\\CarrionSwarm\\CarrionSwarmDamage.mdl"
    set udg_RA_String[5] = "Objects\\Spawnmodels\\Undead\\ImpaleTargetDust\\ImpaleTargetDust.mdl"
    set udg_RA_String[6] = "Abilities\\Spells\\NightElf\\MoonWell\\MoonWellCasterArt.mdl"
endfunction

[highlight]Also the index used for the array variables in the GUI trigger should be (RA_Times Mod 6) + 1

(With 7 simultaneous casts, one of the spells would have no effect..[/code]

Rmx · Jul 29, 2011

Im not gonna input any JASS functions in my GUI spell

I want my spells to be strictly GUI MUI

Magtheridon96 · Jul 29, 2011

Im not gonna input any JASS functions in my GUI spell

I want my spells to be strictly GUI MUI

I know, but I still wanted to "ibkha3o"

mckill2009 · Jul 29, 2011

@Mags, that's not gonna work in normal WE unless you put it in the map header...

Magtheridon96 · Jul 30, 2011

@Mags, that's not gonna work in normal WE unless you put it in the map header...

Most GUIers would do that anyways xD

Lich Prince · Jul 30, 2011

whEn i fIRst saw this spell it had no desciption and it suxed but when i recheck and saw it descripshen i notice it much better when i downloaded :thumbs_up:

Rmx · Aug 2, 2011

10x guys

Maker · Aug 2, 2011

aaron said:
also, if i remember correctly .02 goes to .03 automatically.

Rmx said:
It changes automatically to 0.3 . if it doesn't .. well you could change it

It doesn't change automatically

RainBow ARROW ! [RMX]

Land of the Free (Map)

Moderator

Moderator

Similar threads