[Trigger] Text Message

[AlwaysAndForever]

What's wrong? That only shows the first message!

Spoiler

• Notice 1
  • Events
    • Unit - A unit Begins an upgrade
  • Conditions
  • Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (Triggering unit)) Equal to (==) Town Hall (2)
      • Then - Actions
        • Game - Display to (All players) the text: (String_PlayerColors[(Player number of (Triggering player))] + has constructed the |cffffcc00Town Hall (2).|r)
        • Trigger - Turn off (This trigger)
      • Else - Actions
        • Do nothing
    • -------- /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// --------
      • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Triggering unit)) Equal to (==) Town Hall (3)
        • Then - Actions
          • Game - Display to (All players) the text: (String_PlayerColors[(Player number of (Triggering player))] + has constructed the |cffffcc00Town Hall (3).|r)
          • Trigger - Turn off (This trigger)
        • Else - Actions
          • Do nothing
    • -------- /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// --------
      • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Triggering unit)) Equal to (==) Town Hall (4)
        • Then - Actions
          • Game - Display to (All players) the text: (String_PlayerColors[(Player number of (Triggering player))] + has constructed the |cffffcc00Town Hall (4).|r)
          • Trigger - Turn off (This trigger)
        • Else - Actions
          • Do nothing

 

[Tasyen]

Turned off triggers do not activade themself by events.

 

[AlwaysAndForever]

If I not using turn off, so what can I use for the text! that text works for the first time, not every time when I built something.

 

[Tasyen]

you could split it in 4 triggers
or place players into a force if that should be player unique.

 

[AlwaysAndForever]

Yes I've used 3 parts before, but I want shorter triggers... So I try to use forces

 

[Tasyen]

question happens that once per player or once per unit type.

 

[AlwaysAndForever]

Both

 

[Tasyen]

so for each player the first time the built the townhall.
There is also an count units of unittype of player, might check it beeing 1.
Hmm but that counter thing has the disadvantage procing again when building an second one.

 

[Pyrogasm]

You can delete the "Do Nothing" lines, they're literally pointless. Instead of "Trigger - Turn off" you want to use the action "Skip remaining actions".

 

[Illidan(Evil)X]

Shorter triggers you say? Try a hashtable.

• Upgrade
  • Events
    • Unit - A unit Finishes an upgrade
  • Conditions
    • (Load (Key (Name of (Triggering unit))) of (Player number of (Triggering player)) from UpgradeTable) Equal to False
  • Actions
    • Hashtable - Save True as (Key (Name of (Triggering unit))) of (Player number of (Triggering player)) in UpgradeTable
    • Game - Display to (All players) the text: ((Name of (Triggering player)) + ( upgraded to + (Name of (Triggering unit))))

 

[Chaosy]

I think it can be done without hashtables, and a hashtable would just make that trigger shorter it would have a larger setup instead, the overall gain is probably very small.

Try

set upgraded = triggering unit
if ANY conditions are true

upgraded is equal to townhall (1)
upgraded is equal to townhall (2)
upgraded is equal to townhall (3)​

Then

Display message Name of triggering player + upgraded to + name of upgraded
​

Turning off the trigger does not seem needed to me here.

​

 

[Illidan(Evil)X]

it would have a larger setup instead

No, that's literally all there is to it. No setup is required.

 

[Pyrogasm]

Actually you wrote Triggering Player where it should be Owner of (Triggering Unit).

 

[Illidan(Evil)X]

@Pyrogasm ... It's a player unit event. Triggering player returns the owner of the triggering unit.

 

[Chaosy]

No it does not. triggering player only works for player events.

I tried the following in a temp map:

• Melee Initialization
  • Events
    • Unit - A unit enters Region 000 <gen>
  • Conditions
  • Actions
    • Game - Display to (All players) the text: 1
    • Game - Display to (All players) the text: (Name of (Triggering player))

"1" gets written but not the second one.

 

[Illidan(Evil)X]

@Chaosy ... Maybe if you tried a player unit event and not a game event?

constant gameevent EVENT_GAME_ENTER_REGION = ConvertGameEvent(5)
constant playerunitevent EVENT_PLAYER_UNIT_UPGRADE_FINISH = ConvertPlayerUnitEvent(31)

 

[Pyrogasm]

Yeah it works for playerunitevents. Honestly I didn't know you could use GetTriggerPlayer() in the playerunitevent responses. Logical but nothing actually suggests you can do that because, you know, no player actually causes the event to happen.

 

[Chaosy]

But that is not in any given example so I do not see how that is relevant here

 

[IcemanBo]

Unit events that are registered for a specic player can use TriggeringPlayer.

call TriggerRegisterPlayerUnitEvent(trigger, player, playerunitevent, null) -- is the used function.

For example, "A unit dies" does call the above function with EVENT_PLAYER_UNIT_DEATH for all players.

==

"A unit enters region" looks like (Chaosy, your example)

function TriggerRegisterEnterRectSimple takes trigger trig, rect r returns event
    local region rectRegion = CreateRegion()
    call RegionAddRect(rectRegion, r)
    return TriggerRegisterEnterRegion(trig, rectRegion, null)
endfunction

^which does not register any player event. TriggeringPlayer can't be used here.