Storing All Players to variable question

[matisko666]

As the title says, is it really necessary to store All Players to variable if it's used more than once in a trigger?

 

[PurgeandFire]

Well, it isn't necessary. However, it is recommended to do so efficiency-wise.

When you use (All Players), it calls:

function GetPlayersAll takes nothing returns force
    return bj_FORCE_ALL_PLAYERS
endfunction

(iirc)

So each time you use "All Players", it is performing an extra function call. This does not generate a new force, so you're not leaking. However, assigning it to a global means that you'll read a global (fast) instead of reading a function (slower).

For personal mapping, this usually doesn't matter though (except when the op limit is an issue). It is a matter of nanoseconds and no player will ever notice the difference. As such, it is up to you.

 

[deathismyfriend]

yes it should be stored. never destroy all players
You can actually store it into a variable call allPlayers then never destroy it and use it for everything instead of all players.

 

[matisko666]

So can I store All Players at map's initialization?

 

[PurgeandFire]

Yes, you can. Although, it may not have been loaded yet (certain bj_ globals are loaded on Init). You may want to try doing it on "Time - Elapsed time is 0.00 seconds" if it doesn't work on map init.

 

[matisko666]

Yo, thanks!

 

[matisko666]

Well, I reworked all functions that used All Players or Allies/Enemies of Player group when it comes to showing messages and now nothing shows at all... Yes I tried storing those group at initialization, after 0.00 seconds and even after 1.00 or 5.00 seconds... Nothing happens from now on... I doesn't even fire sound effects that have nothing in common with those groups...

EDIT: That sound firing is problem on my side I found where the problem lies but the rest is still there.

 

[Doomlord]

Probably a trigger of yours is corrupted. Try undoing all you just did and redo them one by one, each time with a test run to pinpoint which one is causing the issue.

 

[matisko666]

This procedure would take too much time, it's like the map itself compiles like 3-4 minutes, then it loads another 1-2 minutes when it's not all optimized... I don't know what could possibly cause the issue that's why I'm going to use playergroups for text messages normally without storing anything, it will add nanoseconds to process the stuff but it will work for me :-/

 

[Doomlord]

Could you send me the map? I could take a look and see what is wrong.

 

[matisko666]

I'm afraid I cannot, it holds many secrets and it's my lifetime work...

 

[Doomlord]

Fair enough. I wish you the best of luck with the map then.

 

[deathismyfriend]

can u post the triggers that deal with setting all players and how it is used ?

 

[matisko666]

I hope you would understand, it's not like I'm not sharing my knowledge, if there's something people want to know I'm more than happy to help them...
DIMF: There's not much to post, I stored All Players to PlayerGroup and when there was a function that wanted to know who to post it to, instead of putting All Players group I set it to the stored variable, it just didn't work at all...

 

[deathismyfriend]

I know it works cause I used to use that. I can't see the problem if I can't see the triggers.

 

[matisko666]

I'll return to it later as I've got so many more important things to rework but thanks for the concern guys...

 

[deathismyfriend]

Ok then and np

 

[Dr Super Good]

You can also use bj_FORCE_ALL_PLAYERS which is already a global. Sure a global with a shorter name is faster but that is only if you are really a speed freak.

 

[deathismyfriend]

You can also use bj_FORCE_ALL_PLAYERS which is already a global. Sure a global with a shorter name is faster but that is only if you are really a speed freak.

the problem isnt that but the fact that he is using GUI.

 

[matisko666]

Well, now that I reverted everything to old values (All Players) does no longer works, what's wrong with it???
Simple

• Game - Display to (All players) the text: Welcome to |c00ff03...

or

• Quest - Display to (All players) the Simple Hint message: Wait for host to ch...

doesn't work at all even the sound at Simple Hint won't fire off!

I deleted every single player group I used for it when I was storing them, it's all like before when it worked but it doesn't. I'm not saying I'm not thankful for help but yes I am now

EDIT: New discoveries showed that when I use storing player groups like this:

• Set TempPlayerGroup = (All players)
• Player Group - Pick every player in TempPlayerGroup and do (Actions)
  • Loop - Actions
    • Hero - Make (Picked player) Heroes gain 200.00% experience from future kills
• Custom script: call DestroyForce(udg_TempPlayerGroup)

then destroying of the "temporary" group destroys it and its use entirely from the game... Is there any way to make this trigger work without destryoing the All Players function?

 

[Doomlord]

Uhm no, you are not supposed to destroy All players under any circumstances. Just store it into a variable and use it.

Source: http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

I am not really getting what you are trying to say. Did you use DestroyForce to delete all force variables? Or what?

 

[matisko666]

All I did was before picking player group (all players) I stored All Players to TempPlayerGroup and after the function with picked player I destroyed the temp group destroying the All Players entirely never able to be used again in the map...

Here's question, now that I know I cannot destroy TempPlayerGroup variable where All Players is stored, should I leave the TempPlayerGroup without the destroying script and when I overwrite that variable with any other player group that is not All Players but only players that are playing for example I can destroy it (when it's not players of control a.k.a. All Players or Allies/Enemies of (player)) with that script?

 

[Doomlord]

All I did was before picking player group (all players) I stored All Players to TempPlayerGroup and after the function with picked player I destroyed the temp group destroying the All Players entirely never able to be used again in the map...

Uhm no, you are not supposed to do that. I just said it earlier.

Here's question, now that I know I cannot destroy TempPlayerGroup variable where All Players is stored, should I leave the TempPlayerGroup without the destroying script and when I overwrite that variable with any other player group that is not All Players but only players that are playing for example I can destroy it (when it's not players of control a.k.a. All Players or Allies/Enemies of (player)) with that script?

You should create a new global for All players altogether and use that temp variable for those other player groups.

 

[deathismyfriend]

Thanks doomlord

@TO
As I said above store all players to a permanent player force global.
Never destroy all players. Plz read above posts again

 

[Doomlord]

Thanks doomlord

@TO
As I said above store all players to a permanent player force global.
Never destroy all players. Plz read above posts again

You are welcome