Spirit Spells Pack

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

15:33, 8th Jul 2014
BPower:
http://www.hiveworkshop.com/forums/spells-569/spirit-spells-pack-253752/#post2553171

 

[Rheiko]

You're just using Single Target Spell for Multiple Units. I didn't see any flaw in your trigger but is this really worth to be approved?

it's not configurable and it's pretty easy to make. the spells are simple in my opinion.

 

[Daffa]

@yanchaspenda
Rheiko have a good point. This is far from approval.
You need a decent spell for approval, mostly involves timers and such.
Try take a look at Approved Spells.

Indonesia

Rheiko punya poin yang bagus. Ini jauh dari bisa diterima.
Kau perlu sebuah Spell (Sihir) yang bagus untuk bisa diterima di Bagian Spell, biasanya mereka menggunakan waktu, efek periodik dan semacamnya.
Coba lihat Spell yang diterima (Approved).

 

[Tank-Commander]

The following goes for all of your spells in the pack:

Unit group selection range should be configurable

• Unit - Add a 3.00 second Generic expiration timer to (Last created unit)

Kill the dummy but don't remove it, should remove it.

• Unit - Order (Last created unit) to Orc Far Seer - Chain Lightning FS_Target

Spell damage should not be done through object data, particularly when there is no triggered damage at all

• Animation - Change (Last created unit) flying height to 1000.00 at 0.00

This flying height should also be configurable

• Unit - Set mana of FS_Caster to ((Mana of FS_Caster) + (50.00 x (Real((Level of (Ability being cast) for FS_Caster)))))

So should this (keeping in mind that if people change the mana cost of the spell in the object editor)

Overall: When you make simple spells they should be as close to perfection as possible, this is not the case here, even if most of the code is alright, as others have suggested, look up other people's approved spells.

 

[BPower]

Very simple spells.

"-------- Don't Copy This --------", so users should delete????

• Custom script: call Data.ShakeStart(GetOwningPlayer(udg_TS_Target), 1)

The Tank-Commander makes some good points.

In my eyes the spell pack is too simple for approval.

Anyways:
1. struct Data
The name Data is irritating, keep in mind that there can only be one public struct labeled "Data" within a map. Furthermore I can't see any reason why you should use a static method over a simple function in this case.
Waits are inaccurate and should be avoided if possible.

2. The spells
In general you should add a configuration trigger where ability, effect, aoe, damage, ... can be setup.

I'll set it to Need Fix, however I can't promise if this gets approved even if everything is done well. It's just to easy to code.