Barathrum the Spirit Breaker Spells v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

16:48, 17th Jul 2012
Magtheridon96:

Comments

• 2.15MB is too big a file size. You don't need most of the models
  in there. You can instead post a link to where a person could download
  them if you see them fitting.
• Never set the animation of a unit by the index in a public resource
  without making it configurable, in fact, you should make your spells
  configurable so that the user could modify things like base damage,
  damage per level, duration, etc...
• In the Nether Strike trigger, you don't need the location arrays,
  you can use temporary location variables instead.
• You have some leaks. For example:
  
  Leak

  • Set NetherPoint[NetherLoop] = ((Position of NetherTarget[NetherLoop]) offset by 120.00 towards NetherAngle[NetherLoop] degrees)

  This leaks. To fix it, use another location, set it to the position of the
  target, and then use that location variable when setting the NetherPoint
  array. Don't forgot to destroy this temporary location though.
• You never really need to set globals to "No unit".
• The periodic triggers should be initially off. You would turn them
  on in the cast trigger and then back off when no units are casting
  the spells anymore.

This needs a total overhaul.

 

[Adiktuz]

Charge - uses waits, bad... waits are inaccurate and they can ruin the MUIness of charge... if I have more than one unit casting charge at almost the same time, charge will bug because of the wait...

Empowering haste damage - the trigger is far longer than how it should be... Learn to use FORMULAS as opposed to using a long chain of If-then-elses...

Greater Bash - uses Unit is Attacked = Abusable

Nether stop - you might want to use hashtables so that you don't need to loop through all instances just to get which one is for the unit that died...

and maybe you could finish fixing the other spells first before making a new pack...

 

[Vladadamm]

Use Waits and so is imprecise.

The bash will start before the projectile reach the target if it's not an instant attack. Instead of having a Greater Bash learn trigger, why you don't detect if the unit has the ability when it attack.

Your Empowering Haste is imprecise, and really not precise. Do some calculations and then convert to Integer to have the level of the ability.

Recycle the Id's for your Indexing system.

 

[BloodSoul]

80 Levels ? Wow... With 9 abilities (1 level each) and using formulas, you can add damage up to 511.

 

[Tank-Commander]

Buggy with that wait, since the shortest they go is 0.27 anyway, so yeah can be glitched, also my god that is a horrid if block, it actually made my browser take forever to load it all

 

[maddeem]

Largest IF THEN ELSE statement I have EVER seen.

 

[gorillabull]

you can simplify the empowered haste damage trigger with something like:
move speed / 10 and setting the level of the ability based on that value
so if its 422/10 ~ 42 for ability level
you will still need a big ability but no conditions this is just ridiculous lol

 

[Adiktuz]

and you don't need the Nether stop trigg... You can always check if the target is alive in the Nether strike loop...

 

[Almia]

Not Mui
-uses Waits
-i think Greater Bash is not abusable
-the author likes to make another person's idea
-this spell has lots of versions,all packs are not mui,including yours

 

[Adiktuz]

and like your other packs, the configurability of this pack is really bad...

 

[Almia]

YES thats right

 

[Storm_hih]

Ok ok just i will try to fix this but after the Tiny spells and i will remove the waits.

 

[shinji]

Master the way to trigger leak less before making spells. Using waits can cause leaks.

 

[Lazy R]

The index size begin to increase on every cast of ability and I don't see any recycling system on them, From what is the momment of Triggers wait 0.01 Seconds -.-

 

[zv27]

Purely informative:
Neither the original versions are not MUI.
Here are just looking at them!

 

[Adiktuz]

The original are actually MUI (at least when I tested them on mirror mode long time ago)

 

[shinji]

Don't make me laugh. Skill in DotA has to be MUI. Or else they won't make -sh (same hero)

 

[Painkiller91]

Buggy with that wait, since the shortest they go is 0.27 anyway,

Not true. As much as I have tested, the shortest wait for me was 0.01.

It also isn't necessarily true that using waits makes spell not-mui. It can still be mui if variables are used properly.

 

[shinji]

Not true. As much as I have tested, the shortest wait for me was 0.01.

It also isn't necessarily true that using waits makes spell not-mui. It can still be mui if variables are used properly.

No. If he doesn't use a recycle system or something, it will bug. Which means its not MUI. Waits are not allowed in spells.

 

[Tank-Commander]

Well you call not true, please provide evidence to back yourself up, Also for a spell to be MUI and use waits, would be rather strange, I can seew howit's possible to create an artificial wait in a loop, since I do it all the time, so please, show us all how to do it.

On another note, Waits are never accurate, they're always very variable, hence why timers are used not waits in other systems.

 

[Adiktuz]

It will be MUI if variables are used correctly, but mostly it will need locals to be MUI...

and yeah, waits are very inaccurate, especially in multiplayer...

personally, I don't see why the waits were used at the first place? they aren't really needed...

 

[mckill2009]

This is Unaceptable, pls use DynamicIndexing or UnitIndexer, and pls put your pickedunit/trigger unit and alike to a variable, so that it's not spammed...

Btw your Empowering Haste Damage is very bad, try to use loops...

Rating: 1/5

 

[Painkiller91]

Well, I've made maps long ago, and started again just recently, but I recall making firebolt - like spells, with waits included, which worked perfectly no matter how many times they are cast at the same time... Had only to use array variable for "target unit of ability beign cast" since "target unit of ability being cast" doesn't work after "wait". "Triggering unit" however, worked for each trigger sepparatly as if it is local variable.
As for waits, it's easy to check. Make one action happen after 0.01 seconds and another after 0.27 and difference is quite obvious. They are inacurate though , I have seen them varying for 0.10-0.20 seconds, but usualy only when a frequent periodic trigger is involved.

 

[Vladadamm]

Not true. As much as I have tested, the shortest wait for me was 0.01.

It also isn't necessarily true that using waits makes spell not-mui. It can still be mui if variables are used properly.

Or you use triggering units instead of variables ?

But no, it will be imprecise in all cases.

It'll be mui with recycling index or with hashtables.

Waits vary for 0.30seconds, and that's always. Using wait in your personnal triggers for a long time (i.e 3minutes) wouldn't be so bad cause you 0.30seconds on 180seconds, is nothing ? But using waits for really short time and when you provide this to the other peoples, it's inacceptable.

Also, MUI and Waits are compatible, but Waits are too imprecise, so it suxx.

 

[shinji]

Well, I've made maps long ago, and started again just recently, but I recall making firebolt - like spells, with waits included, which worked perfectly no matter how many times they are cast at the same time... Had only to use array variable for "target unit of ability beign cast" since "target unit of ability being cast" doesn't work after "wait". "Triggering unit" however, worked for each trigger sepparatly as if it is local variable.
As for waits, it's easy to check. Make one action happen after 0.01 seconds and another after 0.27 and difference is quite obvious. They are inacurate though , I have seen them varying for 0.10-0.20 seconds, but usualy only when a frequent periodic trigger is involved.

I'm telling you it bugs!!! What if someone casts the spell again during the wait? It will bug for sure.

 

[Vladadamm]

Nop. You can use waits and it can still be mui.

As example :

• Respawn
• Unit - A unit Die
• Wait 15 seconds
• Hero - Revive Triggering Unit at Somewhere (Show Respawn Graphics)

Test it and you'll be fixed.

 

[Storm_hih]

personally, I don't see why the waits were used at the first place? they aren't really needed...

I used them to put the spell in cooldown but when i finish fixing the tiny spells i will fix this too.

 

[Adiktuz]

They are inacurate though

--> Exactly why you shouldn't use waits even if you have a way to make it MUI while having waits...

 

[maddeem]

Waits are nearly outlawed in these parts. Don't use them. They are inaccurate, and if the game is paused the wait continues. They also tend to make things not MUI, with overlapping variables and such. You can use maps in your own maps, but do NOT go posting spells that other people will use with waits in them. It is setting a bad example for the people who are still learning.

 

[Storm_hih]

Just wait and I'll fix this spells, i will remove the waits please stop talking about them they are annoying.

 

[Vladadamm]

Too lazy to review the complete triggers now and it's kinda late in France. So, 1thing i saw while readin in 30secs your triggers :

No need to use many variables with arrays to unleak points. 2is enough for you : as example TempP and TempP2 without array.

 

[Adiktuz]

For charge, just check the current order for barathrum and health of the target at the timed looped... no need for extra trigger to stop the charge...

For nether strike, do it too, but for health of target only...

 

[Iconer]

You are famous Like your job!

 

[Almia]

i have a challenge for you Storm_hih:
make a Gui version of my Invoker Spells

 

[Storm_hih]

i have a challenge for you Storm_hih:
make a Gui version of my Invoker Spells

I will try but not now.

 

[maddeem]

i have a challenge for you Storm_hih:
make a Gui version of my Invoker Spells

From what I've seen, you stole that code. Busted?

 

[WyrmSlayer]

where do you get these models? i could create a pure dota 2 juggernaut that has mui skills with bonuses if i had its dota 2 model in wc3 version. please send me a link =D
+rep on my map if you do so =D

 

[Adiktuz]

most of them are available at playdota I believe [or on the dota 2 group on facebook]... but if you use them for a public resource, I believe you'll get an instant ticket for rejection because they are rips... XD...

 

[Iconer]

You got 20 th the most commentary spell

 

[Adiktuz]

because of seriously off-topic posts... XD...

 

[Iconer]

LoL Radamantus Love you

 

[Storm_hih]

where do you get these models? i could create a pure dota 2 juggernaut that has mui skills with bonuses if i had its dota 2 model in wc3 version. please send me a link =D
+rep on my map if you do so =D

From playdota.com from the ai maps section.

 

[Iconer]

where do you get these models? i could create a pure dota 2 juggernaut that has mui skills with bonuses if i had its dota 2 model in wc3 version. please send me a link =D
+rep on my map if you do so =D

Juggernaut?

What?
OMNISLASH

 

[Daeku346]

Actually removing the waits is not good, as it show that instantly the Spirit Breaker will charge instantly, not preparing for Charge. Create new waits and its 5/5.

 

[maddeem]

Actually removing the waits is not good, as it show that instantly the Spirit Breaker will charge instantly, not preparing for Charge. Create new waits and its 5/5.

Haha, no.

 

[Tank-Commander]

You could just easily manufacture an artificial wait using a loop a stored value and a "wait" duration

Example:

Example

• Example
  • Events
    • Time - every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each [Indexer] from 1 to [MaxIndex] do (actions)
      • loop - actions
        • Set ArtificalWait[Indexer] = ArtificialWait[Indexer] + 1
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • ArtificalWait[Indexer] > ArtificialWaitTime
            • Then - Actions
              • <<Actions>>
            • Else - Actions

This method will effectively create a delay or wait in the execution of a spell <without> causing problems or being innacurate however requires a basic knowledge of dynamic indexing.

 

[Noobsmoke]

For that haste issue I think you can use this