Spirit Bladestorm

[Moderator]

13:56, 31st Dec 2009
TriggerHappy:

Seemed fine and leakless.

 

[Vengeancekael]

looks good, but maybe you could post the triggers here.

 

[Inachix]

looks good, but maybe you could post the triggers here.

Triggers added.

 

[Komaqtion]

This leaks a little:

SB Cast trigger leaks:

• Set SB_Location = (Position of SB_Caster)

That point isn't destroyed...

SB Drag trigger leaks:

• Unit - Move SB_Spirit instantly to (Position of (Picked unit)), facing (Facing of (Picked unit)) degrees

You're not using the variable you just set

• Set SB_MoveLoc = (SB_Location offset by (SB_Distance - 4.00) towards (SB_Angle + 4.00) degrees)

Destroy that leak inside the "Then" block, instead of the last actions...

Otherwise, a quite ok spell
Just, maybe you can try to sync the "ghost" with the real caster, so that they spin at the same speed, and the same point in their animation

 

[Inachix]

This leaks a little:

SB Cast trigger leaks:

• Set SB_Location = (Position of SB_Caster)

That point isn't destroyed...

SB Drag trigger leaks:

• Unit - Move SB_Spirit instantly to (Position of (Picked unit)), facing (Facing of (Picked unit)) degrees

You're not using the variable you just set

• Set SB_MoveLoc = (SB_Location offset by (SB_Distance - 4.00) towards (SB_Angle + 4.00) degrees)

Destroy that leak inside the "Then" block, instead of the last actions...

Otherwise, a quite ok spell
Just, maybe you can try to sync the "ghost" with the real caster, so that they spin at the same speed, and the same point in their animation

Thank you for looking over my triggering. The leaks have been fixed and the spirit now is in sync with the caster. Unfortunetly when I move the custom scripts to the "Then" block, the spell doesn't work properly so I have left them unmoved.

 

[LexX]

It's not a leak since it's removed in 2nd trigger...But still it should be remade because if 2 units cast it at 1 time (it happens sometimes) then the spell won't work for 1 of them or will be cast twice for 1 and not casted for another=)I mean these variables should be removed in first trigger.And make the trigger look like that: first variables,then saving them to hastables and then all other actions.

Well I give it 3/5 because idea isn't new and I saw 1 better spell long time ago (-1 ball of my opinion,if I don't count this then 4/5 ),still good work=)

 

[-Berz-]

Triggering	3/5
Eyecandy	3/5
Usefulness	3.5/5
Tooltip	5/5
Total	3.6/5

Triggering is pretty good, thou I could take some more work, e.g. allowing the user to change certain things more easily.
Just make another variable for your set up, like now you have "damage = level of ability x 100" make it:
"damage = 100"
"total damage = damage x level of ability"

Special effect seems to be good, but to big, scale the "spirit down" and replace dust model with ancient protector missile.

Spell could be useful for many maps.

Tooltip seems to be OK and easy to understand.

Have fun!

~Berz

 

[MortAr]

Well it has something to do with spirits, no need always to use ancient protector missle model for the drag

I suggest you to use this "Abilities\Spells\Orc\TrollBerserk\TrollBeserkerTarget.mdl" attached to the chest of the dragged targets. That will make them look a little bit red which will indicates that they are in range of the Spirit Bladestorm.

 

[Inachix]

It's not a leak since it's removed in 2nd trigger...But still it should be remade because if 2 units cast it at 1 time (it happens sometimes) then the spell won't work for 1 of them or will be cast twice for 1 and not casted for another=)I mean these variables should be removed in first trigger.And make the trigger look like that: first variables,then saving them to hastables and then all other actions.

Well I give it 3/5 because idea isn't new and I saw 1 better spell long time ago (-1 ball of my opinion,if I don't count this then 4/5 ),still good work=)

Thanks. Im not sure what you mean by "first variables,then saving them to hastables and then all other actions." Maybe you could give me a brief example? :]

Triggering	3/5
Eyecandy	3/5
Usefulness	3.5/5
Tooltip	5/5
Total	3.6/5

Triggering is pretty good, thou I could take some more work, e.g. allowing the user to change certain things more easily.
Just make another variable for your set up, like now you have "damage = level of ability x 100" make it:
"damage = 100"
"total damage = damage x level of ability"

Special effect seems to be good, but to big, scale the "spirit down" and replace dust model with ancient protector missile.

Spell could be useful for many maps.

Tooltip seems to be OK and easy to understand.

Have fun!

~Berz

Thanks alot for reviewing my spell. I have now made the spell user friendly. The spirit has been scaled down and dust model has been replaced.

Well it has something to do with spirits, no need always to use ancient protector missle model for the drag

I suggest you to use this "Abilities\Spells\Orc\TrollBerserk\TrollBeserkerTarget.mdl" attached to the chest of the dragged targets. That will make them look a little bit red which will indicates that they are in range of the Spirit Bladestorm.

Thank you for your suggestion. I havent used "Abilities\Spells\Orc\TrollBerserk\TrollBeserkerTarget.mdl" because it is very hard to see. Again thank you for this suggestion. I appreciate it.

 

[LexX]

Thanks. Im not sure what you mean by "first variables,then saving them to hastables and then all other actions." Maybe you could give me a brief example? :]

Well,in your 1st trigger you first make variables,then create a unit and set it as variable too,then make some things about the unit and only then save everything in hastables...And I tell you first to make values for variables,then save them in hastables and only after that make things about unit...It's not a mistake,but it'll be a bit more safe=)

 

[MortAr]

Ok, I like you appreciated my suggestion, but now the spell doesn't look good.. this special effect destroy its completly, try to search for something else

And you can add passive ability to the blademaster that has 2 attachments on hes hands, adding something red again (maybe the missle from the Phoenix Fire ability?)

That will make it look awesome.

For now my rate will be 3/5 just because of the clear triggering.

 

[Inachix]

I have updated this spell. I rearranged the triggers but i think its still not what you mean.

I have added the passive ability and i have also changed the drag special effect. Check it out and tell me what you think.

 

[Adiktuz]

how do you set those "keys" cause I cannot seem to get them right...

 

[LexX]

how do you set those "keys" cause I cannot seem to get them right...

Off-topic:
This thread as not about asking how to use something,it's for rating the spell...

 

[Komaqtion]

This thread as not about asking how to use something,it's for rating the spell...

He's asking about the spell...
He means the "Hashtable" actions:

• Hashtable - Save SB_Range as (Key range) of (Key (Triggering unit)) in SB_Hashtable

how do you set those "keys" cause I cannot seem to get them right...

They get it by using the line "Hashtable - Get String ID" and then instead of the red "String you type, for example, "range" as it says in the first of those actions

Btw, back to the spell, I don't see you using this hashtable anywhere in the other trigger:

• Hashtable - Save Handle OfSB_Location as (Key location) of (Key (Triggering unit)) in SB_Hashtable

Or am I missing something ? :S

And also, this leaks:

• Set SB_Angle = (Angle from SB_Location to (Position of (Picked unit)))

 

[MortAr]

Thats something, now its looks very nice. Now its definetily deserves a 5/5.

 

[Maker]

Are you actually using this for something? Maybe I'm just not seeing it?

• Hashtable - Save Handle OfSB_Location as (Key location) of (Key (Triggering unit)) in SB_Hashtable

Has this been pointed out already?

• Hashtable - Save (SB_Time - 0.04) as (Key time) of (Key (Picked unit)) in (Last created hashtable)

 

[Inachix]

He's asking about the spell...
He means the "Hashtable" actions:

• Hashtable - Save SB_Range as (Key range) of (Key (Triggering unit)) in SB_Hashtable

They get it by using the line "Hashtable - Get String ID" and then instead of the red "String you type, for example, "range" as it says in the first of those actions

Btw, back to the spell, I don't see you using this hashtable anywhere in the other trigger:

• Hashtable - Save Handle OfSB_Location as (Key location) of (Key (Triggering unit)) in SB_Hashtable

Or am I missing something ? :S

And also, this leaks:

• Set SB_Angle = (Angle from SB_Location to (Position of (Picked unit)))

Hashtable removed and teh leak is now fixed. Sorry for all the triggering problems but i didn't really plan on uploading this spell when i made it. After I was done I just thought i would upload it to see what you guys thought.

Thats something, now its looks very nice. Now its definetily deserves a 5/5.

Thank you so much.

Are you actually using this for something? Maybe I'm just not seeing it?

• Hashtable - Save Handle OfSB_Location as (Key location) of (Key (Triggering unit)) in SB_Hashtable

Has this been pointed out already?

• Hashtable - Save (SB_Time - 0.04) as (Key time) of (Key (Picked unit)) in (Last created hashtable)

Ah yes, I must of went through that trigger too quickly. Fixed.

 

[Lambdadelta]

-Perhaps you should remove collision of targets so they don't have weird movement. Like crashing each other.
-What if you Blink with this active? Targets go with you
-Why can you attack while spinning? Perhaps make an option to allow attacking or not. Cargo Hold ability.

This spell kind of reminds me of my Whirlpool Except with different SFX concept.

 

[iDORK]

I love this one sooo much. It looks cool also and i would rate this maybe a nice 0/5. Keep up your good work

 

[Lambdadelta]

I love this one sooo much. It looks cool also and i would rate this maybe a nice 0/5. Keep up your good work

UM. 0/5 and you say it is good

 

[Adiktuz]

He's asking about the spell...
He means the "Hashtable" actions:

• Hashtable - Save SB_Range as (Key range) of (Key (Triggering unit)) in SB_Hashtable

They get it by using the line "Hashtable - Get String ID" and then instead of the red "String you type, for example, "range" as it says in the first of those actions

Btw, back to the spell, I don't see you using this hashtable anywhere in the other trigger:

• Hashtable - Save Handle OfSB_Location as (Key location) of (Key (Triggering unit)) in SB_Hashtable

Or am I missing something ? :S

And also, this leaks:

• Set SB_Angle = (Angle from SB_Location to (Position of (Picked unit)))

okay thanks... so I can type whatever string there?

 

[Komaqtion]

okay thanks... so I can type whatever string there?

Yeah, but then you'd have to change the string it uses when it loads that value, like if you change this:

• Hashtable - Save SB_Range as (Key range) of (Key (Triggering unit)) in SB_Hashtable

Into this:

• Hashtable - Save SB_Range as (Key distance) of (Key (Triggering unit)) in SB_Hashtable

Then you'd have to change this (In the seconds trigger):

• Set SB_Range = (Load (Key range) of (Key (Picked unit)) from SB_Hashtable)

To this:

• Set SB_Range = (Load (Key distance) of (Key (Picked unit)) from SB_Hashtable)

 

[Maker]

You could turn the periodic trigger on/off when needed, so it doesn't run all the time for nothing.

On = when ability is cast, and trigger is off
off = when there are no units in the group

 

[Adiktuz]

Yeah, but then you'd have to change the string it uses when it loads that value, like if you change this:

• Hashtable - Save SB_Range as (Key range) of (Key (Triggering unit)) in SB_Hashtable

Into this:

• Hashtable - Save SB_Range as (Key distance) of (Key (Triggering unit)) in SB_Hashtable

Then you'd have to change this (In the seconds trigger):

• Set SB_Range = (Load (Key range) of (Key (Picked unit)) from SB_Hashtable)

To this:

• Set SB_Range = (Load (Key distance) of (Key (Picked unit)) from SB_Hashtable)

I cannot use Picked unit and any other units as a key in the hastable in GUI but in JASS in works okay, is there a problem with my WE? Also is there a new version of TESH that has a list of hashtable functions?

 

[Komaqtion]

http://www.thehelper.net/forums/showpost.php?p=1053321&postcount=197

Try DL'ing that
(Don't remember if hashtables are included :S But I have them in my TESH at least )

I cannot use Picked unit and any other units as a key in the hastable in GUI but in JASS in works okay, is there a problem with my WE?

 

[Maximum_Evil]

looks awesome good job!