Dark Spirits

[Moderator]

12.12
IcemanBo: For long time as NeedsFix. Rejected.

03:48, 12th Dec 2015
IcemanBo:

 

[Laiev]

post the trigger

 

[.OmG.]

I know a little about a jass, but know that the such shouldn't be:

call   UnitAddAbility(dum, 'A001')

You must set the string in beginning of trigger and add comentary.

 

[Banzay89]

I know a little about a jass, but know that the such shouldn't be:

call   UnitAddAbility(dum, 'A001')

You must set the string in beginning of trigger and add comentary.

For what? This does not necessarily.
I'm new at this forum and I'm sorry if something is not properly designed.

 

[Maker]

Try to use proper indenting because the code is difficult to read.

You could set this to a variable instead of calling it for every looped unit.

GetOwningPlayer(d)

You could do the bj_DEGTORAD in the first line

set    ang2=GetRandomReal(1.00,359.00)
set    x=GetUnitX(d)+300*Cos(ang2*bj_DEGTORAD)
set    y=GetUnitY(d)+300*Sin(ang2*bj_DEGTORAD)

or

set    ang2=GetRandomReal(-bj_PI, bj_PI)
set    x=GetUnitX(d)+300*Cos(ang2)
set    y=GetUnitY(d)+300*Sin(ang2)

l=GetSpellTargetLoc()

^You could use

GetSpellTargetX()

and

GetSpellTargetY()

SetUnitScalePercent(sar, sc, sc, sc)

->

SetUnitScale()

Notice that you must change the values.

GetHandleId(t)

^You could save it to a variable, you're using it several times.

Cos(0*bj_DEGTORAD),y+400*Sin(0*bj_DEGTORAD)

0*n = 0.

call   SetUnitFlyHeight(sp, 75.00, 99999.00)

Change 99999.00 to 0. 0 is instant.

My eyes hurt from reading the code.

 

[Weep]

It's pretty heavy on particles from the FX spam making the black area; my FPS went down by more than half.

 

[Bribe]

Post the triggers and let's get this thing a proper looking over.