[Trigger] Someone Help me make this MUI

[-Berz-]

Could someone make me this simple spell MUI?

• Fatal Strike Copy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fatal Strike
  • Actions
    • Set TempLoc6 = (Position of (Triggering unit))
    • Unit - Pause (Triggering unit)
    • Unit - Make (Triggering unit) Invulnerable
    • Unit - Add FlyHeight to (Triggering unit)
    • Animation - Play (Triggering unit)'s death animation
    • Special Effect - Create a special effect attached to the origin of (Triggering unit) using Abilities\Spells\Undead\DeathPact\DeathPactTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • Wait 1.00 game-time seconds
    • Animation - Change (Triggering unit) flying height to 0.00 at 300.00
    • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) - 200.00)
    • Animation - Play (Triggering unit)'s attack animation
    • Unit - Create 1 Dummy(Purple) for (Owner of (Triggering unit)) at TempLoc6 facing Default building facing degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Fatal Strike(dummy) to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Warden - Fan Of Knives
    • Unit - Make (Triggering unit) Vulnerable
    • Unit - Unpause (Triggering unit)
    • Unit - Remove FlyHeight from (Triggering unit)
    • Custom script: call RemoveLocation (udg_TempLoc6)

Thanks

-BerZeKeR-

 

[redscores]

You know... thats leaky like hell? but whatever, i guess for making it MUI add following to the first line:

Custom Script: local location udg_TempLoc6.

So the location is initialized as local.

 

[-Berz-]

Only this? And thats it?
Edit: it gives me an error

 

[Eleandor]

I think that's it indeed. And the trigger doesn't really look leaky to me...

 

[-Berz-]

It gives me an error, Could you be more specific? Because if i would know how to do it i wouldn't ask.

• Fatal Strike Copy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fatal Strike
  • Actions
    • Set TempLoc6 = (Position of (Triggering unit))
    • Custom script: local location udg_TempLoc6.
    • Unit - Pause (Triggering unit)
    • Unit - Make (Triggering unit) Invulnerable
    • Unit - Add FlyHeight to (Triggering unit)
    • Animation - Play (Triggering unit)'s death animation
    • Special Effect - Create a special effect attached to the origin of (Triggering unit) using Abilities\Spells\Undead\DeathPact\DeathPactTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • Wait 1.00 game-time seconds
    • Animation - Change (Triggering unit) flying height to 0.00 at 300.00
    • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) - 200.00)
    • Animation - Play (Triggering unit)'s attack animation
    • Unit - Create 1 Dummy(Purple) for (Owner of (Triggering unit)) at TempLoc6 facing Default building facing degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Fatal Strike(dummy) to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Warden - Fan Of Knives
    • Unit - Make (Triggering unit) Vulnerable
    • Unit - Unpause (Triggering unit)
    • Unit - Remove FlyHeight from (Triggering unit)
    • Custom script: call RemoveLocation (udg_TempLoc6)

 

[redscores]

• Fatal Strike Copy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fatal Strike
  • Actions
    • Custom script: local location udg_TempLoc6.
    • Set TempLoc6 = (Position of (Triggering unit))
    • Unit - Pause (Triggering unit)
    • Unit - Make (Triggering unit) Invulnerable
    • Unit - Add FlyHeight to (Triggering unit)
    • Animation - Play (Triggering unit)'s death animation
    • Special Effect - Create a special effect attached to the origin of (Triggering unit) using Abilities\Spells\Undead\DeathPact\DeathPactTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • Wait 1.00 game-time seconds
    • Animation - Change (Triggering unit) flying height to 0.00 at 300.00
    • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) - 200.00)
    • Animation - Play (Triggering unit)'s attack animation
    • Unit - Create 1 Dummy(Purple) for (Owner of (Triggering unit)) at TempLoc6 facing Default building facing degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Fatal Strike(dummy) to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Warden - Fan Of Knives
    • Unit - Make (Triggering unit) Vulnerable
    • Unit - Unpause (Triggering unit)
    • Unit - Remove FlyHeight from (Triggering unit)
    • Custom script: call RemoveLocation (udg_TempLoc6)

Thats the correct way.

 

[Eccho]

Nah dude, the custom script must be placed at the first line.
A local must be placed like that.

As a gui-spell this is not "leaky like hell". I dont really agreed with redscores

However since you make it a local, you must null it at the end of the trigger.

 

[redscores]

I am faster Eccho.

 

[-Berz-]

Thanks you guys!
But does only local points make spells MUI, or there must be local units, groups, etc?

 

[Eccho]

well... if you use the response "casting unit" instead of triggering unit, you would have to make a local unit yes. Thats why you always should use triggering unit since its already local. Casting unit for instance, is overwritten everytime a new casting event occurs.

I guess, you dont need to bother locals if the trigger is instant ran. (no wait actions/timers and such)
The risk of it running multiply times within that small matter of time is very very very small.

As for using a trigger like this in Jass, I suppose the most part of it would be made in "local" style.

 

[-Berz-]

I just have a problem with "wait 1 gametime sec" because trigger now runs over and over again :S

 

[Eccho]

It should not... I think you ahve exchanged the Fatal Strike condition with the Fatal Strike (dummy) ?

Or you could just add in the condition: "Unit-type of triggering unit is Not Equal to Dummy(purple)"

 

[-Berz-]

Meh making stuff in GUI MUI is not a good idea...

 

[redscores]

• Fatal Strike Copy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fatal Strike
  • Actions
    • Custom script: local location udg_TempLoc6.
    • Set TempLoc6 = (Position of (Triggering unit))
    • Wait 0.01 game-time seconds
    • Unit - Pause (Triggering unit)
    • Unit - Make (Triggering unit) Invulnerable
    • Unit - Add FlyHeight to (Triggering unit)
    • Animation - Play (Triggering unit)'s death animation
    • Special Effect - Create a special effect attached to the origin of (Triggering unit) using Abilities\Spells\Undead\DeathPact\DeathPactTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • Wait 1.00 game-time seconds
    • Animation - Change (Triggering unit) flying height to 0.00 at 300.00
    • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) - 200.00)
    • Animation - Play (Triggering unit)'s attack animation
    • Unit - Create 1 Dummy(Purple) for (Owner of (Triggering unit)) at TempLoc6 facing Default building facing degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Fatal Strike(dummy) to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Warden - Fan Of Knives
    • Unit - Make (Triggering unit) Vulnerable
    • Unit - Unpause (Triggering unit)
    • Unit - Remove FlyHeight from (Triggering unit)
    • Custom script: call RemoveLocation (udg_TempLoc6)

That shouldnt repeat the trigger anymore (if you pause a unit without a 0.01 wait before then the unit casts the spell over and over (because it never finishes the casting and like as it would be stunned while channeling it starts again)).

 

[GhostWolf]

...

Remember to null the local.

The risk of it running multiply times within that small matter of time is very very very small.

I recon it can't happen at all, as warcraft is single threaded.

 

[redscores]

Its meant for preventing double firing of an trigger, not for multithreading it, if the trigger is mult-fired the last instance will be overwritten during the duration of the current one, which can happen if a wait is in the trigger, the stuff will be rewritten, higher attack speed = more danger.

 

[Eleandor]

Remember to null the local.



I recon it can't happen at all, as warcraft is single threaded.

...

1) I don't think it is. If I recall correctly, there are like 70 threads open for triggers and a few hundreds more for stuff done internally.
2) Either way, as far as I know TriggerSleepAction() allows other triggers to be executed meanwhile, including the trigger itself.

 

[GhostWolf]

Warcraft simulates multi threading by going from trigger to trigger, but I think it only happens when you use waits (as in waits and timers), and when there is a trigger with no waits, I think it would run it until the end and only then go to the next one on the queue.

 

[Soga-]

Ghost is right here. Basically, imagine that WC3 uses a queue of triggers. First in, first out. It will execute each trigger in that queue one by one. However, when a wait is used, the trigger is placed back in that queue. As long as the end time for the wait is greater than the current time, when it is the trigger's turn to be executed, it will be placed back into the queue. Otherwise, its wait "flag" is cleared and it goes on to execute the rest of its actions.

As long as you don't use waits or timers, triggers execute one-by-one in a queue system.

 

[Eleandor]

Which would still mean you'll need locals to make something MUI.

 

[GhostWolf]

No, because it will never rewrite itself before the trigger ended, as it will do this only on the next thing in the queue.

 

[Soga-]

Yeah, that's why periodic triggers don't "spam" the trigger queue.