Simple Custom Stats System v1.2 [GUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

15:56, 18th Jul 2012
Magtheridon96:

For starters, you can reduce the number of abilities.
You can cut them in half if you use only one ability that gives negative stats.

If the highest positive bonus is 8192, all you need is a -16384 ability.

 

[defskull]

More features will be added, such as Movement Speed, Attack Speed, Regeneration and such

 

[Kgg123]

Looks interesting but ... the Hero can use the Spell always i think ??^^
FTW nice idea 7/10

 

[defskull]

Looks interesting but ... the Hero can use the Spell always i think

What do you mean by this ?

FTW nice idea 7/10

Again, you didn't actually rate it !

 

[Noobsmoke]

Wow, that's great. Waiting for "More features will be added, such as Movement Speed, Attack Speed, Regeneration and such " to implement it on my map .
Good job 5/5.

 

[Almia]

Nice Idea 5/5

 

[defskull]

Actually, the idea is from vJASS scripting, I made it from scratch in GUI (well a bit JASS there in map header) for GUI users so they do not need any requirements at all, unlike in vJASS, JNGP is required I think.

 

[Tank-Commander]

Well, while it's called in GUI, the actual part you put in "triggers" is simply the preloading, right (as well as setting the powers of 10 to reach wanted values)? or atleast it looks that way, Eitherway I'd put the Jass script in the "Triggers" section and change the category, considering it's operation that's done in GUI (or Jass) but the actual key script is in Jass. Also, you could add the set-up of the variables into the jass section as well of this system, just to make it more compact.

 

[defskull]

I think I'll stick to my current trigger, your suggestion is just to improve the "eye-candy".

 

[maddeem]

For the abilities are you using this method:
1-9, 10-90, 100-900, and so on?
Don't add MS tho, you can change that really easy in triggers xD

 

[Tank-Commander]

I think I'll stick to my current trigger, your suggestion is just to improve the "eye-candy".

actually my suggesting to change category was to make the category correct, since the majority of this is Jass, not GUI. And compressing it for compacting is also to make it easier to use and so that people don't have to import waste

 

[defskull]

For the abilities are you using this method:
1-9, 10-90, 100-900, and so on?
Don't add MS tho, you can change that really easy in triggers xD

Yeah, I'm using a mod function which allows me to find appropriate value for each level such as 874, I would separate a +100 HP to level 8 | +70 HP to level 7 | +4 HP to level 4, therefore it would 800 + 70 + 4.
This algorithm is fully made by halo7568, full credits goes to him for that algorithm search.

actually my suggesting to change category was to make the category correct, since the majority of this is Jass, not GUI. And compressing it for compacting is also to make it easier to use and so that people don't have to import waste

Ohhh change it from GUI -> JASS ?
I prefer not, cause' I want this system to be in favor for GUI-users, if I change it to JASS category, I'm afraid I would scare them away before they actually download and test it >.>"

 

[mckill2009]

sound error should be a global variable coz it will leak and ForPlayer should be nulled...

 

[Magtheridon96]

You should base this on powers of 2.
That's how all the JASS libs do it.

Check out Bonus by Nestharus for a good algorithm, or maybe even Status by Jesus4Lyf.

 

[defskull]

Like 2 4 8, such as computer's memory ?
I don't really get that how to do it, like +2 damage, and then +4 damage, how do you want to +3 damage ?
I know they did it in base 2 and it's perfect, but how it is executed ?
But never mind, I'll stick to this method for now.

 

[Magtheridon96]

It's very efficient with powers of 2.

Let's say I want to add 3847 damage.

I have a list of powers of 2:

1,2,4,8,16,32,64,128,256,512,1024,2048,4096

I'm going to loop over this list:

4096 > 3847 ---- Do nothing
2048 < 3847 ---- Add the +2048 damage ability
=> 3847 - 2048 = 1799 != 0, so we continue...
1024 < 1799 ---- Add the +1024 damage ability
=> 1799 - 1024 = 775 != 0, so we continue...
512 < 775 ---- Add the +512 damage ability
=> 775 - 512 = 263 != 0, so we continue...
256 < 263 ---- Add the +256 damage ability
=> 263 - 256 = 7 != 0, so we continue...
128 > 7 ---- Do nothing
64 > 7 ---- Do nothing
32 > 7 ---- Do nothing
16 > 7 ---- Do nothing
8 > 7 ---- Do nothing
4 < 7 ---- Add the +4 damage ability
=> 7 - 4 = 3 != 0, so we continue
2 < 3 ---- Add the +2 damage ability
=> 3 - 2 = 1 != 0, so we continue
1 = 1 ---- Add the +1 damage ability
=> 1 - 1 = 0, so we stop.

We are done.

So, we added the following:

2048 + 1024 + 512 + 256 + 4 + 2 + 1 = 3847


The powers of 2 algorithm is the fastest you can have.

 

[defskull]

Hahaha I forgot there is +1 damage initially, I thought it started with 2 LOL.
Hmmm I'll try to change the algorithm.

But to think that, each ability will have like 13 levels ? (1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096)

And if I use base 10, I would only need 4 abilities (but each has 9 levels) = 36

Which is more efficient ? (Proven)

Having many abilities (low level quantity) or having low abilities (high level quantity) ?

Also, to perform that check and looping, really, I think it has same efficiency ?

Well, if you prove me, that's nicer, like why is this more efficient than previous, I would be glad

Also, if you convince me enough, I might change the algorithm.

 

[zv27]

Do not change anything just because someone does not like the way you did it.
After all why should you changed something that works just fine?
Can it be done better or can it be done differently? Of course you can!!!


But what it means?
For example:

If I told you now.This is not done well, do this and it will be better(And let's say your system is working perfectly) this means that from my point of view,something better,but this does not mean that it will be better for everyone(that's just my dissenting opinion)

And what now?

Just because I think it is something better or faster or whatever,you should change something that already works perfectly.Well maybe just someone interested only in that the system is quite stable and not a speed or whatever.

 

[defskull]

I can't argue with your statement, as long as the system is non-laggy and stable (does not cause weird bugs that could ruin gameplay, etc) but I was afraid that mods would not approve this, that's all.

An approve system looks more appeal you know.

Also, as I already stated to mag, I need him to prove me first how would his approach is better and does he have a solid prove on that ?

Perhaps some benchmark or something ?

Because as I think deeper, it would be the same, having 13 levels of ability per customization VS having 4 abilities (9 levels each).

Current Update:
Preparing to upload v1.2, added Armor and Damage customization.

 

[Dr.Killer]

Nice idea to support GUI users.
I agree on using powers of 2 instead of this method, but anyway it's your system!
4/5

 

[defskull]

I agree on using powers of 2 instead of this method, but anyway it's your system!

Again, I hope you read my statements
At the end, it's kinda same don't you think ?

Oh and thanks for rating !

 

[Magtheridon96]

@zv27: It's not my opinion, it's the fact that the current algorithm isn't the best one.
Well, not exactly that, it's the fact that there is an algorithm that is way better. The current algorithm is fine, but it is possible to make a much better one for Warcraft III.

@defskull:
Actually, having more abilities and less levels is the right way to go.
Plus, it's way more efficient at the level of the code.

The reason it's more advantageous to have more abilities rather than more levels is because abilities with 4 or less levels can be converted into xml files, thus decreasing the size of the map.

And no, I'm not asking you to make 1 ability with 13 levels, but 13 abilities with 1 level each (You don't need 13 abilities for all of them, damage only needs about 10 abilities because you're never going to need to add more than 1023 damage)

This is up to the user though.

 

[zv27]

@zv27: It's not my opinion, it's the fact that the current algorithm isn't the best one.
Well, not exactly that, it's the fact that there is an algorithm that is way better. The current algorithm is fine, but it is possible to make a much better one for Warcraft III.

@defskull:
Actually, having more abilities and less levels is the right way to go.
Plus, it's way more efficient at the level of the code.

The reason it's more advantageous to have more abilities rather than more levels is because abilities with 4 or less levels can be converted into xml files, thus decreasing the size of the map.

And no, I'm not asking you to make 1 ability with 13 levels, but 13 abilities with 1 level each (You don't need 13 abilities for all of them, damage only needs about 10 abilities because you're never going to need to add more than 1023 damage)

This is up to the user though.

Again, doing the same thing but no matter.
Of course it is possible to do even better algorithm,but this is your very far from being the best.

And after all, defines the man.First you say that the best, and soon after that, maybe it's not so and finally say you can do even better.So what you told us a new(NOTHING) Of course you can better.We know that without you.

 

[Magtheridon96]

What are you trying to argue here?
Just because he did it using a working method means that he should keep it the way it is?
That's the complete opposite of progress my friend.

Also, no one in this thread mentioned how the optimizer can compress abilities with levels lower than 5 to xml files, so you're argument is invalid. I did present new information.

 

[zv27]

What are you trying to argue here?
Just because he did it using a working method means that he should keep it the way it is?
That's the complete opposite of progress my friend.

Also, no one in this thread mentioned how the optimizer can compress abilities with levels lower than 5 to xml files, so you're argument is invalid. I did present new information.

I think I was clear enough

 

[Magtheridon96]

And after all, defines the man.

First you say that the best, and soon after that, maybe it's not so and finally say you can do even better.

Broken English

So what you told us a new(NOTHING)

False

but this is your very far from being the best.

More broken english

And yet:

I think I was clear enough

No, you were not clear enough.

I'm not trying to offend you here, and I don't want to start an argument (I'm not that type of person), but really, I'm only giving him a few tips and showing him the best known algorithm for what he is trying to achieve and why the method that I'm presenting is faster. I'm not forcing him to use my method, I'm showing him how the method I'm outlining is better. He chooses whether or not he wants to implement it.

And yes, I /can/ do better, and we all know that, but I'm not even going to try, so I might as well help defskull ameliorate his script.

 

[zv27]

And yes, I /can/ do better, and we all know that, but I'm not even going to try, so I might as well help defskull ameliorate his script.

hahahaha you are awesome

 

[maddeem]

Bro don't be arguing with Magtheridon96, he is legit.

 

[defskull]

And yes, I /can/ do better, and we all know that

Cocky much ?

Bro don't be arguing with Magtheridon96, he is legit.

Just make sure you do not worship him

Okay, I'll try to change the algorithm since you kinda prove me with legit information there.

 

[Magtheridon96]

Cocky much ?

No, zv27 said that he knows that I can do better, and I just brought that up.

Or at least, that's what I think "Of course you can better.We know that without you. " means.
But then again, 'you' doesn't have to refer to a particular person.

 

[defskull]

Okay, latest updates;
- Sound leak and player leak has been fixed
- Changed to new algorithm to base 2
- Added new customization, Damage and Armor
- Deleted some variables, replaced them with just local variables

 

[ratel]

Wow nice job,I'm hoping to see more +rep and 5/5

 

[maddeem]

I believe you repeated the HP add/remove in the setup

 

[defskull]

Wow nice job,I'm hoping to see more +rep and 5/5

Thanks

I believe you repeated the HP add/remove in the setup

Can you show me where ?

 

[maddeem]

Whoops my bad, you have a very strange setup

 

[defskull]

That setup is to loop all abilities to preload it, I am lazy to preload part by part therefore I made another trigger to loop them all at once.

 

[Noobsmoke]

Noobish question : this system supports unlimited (almost) values ?
I mean adding 99999999 damage or something like that ?

 

[defskull]

It supports a maximum of 16383 to a minimum of -16383 stats.
I might wanna list that for each function in the next update.
It's not the same applies to all customization.

This value is applied to Max HP/MP / Damage / Armor but not will apply to Attack Speed because as we all know the maximum Attack Speed in Warcraft III is around 400% ? (correct me if I'm wrong) so there's no use to add a 16383 of Attack Speed to a unit.

For the current customization, all customization are limited to that values (-16383 ~ 16383).
And this value is not part of configurable because it relates with the abilities in Object Editor.

 

[Magtheridon96]

HP needs to support more and damage needs to support less (That's what most people do)
Armor should also be much less (Max 1024, Min -1024)
:3

 

[defskull]

New customization has been added, Sight Range.

 

[Noobsmoke]

Damn, that's great, keep improving it ^_^

 

[CoLd Bon3]

I even made it only add/reduce MP. It was pretty easy to find what code and abilities to delete. I did this because i simply need interactions with MP only. The system is neat! Great job there, defskull!

 

[defskull]

I even made it only add/reduce MP. It was pretty easy to find what code and abilities to delete. I did this because i simply need interactions with MP only. The system is neat! Great job there, defskull!

Do you used my system for that INT gives Mana Point problem ?

 

[CoLd Bon3]

Do you used my system for that INT gives Mana Point problem ?

Yea, exactly! But i will wait for an update, just as i said.

 

[defskull]

Still, if I change to base 2, you would need a tiring job to copy paste like 40++ abilities.
I'm looking for a solution that is able to export/import those abilities without replacing the custom data inside Object Editor.

Apparently, if you use the Import/Export All Object Data, it will replace custom data inside Object Editor, and you don't want that eh ?

In order for you not to replace those custom data, is to copy and paste those abilities one by one... it's tiring, but hey, at least it does not replace the Raw ID.

 

[CoLd Bon3]

at least it does not replace the Raw ID.

Am... i placed the abilities one by one and the Raw ID problem occured?

 

[edo494]

Defskull, you should make it support a little bit more for the life. 16k is quite low tbh.

 

[defskull]

Am... i placed the abilities one by one and the Raw ID problem occured?

If you copy one by one (140++ times you switch between maps), the problem will never occur as it does not replace the ID of the object.

Like, if you already have custom ability with ID 'A000', and when you copy the ability from the system with ID 'A000' too, and when you paste it, it will automatically turns its ID to 'A001'.

Defskull, you should make it support a little bit more for the life. 16k is quite low tbh.

I am thinking for the solution to import/export those abilities all at a time without replacing custom object that is already in that map, it's tiring for a person to repeat the process for 140++ times.
After I found the solution, I can easily make it support more values.

 

[Magtheridon96]

You know, Jesus4Lyf, Earth-Fury and Nestharus all have systems in vJASS that do this, and they all have only one ability that gives a negative bonus to save file size.

You can refer to their code to figure out how you're going to pull it off here.