[JASS] Custom Stat System (CSS) v1.5g

[edo494]

you dont need loop if you do DisplayTimedTextToPlayer(GetLocalPlayer(), .....)

 

[Doomlord]

i tested and dont work, you can test again, pick 2 same item type, insert socket to 1st one then insert another socket to 2nd one and see what happen

i dont heard yet about that loop, this is the jasscraft result , i thought if it is a native then dont loop inside

Yes indeed the socket thing doesn't work. Fixing it now.

There are a lot things that don't need to be done locally such as requirements because it applies to all the items of that type. You should optimize your code and split it into local and global values for better handling.

SimError is recommended by mods

How do you detect when an item is removed or destroyed?

 

[shadowvzs]

There are a lot things that don't need to be done locally such as requirements because it applies to all the items of that type. You should optimize your code and split it into local and global values for better handling.

u dont got it why i made that
example what happen if u want create item with random stat and with same item type?
example: 2 item but one give 5 damage another 6? u create 2 item type? that possible but what if u need 100 item? u create 100 item?

my old orpg system used mover 300 item, and now only few just coz i save locally, easy to make random stat equipment after i already must saved locally the refine level and inserted gems, the saveing other things aren't big deal, yeah, assign to itemtypeid is pretty good until you dont want many potentional variation on your map

How do you detect when an item is removed or destroyed?

1st i used a periodical loop, like:
it = item array
i = index

when u drop a item or create item to ground then:
i= i + 1
it = your item

in periodic trigger u can check via loop if it[x] == null

now i dont use periodic trigger, i use max item amount, its mean
if i > 100 then remove the oldest item, coz i want avoid the item flood on ground

 

[Doomlord]

u dont got it why i made that
example what happen if u want create item with random stat and with same item type?
example: 2 item but one give 5 damage another 6? u create 2 item type? that possible but what if u need 100 item? u create 100 item?

my old orpg system used mover 300 item, and now only few just coz i save locally, easy to make random stat equipment after i already must saved locally the refine level and inserted gems, the saveing other things aren't big deal, yeah, assign to itemtypeid is pretty good until you dont want many potentional variation on your map

Ah I see. My bad then.

1st i used a periodical loop, like:
it = item array
i = index

when u drop a item or create item to ground then:
i= i + 1
it = your item

in periodic trigger u can check via loop if it[x] == null

now i dont use periodic trigger, i use max item amount, its mean
if i > 100 then remove the oldest item, coz i want avoid the item flood on ground

Nice. I think I had an idea on how to do this.

 

[shadowvzs]

Ah I see. My bad then.

also my favorite was the diablo 1,2, if u remember there also was magical blue item and rare yellow item with random bonus also if u remember to imbue at blacksmith

 

[Doomlord]

System currently set to Needs Fix. I had quite a lot of stuffs to patch up and I don't think I will be available till next weekend.

This is only temporary.

 

[Doomlord]

Version 1.4a updated

All bugs in the earlier version have been addresses and fixed. I have also added a feature to allow easy viewing of registered items' stats.

 

[Almia]

Have you tried this with Item Drops?(those on-death)

Just got in my mind.

edit

I found a bug.

Try getting items then sell it.
The stats remains even though the item is gone.

Here is the screeny:

Screeny

edit edit

WOOOOH!!! My Hero is a God :

Haha

 

[shadowvzs]

Have you tried this with Item Drops?(those on-death)

if u set item drop upon death then that work well, dont remain any stat

 

[Doomlord]

Updated to 1.5:

- Added an item bonuses refresh func.

 

[shadowvzs]

oh, just a ideea, u can avoid the useing hashtable and triggers for item death if u make items invulnarable when user buy it and map init a item pick playable map

call SetItemInvulnerable(whichItem, flag)

i guess i also will do same for avoid the useless item checking, so only the selling left and item removeing by trigger

 

[Doomlord]

oh, just a ideea, u can avoid the useing hashtable and triggers for item death if u make items invulnarable when user buy it and map init a item pick playable map

call SetItemInvulnerable(whichItem, flag)

i guess i also will do same for avoid the useless item checking, so only the selling left and item removeing by trigger

My system aims to be as GUI-friendly as possible and your method won't work with native item removal. It also disables the kill option, narrowing the user's variety of choice.

 

[muzzel]

Hmm, nice try but imo its not flexible enough, and there are already quite a lot of these systems that all look the same.

1. You cant have stats like for example +20% damage, can you?
2. It only handles item stats, what about buffs?
3. It doesnt support "soft stats", like Spellpower or other user-defined stats.

BonusMod however is useful, since its meant to be used on a low layer.

 

[Doomlord]

Hmm, nice try but imo its not flexible enough, and there are already quite a lot of these systems that all look the same.

1. You cant have stats like for example +20% damage, can you?
2. It only handles item stats, what about buffs?
3. It doesnt support "soft stats", like Spellpower or other user-defined stats.

BonusMod however is useful, since its meant to be used on a low layer.

I am sorry if this system doesn't live up to your expectations. I simply don't have the necessary capability to fulfill your needs but I will try my best.

Another thing, I am really tired of getting my system compared to BonusMod already. Why won't anyone look at both the advantages and disadvantages rather than locking on its inevitable flaw?

 

[shadowvzs]

Hmm, nice try but imo its not flexible enough, and there are already quite a lot of these systems that all look the same.

1. You cant have stats like for example +20% damage, can you?
2. It only handles item stats, what about buffs?
3. It doesnt support "soft stats", like Spellpower or other user-defined stats.

BonusMod however is useful, since its meant to be used on a low layer.

1. how cant be 20% damage? save damage to variavle and divide with 5 and add that much damage to unit
2. have buff systems
3. spell power just change a variable there absolute no big deal at all

 

[muzzel]

Another thing, I am really tired of getting my system compared to BonusMod already. Why won't anyone look at both the advantages and disadvantages rather than locking on its inevitable flaw?

im sry, but the 4. bullet in your feature list is:
"BonusMod-like features for extensive usage."

1. how cant be 20% damage? save damage to variavle and divide with 5 and add that much damage to unit

no, if you add an item that grants +20% damage you expect it to boost the overall damage of that unit by 20%, not the current damage value. Also you get problems if you remove the items in a different order. Example
- unit has 100 dmg
- picks up item with +100 dmg (-> has 200 dmg)
- picks up item with +10% Damage (-> has 220 dmg)
- drops item with +100 dmg (-> has 120 dmg)
- drops item with +10% dmg (-> has 109 dmg)

2. have buff systems

inventory system and buff system are the two basic components that modify unit stats. Thus they should share the same backend code for applying stats.

3. spell power just change a variable there absolute no big deal at all

exactly, but while making items you want to handle spellpower and damage as if they were the same kind of stat. You do not want a special treatment for spellpower and other "softstats", you use a system that handles stats so you want it to handle all of them.

 

[shadowvzs]

im sry, but the 4. bullet in your feature list is:
"BonusMod-like features for extensive usage."


no, if you add an item that grants +20% damage you expect it to boost the overall damage of that unit by 20%, not the current damage value. Also you get problems if you remove the items in a different order. Example
- unit has 100 dmg
- picks up item with +100 dmg (-> has 200 dmg)
- picks up item with +10% Damage (-> has 220 dmg)
- drops item with +100 dmg (-> has 120 dmg)
- drops item with +10% dmg (-> has 109 dmg)


inventory system and buff system are the two basic components that modify unit stats. Thus they should share the same backend code for applying stats.

exactly, but while making items you want to handle spellpower and damage as if they were the same kind of stat. You do not want a special treatment for spellpower and other "softstats", you use a system that handles stats so you want it to handle all of them.

its bonus mod system what i never watched yet any bonus mod system what cover every bonus stat, its just show the direction else it isnt lightweight

example damage detection system dont make the spells for u with special damage types

about ur calculation is wrong in that point if u use flat amount then never left 109 hp since it is flat 120=>100 after drop the 20 damage

another side its easily replaceables the flat abilities to percentage one (what i dont really like, in low game the percentages are ok but if someone what use it for wide level range map then its will be hard to make balance)

whatever about damage % most easiest way with dds and variable instead create more ability and call it amplify and not x% damage boost

 

[muzzel]

its bonus mod system what i never watched yet any bonus mod system what cover every bonus stat, its just show the direction else it isnt lightweight

example damage detection system dont make the spells for u with special damage types

Its not supposed to cover every possible bonus stat, it simply should allow you to define exactly the stats you need.

about ur calculation is wrong in that point if u use flat amount then never left 109 hp since it is flat 120=>100 after drop the 20 damage

That means you had to store the (absolute) damage you added, which (as far as i understand) cant be done using this system. Right? Well that sucks too since the bonus you get depends on the order in which you pick up the items.

another side its easily replaceables the flat abilities to percentage one (what i dont really like, in low game the percentages are ok but if someone what use it for wide level range map then its will be hard to make balance)

whatever about damage % most easiest way with dds and variable instead create more ability and call it amplify and not x% damage boost

Im not talking about replacing the absolute damage stat with percentual damage. I just said there are situations where you might want to have both absolute and percentual damage and more generally more flexible stat definitions.

 

[shadowvzs]

Im not talking about replacing the absolute damage stat with percentual damage. I just said there are situations where you might want to have both absolute and percentual damage and more generally more flexible stat definitions.

i dont see the problem with it, just add another abilities and same function handle that too...

 

[muzzel]

i dont see the problem with it, just add another abilities and same function handle that too...

you mean, alter the system?
Cause this:

//* Item Registration API                                                              *
//*                                                                                    *
//* call CSS_ItemInitialize (integer itemRawCode, integer armorBonus,                  *
//* integer attackSpeedBonus, integer damageBonus, integer agilityBonus,               *
//* integer intelligenceBonus, integer strengthBonus, integer lifeRegenBonus,          *
//* integer manaRegenBonus, integer lifeBonus, integer manaBonus,                      *
//* integer sightRangeBonus, integer socket)

doenst look like the system is designed to allow such adaptions.

I still think the system is good, but the design lacks flexibility.

But il rep you for this:

//********************************************************************************************************
//* REQUIREMENTS:                                                                                        *
//*                                                                                                      *
//* JNGP [url]http://www.hiveworkshop.com/forums/tools-560/jassnewgenpack-5d-227445[/url] (Recommended)  *
//* OR:                                                                                                  *
//* Your superhuman capability to transfer 198 abilities to your map. (Not Recommended)                  *
//********************************************************************************************************

Very phunny

 

[shadowvzs]

you mean, alter the system?
Cause this:

//* Item Registration API                                                              *
//*                                                                                    *
//* call CSS_ItemInitialize (integer itemRawCode, integer armorBonus,                  *
//* integer attackSpeedBonus, integer damageBonus, integer agilityBonus,               *
//* integer intelligenceBonus, integer strengthBonus, integer lifeRegenBonus,          *
//* integer manaRegenBonus, integer lifeBonus, integer manaBonus,                      *
//* integer sightRangeBonus, integer socket)

doenst look like the system is designed to allow such adaptions.

if u add + 1 integer and few ability then its allow pretty well

coz here u dont must change nearly nothing

function CSS_AddBonus takes unit u, integer amount, integer bonusType returns nothing
    local integer max = udg_CSS_Power[17]
    local integer min = -udg_CSS_Power[17]
    local integer i = 16
    local integer j = LoadInteger (udg_CSS_Hashtable, GetHandleId(u), bonusType)

    if amount > max - 1 or amount < min then
        call SimError ("Value too high or too low")
        return
    endif

    if amount + j >= max or amount + j <= min then
        call SimError ("Current value at maximum or minimum")
    endif

    set amount = amount + j
    call BoundInt (amount, min, max - 1)

    if bonusType < 0 or bonusType > 10 then
        call SimError ("CSS Error: Invalid bonus type (" + I2S(bonusType) + ")")
        return
    elseif bonusType == 8 or bonusType == 9 then

        if bonusType == 8 and amount*1. + GetUnitState(u, UNIT_STATE_MAX_LIFE) <= 0 then
            call SimError ("Unit's current max life is lower than the negative bonus amount. Unable to subtract.")
            return
        elseif bonusType == 9 and amount*1. + GetUnitState(u, UNIT_STATE_MAX_MANA) <= 0 then
            call SimError ("Unit's current max mana is lower than the negative bonus amount. Unable to subtract.")
            return
        endif

        call SaveInteger(udg_CSS_Hashtable, GetHandleId(u), bonusType, amount)

        if amount < 0 then
            set amount = max + amount
        else
            call UnitRemoveAbility(u, udg_CSS_Abilities[(bonusType + 1)*18 - 1])
        endif

        loop
            if amount >= udg_CSS_Power[i] then
                call UnitAddAbility(u, udg_CSS_Abilities[bonusType*18 + i])
                call UnitMakeAbilityPermanent(u, true, udg_CSS_Abilities[bonusType*18 + i])
                set amount = amount - udg_CSS_Power[i]
            else
                call UnitRemoveAbility(u, udg_CSS_Abilities[bonusType*18 + i])
            endif
        
            set i = i - 1
            exitwhen i < 0
        endloop

        if LoadInteger(udg_CSS_Hashtable, GetHandleId(u), bonusType) < 0 then
            call UnitAddAbility(u, udg_CSS_Abilities[(bonusType + 1)*18 - 1])
            call UnitMakeAbilityPermanent(u, true, udg_CSS_Abilities[(bonusType + 1)*18 - 1])
        endif

    else

        call SaveInteger(udg_CSS_Hashtable, GetHandleId(u), bonusType, amount)

        if amount < 0 then
            set amount = max + amount
            call UnitAddAbility(u, udg_CSS_Abilities[(bonusType + 1)*18 - 1])
            call UnitMakeAbilityPermanent(u, true, udg_CSS_Abilities[(bonusType + 1)*18 - 1])
        else
            call UnitRemoveAbility(u, udg_CSS_Abilities[(bonusType+1)*18 - 1])
        endif

        loop
            if amount >= udg_CSS_Power[i] then
                call UnitAddAbility(u, udg_CSS_Abilities[bonusType*18 + i])
                call UnitMakeAbilityPermanent(u, true, udg_CSS_Abilities[bonusType*18 + i])
                set amount = amount - udg_CSS_Power[i]
            else
                call UnitRemoveAbility(u, udg_CSS_Abilities[bonusType*18 + i])
            endif
        
            set i = i - 1
            exitwhen i < 0
        endloop

    endif
endfunction

 

[muzzel]

So you do have to alter the system. Systems should be flexible enough that you dont have to modify the code in order to use it properly.

 

[Nestharus]

Resources should essentially run themselves, just cnp into the map and done. Having to modify a resource makes everything more sloppy and harder to find >.>.

For example, many resources use Event lib so that other resources can dynamically plugin to them. Having to plug the resource in manually is crazy : o.


Requiring users to modify a resource is poor design.

 

[Doomlord]

Thanks everyone for participating in discussions. Please allow me to point out a few things:

• It is simply impossible to predict the amount of so-called soft stats that a map will need. Thus it is also impossible to make a one-size-fits-all API (I am not friggin' Nestharus for goodness' sake). I do believe that my system only needs configuration, not code alteration as long as you stick to the original functionality. And about the percentage thing and buff handling, gives me some time to think of a way to do it.
  
• Then again, concerning BonusMod, I should remind you guys that it serves only as the foundation of this system and nothing more; and yes I do say that it is for /extensive/ usage, which is inevitable due to obvious reasons.
  
• I would gratefully receive any further suggestions on how to improve this system's flexibility. It is what I have been looking for these days.

 

[muzzel]

[*]It is simply impossible to predict the amount of so-called soft stats that a map will need. Thus it is also impossible to make a one-size-fits-all API (I am not friggin' Nestharus for goodness' sake). I do believe that my system only needs configuration, not code alteration as long as you stick to the original functionality. And about the percentage thing and buff handling, gives me some time to think of a way to do it.

You dont have to predict the amount of soft-stats, you just have to make the system flexible enough so it scales.
Storing these values isnt a problem, you can use hashtables or linkedlists, you just have to think about how you register items. So instead this:

call CSS_ItemInitialize('afac', 150, 400, 800, 15, 45, 55, 85, 100, 100, 1000, 10, 3)

you can use a function that only sets one value, like this:

call CSS_ItemAddStat('afac', STAT_DAMAGE, 100)
call CSS_ItemAddStat('afac', STAT_SPELLPOWER, 40)
etc.

This looks like its a lot more code to write compared to your solution, but keep in mind that usually not all items make use of all stats, so you will only need a couple of these calls to register one item. And its more flexible since you can add another stat (by defining one of these STAT_**** constants) without rendering existing item definitions invalid.

About the creation of new stats, all you have to do is to write a function that allocates IDs for the stats. For stats that are no softstats (and for example need to change abilities) you have to provide functions that are called when the stat is changed. (You can use event libs for this purpose).

 

[Doomlord]

You dont have to predict the amount of soft-stats, you just have to make the system flexible enough so it scales.
Storing these values isnt a problem, you can use hashtables or linkedlists, you just have to think about how you register items. So instead this:

call CSS_ItemInitialize('afac', 150, 400, 800, 15, 45, 55, 85, 100, 100, 1000, 10, 3)

you can use a function that only sets one value, like this:

call CSS_ItemAddStat('afac', STAT_DAMAGE, 100)
call CSS_ItemAddStat('afac', STAT_SPELLPOWER, 40)
etc.

This looks like its a lot more code to write compared to your solution, but keep in mind that usually not all items make use of all stats, so you will only need a couple of these calls to register one item. And its more flexible since you can add another stat (by defining one of these STAT_**** constants) without rendering existing item definitions invalid.

About the creation of new stats, all you have to do is to write a function that allocates IDs for the stats. For stats that are no softstats (and for example need to change abilities) you have to provide functions that are called when the stat is changed. (You can use event libs for this purpose).

That would mean a complete rework of the system's code. I will be making a survey and deciding later. I greatly appreciate your good will in suggesting this but please allow me some more time to think.

EDIT: Here is the survey thread and I will be monitoring it for a while before making the final decision.

 

[Almia]

Does this use ObjectMerger or import?

 

[Doomlord]

Object Merger.

 

[Elemental91]

This might be an extremely stupid question... but I copied the CSS SYstem folder, but the only variable it copied is CSS_String, should I just customly replicate the other variables, or copy them some other way? D:

 

[Almia]

The Preference Create custom variables while pasting data is only supported by GUI. So,create all the variables missing.

 

[MasterTrainer]

Good job on the update! I'll let you know (As always) when I spot a bug =)

 

[Adiktuz]

oooh... this looks really useful... saves people from the boring work of item creation... useful for many people I believe...

 

[Doomlord]

oooh... this looks really useful... saves people from the boring work of item creation... useful for many people I believe...

Thanks. Appreciate that.

 

[btdonald]

It's great ^^!
I've tested it

 

[Doomlord]

It's great ^^!
I've tested it

Thank you.

 

[PurgeandFire]

Alrighty, here is my review.

• For the sake of easy implementation, you should include all your globals in the trigger "Color Code Setting" (and probably rename the trigger appropriately). This means setting them to 0 or initialize them or whatever it may be. This way, when someone copies over the system into the map, they'll have all the globals ready as long as they have "Preferences -> Create custom variables while pasting" checked.
• In the "Main System Code", the function "CSS_ItemInfoSocketPanel" seems a bit iffy. From what I see, it may have a chance of desyncing with the way GetLocalPlayer() is used. Imagine if you group the enum units selected for Player 1, and it is 5, whereas with player 2 it is 1. The group would be destroyed locally for Player 1 and thus, it would cause a desync.
  
  However, this shouldn't be too difficult to fix! It seems like you mostly did it just to shorthand the trigger actions. Instead, you should loop through the players and perform the necessary actions. I also recommend that you use a global variable for the group and just reuse it throughout the trigger, rather than creating one and destroying one each time:
  http://www.thehelper.net/threads/how-to-use-groups-without-leaking.123810/
• Same thing as above for "CSS_ItemInfoPanel".
• Assuming my chrome's "Find" function is working properly, you make the function for preloading items but you never end up calling it. You may also want to consider merging the functions for preloading items and preloading abilities, but it isn't really much of an issue.

Other than that it looks like a pretty solid system.

 

[MasterTrainer]

Is there a way to use only the CSS_AddBonus function and not the others?

 

[MasterTrainer]

Is there a function/group of functions in JASS that allows you to add a stat to a unit like CSS does?

 

[Doomlord]

Is there a way to use only the CSS_AddBonus function and not the others?

I will try to find a way. Sorry but, you know, frigging exams.

Is there a function/group of functions in JASS that allows you to add a stat to a unit like CSS does?

There are functions to add attributes but for other stats, no.

 

[MasterTrainer]

Attributes? How?

 

[Doomlord]

Those functions add/substract hero attributes. Look them up somewhere

 

[MasterTrainer]

Thanks =D

 

[Almia]

You could at least make the Dummy Owner move inside a constant function, but that is optional.

constant function CSS_GemLevel takes nothing returns integer
    return udg_CSS_GemLevel
endfunction

I don't see the use of this, just use the variable directly.

Cache GetHandleId(u) and GetHandleId (UnitItemInSlot (u, i)) in the StatUpdate func.

Actually, you can just use a Global group instead of local group.

if LoadStr (udg_CSS_Hashtable, i, -31 - j) == null then
    set s = "Not Socketed"
else
    set s = LoadStr (udg_CSS_Hashtable, i, -31 - j)
endif

->

set s = LoadStr (udg_CSS_Hashtable, i, -31 - j)
if s == "" then
    set s = "Not Socketed"
endif

    local integer i = GetHandleId (GetSoldItem ())
    local integer k = GetItemTypeId (GetSoldItem ())

cache GetSoldItem

LoadInteger (udg_CSS_Hashtable, i, j)
Cache this in the ItemSpawnCheck.

local integer i = GetHandleId (GetManipulatedItem())
local integer k = GetItemTypeId (GetManipulatedItem())

Cache GetManipulatedItem

LoadInteger (udg_CSS_Hashtable, k, j)
In the ItemDropCheck, cache this.

Use TriggerAddCondition instead of TriggerAddAction(Actions create new thread) and also don't forget to put return false.

In the ItemAcquireCheck, cache this : LoadInteger (udg_CSS_Hashtable, k, j)

Btw, Because of what I have discovered about the JASS Compiler,where the functions are allowed to be used, make sure to warn them that replace the code of the oldest with the code of this system,or perhaps,move the system's code to the Map Header and just create an auto-initializer(which I discovered also).

To create an auto-initializer, you must use one variable(any type,recommended is boolean). When a main function of the system runs(esp. the StatUpdate or anything that is the system's core that the user can use) Add this lines:

if udg_CSS_Initialized == false then // Initialized is boolean
    call CSS_Init()
    set udg_CSS_Initialized = true
endif

So that if the user runs a function, initializer gets initialized too.


This is just a short review from me.

 

[Doomlord]

Dummy Owner? Initializer? Wut?

About the caching, yeh ofc I will do it. Honestly pal, 2 have to be cache? Isn't that too much nitpicking?

 

[Almia]

Dummy Owner = Player(15)

 

[Doomlord]

Okay got it. Thank you for taking your time.

 

[MasterTrainer]

Thanks again for this update Doomlord; really means a lot to me

 

[msongyboi]

lol, so if i dont copy all of the abilities this wont work?

 

[Doomlord]

lol, so if i dont copy all of the abilities this wont work?

Exactly. It is a compulsory element of the system.

 

[msongyboi]

Exactly. It is a compulsory element of the system.

That is pretty damn annoying - I just made my own little system, since It would take much longer ctrl c/ving 198 spells. Still, this system is very customizable so props to you for that.