[JASS] Custom Stat System (CSS) v1.5g

[Moderator]

17:28, 17th Feb 2013
Purgeandfire: Approved and highly recommended. This system is now completely flexible, allowing you to implement the bonus mod separately. It is very well documented and a lot of work has been done to get it bug-free. The examples are great and should be sufficient to help any GUI'er use this.

 

[shadowvzs]

a question, this create 12*13=157 ability?
not shorter if u creaye 1 just with more level?

whatever i guess its enough conortable to copy to another map with textmacro

 

[Doomlord]

158 to be exact but I have an ability implementation macro.

 

[edo494]

you cant create 1 ability with multiple levels because you can only give unit 1 ability with unique rawcode so you wont be able to stack those effects as you can with different abilities with same effect

 

[gorillabull]

the object generation code looks EXACTLY like the one from bonus mode also i think that object generation as vell as lua in general is broken on many poeples computers

 

[Arhowk]

Macros do not work on x64 computers due to a windows update. This spell will be rejected. (Check the Nov. 2012 news batch)

Notice: All scripts that use ObjectMerger and Lua for Object Generation are currently unacceptable because of a Microsoft patch and/or Warcraft III patch that broke Lua. This is only a temporary measure.

you cant create 1 ability with multiple levels because you can only give unit 1 ability with unique rawcode so you wont be able to stack those effects as you can with different abilities with same effect

Thats not the problem with multi-level abilities. The problem is that they lag like hell (having a unit with 8 1-level abilities is faster than having him with 2 10-level abiiteis)

If multi-level abilities didnt lag, than someone with a non-broken computer would just make 1 2-million level bonus for every ability, but the map itself would be closer to a gig.

 

[Chaosy]

In which way is this better than bonus mod? or any other system that allready is made

 

[Doomlord]

Thank for the useful feedbacks and comments. I am going to apply approriate actions as the situation demands.

@gorillabull: I think I mentioned how the macro is based on BonusMod's and full credit goes to Earth-Fury, no?

@Arhowk: thanks for sharing practical and necessary info.

@Chaosy: this extends off BonusMod's features to achieve simple, GUI-friendly registration of item passive stats. It also has the measure to counter the neg max life/mana bug that BonusMod lacks. And what are those 'systems that are already made' you are talking about?

 

[shadowvzs]

If multi-level abilities didnt lag, than someone with a non-broken computer would just make 1 2-million level bonus for every ability, but the map itself would be closer to a gig.

do u tested?
i used 10 ability all with lv10, dont was any noticeable lagg at all, multilevel ability isnt just lv100 abilities.............

@Chaosy: this extends off BonusMod's features to achieve simple, GUI-friendly registration of item passive stats. It also has the measure to counter the neg max life/mana bug that BonusMod lacks. And what are those 'systems that are already made' you are talking about?

have few but not same, nice if have similiar systems with different solutions, because user can choose what he understand better or fit better to his map.

 

[Arhowk]

do u tested?
i used 10 ability all with lv10, dont was any noticeable lagg at all, multilevel ability isnt just lv100 abilities.............



have few but not same, nice if have similiar systems with different solutions, because user can choose what he understand better or fit better to his map.

10 on one unit?

now with every bonus, 100 10 level abilites, on more than one unit

 

[shadowvzs]

10 on one unit?

now with every bonus, 100 10 level abilites, on more than one unit

its depend how do u do..........

stat, mov speed = with trigger
max hp/mp aint that much either, overall what remain at unit that is only damage and attackspeed

have more solution depend how do u need the bonus is and what is the max cap on map

 

[Doomlord]

its depend how do u do..........

stat, mov speed = with trigger
max hp/mp aint that much either, overall what remain at unit that is only damage and attackspeed

have more solution depend how do u need the bonus is and what is the max cap on map

We are talking about green/red bonus so manipulation through trigger is out of the question here ;P

And as far as I am aware, your bringing down 9 stats to only 2 is a magic-like move tbh.

 

[gorillabull]

well there is still the problem with object generation you gonna need to find some other way to create 160 abilities

 

[Doomlord]

well there is still the problem with object generation you gonna need to find some other way to create 160 abilities

No but seriously though, I don't know.

 

[shadowvzs]

We are talking about green/red bonus so manipulation through trigger is out of the question here ;P

And as far as I am aware, your bringing down 9 stats to only 2 is a magic-like move tbh.

thats just response about level, not about ur system because it is nice, but who dont need mui things, just mpi and dont need something complicated for them viable the ability level option because for mpi hp/mp regen (just example) enough a periodic trigger until if system is mui then ability could better.

sry for off

 

[Arhowk]

Anyone with some MPQ knowledge could just copy and paste the abilities since you gave them a unique header

 

[SeriousEnemy]

I like this system. It works like it should and is mostly easy to use, even as a beginner.


You should add more info how to import stuff into another map. This is the hardest part for beginners and they will not spend hours to copy and paste single spells.


Another little thing, I recomment to delete the hero attribute spells.
You can modify it without using spells.

Hope I could help

 

[Doomlord]

I like this system. It works like it should and is mostly easy to use, even as a beginner.


You should add more info how to import stuff into another map. This is the hardest part for beginners and they will not spend hours to copy and paste single spells.


Another little thing, I recomment to delete the hero attribute spells.
You can modify it without using spells.

Hope I could help

Thanks for testing and providing such useful feedbacks.

About the Hero Attribute there is a bit of a misunderstanding as the bonus provided is displayed in green/red value, unlike the white number when triggered.

 

[Anachron]

Like I already said, it's reminding me of my "Advanced Inventory Handling" system I did a while back (in 2009). I know you didn't copy, just makes me realize the history repeats itself and some people are already in my footsteps. Keep up your good work!

 

[Doomlord]

Like I already said, it's reminding me of my "Advanced Inventory Handling" system I did a while back (in 2009). I know you didn't copy, just makes me realize the history repeats itself and some people are already in my footsteps. Keep up your good work!

Thank you very much for your kind words. And yes, there shall always be ppl who will invent the wheel if they don't have it.

 

[shadowvzs]

could u make text appear for longer time?
i mean to this with long duration

    call DisplayTimedTextToPlayer(Player(0), 0, 0, 30, "Type -dmg <amount> to add damage")

coz not appear at chatlog and after if someone is slow then must restart the map for try the another values because text disapear too fast and item bonus stat dont was write into their tooltip or just write into quest

also i guess better if dont disable black mask and fog of war because then peoples can test sight too


i like this system mainly coz jass and not vjass than other systems

 

[Doomlord]

could u make text appear for longer time?
i mean to this with long duration

    call DisplayTimedTextToPlayer(Player(0), 0, 0, 30, "Type -dmg <amount> to add damage")

coz not appear at chatlog and after if someone is slow then must restart the map for try the another values because text disapear too fast and item bonus stat dont was write into their tooltip or just write into quest

also i guess better if dont disable black mask and fog of war because then peoples can test sight too


i like this system mainly coz jass and not vjass than other systems

Requests granted. Except for the item bonuses I recommend that you read up my examplary item declaration to find out what the bonuses are. You can try declaring one or two items and you will be familiar with this system in no time

And thanks for the compliment. I appreciate it.

 

[shadowvzs]

i just wrote that more handy if u add to item tooltop tip, anyway u swaped the mana and life regen bonuses

if i type life regen than that change mana regen and invers if i type mana regen coz u assigned the mana regen abilities in life regen function, same with mana regen function there u add life regen abilitites

• Hero - Instantly revive Paladin 0022 <gen> at (Position of Paladin 0022 <gen>), Show revival graphics

leak

also could be usefull if u rename the test triggers

 

[Doomlord]

i just wrote that more handy if u add to item tooltop tip, anyway u swaped the mana and life regen bonuses

if i type life regen than that change mana regen and invers if i type mana regen coz u assigned the mana regen abilities in life regen function, same with mana regen function there u add life regen abilitites

• Hero - Instantly revive Paladin 0022 <gen> at (Position of Paladin 0022 <gen>), Show revival graphics

leak

also could be usefull if u rename the test triggers

Thanks for pointing that out. Fixing now.

And btw it is called a test trigger, it is not a part of the system, only for better testing. I reckon that you would also find it annoying that ppl are judging the test triggers of your system, no?

EDIT: bug fixed.

 

[shadowvzs]

a question, why dont use a integer for check unit have already that ability or no?

function AddHpRegen takes unit u, integer new returns nothing
    local integer array lifeRegenBonus
    local integer i = 11
    local integer a 
    local integer max = Pow2(12)
    local integer lifeRegen = LoadInteger(udg_h, GetHandleId(u), 9) + new
    call SaveInteger(udg_h, GetHandleId(u), 9, lifeRegen)
    set lifeRegenBonus[0] = 'A000' 
    set lifeRegenBonus[1] = 'A001' 
    set lifeRegenBonus[2] = 'A002' 
    set lifeRegenBonus[3] = 'A003' 
    set lifeRegenBonus[4] = 'A004' 
    set lifeRegenBonus[5] = 'A005' 
    set lifeRegenBonus[6] = 'A006' 
    set lifeRegenBonus[7] = 'A007' 
    set lifeRegenBonus[8] = 'A008' 
    set lifeRegenBonus[9] = 'A009' 
    set lifeRegenBonus[10] = 'A00A' 
    set lifeRegenBonus[11] = 'A00B' 
    set lifeRegenBonus[13] = 'A00C' 

    if lifeRegen < 0 then
        set lifeRegen = max + lifeRegen
        call UnitAddAbility(u, lifeRegenBonus[13])
        call UnitMakeAbilityPermanent(u, true, lifeRegenBonus[13])
    else
        call UnitRemoveAbility(u, lifeRegenBonus[13])
    endif

    loop
        set a = GetUnitAbilityLevel (u, lifeRegenBonus[i])
        if lifeRegen >= Pow2(i) and lifeRegen > 0 then
           if a == 0 then // add if unit dont have ability
            call UnitAddAbility(u, lifeRegenBonus[i])
            call UnitMakeAbilityPermanent(u, true, lifeRegenBonus[i])
           endif
        set lifeRegen = lifeRegen - Pow2(i)
        else
           if a > 0 then //remove only if unit got this ability
            call UnitRemoveAbility(u, lifeRegenBonus[i])
           endif
        endif
        
        set i = i - 1
        exitwhen i < 0
    endloop
endfunction

 

[Doomlord]

a question, why dont use a integer for check unit have already that ability or no?

Uhm, how is it going to improve my current algoritm?

 

[shadowvzs]

its not problem or anything just question u dont thought about use only 1 function for modify the similiar things?
because only difference is the ability raw codes

so something like

function BonusMod takes unit u, integer value, integer properties returns nothing
    local integer array lifeRegenBonus
    local integer i = 11
    local integer a 
    local integer max = Pow2(12)
    local integer NewAmount = LoadInteger(udg_h, GetHandleId(u), properties) + value
    if properties == 9 then
     set lifeRegenBonus[0] = 'A000' 
     set lifeRegenBonus[1] = 'A001' 
     set lifeRegenBonus[2] = 'A002' 
     set lifeRegenBonus[3] = 'A003' 
     set lifeRegenBonus[4] = 'A004' 
     set lifeRegenBonus[5] = 'A005' 
     set lifeRegenBonus[6] = 'A006' 
     set lifeRegenBonus[7] = 'A007' 
     set lifeRegenBonus[8] = 'A008' 
     set lifeRegenBonus[9] = 'A009' 
     set lifeRegenBonus[10] = 'A00A' 
     set lifeRegenBonus[11] = 'A00B' 
     set lifeRegenBonus[13] = 'A00C'
   elseif properties == 10 then
      ............
   endif
//rest action

endfunction

 

[Doomlord]

Well I don't really think about it that much since I think it is unnecessary to do 2 more condition checks. I may be wrong though.

 

[shadowvzs]

Well I don't really think about it that much since I think it is unnecessary to do 2 more condition checks. I may be wrong though.

only 1 more condition check vs around 10 other function i guess worth but u know, its just idea

 

[Doomlord]

Oh sorry I misunderstood your idea, thought you are referring to the "integer that checks if the unit has the ability or not" thing. Yes indeed this is the original path that BonusMod uses with an integer as the identifier for the bonus functions but I want to take a different path, another way. It is not efficient and stuffs but I feel like I could understand it, use it, control it properly as I wanted to. If a mod tell me I must change this then I certainly will but for now I want to leave it that way, it is my first system ever after all.

I understood your point perfectly. It is completely my choice to take this path though and I don't want to stray from it. Thanks for your advice

 

[shadowvzs]

a notice u can make max higher

    set i = 12
    set max = Pow2(i+1)-1

because if ur highest ability lets say add 1024 thing what is 2^10 then ur limit is 2^0+2^1+2^2+2^3+...+2^10 = 2 ^ 11 - 1 = 2047

 

[Doomlord]

Eh what you said is actually my current limit.

 

[shadowvzs]

u use ability index -1 but u can use same max than (ability index + 1)^2-1, its mean if u got 17 ability then 18^2-1 and i could be 17 (how much ability u got )

anyway u sometimes skiped a index and used it for special case

    local integer i = 16
    local integer max = CSS_Powers(17)
    local integer damage = LoadInteger(udg_CSS_Hashtable, GetHandleId(u), 0)

    set damageBonus[0] = 'ZxB0'
    set damageBonus[1] = 'ZxB1'
    set damageBonus[2] = 'ZxB2'
    set damageBonus[3] = 'ZxB3'
    set damageBonus[4] = 'ZxB4'
    set damageBonus[5] = 'ZxB5'
    set damageBonus[6] = 'ZxB6'
    set damageBonus[7] = 'ZxB7'
    set damageBonus[8] = 'ZxB8'
    set damageBonus[9] = 'ZxB9'
    set damageBonus[10] = 'ZxBa'
    set damageBonus[11] = 'ZxBb'
    set damageBonus[12] = 'ZxBc'
    set damageBonus[13] = 'ZxBd'
    set damageBonus[14] = 'ZxBe'
    set damageBonus[15] = 'ZxBf'
    set damageBonus[16] = 'ZxBg'
    //where is the 17? :D
    set damageBonus[18] = 'ZxBh'

its just raise ur limit with custom stat from 4096->8191 for life regen example

 

[Doomlord]

I actually skipped the index for a reason. It is not really important though. Sorry but I probably can't continue this conversation. I had other things in real life to attend to till August. And please don't misunderstand this as an insult.

Bye

 

[shadowvzs]

its fine with fix good description, well organized,5/5.

(little off but why need preload the items if item abilities preloaded too?)

 

[Doomlord]

its fine with fix good description, well organized,5/5.

(little off but why need preload the items if item abilities preloaded too?)

Thanks very much. However this version is bugged a little bit. I am gonna fix the bug plus uploading a new feature: item socketing (like the one in Diablo 2 )

Well preloading items is a must I am afraid, it must be done so that the pickup and drop check are initialized or there will be first use lag otherwise.

 

[shadowvzs]

Thanks very much. However this version is bugged a little bit. I am gonna fix the bug plus uploading a new feature: item socketing (like the one in Diablo 2 )

Well preloading items is a must I am afraid, it must be done so that the pickup and drop check are initialized or there will be first use lag otherwise.

preloading not only for custom items needed?

(hehe slowly u start making a similiar map than me, i also started with custom stat, now i made full screen equipments with refine socket and charms craps )

go ahead (i hope that also only jass)

 

[Doomlord]

preloading not only for custom items needed?

(hehe slowly u start making a similiar map than me, i also started with custom stat, now i made full screen equipments with refine socket and charms craps )

go ahead (i hope that also only jass)

Yep. In my case you have to preload items.

Yes the socketing method is in JASS as usual. And this one utilizes the item-swap method rather than through an external mean (kinda like Diablo 2). Currently you can't unsocket or use runes though I think I will add rune on another day.

 

[shadowvzs]

Yep. In my case you have to preload items.

Yes the socketing method is in JASS as usual. And this one utilizes the item-swap method rather than through an external mean (kinda like Diablo 2). Currently you can't unsocket or use runes though I think I will add rune on another day.

item swap, do you mean u make from every item more version only coz of sockets and when u add into item 1 socket then swap item?

 

[Doomlord]

item swap, do you mean u make from every item more version only coz of sockets and when u add into item 1 socket then swap item?

Uhm no. That would be going against this system's motto.

When I said "item swap" I was referring to the act of right-clicking on an item then left-click on another to swap their positions

In this case, you will right-click on the Gem then left-click on the item to socket. It is quick and easy enough

 

[shadowvzs]

Uhm no. That would be going against this system's motto.

When I said "item swap" I was referring to the act of right-clicking on an item then left-click on another to swap their positions

ah, i understand now what u mean under swap
whatever the main problem is with makeing maybe equipment system later, is the 6 slot limit in inventory because lets say atm u have 2 socket item and 1 equipment and already only 3 space left in inventory :/

another ideea is good, but for me that 6 slot limit annoyed, thats why i started with multiboard equipment system then everything remade to full screen inventory.

 

[Doomlord]

ah, i understand now what u mean under swap
whatever the main problem is with makeing maybe equipment system later, is the 6 slot limit in inventory because lets say atm u have 2 socket item and 1 equipment and already only 3 space left in inventory :/

another ideea is good, but for me that 6 slot limit annoyed, thats why i started with multiboard equipment system then everything remade to full screen inventory.

Eh? I don't understand what you mean by equipment system

 

[shadowvzs]

Eh? I don't understand what you mean by equipment system

i meant u 1st made a system what add custom stat, assigned to items, now u make sockets, soon (i guess because u going to that way ) u will make equipment system[items categorized to weapons/armors etc and cant hold 2 from same type]

j

 

[Doomlord]

i meant u 1st made a system what add custom stat, assigned to items, now u make sockets, soon (i guess because u going to that way ) u will make equipment system[items categorized to weapons/armors etc and cant hold 2 from same type]

Probably not since I am just utilizing the power of my stat system to create extensions. Mainly to prove that it is not a copy of other BonusMod systems. That being said, it is obvious the equipment system isn't based on the stat system and thus I possibly won't do it.

But your system is awesome enough I can't hope to compete

 

[shadowvzs]

Probably not since I am just utilizing the power of my stat system to create extensions. Mainly to prove that it is not a copy of other BonusMod systems. That being said, it is obvious the equipment system isn't based on the stat system and thus I possibly won't do it.

But your system is awesome enough I can't hope to compete

yes thats how i started my system too, 1st was only midifing the max hp/mp, then the dmg and attack speed and at end?
even when i added full screen inventory and made socket/refine another crap with sht load codes still got comment about it is a "copy" of kobas system, when i dont watched his system also was wrote myself the whole crap

ust a not, dont add effect to gem until not inserted to equipment/=item because that weird
example in diablo 2 too, when gem dont was inserted, just was in inventory in natural form, dont gived any stat bonus, only after player inserted into item

this was the previous version

http://www.hiveworkshop.com/forums/map-development-202/orpg-template-223745/#post2226807

ain't was perfect, but also not the 1st edition so u started with enough strong core

 

[Doomlord]

yes thats how i started my system too, 1st was only midifing the max hp/mp, then the dmg and attack speed and at end?
even when i added full screen inventory and made socket/refine another crap with sht load codes still got comment about it is a "copy" of kobas system, when i dont watched his system also was wrote myself the whole crap

ust a not, dont add effect to gem until not inserted to equipment/=item because that weird
example in diablo 2 too, when gem dont was inserted, just was in inventory in natural form, dont gived any stat bonus, only after player inserted into item

Well. Okay seems like a good suggestion. I will add a function to configure it i.e allow gems to give bonuses or not when not socketed.

Don't worry I also got one such comment from C***sy but I really don't care. The users will judge it for us.

 

[shadowvzs]

you could explain this?

click

// SimError by Vexorian at wc3c.net

// Sim Error (modified)

function SimError takes string s returns nothing
    local string msg = "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n|cffffcc00" + s + "|r"
    local player ForPlayer = GetTriggerPlayer()
    local sound error = CreateSoundFromLabel("InterfaceError", false, false, false, 10, 10)

    if GetLocalPlayer() == ForPlayer then
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(ForPlayer, 0.52, 0.96, 2.00, msg)
        call StartSound(error)
    endif

    set ForPlayer = null
endfunction

function SimNotification takes string s returns nothing
    local string msg = "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n|cff32cd32" + s + "|r"
    local player ForPlayer = GetTriggerPlayer()

    if GetLocalPlayer() == ForPlayer then
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(ForPlayer, 0.52, 0.96, 2.00, msg)
    endif

    set ForPlayer = null
endfunction

why use that instead the simple DisplayTimedTextToPlayer? i mean the getlocalplayer part, also i dont see event for them so idk if triggerplayer is work?

a problem, u attach data to item type id, result is if user use 2 item what got same item type id then system is screwed totally because u cant put nothing to 2nd

LoadInteger (udg_CSS_Hashtable, k, -2)

use this

LoadInteger (udg_CSS_Hashtable, GetHandleId(your item), -2)

if item is sold, destroyed then flush the item handle id

for me here started the totally new rewrited system, coz i attached every data to item handle id (dmg, level requiment, class requiment, stat requiment, attack speed, hp, model path if attachment villager map, price, self item, sockets)

(dont need negative value for hash index, u can use ofc just i think easier to handle the normal positive index, like item infor between 1-100, socket info 101-200 (example: 101=socket item type id, 102=the amount, 103 the 2nd socket item if it was inserted to item, item typeid, 104 the 2nd item amount))

 

[Doomlord]

you could explain this?

click

// SimError by Vexorian at wc3c.net

// Sim Error (modified)

function SimError takes string s returns nothing
    local string msg = "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n|cffffcc00" + s + "|r"
    local player ForPlayer = GetTriggerPlayer()
    local sound error = CreateSoundFromLabel("InterfaceError", false, false, false, 10, 10)

    if GetLocalPlayer() == ForPlayer then
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(ForPlayer, 0.52, 0.96, 2.00, msg)
        call StartSound(error)
    endif

    set ForPlayer = null
endfunction

function SimNotification takes string s returns nothing
    local string msg = "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n|cff32cd32" + s + "|r"
    local player ForPlayer = GetTriggerPlayer()

    if GetLocalPlayer() == ForPlayer then
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(ForPlayer, 0.52, 0.96, 2.00, msg)
    endif

    set ForPlayer = null
endfunction

why use that instead the simple DisplayTimedTextToPlayer? i mean the getlocalplayer part, also i dont see event for them so idk if triggerplayer is work?

a problem, u attach data to item type id, result is if user use 2 item what got same item type id then system is screwed totally because u cant put nothing to 2nd

LoadInteger (udg_CSS_Hashtable, k, -2)

use this

LoadInteger (udg_CSS_Hashtable, GetHandleId(your item), -2)

if item is sold, destroyed then flush the item handle id

for me here started the totally new rewrited system, coz i attached every data to item handle id (dmg, level requiment, class requiment, stat requiment, attack speed, hp, model path if attachment villager map, price, self item, sockets)

(dont need negative value for hash index, u can use ofc just i think easier to handle the normal positive index, like item infor between 1-100, socket info 101-200 (example: 101=socket item type id, 102=the amount, 103 the 2nd socket item if it was inserted to item, item typeid, 104 the 2nd item amount))

DisplayTimedTextToPlayer would require a loop through 15 players Plus this is much more convenient.

About the item type and item handle thing, here is a picture

http://www.hiveworkshop.com/forums/pastebin.php?id=zknxku

Test and see for yourself if you don't believe me.

 

[shadowvzs]

DisplayTimedTextToPlayer would require a loop through 15 players Plus this is much more convenient.

About the item type and item handle thing, here is a picture

http://www.hiveworkshop.com/forums/pastebin.php?id=zknxku

Test and see for yourself if you don't believe me.

i tested and dont work, you can test again, pick 2 same item type, insert socket to 1st one then insert another socket to 2nd one and see what happen

i dont heard yet about that loop, this is the jasscraft result , i thought if it is a native then dont loop inside

native DisplayTextToPlayer takes player toPlayer, real x, real y, string message returns nothing
native DisplayTimedTextToPlayer takes player toPlayer, real x, real y, real duration, string message returns nothing