Shadow Paralysis v1.4

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

14:32, 5th Jan 2015
Maker: Check my reply in this thread.

 

[gorillabull]

7/5 because this features characters from my favorite narito show

 

[BPower]

Work yourself into the basics of Wc3 coding in GUI.
--> Check out the link in my signature: Things that leak

 

[Meatmuffin]

There are leaks, though this is a quite creative implemention nonetheless. +rep

If it's possible, add an actual screenshot of the spell (in addition to your current one), and make it support levels.

 

[dark09cry]

Sorry about that. I also noticed the leaks, right after I uploaded it but I have fixed it and will update soon.

 

[deathismyfriend]

Only use and all condition blocks inside an or all condition block.

Anything used twice or more should be stored in a variable and the variable should be used. Example: Picked unit should be stored.

These leak locations.

• (Distance between (Position of SP_Caster[SP_Loop_Integer]) and (Position of SP_DummyVar[SP_Loop_Integer])) Less than SP_Distance[SP_Loop_Integer]
• Set SP_SpawnPoint[SP_Loop_Integer] = ((Position of SP_DummyVar[SP_Loop_Integer]) offset by 35.00 towards SP_Angle[SP_Loop_Integer] degrees)
• Set SP_Detector[SP_Loop_Integer] = (Units within DetectRadius of (Position of SP_Shadow[SP_Loop_Integer]))
• Set SP_Angle[SP_Index] = (Angle from (Position of SP_Caster[SP_Index]) to SP_Target[SP_Index])

You also never remove the locations that you set so all of them leak.

Never use Integer A/B. Create an integer variable and use that for your looping.

Also abilities should be able to have multiple levels.

 

[GywGod133]

In you Unit Group you must put the picked unit in a variable

 

[Meatmuffin]

In you Unit Group you must put the picked unit in a variable

It's already pointed out by DIMF.

 

[GywGod133]

This....

• Unit Group - Pick every unit in SP_ParalyzedUnits[SP_Loop_Integer] and do (Actions)
  • Loop - Actions
    • Unit - Cause SP_Caster[SP_Loop_Integer] to damage (Picked unit), dealing SP_DPS[SP_Loop_Integer] damage of attack type Spells and damage type Magic

 

[deathismyfriend]

• Custom Script: call SetUnitPropWindow( SP_Shadow[SP_Loop_Integer], 0)

To enable movement once more, do

• Custom script: call GetUnitDefaultWindow( SP_Shadow[SP_Loop_Integer] )

You have to get the units prop window first and set it to a variable then you have to set the units prop window.

Getting the units default prop window is bugged and can cause unwanted results.

 

[GywGod133]

I tried your spell if it works well and it's not MUI

 

[dark09cry]

I tried your spell if it works well and it's not MUI

What's the problem?

 

[deathismyfriend]

You have location leaks.

You store picked unit in a variable above this but you should use it in these conditions.

• ((Picked unit) is A structure) Equal to False
• ((Picked unit) is in SP_Paralyzed[SP_Integer[1]]) Equal to False
• ((Picked unit) is alive) Equal to True
• (Picked unit) Not equal to SP_Caster[SP_Integer[1]]
• (Unit-type of (Picked unit)) Not equal to DummyId
• ((Picked unit) belongs to an enemy of (Owner of SP_Caster[SP_Integer[1]])) Equal to True

This should be in your de-indexing code.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• SP_Integer[0] Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)
• Else - Actions

You should include a changelog so people know what you fixed.
Never rename a version from 1.0 to 1.0[reworked] What is your next version ? 1.0[reworked again] ?
Just name it v1.1

 

[dark09cry]

Thanks for noticing, I forgot to store that one...

I'll fix it right away.

You should include a changelog so people know what you fixed.
Never rename a version from 1.0 to 1.0[reworked] What is your next version ? 1.0[reworked again] ?
Just name it v1.1

Yeah you got a point... that's my fault. lol...

 

[deathismyfriend]

There are some leaks.

• Set SP_Angle[SP_Integer[0]] = (Angle from (Position of SP_Caster[SP_Integer[0]]) to SP_Target[SP_Integer[0]])
• (Distance between SP_StartDistance[SP_Integer[1]] and (Position of SP_Last[SP_Integer[1]])) Less than SP_EndDistance[SP_Integer[1]]
• Set SP_Point[SP_Integer[1]] = ((Position of SP_Last[SP_Integer[1]]) offset by 35.00 towards SP_Angle[SP_Integer[1]] degrees)
  • Set SP_Group2[SP_Integer[1]] = (Units within 45.00 of (Position of SP_Picked[SP_Integer[1]]))

This should be stored in a variable as it will most likely be used more than once.

• (SP_DPS[SP_Level[SP_Integer[1]]] x 0.03)
• /// And this.
• (SP_MPS[SP_Level[SP_Integer[1]]] x 0.03)
• /// And this.
  • (Owner of SP_Caster[SP_Integer[1]]))

You should use a tempGroup instead of SP_Group2[SP_Integer[1]]

 

[Maker]

-Paralysis spell should not pause units

-Set SP_Group[SP_Integer[0]] = (Random 0 units from (Units in (Playable map area)))
^That is an unnecessarily heavy action and created leaks that are unavoidable with GUI. Use
Custom script : Set udg_SP_Group[udg_SP_Integer[0]] = CreateGroup()

-Use leak LastPoint

Needs Fix

 

[dark09cry]

-Paralysis spell should not pause units

-Set SP_Group[SP_Integer[0]] = (Random 0 units from (Units in (Playable map area)))
^That is an unnecessarily heavy action and created leaks that are unavoidable with GUI. Use
Custom script : Set udg_SP_Group[udg_SP_Integer[0]] = CreateGroup()

-Use leak LastPoint

Needs Fix

Can you direct me to an alternative method of pausing units? All I know about it is in GUI... Thanks.

 

[IcemanBo]

You could stun enemies.