Selection Hero System (v1.3)

[Moderator]

Selection Hero System (v1.3) | Reviewed by Maker | 15th Mar 2013

APPROVED

There are no bugs (that I could find) Leak Set SHS_Sys_Point_Interface = ((Center of Showcase <gen>) offset by 90.00 towards 180.00 degrees) The camera is not completely locked, it moves if I scroll with mouse wheel You could turn off the button triggers when everyone has picked a hero

[tr]

Old reviews Selection Hero System (v1.2) | Reviewed by Maker | 4th Mar 2013 NEEDS FIX Leak Set SHS_Sys_Point_Interface[SHS_Sys_NumberPlayerIntegerA] = ((Center of...offset by...) You have location leak when you create the selected real hero Cam Fixed and Mult Update trigger should not set the multiboard texts every 0.01 seconds, neither should it min/max the board that often The multiborad displaying method is not MUI, it will display all multiborads to every player It would be nice if all players could share the same location. If one uses the same for eveyone now, the units are overlapped. You have missing passive icons. Things that leak Spell Submission Rules [tr] Selection Hero System (v1.1) | Reviewed by Maker | 3rd Mar 2013 NEEDS FIX Leaks Set Point_Interface[(Integer A)] = ((Center of Regions_Interface[(Integer A)]) offset by...) Unit - Create 1 |cff000000.|r [Dummy] for (Player((Integer A))) at (Center of... You have location leaks when you create the selected real hero Cam Fixed and Mult Update trigger should not set the multiboard texts every 0.01 seconds, neither should it min/max the board that often A useful trick when setting up the heroes is to use a variable for the index. Set integer = 0 Set HeroDummy[variable] = x, set Hero[variable] = y and so on. Use a variable for Player number of (Player(Integer A))) in Startup trigger You don't need the dummy unit types, create units based on the hero types with triggers. Give the units Locust ability to make them unselectable Abilities with no cooldown would be better for Next and Previous buttons Things that leak Spell Submission Rules [tr]

 

[Maker]

• Leaks
  
  • Set Point_Interface[(Integer A)] = ((Center of Regions_Interface[(Integer A)]) offset by...
  • Unit - Create 1 |cff000000.|r [Dummy] for (Player((Integer A))) at (Center of Regions_Interface[(Player number of (Player((Integer A))))]) ...
  • Camera - Pan camera for (Player((Integer A))) to (Center of Regions_Interface[(Player number of (Player((Integer A))))]) over 0.00 seconds
• You could use a variable for player number and use the variable when referencing multiboard index
• The camera can be locked in a better way. Try panning over 0.1 seconds
• Fix the file type of the map
• Use Begins casting an ability event
• Use an ability that can be casted faster, now there is a short cooldow
• You don't need dummy units in object editor, add Locust to the created units

 

[Chaosy]

It looks ok from the screenshot, but there is so many systems that use a multiboard so I do not suggest this method.

also there is a few leaks in the triggers

 

[Felipe Gormadoc]

- Maker
Hey man, thanks for tips.

- Chaosy
if you discover a leak or bug let me know please.

i updated the system, i fix:
-Camera, I traded pan cam by lock cam
-fix the events of "Buttons Triggers"
-fixed the file map
-add little cooldown for "next" and "previous" buttons
-fixed the function of "Rotate" button

 

[Almia]

@Maker

This are my additional reviews.

-For the configurables,you dont need arrays.All you need is a hashtable and a trigger which registers values.
Here is an example:

set Hero = Palladin
set Level = 5
Trigger - Run Register<gen>

That will the configuration looks as an example.

For registration:

Hashtable - Save Hero as Key of Key in MyHash
Hashtable - Save Level as Key of Key in MyHash

this registers the values inside the hashtable.You can use it via loading it.
Here are some examples the uses this kind of method:
http://www.hiveworkshop.com/forums/...n-window-v1-0-a-226393/?prev=status=a&u=Almia
http://www.hiveworkshop.com/forums/spells-569/compressed-tavern-v1-4-a-223378/?prev=status=a&u=Almia
http://www.hiveworkshop.com/forums/...rce-cost-v1-1-a-223384/?prev=status=a&u=Almia
http://www.hiveworkshop.com/forums/...-218548/?prev=status=a&d=list&r=20&u=defskull
http://www.hiveworkshop.com/forums/...-228697/?prev=status=a&d=list&r=20&u=defskull
http://www.hiveworkshop.com/forums/...-218904/?prev=status=a&d=list&r=20&u=defskull

- Cache the following values to increase speed:
(Player number of (Owner of (Triggering unit)))
(Owner of (Triggering unit))
(Player(Integer A))
[(Player number of (Player((Integer A))))

-Your system uses Integer A. We in this site guarantee to not support this because there is a possibility that using this for every trigger can crash the map(based on my experience). Just create a new integer variable to replace integer A. Also,Integer A is slow

-There are so many constant values inside the system.Please create a new trigger to have the main system configurable,like these values:
Abilities\Spells\Human\ReviveHuman\ReviveHuman.mdl
Set Angle_Rotate[(Integer A)] = 270.00
Etc.

-Your system lacks in prefixes.You should add it so that it wont collide in the maps of the users if they accidentally have the same name of variables.

- Colors inside the description of multiboard(|cff80ff00Name,(|cff80ff00Type:|r ,etc) should be configurable

There you have my extra reviews.

 

[Felipe Gormadoc]

ok guys
new update ready, look the changelog for more informations

Thanks

 

[Juliano]

After spending about an hour looking for a hero selection system for my map, I chose yours, here is why:
-Easy to configure, only edit the hero types and texts
-Absolute no need to know JASS or advanced triggering to implement
-Can be used by multiple people
-Doesnt use large ingame images(will not need a large portion of the map to place)
-Simple and describes hero well

Suggestion: add a -repick command to take the player back to the multiboard and allow to chance the hero.

+rep

 

[Tiagomrorais]

Realy liked this system, way more than others out there, is much more simple, easy to configure and put to work, the only problem is whenever you put it on Lan, or multiplayer becomes very very laged.. i dont know the reason tought..

 

[Tasyen]

Cause it has some flaws in its code. i used it in one of my, not on hive uploaded, projects and had to overwork it first :|.

How to fix:

1. A Easy fix would be to lower frequenzy in the Trigger Camera Fix from 0.01 -> 0.03, this saves alot of performance.
2. Trigger Startup: Move The Action: Trigger - Run Multiboard Update <gen> (checking conditions) out of the Loop, Cause it just just doesn't make much sense to update all tables every time a Playing player was found.
3. Well it doesn't felt MPI for me at my Lan Plays, you need to make "show Multiboard" only for local player -> each player sees only its own table.

I did that this way:

• Custom script: if GetLocalPlayer() == udg_SHS_Sys_PlayerIntegerA then
• Multiboard - Show SHS_Sys_Multiboard[SHS_Sys_NumberPlayerIntegerA]
• Multiboard - Maximize SHS_Sys_Multiboard[SHS_Sys_NumberPlayerIntegerA]
• Custom script: endif

 

[DPL]

No bugs detected. Also its good you can edit the description with a simple line. A noob in coding such as me, can use the system e.a.s.y.