Aggro System v1.3

[Moderator]

Aggro System v1.3 | Reviewed by BPower | 14.06.2015 [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] Changes unit ownership from neutral to aggressive and back. The system currently fires on unit attack, spell cast, target order and periodically via timer event. I can see this beeing useful for a few mappers. Code[/COLOR]] Unnessesary code duplicates are catching my eyes. You should merge the aggro and neutral system under one trigger, basically they are identical except for one condition. You can null your unit variables just once and at the bottom. In "clicking" you attempt to destroy a group handle, which does not exist in the first place. "Range" trigger needs a workover, as it currently might work for few camps, but gets unprecise for huge maps. Permanent running 0.03 timers are performance killers. You should think of a better solution. Rating[/COLOR]] CONCEPT CODE RATING STATUS 3/5 1/5 2/5 NEED FIX

Old Reviews

Aggro System v1.25 | Reviewed by Maker | 27th Mar 2013

NEEDS FIX

Check my reply in this thread.

[tr]

Aggro System v1.2 | Reviewed by Maker | 24th Mar 2013 NEEDS FIX Attack Aggro should not check specific abilities beign cast It hould work with any ability without needing to add each one by one Attack Aggro has a if/then/else with no condition Clicking Aggro leaks a location and you should abort the trigger if it was an item that was clicked Range Aggro has a location leak and it runs 100 times a second, too often Range Aggro check for Wind Walk buff, which is a specific buff, the system should check for invisibility status towards a player Readable triggers [tr] Aggro System v1.1 | Reviewed by Maker | 18th Feb 2013 Needs Fix Required changes The Player Group - pick every player in group actions are not needed. Use owner of unit function and check if the owner is in player group. Use a variable for the player to change ownership to. Range Aggro trigger needs a complete rework. I recommend you ask for help in Triggers & Scripts Suggested changes Add support for units de-aggroing [td]

[/TD]

 

[Ofel]

Post the triggers, please....

Edit
Also, you need to store some function in variable that used more than once.
Example :

Trigger

• Attack Aggro
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set Temp_Unit = (Attacked unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Owner of Temp_Unit) Equal to Neutral Passive
      • Then - Actions
        • Unit - Remove Wander (Neutral) from Temp_Unit
        • Unit - Change ownership of Temp_Unit to Player 8 (Pink) and Change color
        • Unit - Order Temp_Unit to Attack (Attacking unit)
      • Else - Actions

 

[Echo]

Alright I will do so when I get back on my main computer .

 

[Maker]

You are leaking and the system could support hostile->passive.

 

[Wolf_Wing]

Post Some Trigger Please..........
and you need to add some trigger like this

TRIGGER

add some player to group so....its will work for other player

• Player
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Add Player 1 (Red) to PlayerGroup
    • Player Group - Add Player 2 (Blue) to PlayerGroup
    • Player Group - Add Player 3 (Teal) to PlayerGroup
    • Player Group - Add Player 4 (Purple) to PlayerGroup
    • Player Group - Add Player 5 (Yellow) to PlayerGroup
    • Player Group - Add Player 6 (Orange) to PlayerGroup
    • Player Group - Add Player 7 (Green) to PlayerGroup
    • Player Group - Add Player 8 (Pink) to PlayerGroup
    • Player Group - Add Player 9 (Gray) to PlayerGroup
    • Player Group - Add Player 10 (Light Blue) to PlayerGroup
    • Player Group - Add Player 11 (Dark Green) to PlayerGroup
    • Player Group - Add Player 12 (Brown) to PlayerGroup
    • Player Group - Add Neutral Hostile to PlayerGroup
    • Player Group - Add Neutral Victim to PlayerGroup
    • Player Group - Add Neutral Extra to PlayerGroup
    • Player Group - Add Neutral Passive to PlayerGroup

and do some trigger like this
EXAMPLE:

• Attack Aggro
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set Temp_Unit = (Attacked unit)
    • Player Group - Pick every player in PlayerGroup and do (Actions)
      • Loop - Actions
        • Set Player = (Picked player)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of Temp_Unit) Equal to Player
          • Then - Actions
            • Unit - Remove Wander (Neutral) from (Attacked unit)
            • Unit - Change ownership of (Attacked unit) to Player 8 (Pink) and Change color
            • Unit - Order (Attacked unit) to Attack (Attacking unit)
          • Else - Actions

 

[Zwiebelchen]

There's already a nearly flawless and approved aggro system available on hive:
https://www.hiveworkshop.com/forums...tem-2-5-a-156179/?prev=status=a&u=Zwiebelchen

... well ... unless I understood the purpose of this system wrong. In this case, just ignore my post please!

 

[Echo]

Sorry guys I was suppose to look over the map 1 more time before putting it up and leaving for a few days, as soon as i get home i am cleaning everything and adding more to the system.

I am guessing from the comments people want me to make the system work for a player rather than just a hero. I'll work on this asap

And Zwiebelchen this system doesn't work with threat, it deals with how a passive unit turns aggressive and attacks the hero unit.

Edit: I have updated the system, thanks for the help guys ^^.

 

[Chaosy]

1. use a DDS
2. I think you leak unit groups, not sure tho I never used it that way

3/5 there's already a better one out there in my opinion but this is GUI so it's ok I guess

 

[edo494]

Chaosy is right, bj_wantDestroyGroup only has effect if you are doing Pick every unit in ..., this way you create new group and never destroy it every time the trigger runs
I recommend using DestroyGroup(udg_yourgrouphere) if you are not using this group somewhere else

 

[Echo]

How do I destroy the group when the variable is set to a unit? I have never really come across this issue before.

Edit: I have fixed the leaking trigger.

 

[Almia]

Casting Unit - Triggering Unit

(Owner of A_Temp_Attacked) > cache this into a variable

(Owner of A_Temp_Ordered_Unit) > cache to.

Wander(Neutral) > cache in an ability variable so that users can easily handle this.

You are leaking two unit groups in Range Aggro trigger and Range N trigger.

Also, the 300 range value there should be configurable

 

[Maker]

Attack aggro could look like this I think:

Trigger

• Attack Aggro
  • Events
    • Unit - A unit Is attacked
    • Unit - A unit Begins casting an ability
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Triggering unit) Equal to (Casting unit)
      • Then - Actions
        • -------- Set the variables --------
        • Set A_Temp_Attacked = (Target unit of ability being cast)
        • Set A_Temp_Attacking = (Casting unit)
        • -------- Checking if the triggering units match with the set players --------
      • Else - Actions
        • Set A_Temp_Attacked = (Attacked unit)
        • Set A_Temp_Attacking = (Attacking unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Owner of A_Temp_Attacked) is in A_Aggroing_Player) Equal to True
        • ((Owner of A_Temp_Attacking) is in A_Aggro_Player) Equal to True
      • Then - Actions
        • -------- If they do --------
        • Unit - Remove Changing_Ability from A_Temp_Attacked
        • -------- You can change the ownership by changing the A_Hostile_Player variable in the settings trigger. --------
        • Unit - Change ownership of A_Temp_Attacked to A_Hostile_Player and Change color
        • Unit - Order A_Temp_Attacked to Attack A_Temp_Attacking
        • Set A_Temp_Attacked = No unit
        • Set A_Temp_Attacking = No unit
      • Else - Actions

((Target item of issued order) is in (Playable map area)) Equal to True

->

(Target item of issued order) Not equal to No item

In Clicking Aggro you have RemoveLocation in three places when you should only have it in one place. Same thing for Range Aggro trigger.

Range aggro leaks two unit groups.
Clicking Neutral leaks unit group.
Range Neutral leaks two unit groups.

 

[FaLLeN]

dont know what it does... seems useless.

You could create a sys in which some creeps are like passive which won't attack you unless you init combat.
or
lesser creeps fleeing
or
realy aggresive strong monsters that follow you too your grave O'O