Ninja Spell Pack v1.2

[Moderator]

10:48, 15th Jun 2010
Hanky:
Your spells got some leaks and aren't even MUI/MPI. Next time please read the spell submission rules. Fix those things.

 

[baassee]

Laughed on this pack cause it has a very bad feeling about it and I was right.

First of all these are not MUI at all.

You have some notice about how to remove leaks but you didnt find all of them, example in the trigger vanish you leak 30 times per cast

• Unit - Create 1 Vanish for (Owner of A_Vanish_Unit_Caster) at (A_Vanish_Position_Caster offset by 200.00 towards ((Real((Integer A))) x 20.00) degrees) facing A_Vanish_Position_Caster

or in the vanish remove trigger you leak 30 times

• For each (Integer A) from 1 to 30, do (Actions)
  • Loop - Actions
    • Special Effect - Create a special effect at (A_Vanish_Position_Caster offset by 300.00 towards ((Real((Integer A))) x 20.00) degrees) using Abilities\Spells\NightElf\Cyclone\CycloneTarget.mdl
    • Special Effect - Destroy (Last created special effect)

Also you run most of the timers at 0.01, which is bad, use 0.02 as minimum but 0.03 and 0.04 are also good.

In shadow walk cast trigger you have way to many ITE functions to check. Just use set level of abilirt to level of ability "your ability" of triggering unit and you will avoid these.

Remove death sounds of dummies in object editor else shadow walk will be very annoying walk instead.

Shuriken only works for player red if you want to fire it before waiting.

Make shuriken channeling so you can intrerupt it without selecting the blade.

Also if you select the unit before the spell ends, you have 0 collision.

No need to do like this, just use the command destroy last created sp

• Special Effect - Create a special effect attached to the origin of B_Shuriken_Unit_Picked using Abilities\Spells\Other\Stampede\StampedeMissileDeath.mdl
• Set B_Shuriken_Effect_LastEffect[3] = (Last created special effect)
• Special Effect - Destroy B_Shuriken_Effect_LastEffect[3]

same goes with this, you dont need variable ofc it's performance increasing but very small ... not even noticeable

• Destructible - Pick every destructible within 150.00 of B_Shuriken_Position_LastCreate and do (Actions)
  • Loop - Actions
    • Set B_Shuriken_Trees_Picked = (Picked destructible)
    • Destructible - Kill B_Shuriken_Trees_Picked

Also you leak unit groups, need to be set into a variable and after you've used it use this line:

call DestroyGroup(udg_YOURGROUP)

Same in the Shuriken damage loop, you don't need so many ITE functions cause you dont even use the level!

have fun fixing this, also read some good tuts and you will be fine

have a nice day

regards

~baassee

 

[Aspard]

Epic fail!

Shuriken... wtf is that? oO\

Wow! There is a new voting for approvement system in this section also as in the Maps one. Great! You know for what to vote here, don't you?

 

[Slaydon]

Shuriken isnt a ninja weapon or somth?

 

[-Berz-]

Aspad, shuriken is like a throwing knife, only that it's in a shape of a star and it's used by ninjas

 

[Pakmand]

in shadow walk the black shadows dies and bleeds loks totally ugly
remove them instead of killing them te sound it makes is also bad and the dodge aboloty given make it no icon so you have the abilyty but dont the iven looks bad

 

[Aspard]

I know what the hell is Shuriken, but what the fu*k is happening to my WarCraft, when I use it in-game?

 

[evangle]

ok, EVERY1 STOP TROLIN, i think its brilliant, i <3 the gost walk and will use it in my map

 

[evangle]

unfortunatly, it dident work when i coppied and paseted it in

 

[Slaydon]

evangle, do you got sound on warcraft? try to ghost walk with sound, and dont double post, use the edit button

 

[Dalharukn]

ok, EVERY1 STOP TROLIN, i think its brilliant, i <3 the gost walk and will use it in my map

thanks

 

[Roflcoptor]

ok, EVERY1 STOP TROLIN, i think its brilliant, i <3 the gost walk and will use it in my map