DBWater Spell Pack v1.2

[Moderator]

14:32, 6th May 2011
Bribe:

1. This is not MUI
2. You need to use DestroyGroup, not GroupClear
3. Plenty of leaks, many of which are caused by this not being MUI
4. You actually have to remove the leaks, not just set them to variables.
5. Totally not MUI, not even MPI or even an attempt at making this possible to be cast by more than one unit at a time
6. Water Slam cast is way too simple to be a spell. You could trigger the same thing in object editor. And it leaks.
7. The remaining is just more of the same things I've already pointed out. We can walk you through the process of fixing your trigger little by little, but there are layers of changes that need to be made and I feel this entire system just needs to be re-written after you have developed your skills in making things MUI and leakless. Please ask for help making your spells MUI and leakless in the http://www.hiveworkshop.com/forums/triggers-scripts-269/ forum.

Rejected.

 

[Dominic74]

Post Triggers.

 

[Maker]

Read this: http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

The waits make the spells not MUI. Get rid of the waits.

 

[Magtheridon96]

D:
Hey! I was just about to upload a Tsunami Spell I was working on for 3 days now!
D:< AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHHHHHHHHHHHHHH


DIE! ...

Sorry... I was off-guard.. and Quite PISSED

Anyways, back to the spells, as Maker said, your using waits. Instead of waits make loop triggers. Waits prevent the spell from working on multiple units at once.

Also, there are so many leaks. I didn't look at the code, but i'm sure of what i'm talking about.

Things that leak:
-locations
-unit groups
-special effects
-lightning effects
-native unit groups (Use "bj_wantDestroyGroup()" before you pick a unit group to destroy it correctly. This doesn't make the "DestroyGroup(....)" function redundant. If you set a variable to a unit group, you must destroy the group when you don't need it anymore. It will cause leaks and tons of lag!)

Ever play Green Circle TD? Yeah... LAG because of LEAKS. I hope this shows you the importance of clearing leaks.

Read the tutorial Maker gave you. Trust me it's EXTREMELY useful.

Overall, your spell ideas are okay. I'd give it a 2/5 (I'm still pissed at you -.-)

 

[opiumwar]

wew.. 5 triggers with 0.01 intervals can make you lag
better make em 0.03 above (higher if the unit is just being commanded to stop)
and the water pool can be optimized

EDIT:found bugs the hero doesn't go to the target point when using water wave and the hero can go outside the map

 

[Death-Blade]

wew.. 5 triggers with 0.01 intervals can make you lag
better make em 0.03 above (higher if the unit is just being commanded to stop)
and the water pool can be optimized

EDIT:found bugs the hero doesn't go to the target point when using water wave and the hero can go outside the map

I didnt set Water_Wave_Targeted_Point, I forgot it. And there are multiple triggers because those triggers their start and end are not at the same time.

 

[Manasurge]

Repeat comment on your last spell
NEVER USE

• Wait X seconds

And please!!! Read the tutorial Maker linked and the ones i sent you so we won't see this again

 

[Adiktuz]

@Magtheridon - upload it!!!

@DB - hmmm... the triggers cause too much strain I think (.01 interval for 5 time loops), and waits make them not MUI...

 

[Magtheridon96]

@Magtheridon - upload it!!!

Meh ... I wrote it a month ago in GUI

I hate GUI now >.<
vJASS is epic!
I'll rewrite a new tsunami spell in vJASS, but the problem is, the special effects would be ... off

I'm going to have to create over 100 dummies xD (To fill the wave (Z counts 3) ))
Maybe special effects would work, but the damage would be ... never mind .. I'll just go upload it after I finish this other spell I'm working on.