Evil Ninja Magic v1.1

[Moderator]

Bribe

Instead of the "or - block" (you can delete that) you can just replace "Set Ninja_Level = 0" with "Skip remaining actions".

Why a different ability for each buff level? That's really innefficient.

The fact that this checks "(Unit-type of (Attacking unit)) Equal to Skill Tester" in the conditions means that this is totally not modular.

"A unit is attacked" is also highly abusable by spamming the "stop" action.

The only features this offers depends on the object editor...

This thing needs such a major overhaul to be useful, it has to be rejected.

 

[Marsal]

post triggers

 

[prplprince]

trigger posted. sorry forgot about it

 

[Magtheridon96]

To post the triggers correctly, you should copy the trigger as text in the world editor, and paste it into Something like this:

Show

• Set TempUnit = bla bla bla...

Open brackets, write "TRIGGER", close brackets
Open brackets, write "/TRIGGER", close brackets

To all you other guys: Sorry for stating the obvious

 

[prplprince]

thanks lol. you probly noticed by now that this is my first skill I ever submitted

 

[Marsal]

You should use the other If to prevent using "Do Nothing"

 

[prplprince]

you mean to make all 6 IFs into one IF/Else?

 

[Marsal]

Yeah like this:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• Then - Actions
• Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • Then - Actions
  • Else - Actions

I don't know if it's a big problem in your trigger but the thing I know is that "Do Nothing" is not okay

 

[prplprince]

well I think the only problem would be is the seperate IFs store the level of the buff and if I collapse them into one IF like you say then I dont know how I would store the level

 

[Marsal]

like this:

trig

• Melee Initialization
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Has buff lv1
      • Then - Actions
        • Set Level := 1
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Has buff lv2
          • Then - Actions
            • Set level := 2
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Has buff lv3
              • Then - Actions
                • Set level := 3
              • Else - Actions

 

[prplprince]

ohh ok that would work. Ok i will change it

edit:
how does that look?

 

[baassee]

This event sucks. Unfortunatly, damage detection isn't the strongest side of GUI.

 

[Magtheridon96]

Good Job:

[+] No leaks
[+] MUI
[+] Useful
[+] Original
[+] Works properly

[-] Way too simple

Thus, your final score would be a 4/5

 

[prplprince]

This event sucks. Unfortunatly, damage detection isn't the strongest side of GUI.

Yeah I tried a couple different things but this was one of the few ways that it worked.

Good Job:

[+] No leaks
[+] MUI
[+] Useful
[+] Original
[+] Works properly

[-] Way too simple

Thus, your final score would be a 4/5

Thanks and its my first skill too so i would be happy with a pass and i get a 4/5

 

[Ironside]

Probably way to simple.

Anyway, don't check the conditions two times, you check them in the trigger conditions
and in actions in the ifs

 

[prplprince]

well when i check in the actions i have the Level variable

 

[baassee]

Yeah I tried a couple different things but this was one of the few ways that it worked.

You know that this event is bugable? And also, I think this trigger is too simple to be approved but we'll see what the moderators will say.

 

[mckill2009]

you dont need this...

• Set Ninja_Dummy_Unit = (Last created unit)

"Last created unit" is enough...

example:

• Unit - Add Ninja Slow Dummy to Last created unit
• Unit - Add a 0.70 second Generic expiration timer to Last created unit
• Unit - Set level of Ninja Slow Dummy for Last created unit to level of blahh blahhh <<<< additional
• Unit - Order Last created unit to Orc Shaman - Purge (Attacked unit)

always put this to the last...

• Unit - Order Last created unit to Orc Shaman - Purge (Attacked unit)

because AI/computer cant cast this spell (dummy spell) if not...

 

[defskull]

Are those buff on the enemy unit is, permanent ???
That's not cool, lol

 

[CeDiL]

Okay, first purge has nothing related with bash, it's only slow.
Second it removes the buffs from target.
Third, this would need a decent damage detection system.
Fourth, damn who will need a spell that's simply purging the unit, too simple.
Fifth, some of your If's are not needed, or can be combined together.
2/5

 

[defskull]

Agreed, your trigger needs to be optimized.

 

[prplprince]

Okay, first purge has nothing related with bash, it's only slow.
Second it removes the buffs from target.
Third, this would need a decent damage detection system.
Fourth, damn who will need a spell that's simply purging the unit, too simple.
Fifth, some of your If's are not needed, or can be combined together.
2/5

Ill answer your inquires.

1) Yeah I used purge because it is a slow
2) Removing buffs from targets is a bonus
3) I cant think of a better DD system atm
4) Never said it was rocket science
5) That I will do. Probly get rid of the first IF in the conditions.

 

[CeDiL]

Ill answer your inquires.

1) Yeah I used purge because it is a slow
2) Removing buffs from targets is a bonus
3) I cant think of a better DD system atm
4) Never said it was rocket science
5) That I will do. Probly get rid of the first IF in the conditions.

Okay it's your spell, let's just see what it will finaly look like

 

[prplprince]

Okay it's your spell, let's just see what it will finaly look like

ha true