Napalm Missile v0.02

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

10:48, 31st May 2011
Maker: The looping trigger should be initially off and turned off when there's no active instance of the spell running. The Unit Dies trigger should be turned on/off also.
You could improve the tooltips, look at standard WC3 abilities for comaparison.
You're adding/removing Storm Crow form in the looping trigger which is bad, only add it once or add it in the object editor.
Remove the + 0.00:

• Animation - Change Fire[A] flying height to (((Sin(((Time[A] x 308.00) + 0.00))) x 150.00) + 200.00) at 0.00

Remove the x 1:

• Animation - Change U flying height to 0.00 at ((Current flying height of U) x 1.00)

Set the dummies to can't raise, does not decay. Then you can remove the 2 second wait and Remove unit from game.
The spell creates about 70 dummies, maybe you could use less.
You should recycle the indexes.

 

[Adiktuz]

since you already set integerA into A why not just use For Each Integer Variable A...

since you only use TempLoc[0] and TempLoc[1], I suggest just using two different variables rather than an array where you only use 2 indexes...

also Replace TempGroup[0] with a non-array variable...

 

[wolfman]

since you already set integerA into A why not just use For Each Integer Variable A...

since you only use TempLoc[0] and TempLoc[1], I suggest just using two different variables rather than an array where you only use 2 indexes...

also Replace TempGroup[0] with a non-array variable...

Done

 

[Adiktuz]

I suggest you learn recycling indexing coz right now, this could cause bug if a user makes this run 201 times before the first spell finishes since you reset the index when it reaches 200... and its also a bad idea to just recycle after it reaches a set amount...

also its better to save the max index currently used into a variable and use that as the higher bound of the integer loop so that you would only loop thru the indexes in use instead of the current one which loops all indexes...

 

[wolfman]

ohh okay i will change that.
I was trying to figure out how to make the loops less lol. thanks

Edit:
So if i just keep on increasing the index and never reset it, and make all the loops from IndexMin to IndexMax, that would be okay?
Would it be a problem if the index gets really high? like over 1000

 

[Adiktuz]

^_^

anyway, the spell looks cool.

 

[wolfman]

Thanks lol

I might redo some of it in jass tho, cause it lags if you cast it a bunch of times

 

[Marsal]

Not the best but looks cool. Here you are a good indexing example.

triggers

first set the maximum array value, try to set it to a proper value around 4-5.

• Init
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Ability
  • Actions
    • Set Get = False
    • For each (Integer A) from 1 to Max, do (Actions) [loop till the maximum size given in an init trigger]
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Get Equal to False
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Recycle[(Integer A)] Equal to True [checks if the integer A slot is free]
              • Then - Actions
                • Set Index = (Integer A)
                • Set Get= True [with this the trigger only choose the first free slot]
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Integer A) Equal to Max
                  • Then - Actions
                    • Set Max = (Max + 1) [if the current size is not enought it increases it]
                    • Set Recycle[Max] = True
                  • Else - Actions
          • Else - Actions
    • Set Caster[Index] = (Triggering unit)
    • Set Timer[Index] = (2.00 + (Real((Level of Ability for Caster[Index]))))
    • Set Etc.... [other things you want to store example locations or damage]
    • Set Has[Index] = True [this will check if the trigger still have to run for that unit]
    • Set Count = (Count + 1) [counts the number of units casted the spell]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Loop <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on Loop <gen>
      • Else - Actions

• Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer Integer) from 1 to Max, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Has[Integer] Equal to True
          • Then - Actions
            • [Things you want to do]
            • Set Has[Index] = False
            • Set Count = (Count - 1)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Count Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions

Also the wait.... you should just add a 2 second expiration timer to that unit and a trigger that removes the unit when it dies.

 

[Adiktuz]

its already dead before the wait, there's no reason to add expiration timer... that wait wont cause bugs but its better to get rid of it...

also rather than running it four times per loop, you might want to make the Angle*bj_DEGTORAD done at the top (replacing the current Set Angle[A] = blahblah with something like maybe Custom script: set udg_Angle[A] = udg_Angle[A] + 7*bj_DEGTORAD), of course the initial angle should also be multiplied by bj_DEGTORAD right at the start...

 

[Marsal]

heh ~.~ i haven't seen that thing ~.~

 

[Maker]

COmments

Improve the tooltip. Add level data for example. Remove the last "s" in "increases".
Set the ability icon position to 0,2 for example.
Missile move trigger should be initially off and turned on/off when needed.
Remove the +0.00

• Animation - Change Fire[A] flying height to (((Sin(((Time[A] x 308.00) + 0.00))) x 150.00) + 200.00) at 0.00

Remove the x1

• Animation - Change U flying height to 0.00 at ((Current flying height of U) x 1.00)

In the dying trigger, instead of using unit group variables you could use

• Custom script: set bj_wantDestroyGroup = true

and you could calculate the damage before the loop.

The effect looks good and so does the movement. Could you make it randomize the side?

 

[illegalpie]

COmments

Improve the tooltip. Add level data for example. Remove the last "s" in "increases".
Set the ability icon position to 0,2 for example.
Missile move trigger should be initially off and turned on/off when needed.
Remove the +0.00

• Animation - Change Fire[A] flying height to (((Sin(((Time[A] x 308.00) + 0.00))) x 150.00) + 200.00) at 0.00

Remove the x1

• Animation - Change U flying height to 0.00 at ((Current flying height of U) x 1.00)

In the dying trigger, instead of using unit group variables you could use

• Custom script: set bj_wantDestroyGroup = true

and you could calculate the damage before the loop.

The effect looks good and so does the movement. Could you make it randomize the side?

I agree completely, Only thing I'd add is to fix the Tooltip, and make some real testing units, just make them able to continuously spawn, 5000 health with no movement is kinda annoying.

 

[wolfman]

The effect looks good and so does the movement. Could you make it randomize the side?

Should i make the missile spin either to the left or to the right? or just to any random angle around the caster?
Because now it just spins around a point offset 128 from the caster towards caster facing + 90
So would you suggest changing the angle to a random angle or should i make it only either +90 or -90

Btw, thanks for the feedback everybody

And as far as the testing units, i only made them not move so you could make the missile go directly over them and see the trail damage caused by the napalm. But that was mostly for testing purposes to make sure it worked properly xD so i will consider making it more exciting

 

[illegalpie]

Should i make the missile spin either to the left or to the right? or just to any random angle around the caster?
Because now it just spins around a point offset 128 from the caster towards caster facing + 90
So would you suggest changing the angle to a random angle or should i make it only either +90 or -90

Btw, thanks for the feedback everybody

And as far as the testing units, i only made them not move so you could make the missile go directly over them and see the trail damage caused by the napalm. But that was mostly for testing purposes to make sure it worked properly xD so i will consider making it more exciting

Good, the only other comment, that i just thought of now, would be to make the trail last longer, as it doesn't do substantial burn damage. Also, just another idea, why not make the ball start small, then get bigger as it rotates, then when its at the final scale (You choose) it launches.

 

[pedrojanu]

do not you think that your trigger is very similar to mine?
http://www.hiveworkshop.com/forums/...-a-178830/?prev=c=114&t=61&r=20&d=list&page=3

 

[Adiktuz]

if ur talking about idea, they look the same

but trigger-wise, this is much better than yours...

 

[wolfman]

Good, the only other comment, that i just thought of now, would be to make the trail last longer, as it doesn't do substantial burn damage. Also, just another idea, why not make the ball start small, then get bigger as it rotates, then when its at the final scale (You choose) it launches.

Thanks, these sound like good ideas
And the napalm trail isnt really supposed to do much damage, it is kind of like a little bonus thing as the main part of the spell is the actual missile.
But i will consider adding an option of making the trail actually stay on the ground and continue to do damage for a set amount of time.



And as far as the other spell, yeah i guess it looks similar, but i didnt copy your idea or anything, ive never even seen that before

 

[88WaRCraFT3]

1 Thing that you must do, is to add prefix + _ before each of variables, cause there are many spells like yours and it comes to conflicts + they overlay each other... fix and +rep + 5/5, for now 4/5 (Prefix Example NM_XXXXXXXXX)

 

[wolfman]

1 Thing that you must do, is to add prefix + _ before each of variables, cause there are many spells like yours and it comes to conflicts + they overlay each other... fix and +rep + 5/5, for now 4/5 (Prefix Example NM_XXXXXXXXX)

Yeah i figured i would have to do something like that lol. But should i do that to all of them? or only ones with arrays, since it wouldnt matter if the others overlap because i dont have to save a value for any period of time.
For example, X and Y. Or TempGroup or TempLoc, stuff like that

 

[88WaRCraFT3]

hmmm, would be good to change that thing for Integer, MaxInteger, Caster, Target.
But you can do that for all, if you're not lazy

 

[bnw2000]

Is there really a need to add crow form to the "fire missle" unit.
Cant you just set it to flying movement , then set its default height to 0 . then do the animation.

Just saying lol. But the math..... omg... lol

 

[Maximum_Evil]

When copy pasting the triggers I get this error:

But the spell looks really cool and original

 

[Maker]

Make sure you have enabled "Automatically create unknown variables" in preferences.

 

[Maximum_Evil]

Make sure you have enabled "Automatically create unknown variables" in preferences.

I have that but mine is disabling "MissleMove", I have deleted all the custom script and than it just worked. Weird ;S

 

[Maximum_Evil]

When I tried to import it, it got soo many errors on the 3rd trigger