is this a bad Trigger

[polardude]

i need to know if this is a bad trigger

• Regrow Trees Setup
  • Events
    • Time - Elapsed game time is 2.00 seconds
  • Conditions
  • Actions
    • Destructible - Pick every destructible in (Entire map) and do (Actions)
      • Loop - Actions
        • Trigger - Add to RegrowTrees <gen> the event (Destructible - (Picked destructible) dies)

• RegrowTrees
  • Events
  • Conditions
  • Actions
    • Custom script: local destructable BADTREE = GetDyingDestructable()
    • Wait 20.00 seconds
    • Custom script: call DestructableRestoreLife( BADTREE, GetDestructableMaxLife(BADTREE), true )

 

[deathismyfriend]

Depends what you consider bad. In my opinion yes it is bad.

Although it should work fine.

 

[polardude]

can it make the game crash ? or is it fine

 

[Dr Super Good]

It is a very naughty trigger! The bits used to store it were cursed by Satan himself! You will need to re-create it from scratch surrounded by incense while reciting verses from the Bible to make sure Satan does not curse it again and it becomes a good trigger. Ok enough messing around with grammar, time to get serious and technical.

Regrow Trees Setup does not work if there are more than 32 or 64 (some low number) of destructible on the map. The enumeration has a very low limit, certainly not the thousands which are normally the case with trees. You will need to break the map into very small units and then enumerate each such unit separately. You may need to use multiple threads for this to avoid hitting the op-limit.

Not all destructibles are trees. You may want to add some checks before adding them to the trigger.

 

[polardude]

• Regrow Trees Setup
  • Events
    • Time - Elapsed game time is 2.00 seconds
  • Conditions
  • Actions
    • Destructible - Pick every destructible in (Playable map area) and do (Actions)
      • Loop - Actions
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Destructible-type of (Picked destructible)) Equal to (==) Felwood Tree Wall
          • Then - Actions
            • Trigger - Add to RegrowTrees <gen> the event (Destructible - (Picked destructible) dies)
          • Else - Actions

it seams to work

 

[Dr Super Good]

It should for a very few number of trees. People keep reporting that the Pick every destructible in Region (rect) action only iterates through the first X destructibles where X is quite small compared to the thousands you can have.

 

[polardude]

but i have try to use Force of Nature all a round the map to see
and not matter where i do it they grow back

 

[Dr Super Good]

Like I said, you will need to break it into smaller rects and then generate the events using those.