Is there a leak that need to be cleared?

[jonbon29]

Hello guys I just wanna ask if there is a leak that needed to be cleared.

Binding Shot

Events
Unit - A unit Starts the effect of an ability
Conditions
(Ability being cast) Equal to |cffadff2fBinding Shot|r
Actions
-------- ------------------------------------------------------------------------------------------------- --------
-------- Getting the Spell constants --------
-------- ------------------------------------------------------------------------------------------------- --------
Set Temp_Unit = (Triggering unit)
Set Temp_Target = (Target unit of ability being cast)
Set Temp_Ability_Level = (Level of (Ability being cast) for Temp_Unit)
-------- ------------------------------------------------------------------------------------------------- --------
-------- Setting the Spell values --------
-------- ------------------------------------------------------------------------------------------------- --------
Set Temp_Base_Damage = 10.00
Set Temp_Total_Damage = (Temp_Base_Damage x (Real(Temp_Ability_Level)))
-------- ------------------------------------------------------------------------------------------------- --------
Unit - Cause Temp_Unit to damage Temp_Target, dealing Temp_Total_Damage damage of attack type Pierce and damage type Normal
-------- ------------------------------------------------------------------------------------------------- --------
-------- Clearing leaks --------

The trigger is simple, its just an ensnare ability with damage. The damage is kinda faster than the missile, so the unit receives damage before the missile hits him. Any idea to fix that without making the missile speed faster?

 

[RobertMKD]

Nope, there isn't.

 

[Wasabee]

A missile system might help you with your trigger.

 

[BloodDrunk]

You just have to trigger entire spell.
Can you describe your problem?

 

[Arad MNK]

Hello guys I just wanna ask if there is a leak that needed to be cleared.

Binding Shot

Events
Unit - A unit Starts the effect of an ability
Conditions
(Ability being cast) Equal to |cffadff2fBinding Shot|r
Actions
-------- ------------------------------------------------------------------------------------------------- --------
-------- Getting the Spell constants --------
-------- ------------------------------------------------------------------------------------------------- --------
Set Temp_Unit = (Triggering unit)
Set Temp_Target = (Target unit of ability being cast)
Set Temp_Ability_Level = (Level of (Ability being cast) for Temp_Unit)
-------- ------------------------------------------------------------------------------------------------- --------
-------- Setting the Spell values --------
-------- ------------------------------------------------------------------------------------------------- --------
Set Temp_Base_Damage = 10.00
Set Temp_Total_Damage = (Temp_Base_Damage x (Real(Temp_Ability_Level)))
-------- ------------------------------------------------------------------------------------------------- --------
Unit - Cause Temp_Unit to damage Temp_Target, dealing Temp_Total_Damage damage of attack type Pierce and damage type Normal
-------- ------------------------------------------------------------------------------------------------- --------
-------- Clearing leaks --------

Please put them in Trigger wraps.

The damage is kinda faster than the missile, so the unit receives damage before the missile hits him. Any idea to fix that without making the missile speed faster?

Chaosy Answered to your problem in a Similar Question. (~5 Threads down)

I think I know an OK way to do this without advanced systems.

Check missile speed in object editor.
When storm bolt (any missile spell) is cast start a timer that lasts for distance to target / missile speed. When timer ends, do stuff.

The only issue here is that if the unit moves it will be slightly invalid.

 

[Wietlol]

If you want an accurate solution, then there are two other options in that same thread:
execution via missile system
onHit detection via DDS

 

[Arad MNK]

If you want an accurate solution, then there are two other options in that same thread:
execution via missile system
onHit detection via DDS

That's Right. But I Prefer to use Chaosy's.

 

[Zwiebelchen]

If your missile isn't terribly slow, you can also just use a fixed delay for dealing the damage, like 0.5 seconds.
It doesn't really matter if the damage is perfectly on time or not. That there is a visual delay is what matters. Just take the average time the missile would need to hit the target.

 

[Wietlol]

make sure that you do use the "Wait <real> second of game-time" and NOT "Wait <real> seconds"
thank me later

 

[Arad MNK]

Waiting Game-time Seconds leaks a Reference.

 

[Wietlol]

Waiting normal doesnt use game time but real life time (but still inaccurate)
You can place this function in the header or inside a library and use that one instead:

    function WaitGameTime takes real duration returns nothing
        local timer t
        local real  timeRemaining
        
        if duration > 0 then
            set t = CreateTimer()
            call TimerStart(t, duration, false, null)
            loop
                set timeRemaining = TimerGetRemaining(t)
                exitwhen timeRemaining <= 0
                
                if timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD then
                    call TriggerSleepAction(0.1 * timeRemaining)
                else
                    call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
                endif
            endloop
            call DestroyTimer(t)
            set t = null
        endif
    endfunction

 

[Daffa]

^aint that script leaks timer handle if it doesn't pass the check? (Though naturally they should pass).

 

[Wietlol]

no
the timer variable t is uninitialized (which is pretty dangerous in JASS but that doesnt matter) anyway, if it succeeds the if statement, then it gets created and therefor has to be destroyed and nulled
so it is not necessary to have outside of the if statement and is even better.
for the nullification of the variable it doesnt matter but if I place the DestroyTimer() outside the if block, it can and will crash the code if the duration is lower than or equal to 0

 

[jonbon29]

Thanks guys I'll try everyone that's been said in this thread, then I'll decide what to do.