Graphics of GUI Functions Appear in Trigger Title

[KILLCIDE]

Some Trigger Title Events Map initialization Conditions Actions Visibility - Disable fog of war Visibility - Disable black mask

Set Some Trigger Title Events Map initialization Conditions Actions Visibility - Disable fog of war Visibility - Disable black mask

Map initialization Events Map initialization Conditions Actions Visibility - Disable fog of war Visibility - Disable black mask

As you can see, if you have the word "Set" as the first word in a trigger title, it recieves the graphic for the actual function. Other functions in the trigger editor do not have this problem because they all preceed a "-", which is not allowed in titles of the Trigger Editor. The problem also appears when you have the trigger title as "Map initialization."

 

[Ralle]

Oh man, that sucks. Gotta fix that

 

[Chaosy]

This is been around for ages. Never cared enough to report it though.

 

[Ralle]

The only problem is that people like to paste half triggers. Like only pasting in "Map - Set ..." in a TRIGGER tag. This will result it in being the white document icon. I think the following will be a neat solution:

If the trigger code contains more than 4 lines of code, it will have the outer most be the white document icon. If not, it will highlight all of them as what they are. The reason for the number 4 is that an empty trigger is 4 lines.

 

[KILLCIDE]

If the trigger code contains more than 4 lines of code it will have the outer most be the white document icon.

What would happen if I do something like this:

• Unit - Create 1 Ralle blah blah
• Set SomeUnitVariable = (Last created unit)
• Special Effect - Create blah blah

 

[Tank-Commander]

Maybe it'd be a better idea to take something along the lines of [TRIGGER="Name"][/TRIGGER] or to simply leave it as is - it's not like the icon being a bit messed up is much of an issue especially since most pasted triggers start with acronyms like "SPE Cast" - the bug has existed or as long as I've been on the site XD

 

[KILLCIDE]

That would be a problem since using "Copy as Text" adds the title along with it.

How about just make it so that anything before the word "Event" gets the white document icon?

 

[Ralle]

I have implemented something which is not on the server yet. I detect if the trigger has varying indentations as in, it is a tree. If that is the case, anything without indentation gets the white document icon.

 

[KILLCIDE]

So what will happen to triggers like this?

• Unit - Create 1 Ralle blah blah
• Set SomeUnitVariable = (Last created unit)
• Special Effect - Create blah blah

 

[Chaosy]

While on the topic of the trigger tag.

Maybe make the white background not extend so far by default? let's be honest most of the time we use a third of it.

 

[Ralle]

So what will happen to triggers like this?

• Unit - Create 1 Ralle blah blah
• Set SomeUnitVariable = (Last created unit)
• Special Effect - Create blah blah

It would have no depth and there would be no white icon, all of them would have specific icons.

This image describes how I plan for it to work:

 

[KILLCIDE]

Ahh got it. Excited to see the update!

 

[Ralle]

Have a look now.

 

[KILLCIDE]

Hmm it seems to bug out for some functions o: check out this thread.

 

[Ralle]

Check it now!

 

[KILLCIDE]

• Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  • Loop - Actions
    • -------- test 123 --------

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  • Loop - Actions
    • -------- test 123 --------

• Set DoesNotWork = True
• For each (Integer A) from 1 to 10, do (Actions)
  • Loop - Actions
    • -------- test 123 --------

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • TriggersDoNotWork Equal to True
  • Then - Actions
    • Game - Display to (All players) the text: RAAAAAAAAAALLE!
  • Else - Actions

 

[Ralle]

It works. You are using it wrong.

If there is nesting, you are expected to have the trigger header as the outermost node.

I guess I could detect if it has the children "Events" "Conditions" and "Actions"...................................

 

[KILLCIDE]

Hmm that's going to break a handful of my threads

 

[Ralle]

So you think I should do this?

I guess I could detect if it has the children "Events" "Conditions" and "Actions"...................................

 

[KILLCIDE]

That would be a great fix! I hope I'm not asking too much a little similar to my previous suggestion

How about just make it so that anything before the word "Event" gets the white document icon?

 

[Ralle]

I believe it is perfect now.

 

[KILLCIDE]

I'll post back in this thread if I run into something again ^^ thank you, ralle!

 

[Ralle]

It works by looking at the tree. There has to be a tree. Every node at level 0 which has a child node that starts with the word "Actions" will get a white document icon. Sounds good?