Forbidden Spell Pack 2.5

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

2 Dec 2011
Bribe: This has memory leaks.

 

[-Berz-]

Pls comment and rate.

 

[redscores]

Looks good so far, but the teeth spell deals earlier damage and looks like a simple carrion swarm.

 

[-Berz-]

i was thinking about that the dummyes deals the damage, but the problem is that the units in front of the caster gets 500 dmg and units in the distance about 50. but i will l probbably set that the dummies deals the damage, and that the casters spell is just a spell with no effect.

 

[-Berz-]

i get this program that check leaks http://www.thehelper.net/forums/showthread.php?t=85048
i found only 2 non important leaks(i only checked spells, i didnt check other triggers)

 

[Fabba]

Nice spells, one thing you missed with the Taste of Death was the if/then/else condition. So when the condition returned 'false' then the trigger removed an empty location. Ill guess you have fixed that now

Thumb up for you!

 

[-Berz-]

Thanks, i repaired leak as you told me.

 

[Yearight]

It good, i like it

 

[Kwah]

Very Nice spell pack. No real reccomendations. Good use of SFX.

Why are you using all the different TempLoc's if you have nulled it you can use it again.

 

[-Berz-]

i didnt know that..RLY? xD but they arent nulles, just destroyed. and i have a better preview trough triggers

 

[-Berz-]

Updated, new spell some loc leak fix. I hope you people like it

 

[xxdingo93xx]

Found a 'bug' lol...

The ability Demonic Fists(speed) gives you on level 2 7500% attackspeed bonus...

 

[-Berz-]

Lol... didnt test it :S thanks for telling me, i'll fix it.
edit: ok new version is out, thanks, xxdingo93xx!

 

[xxdingo93xx]

No problem

 

[Dark_Dragon]

Nice spell pack and I like them + ideas of spells are pretty good. Only thing I found out about leeks are that in for loop you set some temp point to some point but remove them after the loop. So if you loop 1 to 36 times there will be 35 location leeks, you only need to put call RemoveLocation( udg_TempPoint ) in that loop to. Do that at every place you find out, other than that I think everything is fine gj on ur spell pack!

 

[-Berz-]

Thanks, but i think that the removelocation in a loop isn't a smart idea(so they say)
Wehn ill have some more time i will make some new spells, i'm just to busy at the moment(dunno probably next week?)
Any way thanks for the comments you guys
I will stay in touch.

HF -BZR-

 

[Dark_Dragon]

Np fix it when you want, just to know RemoveLocation does not leek in loop it only clears memory (that location) so it is good, but ofc its only my suggestion to fix that its your spell after all so choose what you want to do

 

[-Berz-]

Dark_Dragon, well i asked on the forum and they say that i should remove it in a loop so i did. I'll upload new version when i made a new spell (i just need an idea for it)
Do you have any?(idea)

 

[Dark_Dragon]

ofc its good to remove location inside a loop it does not matter where it is, but if not removed its a leek in memory. About ideas i am not sure which one should you add and btw i like your ideas for spells, so for your spells i think its best to code your own ideas isn't it?

 

[-Berz-]

Ok, i'll probably made one last spell, than i'll start on something new(Wee.. N3w Sp311 P@x )

 

[-Berz-]

Last spell is almost done. I will also try to edit the Nether Chains(sometimes it don't work right)<- help is welcome

HF -BZR-

 

[Dark_Dragon]

I have just changed Player is an enemy of player to Unit belongs to an enemy of player - Matching Unit belongs to an enemy of Owner of Trigger Unit.

One very big leek in this spell Neither Chains is that you lag a mass number of groups. As you can see GUI leeks two groups not only one. set my_group = Units within 900 of point matching ...

One group is in your variable my_group and other one is generated by function Units within... To fix this add this line of code just above your set my_group to:

Custom Script: set bj_wantDestroyGroup = true

This will fix it, so it should look like this:

Custom Script: set bj_wantDestroyGroup = true
set my_group = Units within ...
...

 

[-Berz-]

Could you submit me (edited text trigger) Just go to "pastebin" Paste in (your) edited trigger, use trigger tag and give me a link of pastebin?

 

[Dark_Dragon]

Here it is, works for me and i made it to be MUI, guess you will enjoy it!

http://www.hiveworkshop.com/resources_new/pastebin/show/c94a9154b639457ce47f472ffe2f2ef6/

 

[-Berz-]

Ok, thanks i'll fix it.
I see you null the units. I was nulling them before, and people told me its 99,99999% useless... so i quit nulling them.

 

[Dark_Dragon]

Well every handle should be nulled because blizzard functions like RemoveLocation take some location and copy its data in to new local and then it removes this (temp) local. However your main variable is not null now, actually you don't need to null locals because they are destroyed after trigger finishes exec.

Global variables stay forever and to prevent a little of leek you should null them at least.

Only blizzard function i know which does not load local in function is GroupEnumUnitsInRange and GroupEnumUnitsInRect

as they take group whichGroup and fill it up whit units but this function does not return group, this function takes group pointer variable. If you have worked in C++ you will know what pointers are.

However about nulling its true that its not that much of leek, but ill suggest you to null globals.

EDIT: Sorry about one thing when i was changing globals to locals i forgot to set udg_TempLoc9 = l
before creating main drain effect so just add that!

 

[-Berz-]

http://www.hiveworkshop.com/resources_new/pastebin/show/2332986d54fb26a0a68935c79a2e58da/

Dark_Dragon, i did as you told me but it don't work :S

 

[Dark_Dragon]

Hmm if you added set udg_TempLoc9 = l before creating main drain effect then ill just send you the map i had created (your map) but i recoded spell Nether Chains. Just send me mail at <[email protected]>

Ahh, one more thing you used your GroupVar4 in other way you dont need to use bj_wantDestroyGroup. Use it only when you do ForGroupBJ its For Unit Group in GUI i think. After that function bj_wantDestroyGroup is set to false.

EDIT: I found out that it will be easy for me only to put this up here at pastebin again. This must work for sure and its heavy optimization + MUI.
To install it just copy first seen code to map header its in trigger editor (click on your map name blue icon) there past this text and make trigger in GUI as seen how its made. Link is:
http://www.hiveworkshop.com/resources_new/pastebin/show/9eb146a01cc4970b3ee63871aa98fc56/

 

[-Berz-]

Man, i need to learn JASS :S
I would, but never prgram before...I mean i undarstand what it does(like 70%) i just dont know how to put all together. And did you DL last version or do you have 1.05? because i fixsed something in 1.06. thanks for your support, but if i use all those custom scrips its just not "original" :S

 

[Dark_Dragon]

Ok i dl the 1.06 and yes its only a little of jass but if you dont know then ill try to do in GUI. Here is the link no jass script and more GUI only a little custom script for locals so that spell is MUI but you do understand that i guess if not ill explain you, just ask!

But i guess if there is something you dont understand it may be a if then else order. Which basically checks did it found random unit or does it have to pick first one or are there no units. Btw i added to matching unit to check is it structure.

Link: http://www.hiveworkshop.com/resources_new/pastebin/show/e9bb8f806cf8743c840e2b71e85e2a64/

EDIT: If you even dont want this much of custom script then you can use non-MUI version here:
http://www.hiveworkshop.com/resources_new/pastebin/show/749a81afb36e3b19993d85562b17dee9/

 

[Need_O2]

looks awsome

 

[-Berz-]

Need_O2, Thanks, I would do more of this spells, but i'm thinking on getting a new Spellpack, I just don't have much free time..

 

[-Berz-]

Meh!! i forgot to remove the default spells on Blade Master, I'll do that in next version D:
Please feedback & rate.

 

[Hanky]

Good spellpack, but you could set in the spell nether chain the z of the lightning lower because it dont look so well, try to let the start of the lightning be in the effect model. Else the spellpack is really good and I was wondering of no lags cause its GUI. The only thing I really dont like is that thing with a G at the beginning a I at the end and a U at the middle but else good job.

 

[-Berz-]

Thank, but why do you all hate GUI so much?
I'll make an update today, i would done it now, but we get a power cut and i didn't save my map, so i need to write tooltips and edit some triggering, edit screenshot... Damn electricity!

 

[Hanky]

If you would know JASS you would know why all hate GUI so much exspecially in spells.

 

[Flame_Phoenix]

SO my friend, when will you start using JASS on this magnificent spell pack ?? =P

Btw, reasons for not using GUI:
- makes your spells inaccurate
- makes your spells inefficient
- makes your spells not MUI
- makes your spells leak (some)
- it doesn't allow you to use your full imagination because it has limitations
- The more complex, the harder to read and import

My friend, you have the power to do it with JASS, I say you take advantage of it =) I just know you can totally do it ! I believe in you m8 =D
Remember: "JASS is the path to success"

 

[-Berz-]

I think...newer, i don't have intention to learn it
(I'm a GUITARD!!!)
100-dls YEA, BABY, YEA!!

 

[Flame_Phoenix]

Why not learn JASS ?? =( Please read my last post mate =/
I bet if you do it JASS you will get it approved and get up to 500 dl =)

 

[-Berz-]

FP thanks, for your support, but really i no longer have intention to learn JASS, i tried to many times and result was HIGH BRAIN DAMAGE

formula:
Me+Learn JASS = FATAL ERROR

 

[redscores]

Just a tip, fix your location leaks in your triggers, they are horrid (around 50 leaks++ pro cast of Drag).

 

[-Berz-]

@redscores, i have leak check, i didn't find any location leaks.
btw, i'm a GUItard an i think it can't be much better done in GUI(i could use some custom scripts for locals< but why i don't know how to set them)
The number of global variables is way to big(but lots of them aren't even used)
Could you tell me for "specific" "location" leak so i could fix it, because i don't find any of them

Thanks for your comment!

 

[Flame_Phoenix]

Well, did you had problems understanding my converted code ?? =S

I can try remaking it again if you want

 

[-Berz-]

@FP what code? I don't remember,...rly i don't :S and do you find 50+ leaks?

 

[Dark_Dragon]

Huh heavy leek in your drag slide trigger...

I again made a little custom script but its GUI so plz fix it here is a little code which is heavy faster and does not use locations (so nothing needs to be removed) you leek 2x locations every 0.03 seconds which is bad plus turning collision off sometimes does not work. This code makes sure your unit is moved properly. Link:
http://www.hiveworkshop.com/resources_new/pastebin/show/cf8b8747bbcace92789242644aa569cf/

Plz use it as its really fast!!!

 

[-Berz-]

Thanks Dark Dragon, I'll use your code and make an update when spells will be MUI.

 

[Dark_Dragon]

Ah i am glade to hear that! good luck whit making them MUI

 

[xxdingo93xx]

Wow, congratulations with the (not yet-)approve, -BerZeKeR- Dr Super Good?!! Could you please check my spell "Spike Impact", too? It is MUI, leakless and it rocks, could be a useful resource on HWS

 

[-Berz-]

I think its impossible to make some spells here MUI (yes possiblw with Jass). but i will still submit my spells here, even if it they aren't MUI i just hope that it won't get ignored, because there is nice numbers of downloads and i'm sure that people who dl-it find the spells useful(even if there was only one line they needed)

I would just like to thanks all of you again for help/comments/critic/downloads

Thanks!

-BerZeKeR-

p.s
2 new spells comming up soon

edit 2:
Meh, i just have a bout 10 new spells, they still need work on(mostly tooltips), its a real mess now(over 30 variables for points(many are not used))'
Many not working triggers, many not used spells, even not used heroes.
its sucha mess D: