Flash Sword w/ Knockback

[Maker]

It's too simple, leaks and it's not MUI.

http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

You don't need the first trigger.

(Attacking unit) Equal to Caster
Boolean Equal to True
->
Level of passive for attacking unit greater than 0

Set Chance = (Random integer number between 1 and 4)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Chance Equal to 3
->
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) equal to 3

 

[baassee]

This is awesome.

 

[adishaireen]

It's too simple, leaks and it's not MUI.

http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

You don't need the first trigger.

(Attacking unit) Equal to Caster
Boolean Equal to True
->
Level of passive for triggering unit greater than 0

Set Chance = (Random integer number between 1 and 4)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Chance Equal to 3
->
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) equal to 3

wait, if i don't set the boolean is true at the condition, the spell wouldn't work.

and what is the use of "Level of passive for triggering unit greater than 0"??

maybe i can remove the "attacking unit equal to caster". but i can't remove the boolean...

and baassee, what is awesome???

 

[baassee]

Remove that condition.

 

[Maker]

Whoops, I meant attacking unit not triggering unit.

 

[adishaireen]

you mean the attacking unit???

and base, remove which condition??

 

[baassee]

I thought that this spell was awesome!

Remove this

• Boolean Equal to True

 

[adishaireen]

i've said this just now: wait, if i don't set the boolean is true at the condition, the spell wouldn't work.

so what i wanna place at the condition if the boolean doesn't there???

 

[Maker]

• Flash Sword Ability
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Level of Flash Sword for (Attacking unit)) Greater than 0
  • Actions

 

[baassee]

You know, this doesn't require two triggers at all. And it leaks like the other spell of yours.

 

[adishaireen]

thanks maker. and baassee too. now, i will update my spell like maker said.

and make it one like baassee said.

and vote 4 approval.

 

[Marsal]

Well it's too simple and this is just a simple object editor spell if you use the Orb of Slow..... Noone will approve this I think.

 

[adishaireen]

Well it's too simple and this is just a simple object editor spell if you use the Orb of Slow..... Noone will approve this I think.

and you wanna make it complicated???

and it only 25% chance to make it in each attack,if compared to orb of slow, it is always call the lightning.

 

[Marsal]

Awww tear my eyes off

"Think before post"

complicated???

It's the easiest and almost the best way to make this spell..... And no, it will not call the lightning everytime if you change the chances to 25%.....

 

[baassee]

But you waste an orb effect instead.

 

[adishaireen]

no. i mean when you didn't change the chances.

 

[Marsal]

Maybe it's better if I just give up... You just have to click on that damn chance line double and change the goddamn value...... Is it that hard?

But you waste an orb effect instead.

That why I said "almost the best".

 

[adishaireen]

no.it IS not hard.

and don't be angry...

coz that will be a problem.

 

[baassee]

I'm always mad about stuff-alike-stuff and that's not a problem.

 

[adishaireen]

not you baassee. but marsal.

 

[Bribe]

This is really really simple. Either spruce it up or... I don't know. I could build this same thing in Object Editor, which is a problem.

 

[Marsal]

no.it IS not hard.

and don't be angry...

coz that will be a problem.

I'm rather nervous than angry because there is someone who just can't try to listen to a bit more experienced triggerer.

 

[Jay the Editor]

adishaireen, try to think more creative and complicated spell .. ^-^ good luck
sadly, i cant vote for approval too .. it's too simple ..

 

[defskull]

Well, same like me when I was new to triggering world
Haha thanks for crack me up

 

[adishaireen]

this is the first passive spell and i've got this idea from rogue galaxy......very simple.

and then i will update my spell.

and it will be a Flash Sword with Knockback

Check it out and download it.

 

[defskull]

Now THAT'S what we're thinking of a "unique" spell
You need to be more creative, well, it's a good thing for a start, +2 rep for trying and good luck next time

 

[Bribe]

• Leaks like crazy.
• Not a sign in the whole thing of it being castable more than once at the same time (not MUI).
• Waits are imprecise which means this will have really random results.
• You should use MonsoonBoltTarget.mdl instead of this doodad as that can be destroyed instantly and still play its animation.

Definitely, definitely needs fix.

 

[adishaireen]

• Leaks like crazy.
• Not a sign in the whole thing of it being castable more than once at the same time (not MUI).
• Waits are imprecise which means this will have really random results.
• You should use MonsoonBoltTarget.mdl instead of this doodad as that can be destroyed instantly and still play its animation.

Definitely, definitely needs fix.

owh..thanks. and tell me the leaks.

and i have change the doodad to moonson that you've said.

check it out. and please tell me the leaks by post the leaking trigger.

and vote 4 approval

 

[Bribe]

Set Angle = (Angle from (Position of Caster) to (Position of Target))

Leaks x2 (Position of Caster) and (Position of Target)

Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl

Turn all of these into:

Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)

Set FlashKnockBack = ((Position of Target) offset by 10.00 towards Angle degrees)

Leaks (Position of Target) and FlashKnockback is also never removed.

 

[adishaireen]

Set Angle = (Angle from (Position of Caster) to (Position of Target))

Leaks x2 (Position of Caster) and (Position of Target)

Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl

Turn all of these into:

Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)

Set FlashKnockBack = ((Position of Target) offset by 10.00 towards Angle degrees)

Leaks (Position of Target) and FlashKnockback is also never removed.

you mean like this:

[trigger=Flash Sword Ability]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Target = (Attacked unit)
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Wait 0.50 seconds
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Wait 0.50 seconds
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Wait 0.50 seconds
For each (Integer A) from 1 to 20, do (Actions)
Loop - Actions
Unit - Pause Target
Set Position_Caster = (Position of Caster)
Set Position_Target = (Position of Target)
Set Angle = (Angle from Position_Caster to Position_Target)
Set FlashKnockBack = ((Position of Target) offset by 10.00 towards Angle degrees)
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Wait 0.00 seconds
Unit - Cause Caster to damage Target, dealing 100.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to FlashKnockBack
Unit - Unpause Target
Special Effect - Destroy (Last created special effect)
Custom script: call RemoveLocation(udg_FlashKnockBack)
Else - Actions
[/trigger]

 

[defskull]

AVOID using "Wait" action.

 

[adishaireen]

AVOID using "Wait" action.

so what i'm gonna use instead of waits???

 

[baassee]

Learn spell making.

 

[Bribe]

For one, if you can make your spell using waits and haven't noticed a need to remove the randomocity factor, it's probably too simple and maybe should just be used for something like a cinematic scene.

Implementing a real knockback, one that uses a timer - (hint hint at the alternative to waits), and using a single monsoon bolt to kick off the spell, without any wait action, that might actually look cool.

From personal experience with knockback systems, attach the bolt to the unit so the effect drags with him when he's knocked back. It's good.

 

[adishaireen]

For one, if you can make your spell using waits and haven't noticed a need to remove the randomocity factor, it's probably too simple and maybe should just be used for something like a cinematic scene.

Implementing a real knockback, one that uses a timer - (hint hint at the alternative to waits), and using a single monsoon bolt to kick off the spell, without any wait action, that might actually look cool.

From personal experience with knockback systems, attach the bolt to the unit so the effect drags with him when he's knocked back. It's good.

timer????

 

[Bribe]

Never used a timer before?

You're just getting started

Maybe not the best time to be sharing public resources then. Stuff like this can't be approved. I might advise starting in the World Editor Help Zone and the tutorials section.

 

[adishaireen]

Never used a timer before?

You're just getting started

Maybe not the best time to be sharing public resources then. Stuff like this can't be approved. I might advise starting in the World Editor Help Zone and the tutorials section.

owh.thanks 4 the help.

wait, you mean countdown timer??

 

[adishaireen]

no..i have update my spell and the knockback is not like mine...it is like greater bash

 

[Bribe]

You're leaking some locations, leaking the special effect and the timer should run 0.03, not 0.01 (it's too much lag).

This still has a lot that needs to be changed in order to make it MUI. I advise looking at some of the other spells here how they do indexing, and see if you can build on that. Also, some good MUI tutorials could help.

 

[adishaireen]

You're leaking some locations, leaking the special effect and the timer should run 0.03, not 0.01 (it's too much lag).

This still has a lot that needs to be changed in order to make it MUI. I advise looking at some of the other spells here how they do indexing, and see if you can build on that. Also, some good MUI tutorials could help.

tell me where is the leaks..

 

[Bribe]

That is not my role to do your programming for you, I am only in this forum to critique. If you can't see the memory leaks on your own, you should develop this spell in the Triggers & Scripts forum where there are a lot of people who will help you spot your memory leaks.

This spell needs lots and lots of thought put into it before it is ready, and part of the requirement is that only "finished" products are allowed to be submitted. In some exceptions, which I have repeatedly made for this spell, I have laxed the rule. Because people expect these submissions to be reliable, it is time for this to be rejected.

When you are finished developing this spell in Triggers & Scripts, let me know, and I will un-reject this so it can be downloadable and enjoyed by everyone. Thanks.

 

[Adiktuz]

Suggestions:
-Read some MUI and spellmaking tutorials first on the tuts section
-use the T&S sections to learn (See Bribe's suggestion above)
-I suggest running this off using a DDS since the current event ur using can be abused

 

[adishaireen]

thanks...