Lightning Flash v5

[Moderator]

13 Dec 2011
Bribe: Actually, even with that room for improvement I think the spell is cool. Changed from "Useful" to "Recommended".

You've made some good changes but there are areas that you could still work on. For example, the number of dummy units created (the should be configurable).

You don't need to set the TempUnit variable, (Last created unit) is find here.

(Owner of Unit) could be set to a TempPlayer var before entering the loop.

Rather than using a (Matching conditions) group filter, just use an if/then/else block inside the loop - actions block. This makes it easier to customize as well as improving readability and efficiency.

 

[Magtheridon96]

Simple, but fine.

Commentary

You should store (Triggering unit) in a variable to increase efficiency. Use it afterwards instead of repeatedly calling the same function over and over again.

Also, you don't need TempPoint or TempPoint0.

• Set TempPoint0 = (Position of TempUnit)

That would be the same as Point since you know the unit is being created at Point.

Also, you aren't using Point anymore after you started using TempPoint, so you might as well remove it and set it to that Position.

Actually, on second thought, all those locations point to the same place >_>

Just set Point to the position of the spell and don't set anymore locations.
Then use Point wherever you use TempPoint or TempPoint0
You'd remove the location Point at the end of the trigger.

• -------- its 0.31 because having more units alive is usally more lag and this is the lowest it can get, if any lower, flamestrike will not appear, and if higher, the game will lag longer. --------

Or you can create a dummy unit with no model, order him to cast the spell, and create a special effect with the Flamestrike model.

• -------- its 0.30 because having more units alive is usally more lag and this is the lowest it can get, if lower, it will not slow nearby enemies, and if higher, the game will lag longer. --------

You can solve this by setting the casting backswings and animation times in the Object editor for that dummy unit to 0.

edit
Also, you shouldn't use imports like that. They're useless. All they do is increase the file-size.
You should only use imports if you really have to. (Like if there are no other effects that are compatible with your spell or something)

Could use improvements, but it will be fine after that.

 

[xIceShotx]

Simple, but fine.

Commentary

You should store (Triggering unit) in a variable to increase efficiency. Use it afterwards instead of repeatedly calling the same function over and over again.

Also, you don't need TempPoint or TempPoint0.

• Set TempPoint0 = (Position of TempUnit)

That would be the same as Point since you know the unit is being created at Point.

Also, you aren't using Point anymore after you started using TempPoint, so you might as well remove it and set it to that Position.

Actually, on second thought, all those locations point to the same place >_>

Just set Point to the position of the spell and don't set anymore locations.
Then use Point wherever you use TempPoint or TempPoint0
You'd remove the location Point at the end of the trigger.

• -------- its 0.31 because having more units alive is usally more lag and this is the lowest it can get, if any lower, flamestrike will not appear, and if higher, the game will lag longer. --------

Or you can create a dummy unit with no model, order him to cast the spell, and create a special effect with the Flamestrike model.

• -------- its 0.30 because having more units alive is usally more lag and this is the lowest it can get, if lower, it will not slow nearby enemies, and if higher, the game will lag longer. --------

You can solve this by setting the casting backswings and animation times in the Object editor for that dummy unit to 0.

edit
Also, you shouldn't use imports like that. They're useless. All they do is increase the file-size.
You should only use imports if you really have to. (Like if there are no other effects that are compatible with your spell or something)

Could use improvements, but it will be fine after that.

thx for opinion

Or you can create a dummy unit with no model, order him to cast the spell, and create a special effect with the Flamestrike model.

Well, what i meant is that usually dummies cant use spells instantly and if the expiration timer is lower, the dummy isnt able to cast the spell

 

[Chaosy]

personly i dont think the fire effect suits this but the triggers is good 3/5

 

[xIceShotx]

Ima wait a while to update just incase there should be more changes to the spell, i mean like, might as well update the spell with alot of changes

 

[Magtheridon96]

Well, what i meant is that usually dummies cant use spells instantly and if the expiration timer is lower, the dummy isnt able to cast the spell

--->

You can solve this by setting the casting backswings and animation times in the Object editor for that dummy unit to 0.

edit

Ima wait a while to update just incase there should be more changes to the spell, i mean like, might as well update the spell with alot of changes

While you're at it, make sure your dummies' death types are:
Can't raise, Doesn't decay

And fix the position of the Spell Icon so that it appears in the coordinates (0, 2)

 

[xIceShotx]

While you're at it, make sure your dummies' death types are:
Can't raise, Doesn't decay

Wow! I hardly ever forget to change it to that! I am soo surprised i forgot xD

edit

You can solve this by setting the casting backswings and animation times in the Object editor for that dummy unit to 0.

Okay, i agree with the slowingSlowing spell once spell is casted for this, if you're talking about the flame strike too, wouldn't it look better the way it is right now?

edit
Just another question
See the variable Owner? Should i change it to a unit variable making it triggering unit? or just create 2 variables?

 

[Magtheridon96]

Okay, i agree with the slowing for this, but if you're talking about the flame strike too, wouldn't it look better the way it is right now?

It would pretty much look the same, but the effect may look slightly smaller (I think)

The most important things in code:
- Functionality
- Efficiency
- Readability
- Usability

 

[SpectreD]

simple, needs some fixing

 

[xIceShotx]

Updated : v4

 

[Maker]

Remove loopPoint variable, use TempPoint instead.
Filter out dead units from being damaged.
You could calculate the damage/mana burn outside the unit group loop, so you calculate them only once.
The dummies could give less vision.
Art - Cast point defines the delay between receiving and order an casting the spell. The dummy's cast point is 0.3, that is why the minimum expiration time must be 0.31 seconds for you. Set the cast point to 0 for instant cast.
Make the floating text optional. If only one spell in a game produces floating text, it can look awkward.

Good job with the spell. Looks good to me.

 

[xIceShotx]

Lol, my bad, i goofed xD. Forgot to put "Spell Settings" trigger in description, ill put it next update since i'm working on it atm.

 

[WizardYu]

Triggering looks good, looks cool and yea 5/5

 

[The_beast_of_doom]

I dislike the fire at the end perhaps multiple chain lighting effects?

 

[xIceShotx]

Updating to v5 even though its approved xD
It could still have room for improvements like bribe said.
Edit - Sorry for the huge delay, i was trying to find additional options that can be added to the spell, and i think i finished it!, now i will be uploading the new version ;D
---------------------------
Updated!, v5: I know my spell got approved already with a 4/5 rating from v4, but i figured that there are many new options i can do

Spoiler

[rainbow]The new trigger is like 3x longer than v4 xD, with many more features!, check changelog/description/triggers to see!

[/rainbow]
Move mouse cursor to black area to see message

 

[gorillabull]

very nice spell looks like the peasants are caught on fire by the lightning strike. flamestrike is not the best model to use but does the job great!

 

[Magtheridon96]

youtube.com/user/RealSuperEffective

...
Do not spam or advertise. This is inappropriate.

Well, his post got deleted.

 

[erdelf]

Good work,

I think I am to stupid to do the import without errors. Maybe you can help me:

I have the three spell units, the ball, the two buffs and the abilities, but it doesn't work. The unit who spell this, make their usual attack movement and nothing happens

 

[xIceShotx]

Good work,

I think I am to stupid to do the import without errors. Maybe you can help me:

I have the three spell units, the ball, the two buffs and the abilities, but it doesn't work. The unit who spell this, make their usual attack movement and nothing happens

woah, ive been gone for about 2 months or higher, sorry i couldnt reply, can you maby link a downloadable version of your map? only if you didn't get it to work though

 

[Shehyee]

why it doest cast flame strike in mine or the Fire (Neutral Hostile)