KnockBack

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

21:38, 15th Oct 2010
The_Reborn_Devil:

We already have many knockback systems and this doesn't add anything new, in fact it got less functionality than many others. Your JASS version could also be optimized a lot. If you want to have a JASS version you should at least have a JASS version of the KnockBackMain trigger as well.


Status: Rejected until updated
Rating: N/A

PM me or another mod once you've updated this with more functionality and a better and more optimized JASS version (or no JASS version at all). Have a nice day!

 

[YellowAfterlife]

* Edited. Added a map name, comment on trigger input, and fixed one small plain error. Whoever was fast enough to download the spell in these 5 minutes, redownload.

 

[Maker]

You need collision detection, units go through other units, trees, cliffs, out of playable map area and so on.

The loop period could be 0.03 instead of 0.01.

The loop should be turned off when no units are being knocked back.

You never reduce the knockCount so the loop runs from 1 to 3 for example even though the is only one unit being knocked back.

You could make the knocback speed be reduced with each loop, to simulate friction.

 

[Anachron]

Please guys, there is a reason why we use JASS. Advanced stuff should always be done in (v)JASS since its a lot faster then.

No matter how well you code it in GUI, in JASS it will always be better.

 

[Mainy]

Already there are many spells like this... And this is not the best that have already been approved.

 

[YellowAfterlife]

Updated.
Maker, added collision checking via IsTerrainPathable.
Added "square" speed curve.
Set loop period to 0.03.
KnockCount is automatically reduced and loop is disabled if KnockCount == 0.
Anachron, added a JASS version, which consists of 2 triggers. I hope you're pleased. (formatting guidelines may be not preserved because triggers were recoded from scratch through normal WE)
Mainy, look once more.

 

[Mainy]

Just post the codes on description.

 

[Zeatherann]

looking...

Review: Interesting and simple, nice lightweight system/spell/thing

The GUI code is well considering it uses an index system rather than hashtables.
I love that doesn't reset the unit order
Overall it's nice but i have a question:

if not IsTerrainPathable(udg_zzX, udg_zzY, PATHING_TYPE_WALKABILITY) then

Why is that in JASS in the gui version? Can you not do that in GUI?

 

[YellowAfterlife]

Thanks, Zeatherann.
Common.j function was preffered over it's GUI version because then I'd need to add two more lines, one for creating and assigning a new location, and one for removing it. And recycling a lot of locations 33 times per second does not look like effective way.
Mainy, done. JASS version and variable notes are now avaible in the description.

 

[Zeatherann]

Yellow, nice and i totaly understand

Edit: Put your jass code in

 Tags

 

[baassee]

This aint JASS, this is converted GUI, even if you make them with user defined globals you can still merge the triggers.

Remove the GetAttackedUnitBJ as it returns GetTriggerUnit() which you should use instead.

Anachron didn't tell you to make it in JASS, he just pointed that the JASS is better although harder for GUIers if you don't know how to call a function.

Instead in your indexing for disabling/enabling a trigger, let it run on a normal user defined global timer which you start when there are instances and pause if there are none.

function Trig_KnockBackJ_Conditions takes nothing returns boolean
    if ( not ( GetUnitTypeId(GetAttacker()) == 'hrif' ) ) then
        return false
    endif
    return true
endfunction

function Trig_KnockBackJ_Actions takes nothing returns nothing
    // Knockback angle:
    set udg_zzReal = Atan2(GetUnitY(GetAttackedUnitBJ())-GetUnitY(GetAttacker()),GetUnitX(GetAttackedUnitBJ())-GetUnitX(GetAttacker()))
    call Trig_KnockBackJadd(udg_zzReal,15,GetAttackedUnitBJ(),12)
endfunction

//===========================================================================
function InitTrig_KnockBackJ takes nothing returns nothing
    set gg_trg_KnockBackJ = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_KnockBackJ, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_KnockBackJ, Condition( function Trig_KnockBackJ_Conditions ) )
    call TriggerAddAction( gg_trg_KnockBackJ, function Trig_KnockBackJ_Actions )
endfunction

This above is just a waste, use a seperate trigger to show us the example.

I think the GUI version is alright, meh just because you use SetUnitPos (that's why the orders get interrupted).

Good job but the JASS version is a little meh

 

[YellowAfterlife]

This aint JASS, this is converted GUI, even if you make them with user defined globals you can still merge the triggers.

Remove the GetAttackedUnitBJ as it returns GetTriggerUnit() which you should use instead.

Anachron didn't tell you to make it in JASS, he just pointed that the JASS is better although harder for GUIers if you don't know how to call a function.

Instead in your indexing for disabling/enabling a trigger, let it run on a normal user defined global timer which you start when there are instances and pause if there are none.

function Trig_KnockBackJ_Conditions takes nothing returns boolean
    if ( not ( GetUnitTypeId(GetAttacker()) == 'hrif' ) ) then
        return false
    endif
    return true
endfunction

function Trig_KnockBackJ_Actions takes nothing returns nothing
    // Knockback angle:
    set udg_zzReal = Atan2(GetUnitY(GetAttackedUnitBJ())-GetUnitY(GetAttacker()),GetUnitX(GetAttackedUnitBJ())-GetUnitX(GetAttacker()))
    call Trig_KnockBackJadd(udg_zzReal,15,GetAttackedUnitBJ(),12)
endfunction

//===========================================================================
function InitTrig_KnockBackJ takes nothing returns nothing
    set gg_trg_KnockBackJ = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_KnockBackJ, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_KnockBackJ, Condition( function Trig_KnockBackJ_Conditions ) )
    call TriggerAddAction( gg_trg_KnockBackJ, function Trig_KnockBackJ_Actions )
endfunction

This above is just a waste, use a seperate trigger to show us the example.

I think the GUI version is alright, meh just because you use SetUnitPos (that's why the orders get interrupted).

Good job but the JASS version is a little meh

Well, you're right somewhere. Blizzard-based functions are not a thing to leave in this case.

function Trig_KnockBackJ_Conditions takes nothing returns boolean
    return GetUnitTypeId(GetAttacker()) == 'hrif'
endfunction

^ That's how a condition should look like. Edited code in the description.
Preview for ones that dont have time to download this just to see if it fits their need: http://www.youtube.com/watch?v=uoaFFcTmhm0
(or check the end of description for embed video)

 

[baassee]

Heh I know how a conditions looks like

 

[Zeatherann]

Yea, didn't really screen the JASS version because this is ment to be a GUI knockback.

I have one suggestion: use x and y along with a vx and vy so you can 'add' kockbacks a bit better, just a thought. You have it so the knockbacks are added, but each time it's a new entry into the index, with vx and vy as reals you wouldn't need to add to the index.

Will say for GUI this is pretty awesome, hands down. 4/5 +votes for approval

 

[dardas]

well, i just looked in the version of jass,
and i say it could be really optimized alot,
but the gui version is amazing,
probably gonna use it for mah system after he fixed version of jass =]

 

[BotLoot]

I like it for lightweight and simplicity over many other system, however it does have issues with trees and stunned units.
Useful for small/slow knockbacks or maybe telekinesis spells.