Fire Ward (GUI)

[Moderator]

16:56, 18th Jun 2009
hvo-busterkomo:

Review

Looks leak free, MUI, is well documented, and has an acceptable effect. The only problem is that it doesn't support multiple levels. Approved with a 4/5 rating.

 

[-Berz-]

As far as i know this is not MUI, because transferring units from one trigger to another, isn't that simple, but its ok, so far ;D

Try to do this, and you won't need to calculate degrees

• Set Location = (Target point of ability being cast)
• Set Loop_Number = 5
• For each (Integer A) from 1 to Loop_Number, do (Actions)
  • Loop - Actions
    • Set Loop_Location = Location offset by 500.00 towards (360.00 x ((Real((Integer A))) / (Real(Loop_Number)))) degrees)
    • Custom Script - You know how to clear leaks right? :D

If you use this you can get rid of FW_Real Variables


Testing...

Seems like a good Spell with a good idea, its useful many maps.

Only problem is in triggering (don't get me wrong, triggering is good, even I don't know how to make such spell MUI D

Oh, one more thing, take a look in your Tooltip, there are some grammar mistakes like 5 ward, it should be 5 wards ^^

 

[Septimus]

As far as i know this is not MUI, because transferring units from one trigger to another, isn't that simple, but its ok, so far ;D

Isn't MUI? I test it and it seems to be fine. I would try to optimize it again.

 

[-Berz-]

Dunno maybe it is, I'm not some uber coder, let us wait for someone pro to tell us ;D

 

[Septimus]

Try to do this, and you won't need to calculate degrees

Yeah, my maths is bad. That is why I use a rather long way to do it...

Thanks for pointing out.

Oh, one more thing, take a look in your Tooltip, there are some grammar mistakes like 5 ward, it should be 5 wards ^^

Yeah, I need somebody who are good in English to help me.

 

[Dark_Dragon]

well again nice idea and is leakless...

however its not MUI if its casted 1 seconds or less after first cast.

i would suggest you to use sleep of 0.9 seconds since it will be around 1 second and then make it MUI in same trigger.

sleeps are bad coz they are unprecious but it will help you make your spell MUI faster if you are beginner.

well if you still want to use timers then maybe asking Paladon or Kingz would be good idea. Check there spells or ask them ~via private messages and they will try to help you.

i wont rate it until its MUI but you have some nice ideas and spell making for beginner.

Keep it up!
~Dark Dragon

 

[-Berz-]

Unleashes 5 fire wards that shoots flames of fire to the middle of the target point, fire deals damage to every enemy unit being hit by it.
Level 1 - 2 charges, 65 damage per unit
Level 2 - 3 charges, 65 damage per unit
Level 3 - 4 charges, 65 damage per unit

Dunno, try it like this =)

Its a bit hard to read, I hope it shows the point what the spell does

 

[Septimus]

The current problem is, I want to make those ward to cast fire for specific amount and then dies. It require the second trigger in order to do so.

I know there is a alternate way with it, but it involve maths... could point out the maths solution?

 

[-Berz-]

Somehow put "Chargesr"(Integer variable) in the Main Trigger

set Charges = Level of (ability being cast) + 1 (so on level 1, 2 charges, on level 2, 3 charges, on level 3, 4 charges

Then put a counter in your periodic trigger (Another integer variable and name it (dunno) Charges_Counter)

so it would look like:

set Charges_Counter = Charges_Counter + 1
If
Charges_Counter is equal to Charges
Then
set Charges = 0
set Charges_Counter = 0
turn off this trigger
Else
/

If you don't understand fell free to ask

Edit:

Here is the Trigger:

• Fire Ward
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fire Ward
  • Actions
    • Set FW_Target_Point = (Target point of ability being cast)
    • Set FW_Target_Position = FW_Target_Point
    • Set FW_Integer = (Level of Fire Ward (Ward Ability) for (Triggering unit))
    • Set FW_Level = (Level of Fire Ward for (Triggering unit))
    • Set FW_Charges = (FW_Level + 1)
    • For each (Integer FW_Integer) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set FW_Spawn_Point = (FW_Target_Position offset by 500.00 towards (FW_Real + 72.00) degrees)
        • Unit - Create 1 Fire Ward for (Owner of (Triggering unit)) at FW_Spawn_Point facing FW_Target_Point
        • Unit - Add a ((Real(FW_Level)) + 3.00) second Generic expiration timer to (Last created unit)
        • Unit - Add Fire Ward (Ward Ability) to (Last created unit)
        • Unit - Order (Last created unit) to Neutral Pandaren Brewmaster - Breath Of Fire FW_Target_Position
        • Set FW_Real = (FW_Real + 72.00)
        • Custom script: call RemoveLocation(udg_FW_Spawn_Point)
    • Custom script: call RemoveLocation(udg_FW_Target_Point)
    • Custom script: call RemoveLocation(udg_FW_Target_Position)
    • Trigger - Turn on Fire Ward Shoot <gen>

• Fire Ward Shoot
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set FW_Group = (Units of type Fire Ward)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in FW_Group) Greater than 0
      • Then - Actions
        • Unit Group - Pick every unit in FW_Group and do (Actions)
          • Loop - Actions
            • Set FW_Facing_Real = (Facing of (Picked unit))
            • Set FW_Spell_Position = (Position of (Picked unit))
            • Set FW_Spell_Position_2 = (FW_Spell_Position offset by 500.00 towards FW_Facing_Real degrees)
            • Unit - Order (Picked unit) to Neutral Pandaren Brewmaster - Breath Of Fire FW_Spell_Position_2
            • Custom script: call RemoveLocation(udg_FW_Spell_Position)
            • Custom script: call RemoveLocation(udg_FW_Spell_Position_2)
      • Else - Actions
        • Set Charges_Counter = (Charges_Counter + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Charges_Counter Equal to FW_Charges
          • Then - Actions
            • Set Charges_Counter = 0
            • Set FW_Charges = 0
            • Custom script: call DestroyGroup(udg_FW_Group)
            • Trigger - Turn off (This trigger)
          • Else - Actions

Edit;

Oh....I forgot to include the trigger i posted in my first post D:
Will you manage to put that in? ;D

 

[Septimus]

Ok, I update it according to your way.

I am not sure if it was MUI or not after I update it using your way....

 

[-Berz-]

Nope it's not MUI D: As I said, I don't know how to make that sort of spells MUI, sorry :S

 

[Septimus]

Nope it's not MUI D: As I said, I don't know how to make that sort of spells MUI, sorry :S

You should have said it isn't MUI. I just want a MUI spell.

 

[Kingz]

Since you are new to spellmaking i won't bug you how inefficent is the way you made it MUI.
Yes i tested it, put cooldown to 0 and it is MUI.
Possible improvements:

• better loop trigger coding
• implementation of indexes
• arrayed variables

When i said better loop trigger i meant that it looks non unique like this, every single ward on the map will fire on the same moment even if they are summoned in difrent time intervals.
Example:
1 cast i summon the wards, i wait 1.6 seconds, the wards fired 2 times by now.
2 cast i summon the wards, i before waited 1.6 seconds, the wards fire immediatly and after 0.4 seconds again.
Well nice for a beginer but you should now try to make something more complex and try to make a spell more trigger, less object based.
That way you will improve your triggering.
Just to notify you, dead units are picked when using Units of Type in the unit group. This doesn't make a big difrence though, only ~2-3 seconds wait before the trigger turns off.
Only thing i can recommend you is to take a look at tutorials about indexing that is how to make MUI spells via index's.
There is one tutorial about it in my signature...
Hope this helped.

 

[Septimus]

Just to notify you, dead units are picked when using Units of Type in the unit group. This doesn't make a big difrence though, only ~2-3 seconds wait before the trigger turns off.

But, did't a dead unit would be remove right away if the death status was set to cannot raise, does not decay?

 

[Kingz]

No you need a condition to check unit status.
Dead units stay memorised some time in warcraft until it removes them.
And you don't need to change anything in your spell it is MUI.
I only said i tested it by spamming it and it didn't bug.
That is what i meant when i said: "I put the cooldown to 0"
How else could i spam it?

 

[Septimus]

So it was safe? Ok, I would add condition asap.

 

[Kingz]

Yep spammed it as fast as i can and it didn't crashed^^
Well it is a matter of 3 seconds, the thing you should try is to get better at triggering.

 

[Septimus]

Yep spammed it as fast as i can and it didn't crashed^^
Well it is a matter of 3 seconds, the thing you should try is to get better at triggering.

I have add the life condition just like you told, hopefully everything work even better now.

And of course it won't crash, I have test it before I release it to the public.. :=P

I have to take time to learn about indexing, loop and array. Those involves maths and my maths was rather bad. :=/

 

[Dark_Dragon]

I only said i tested it by spamming it and it didn't bug.

many spells which are casted at same time but are not MUI do not bug.
however there are things which make it non-MUI.
spamming spell is a bad way of testing is spell MUI, but checking code is always the safe method.

i am not saying that every non-MUI spell does not bug so user can see quickly that its non-MUI.

ill tell you why this spell is not MUI.

if we look like this someone uses this spell so trigger is executed and second time someone else casts it trigger is again executed so first trigger reaches its timer limit and it says pick every unit of type... there are 2x of this unit types in map now coz there are 2 casts. i think one cast summons 5 units so if there are 2 casts that means there are now 10 units. His action tells for each of this units cause dummy to cast spell... but wait it should be only 5 units coz this is first cast but his second cast is now executed as well so damage for both spells is done now but second cast is just now to be executed and will deal even more damage.

in fact he will always deal extra damage on spell casts, when casted in less then or equil 1 second right?

so its logical that he will deal this amount of damage

damage dealt = 100*number of instant casts^2 %

so lets see example you cast it once at a time:
100*1^2 = 100% damage -> good it works well

now cast it 2 times at same time
100*2^2 = 400% damage -> bad two casts deal 400% damage it should be 200%

3 casts at same time
100*3^2 = 900% damage -> bad it should be 300% damage coz 3 casts


i hope you can understand now that its not MUI... and i hope i described it well
try to make it MUI, if you need help and cant find it ask me and ill help you!
~Dark Dragon

 

[Yearight]

Btw you can use dummies mana as an integer for the charges of fire casted. I guess that wont be necessary now. Or as the level of the fire charge casted.

 

[Rmx]

Review

Idea/Creativity : 8.5/10
Trigering/Scripting : 5/10
Balanced in Gameplay : 8/10
Description/Originality : 8.5/10
Efficiency : 6/10
User Friendly : 3/10

Is Multi Instanceable : [X] (-2)

Final Rating : 37
Status : Usefull

Rating System
0 - 15 = SHIT
16 - 25 = Unacceptable
26 - 35 = Lacking
36 - 45 = Useful
46 - 55 = Recommended - Highly Recommended
56 - 60 = EPIC *Highly Recommended *

My View of the spell.
I'm keeping a close Look at ur work Septimus, and it's getting better and better.

Well the spells seems Not MUI, also it not that efficient coz the wards of fire, in
all the map fires at the same time Always.

How to improve : Make MUI and more efficient also more user friendly
like putting some help comments also try to avoid unit groups in MUI keep up the GJ .

 

[Septimus]

Dragon, I do not understand the damage you mention since the damage was set by ability and not trigger. The trigger was to order each ward to cast it again for specific amount.

 

[Deuterium]

I'm a bit late on commenting on this spell, well I'll do it briefly then.

[+]

1. I like the idea; simple and nice.


2. The star like fire after each fire charge is special!


3. Leakless.


4. Documentation on how to import and credits are available.



[-]

5. Not MUI


6. Tooltips need a lot of fixing...



My Advice:

Read Kingz tutorial (found as the last link in his signature) in which he explains an Indexing system on how to make spells MUI.

About the tooltips, you can PM me for help (if I have time tonight I'll fix them even before you PM ) and I can also help you with making it MUI...

 

[Septimus]

Read Kingz tutorial (found as the last link in his signature) in which he explains an Indexing system on how to make spells MUI.

I going to read it when I have the time. I quite busy with my own campaign and cinematic at this moment.

 

[Kingz]

@Dark_Dragon's post
Well that is what i mentioned before, the way the spell is made MUI is not efficent.
I get what you are telling but in a weird way this can be counted as MUI...
I mean i doesn't bug, it only has a bad interval based damage dealing

 

[Septimus]

so it was between mui and non-mui?

Gee, I create a strange spell.

 

[aaron]

ermm dealing with units in spells are hard for me but yours it pretty good since your new (or should i say IF your new) ^^

 

[baassee]

This is just a badass, and dont worry if the spell makers are to harsch, they just give constructive critism

I think I will use this in my map cause dont need MUI there but I think you should take a break from the campaign and take a look at Kingz tutorial

+rep

 

[Dark_Dragon]

well you asked me to make it MUI since you needed help with it... so i made it MUI:

Link: DD Fire Ward

enjoy!

 

[Septimus]

This is just a badass, and dont worry if the spell makers are to harsch, they just give constructive critism

Nah, don't worry about it. I know how to distinguish a constructive critism and none constructive. If I do not accept what they told me, I won't be doing an update non-stop by now.

well you asked me to make it MUI since you needed help with it... so i made it MUI:

Thanks Dragon, I would update it asap.

 

[Septimus]

Everyone says it's not MUI. Im not even going to try it. Im going to wait for the changelog or a new post to say it's now MUI.

Are you blind or illiterate? (No offense, but you are currently showing the sign of it and I want to know if you really are blind or illiterate) It clearly written it was fully MUI by now. Previously it was consider as MUI as well, it just have bad interval damage which it had been fix by Dark Dragon.

 

[Deuterium]

Version 1.05 Update

Reconstruct the entire spell, now it was fully MUI (Full credit for reconstruct goes to Dark Dragon).

Amount of fire unleash by fire ward increase by 1 per level instead of 2 for balance purpose.

Everyone says it's not MUI. Im not even going to try it. Im going to wait for the changelog or a new post to say it's now MUI.

Who said it's not MUI!? Read the changelog! It is MUI!

And second, why do you care on whether the spell MUI or not?

MUI doesn't affect on whether the spell is good or not, but it just comes as an extra to the spell...


And please, please stop being childish. Your sole purpose here is trying to give Septimus a bad image by negatively criticizing him and whatever he does!

And if that's what your trying to do, than you're acting stupid - believe me. Why?

You're the one getting a bad reputation by doing so.

And I'm not talking about that BIG RED GEM you've got, but about your real reputation which is as bad as you can imagine...

 

[Guishiu]

As far as i know this is not MUI, because transferring units from one trigger to another, isn't that simple, but its ok, so far ;D

You know how to clear leaks right?
Oh, one more thing, take a look in your Tooltip, there are some grammar mistakes like 5 ward, it should be 5 wards ^^

Is this guy not saying it's not MUI? The very FIRST post. ROFL And so when i said that, it was still not MUI. Thank you, and good nite. Now the spell is, I shall give it a looksee.

Ok, i tested it. (5/5) Great Job! + rep
You, wow. Awesome. The spell works great and, not only that but, you showed me how to make a spell MUI with variables. Previously when I taught myself how this works I had been using (Playernumberoftriggeringplayer), you used a variable to set it to the triggering UNIT.

 

[Rmx]

Edit : Did another Review when it has been reconstructed ....

Review

Idea/Creativity : 9/10
Trigering/Scripting : 9/10
Balanced in Gameplay : 9/10
Description/Originality : 9/10
Efficiency : 9/10
User Friendly : 6/10

Is Multi Instanceable : [√]

Final Rating : 51
Status : Highly Recommended

Rating System
0 - 15 = SHIT
16 - 25 = Unacceptable
26 - 35 = Lacking
36 - 45 = Useful
46 - 55 = Recommended - Highly Recommended
56 - 60 = EPIC *Highly Recommended *

Edit : Reviewed the Spell when it has been reconstructed...

 

[Billy the Cat]

Nice spell, but 2 things:
Won't huge AoE damage kill the wards?
Setting the amount higher as 5 with the triggering as it is now would give problems since they are created with a 72 degree angle between them
Easy for others to fix of course, but since you made a variable to easily change the amount of wards I wanted to tell you

 

[Septimus]

Won't huge AoE damage kill the wards?

The ward cannot be attack.

 

[Billy the Cat]

Ok my mistake...
I thought Locust didn't make Invulnerable.

 

[Anachron]

Sep, thats the purpose of posting links to your other resources?

Anyway, good spell, even while being GUI.

 

[Septimus]

Maybe I should add additional name to it. Star Wards?

 

[Deuterium]

Why don't you make a new spell called Star Wards... hehe smart eh?
Wow that made me think of Super Mario 64 xD

No really, be creative and make a Star Ward, I already got an idea, but well, I think I'm gonna do that