Lightning Ward (GUI/JASS/VJASS)

[Moderator]

19:50, 7th May 2009
Dr Super Good:

Highly Recommended

Very impressive spells. I feared that they might lag on my PC looking at the screenshot but was suprized to see that even with multile casts of multiple version, no lag occured. It seems completly leakless and obviously is fully MUI, as the test proves. It also looks cool, which is important and I can see many maps using this spell with no problems. It also seems to be easilly balencable as quite a few of its effects are object editor related, but there is also some customizability in the actual spell itself. Testing this spell was not that good, as the test conditions are poor as multiple versions are cast with the same button.

Suggestions . . .
- Improve test map, fixing it so that you can choose which version is cast properly and that it is easier to test (better creep arangement).

Advice: If you do not understand why this spell was given the rating it received or if you would like to ask questions about how to improve this spell. Feel free to send a private message to spell moderator Dr Super Good.

 

[-Berz-]

Haha, simple and really useful ;D

Could use some more eye candy, but its ok as it is.

Good Job =)

 

[Septimus]

This is my first spell and I still trying to figure out a even more effective coding, right now I try to figure out how to set the If/Then/Else of the level and duration in much appropriate way so it would not restrain the level into max 3 (Maybe you won't understand what I trying to say at here ).

Creating spell really tough, it need a good creativity to make even 1 spell. Do not worry about this spell, it was leak free unless I forgot about something.

I think my spell description need to be change, any idea how to make it sound better?

 

[-Berz-]

It is leak free and MUI, so don't worry ;D You have problems with ideas/creativity too? Join the club :<

 

[baassee]

omg the insane map maker is making insane spells

will check it when I comes home from school

 

[xxdingo93xx]

Well, this is a very simple spell ...
Not the best, but judging about this is your first spell - compliment, I don't have to mention about location leaks etc.

 

[Rmx]

Nice spell for a beginner But needs alot of work to make Better spells ...

Keep up the GJ .. + REP

 

[Septimus]

If I have a good idea and my maths was any better, I could create a better spell... :=/

 

[Dark_Dragon]

very good for beginner spell!

things i would suggest are as following:

1. --------------------------------------
Change your spell event to:

• Unit - A unit Starts the effect of an ability

2. --------------------------------------
Change your if then else [(if then else) if then else] with following line:

• Set LW_Duration = (5.00 + (5.00 x (Real(LW_Level))))

3. --------------------------------------
In your variable LW_Target_Unit store Target unit of ability being cast and create new variable LW_Target_Pos and store target's position. Then instead of whole the time calling Target Unit of ab... use LW_Target_Unit

its not coz of speed its coz when calling that function multiple times in same trigger might bug. Its blizzard bug, so that is why i suggest you to use variable coz 1. when called it will work 100%.

4. --------------------------------------
I would add few comments but since code is simple it does not need to have any comments. Well for other beginners it should but as said not needed.


that would be all fix this and it will be 5/5 coz this is your first spell.
+rep anyway
~Dark Dragon

EDIT: :O you said if you where better at math? maybe i might help you...

 

[Septimus]

2. --------------------------------------
Change your if then else [(if then else) if then else] with following line:

Ahh, yes. That is what I been thinking about it, I been trying to fix this. But, I don't know how cause my maths sucks...

Thanks, +rep

3. --------------------------------------
In your variable LW_Target_Unit store Target unit of ability being cast and create new variable LW_Target_Pos and store target's position. Then instead of whole the time calling Target Unit of ab... use LW_Target_Unit

its not coz of speed its coz when calling that function multiple times in same trigger might bug. Its blizzard bug, so that is why i suggest you to use variable coz 1. when called it will work 100%.

I don't know there is a existence of such a bug.

 

[Deuterium]

Although I don't like the special effects, it might come in handy for some people...

 

[Dark_Dragon]

no no no xD

you got me wrong i mean you should store unit in LW_Target_Unit not point here is the code how it should look like:

• Lightning Ward
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Lightning Ward
  • Actions
    • Set LW_Target_Unit = (Target unit of ability being cast)
    • Set LW_Target_Point = (Target point of ability being cast)
    • Set LW_Target_Pos = (Position of LW_Target_Unit)
    • Set LW_Level = (Level of Lightning Ward for (Triggering unit))
    • Set LW_Duration = (5.00 + (5.00 x (Real(LW_Level))))
    • For each (Integer LW_Integer) from 1 to 5, do (Actions)
      • Loop - Actions
        • Set LW_Spawn_Point = (LW_Target_Pos offset by 500.00 towards (LW_Real + 72.00) degrees)
        • Unit - Create 1 Lightning Ward for (Owner of (Triggering unit)) at LW_Spawn_Point facing LW_Target_Point
        • Unit - Add a LW_Duration second Generic expiration timer to (Last created unit)
        • Unit - Add Lightning Bolt to (Last created unit)
        • Unit - Order (Last created unit) to Undead Crypt Lord - Locust Swarm
        • Unit - Order (Last created unit) to Attack LW_Target_Unit
        • Set LW_Real = (LW_Real + 72.00)
        • Custom script: call RemoveLocation(udg_LW_Spawn_Point)
    • Custom script: call RemoveLocation(udg_LW_Target_Point)
    • Custom script: call RemoveLocation(udg_LW_Target_Pos)

anyway its 5/5 now gj on ur first spell and if you need help with math or coding...
feel free to ask me ill try to help!

Greets!
~Dark Dragon

 

[Septimus]

Ooops.. my bad, I mistaken what you mean... Would fix it asap.

 

[Kingz]

Wow, you say this is your first spell?
Gj, i mean it is refreshing to see someones first spell and that i don't have to implicate how to fix leaks and use variables...
Well deserves 5/5 +rep^^

 

[Septimus]

Wow, you say this is your first spell?
Gj, i mean it is refreshing to see someones first spell and that i don't have to implicate how to fix leaks and use variables...
Well deserves 5/5 +rep^^

I know how to fix leak and use variable/array. The only main problem with spell is, it require maths such as radian, offset, degree and etc etc. Which are my natural weak spot in spell making.. XD

 

[-Berz-]

I'll check it when i get home 8)

 

[Dark_Dragon]

since its your first jass spell i think its really awesome. I can say only great job on it its well optimized and leakless. Well i am not sure do you know but actually that AnyUnitEventBJ cause 16 memory leaks of type boolexpr to fix that make function which returns true and takes nothing, the in init trigger:

local filterfunc ff = Filter(function ThatTrueFunc)
set i = 0
loop
exitwhen (i >= bj_MAX_PLAYER_SLOTS)
call TriggerRegisterPlayerUnitEvent(trig, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, ff)
set i = i + 1
endloop

call DestroyFilter(ff)
set ff = null

Greets!
~DD

 

[Kingz]

EDIT:
Post was wrong, just do what dd said^^

 

[Rmx]

the spell is very efficient i like it and the visual effects are great 5/5 for me and +rep

Edit : Fist i need to spread some rep

 

[Septimus]

Update with vjass version.

User now have the option to use this spells in GUI, JASS or VJASS.

If you are newbie and refuse to use JASS; you're welcome to use GUI.
If you are JASS user, but not familiar with VJASS; you're welcome to use JASS.
If you are JASS user, but want 100% perfect coding; you're welcome to use VJASS.

3 selectable option, have a nice day.

 

[ShadowMan]

Interesting first spell. Well done!

[Change]
You should probably change the order strings for the spells used for each type of triggering,
because, as it is, if you learn all of them and you want to cast one, the unit is ordered to cast
all of them.

[Suggestions]
I suggest that in the future you make your variables* more descriptable, so that you above all know what they are/stand for.
Don't worry about the name size, it's more important that you know what they are used for.

Again, this is a suggestion, because when you get into it more you start dealing with more variables
and it can get a bit messy if you use abbreviations

*Referring to programming in general, but in this case JASS scripts

Off topic

What is vJass? I might already have it, but I'm unsure.
Does it come in the NewGen Pack?

What I can do with my current GDI:

• Define globals
• Use structs (love)
• Define scope

 

[Kingz]

One tip:
Use large letters for global variables and normal letters for local variables.
This makes jassers easier to read and understand the code + i think it's a standard now

 

[ShadowMan]

One tip:
Use large letters for global variables and normal letters for local variables.
This makes jassers easier to read and understand the code + i think it's a standard now

Yah, they made it standard. Read it in the latest JASShelper readme.

 

[Septimus]

Ok, I would make it this way in my next jass spells. I use this standard cause it was easy for me.