Fade Filters

streetpunk · Sep 26, 2016

So I've learned how to apply the fade filter to specific players, my question is how can I aplly multiple filters at the same time, AND my second doubt is about why when I apply a fade filter for a player, the fade filter of the other player "blinks" in the screen ?

Wietlol · Sep 26, 2016

IIrc, you cannot have multiple fade filters on top of each other.

Virus-X · Sep 26, 2016

Fade fliters only use in cinematic, if you don't turn on cinematic, you got disconnected.

DracoL1ch · Sep 26, 2016

Virus-X said:
Fade fliters only use in cinematic, if you don't turn on cinematic, you got disconnected.

do you even test what you saying?

Dr Super Good · Sep 26, 2016

Fade filters should not be used as part of game play as I recall them disabling tooltip display, which causes major usability problems.

streetpunk · Sep 27, 2016

I actually meant Advanced Filters, but I could't remember which one I was referring, I saw this tutorial by Purge : Tips and Tricks for the Cinema and there he spoke about a solution for simultany filters: Fade Filter for Triggering Player but I could't understand a thing as it's in JASS code.

Wietlol · Sep 27, 2016

Dr Super Good said:
Fade filters should not be used as part of game play as I recall them disabling tooltip display, which causes major usability problems.

This can be fixed by calling some EnableUI function or something like that... should check one of my old maps to see what the actual function name was.

DracoL1ch · Sep 27, 2016

Wietlol said:
This can be fixed by calling some EnableUI function or something like that... should check one of my old maps to see what the actual function name was.

they just dont. Im using fadefilters right now, theres no drawbacks

WaterKnight · Sep 27, 2016

The GUI Video - Fade Filter action uses the CinematicFadeCommonBJ function which is the culprit for disabling user UI.

streetpunk · Sep 27, 2016

The problem I'm having right now is that when I apply a (Advanced) Filter to a player, the other player's Filter blinks or even vanish completly.

Here's the triggers I'm using:

This trigger applies a filter when the hero acquires an item

Applying Filter
- Events
  - Unit - A unit Acquires an item
- Conditions
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Item-type of (Item being manipulated)) Equal to Helmo de Bronze
    - Then - Actions
      - Set AlphaReal = 0.00
      - Set TempForce = (Owner of (Triggering unit))
      - Custom script: if GetLocalPlayer() != udg_TempForce then
      - Set AlphaReal = 100.00
      - Custom script: endif
      - Cinematic - Apply a filter over 2.00 seconds using Key alpha blending on texture war3mapImported\DefaultFilter.blp, starting with color (100.00%, 100.00%, 100.00%) and 0.00% transparency and ending with color (100.00%, 100.00%, 100.00%) and 0.00% transparency
      - Custom script: call EnableUserUI(true)
    - Else - Actions

This trigger applies another filter to the hero when it's damaged (i'm using Bribe's DDS)

Blood Filter
- Events
  - Game - DamageEvent becomes Equal to 1.00
- Conditions
- Actions
  - Set AlphaReal = 0.00
  - Set TempForce = (Owner of DamageEventTarget)
  - Custom script: if GetLocalPlayer() != udg_TempForce then
  - Set AlphaReal = 100.00
  - Custom script: endif
  - Cinematic - Apply a filter over 2.00 seconds using Key alpha blending on texture war3mapImported\BloodFilter.blp, starting with color (100.00%, 100.00%, 100.00%) and AlphaReal% transparency and ending with color (100.00%, 100.00%, 100.00%) and AlphaReal% transparency
  - Custom script: call EnableUserUI(true)
  - Set Loc1 = (Position of DamageEventTarget)
-------- THIS ACTION REMOVES THE DUMMY UNIT BEFORE CREATING ANOTHER --------
- Unit Group - Pick every unit in (Units owned by TempForce of type Cavalo Leve (dummy)) and do (Actions)
  - Loop - Actions
    - Unit - Kill (Picked unit)
-------- I CREATE A DUMMY UNIT TO COUNT THE TIME THE FILTER SHOULD STAY ON, AFTER IT DIES, THE FILTER MUST BE SET TO THE DEFAULT FILTER --------
- Unit - Create 1 (dummy) for TempForce at Loc1 facing Default building facing degrees
- Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
- Custom script: call RemoveLocation(udg_Loc1)

This trigger checks when the unit dies and applies the default filter to the player:

Untitled Trigger 026 Copy
- Events
  - Unit - A unit Dies
- Conditions
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Dying unit)) Equal to (dummy)
    - Then - Actions
      - Set AlphaReal = 0.00
      - Set TempForce = (Owner of (Triggering unit))
      - Custom script: if GetLocalPlayer() != udg_TempForce then
      - Set AlphaReal = 100.00
      - Custom script: endif
      - Cinematic - Apply a filter over 2.00 seconds using Key alpha blending on texture war3mapImported\DefaultFilter.blp, starting with color (100.00%, 100.00%, 100.00%) and 0.00% transparency and ending with color (100.00%, 100.00%, 100.00%) and 0.00% transparency
      - Custom script: call EnableUserUI(true)
    - Else - Actions

DracoL1ch · Sep 27, 2016

WaterKnight said:
The GUI Video - Fade Filter action uses the CinematicFadeCommonBJ function which is the culprit for disabling user UI.

they always have an option to add a handwritten calls

PurgeandFire · Sep 28, 2016

@streetpunk The alpha technique that sets the alpha real to 0 then 100 doesn't work for simultaneous fade filters, as I mentioned in the note. The filters are still applied globally, just with different alpha values, so that's why it ends up bugging out/vanishing since the 0 alpha filter replaces the old one. You have to use WaterKnight's function. There isn't really an easy way to do it in GUI.

streetpunk · Sep 28, 2016

So I can't show a custom filter for one player, and a different custom filter to other player at the same time? about WaterKnight's solution, I don't understand JASS, but I just need the directions pointed out to me so I can addapt it to my needs, can you please help me with that ? With his solution is it possible to do one different filter for each player at the same time?

DracoL1ch · Sep 28, 2016

streetpunk said:
So I can't show a custom filter for one player, and a different custom filter to other player at the same time? about WaterKnight's solution, I don't understand JASS, but I just need the directions pointed out to me so I can addapt it to my needs, can you please help me with that ? With his solution is it possible to do one different filter for each player at the same time?

sure, DisplayFadeFilter(localplayer==myplayer)

streetpunk · Sep 28, 2016

where does it fit ?

DracoL1ch · Sep 28, 2016

JASS:

call SetCineFilterTexture("DamageMask.blp")
    call SetCineFilterBlendMode(BLEND_MODE_BLEND)
    call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
    call SetCineFilterStartUV(0, 0, 1, 1)
    call SetCineFilterEndUV(0, 0, 1, 1)
    call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 0)
    call SetCineFilterDuration(1.)
    call DisplayCineFilter(p==LocalPlayer)

guess you'll get how to adapt it

WaterKnight · Sep 28, 2016

OP wants to have different filters for different players running simultaneously, so all of those calls should be inside a local block.

DracoL1ch · Sep 28, 2016

WaterKnight said:
OP wants to have different filters for different players running simultaneously, so all of those calls should be inside a local block.

nope, he only have to make local condition for the string setup
if player==1 then s="effect1.blp"

Wietlol · Sep 28, 2016

Make sure not to ruin the string table.
(I am not sure if it causes a desync.)

DracoL1ch · Sep 28, 2016

Wietlol said:
Make sure not to ruin the string table.
(I am not sure if it causes a desync.)

its not a thing for good 4 years, forget it already D:

WaterKnight · Sep 28, 2016

DracoL1ch said:
nope, he only have to make local condition for the string setup
if player==1 then s="effect1.blp"

Not really, as calling the filter functions with local-different parameters would still force an update.

call DisplayCineFilter(p==GetLocalPlayer()) would show whatever filter is currently set for p to p AND hide whatever individual filter is currently set for other players from them. You could save the local state and use that instead but cine filters also feature some transition that would restart/you would be required to monitor that. Just put all of the filter calls in the local block. The GUI action Video - Advanced Filter is fine to be local-wrapped in case you relinquish Video - Fade Filter respectively CinematicFadeCommonBJ and the jass functions setting up the tranisition timers because other than calling the cine filter natives, Video - Advanced Filter only kills those timers (if they exist).

streetpunk · Sep 28, 2016

I copied the code into a text trigger but when I start the map it returns errors, what must I do for it to work? I'm sorry for bothering so much, but I have very little (to none) knowledge about jass coding

Dr Super Good · Sep 28, 2016

I am fairly certain string table desyncs are a thing. At least that is what previous feedback and issues leads one to believe.

DracoL1ch · Sep 29, 2016

streetpunk said:
I copied the code into a text trigger but when I start the map it returns errors, what must I do for it to work? I'm sorry for bothering so much, but I have very little (to none) knowledge about jass coding

you have to state correct BLP mask path. if its incorrect, fatal will happen. im not gonna tell you exact pathes, but you can search for them.
Creating a Custom Fade Filter
Fade Filter - Wc3C.net
etc etc, use google

Dr Super Good said:
I am fairly certain string table desyncs are a thing. At least that is what previous feedback and issues leads one to believe.

nope. tell me how different state of the memory on my pc may affect anyone else, if we only translate actions while playing

Dr Super Good · Sep 29, 2016

DracoL1ch said:
nope. tell me how different state of the memory on my pc may affect anyone else, if we only translate actions while playing

The very definition of a desync is that your game state is different from other players.

DracoL1ch · Sep 29, 2016

Dr Super Good said:
The very definition of a desync is that your game state is different from other players.

strings are being cached like literally any dev would do using C++. its must have tech to save memory. it have nothing to do with syncing - it doesnt affect anyone's state, instead it lookups for proper hash, if there are none found - creates a new one. not a single byte has been transfered with that

Tal'Rarity · Sep 29, 2016

It's locally setting a string for those players while still not set for others so it'll d/c one of those groups.

DracoL1ch · Sep 29, 2016

Dat-C3 said:
It's locally setting a string for those players while still not set for others so it'll d/c one of those groups.

do I really need to say it wont? daily reminder that there's no proofs for all that bullshit about string table desyncing issue

streetpunk · Sep 29, 2016

DracoL1ch I had changed the blp name before I posted earlier, is there any other changes that must be made ?

DracoL1ch · Sep 29, 2016

just drop your code here to check

streetpunk · Sep 29, 2016

The text trigger contains only this:

Code:

call SetCineFilterTexture("bronzeblood.blp")
    call SetCineFilterBlendMode(BLEND_MODE_BLEND)
    call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
    call SetCineFilterStartUV(0, 0, 1, 1)
    call SetCineFilterEndUV(0, 0, 1, 1)
    call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 0)
    call SetCineFilterDuration(1.)
    call DisplayCineFilter(p==LocalPlayer)

This is the "custom script" gui I've also made, this one only returns an error on:

Custom script: call DisplayCineFilter(p==LocalPlayer)

Untitled Trigger 032
- Events
  - Unit - A unit enters (Playable map area)
- Conditions
- Actions
  - Custom script: call SetCineFilterTexture("bronzeblood.blp")
  - Custom script: call SetCineFilterBlendMode(BLEND_MODE_BLEND)
  - Custom script: call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
  - Custom script: call SetCineFilterStartUV(0, 0, 1, 1)
  - Custom script: call SetCineFilterStartColor(128, 226, 255, 200)
  - Custom script: call SetCineFilterEndColor(128, 226, 255, 0)
  - Custom script: call SetCineFilterDuration(1.)
  - Custom script: call DisplayCineFilter(p==GetLocalPlayer())

Dr Super Good · Sep 29, 2016

DracoL1ch said:
strings are being cached like literally any dev would do using C++. its must have tech to save memory. it have nothing to do with syncing - it doesnt affect anyone's state, instead it lookups for proper hash, if there are none found - creates a new one. not a single byte has been transfered with that

Except it also assigns strings a unique identifier. Also nothing stops the game being programmed to do something stupid like check for string table integrity as part of sync.

DracoL1ch · Sep 29, 2016

streetpunk said:

The text trigger contains only this:

Code:

call SetCineFilterTexture("bronzeblood.blp")
    call SetCineFilterBlendMode(BLEND_MODE_BLEND)
    call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
    call SetCineFilterStartUV(0, 0, 1, 1)
    call SetCineFilterEndUV(0, 0, 1, 1)
    call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 0)
    call SetCineFilterDuration(1.)
    call DisplayCineFilter(p==LocalPlayer)

did you actually defined LocalPlayer var? its alias for GetLocalPlayer() in my code

Code:

call SetCineFilterTexture("bronzeblood.blp")
    call SetCineFilterBlendMode(BLEND_MODE_BLEND)
    call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
    call SetCineFilterStartUV(0, 0, 1, 1)
    call SetCineFilterEndUV(0, 0, 1, 1)
    call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 0)
    call SetCineFilterDuration(1.)
    call DisplayCineFilter(p==GetLocalPlayer())

DracoL1ch · Sep 29, 2016

Dr Super Good said:
Except it also assigns strings a unique identifier. Also nothing stops the game being programmed to do something stupid like check for string table integrity as part of sync.

this game actually supports multiple languages at once, so this kind of checks would be over stupidity

streetpunk · Sep 29, 2016

Untitled Trigger 032
- Events
  - Unit - A unit enters (Playable map area)
- Conditions
- Actions
  - Set TempPlayer = (Owner of (Triggering unit))
  - Custom script: if GetLocalPlayer() != udg_TempForce then
  - Custom script: endif
  - Custom script: call SetCineFilterTexture("bronzeblood.blp")
  - Custom script: call SetCineFilterBlendMode(BLEND_MODE_BLEND)
  - Custom script: call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
  - Custom script: call SetCineFilterStartUV(0, 0, 1, 1)
  - Custom script: call SetCineFilterStartColor(128, 226, 255, 200)
  - Custom script: call SetCineFilterEndColor(128, 226, 255, 0)
  - Custom script: call SetCineFilterDuration(1.)
  - Custom script: call DisplayCineFilter(p==GetTempPlayer())

It's still returning error on the last line

DracoL1ch · Sep 29, 2016

local, not temp

streetpunk · Sep 29, 2016

Untitled Trigger 032
- Events
  - Unit - A unit enters (Playable map area)
- Conditions
- Actions
  - Set LocalPlayer = (Owner of (Triggering unit))
  - Custom script: if GetLocalPlayer() != udg_LocalPlayer then
  - Custom script: endif
  - Custom script: call SetCineFilterTexture("bronzeblood.blp")
  - Custom script: call SetCineFilterBlendMode(BLEND_MODE_BLEND)
  - Custom script: call SetCineFilterTexMapFlags(TEXMAP_FLAG_NONE)
  - Custom script: call SetCineFilterStartUV(0, 0, 1, 1)
  - Custom script: call SetCineFilterStartColor(128, 226, 255, 200)
  - Custom script: call SetCineFilterEndColor(128, 226, 255, 0)
  - Custom script: call SetCineFilterDuration(1.)
  - Custom script: call DisplayCineFilter(p==GetLocalPlayer())

Didn't work either

DracoL1ch · Sep 29, 2016

you have no idea how to jass, amirite?
p stands for desired player who should receive this mask. so use Player(1) instead in case if you wanna show it to blue, Player(0) for red, etc etc.

Code:

call DisplayCineFilter(Player(1)==GetLocalPlayer())

streetpunk · Sep 29, 2016

So I just have to put "TempPlayer" instead of "Player(1)" to set it to my desired variable ?

PS: I've changed Player(1) to (0), the map is starting, but the game crashes as soon as the event of the trigger is fired

DracoL1ch · Sep 29, 2016

crash normally happens if specified BLP incorrect or not found. im using 64x64 blp with alpha-channel

streetpunk · Sep 29, 2016

Ok, the map isn't crashing anymore, but why the image only appear for a fraction of seccond and starts fading to the sides ?

DracoL1ch · Sep 29, 2016

call SetCineFilterDuration(1.)
choose duration

streetpunk · Sep 29, 2016

infinite ? and how can I hide the filter later ?

DracoL1ch · Sep 29, 2016

9999. as duration, display(false) to hide

streetpunk · Sep 29, 2016

Why when I activate a filter to one player, the filter of the other player gets cleared ?

DracoL1ch · Sep 29, 2016

'because I assumed you only need it for one player at time. so you have to turn filters on/off locally

WaterKnight said:
Not really, as calling the filter functions with local-different parameters would still force an update.

call DisplayCineFilter(p==GetLocalPlayer()) would show whatever filter is currently set for p to p AND hide whatever individual filter is currently set for other players from them. You could save the local state and use that instead but cine filters also feature some transition that would restart/you would be required to monitor that. Just put all of the filter calls in the local block. The GUI action Video - Advanced Filter is fine to be local-wrapped in case you relinquish Video - Fade Filter respectively CinematicFadeCommonBJ and the jass functions setting up the tranisition timers because other than calling the cine filter natives, Video - Advanced Filter only kills those timers (if they exist).

just what he said

JASS:

if GetLocalPlayer()==Player(1) then
call DisplayCineFilter(true)
endif

streetpunk · Sep 29, 2016

I just wish I could understand correctly what each function on the strings does, but it's working perfectly now! Thanks a lot everyone! +rep all!

Dr Super Good · Sep 29, 2016

JASS Player(1) is the same as GUI Player - 2 Blue.

streetpunk said:
PS: I've changed Player(1) to (0), the map is starting, but the game crashes as soon as the event of the trigger is fired

Post the current triggers for investigation.

DracoL1ch said:
crash normally happens if specified BLP incorrect or not found. im using 64x64 blp with alpha-channel

Must it be mipmapped or non-mipmapped?

streetpunk · Sep 29, 2016

It was indeed the .blp file, Dr Super Good, it had war3mapimported/ before it's name, I think for JASS purposes you can't use that, you must remove the "war3mapimported", I even changed the file name on the string to include the "war3mapimported" but it only worked when I removed that from both string and imported file. Dr, any tips you could give for what each function does? If I put a 1 sec on the duration function it doesn't vanish normaly, instead it fades moving to the side in a weird way

DracoL1ch · Sep 29, 2016

and then you have

Code:

call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 0)

lines, which you prolly wanna use as

Code:

call SetCineFilterStartColor(128, 226, 255, 200)
    call SetCineFilterEndColor(128, 226, 255, 200)

which means "dont fade it, keep it as is"