02:29, 23rd Nov 2008
Dr Super Good:
Very good spell pack. All the spells are highly customizable and seem to do their job well. Only problems I noticed are that some spells are not the most efficent. Still I can only recomend using the spells if they are what you are after.

Possiable areas for improvement
- Improve code efficiency.

 

Bug:

When using the blademaster spell, at a barrel, you fly in some random way, cause its not an unit.

Also, please do not use custom models in spells, unless thats what the spell is about.

 

ok. they look nice and also i didn't found any leaks (ok realy long spell scripts... 800lines per spell is realy much to read XD)
also it's realy well documented , I can see you have put a lot of work in it so i give you

ok like blooddancer said custom models are nice, but not needed in this case... 4.9/5

 

I appreciate your intelligence Blooddancer actually its not a bug but my mistake for allowing it to be casted at barrel. You have my thanks for this one.

Now Its updated and cant be cast on barrel (destructable) as ofc i used GetSpellTargetUnit(), GetUnitX, Y ... and ofc it did not work.

Thanks again!

About part in custom models, I know that you people don't like it for some reason 'size' but i think its nice to give people idea on which model or hero can spells be used on.

 

Its no just the downbload size
its also the size of all Spells and datas of Hive atall
Because its just useless to have one model 1000 times in different Spells and model section

The Spells look nice , but the blademasters Spell looks really strange and not intentioned when casted from a very short range

The first time i casted Dark Torture one Sword was not removed and stayed forever

All in all they look nice but its such an huuuge code , i was too lazy to check everything but i can imagine that some things are not really necessary

Ill give you a [4/5] for this

 

Well, I will not rate in my standard rating style this time because the code is too long...

omg xD nearly 3400 lines used totally for 3 spells, sooooooooo many globals and using a library for a spell (?)...
I am not very sure but you surely have planned that. I usually only use libraries for systems and scopes for spells.
Well, the spell performace rockz and I give a 10/5 for that, ideas are great. The coding seems to be leakless, perfect but also clearless. I can't figure out to configure it xD Well, 5/5 from me.

 

alot of lines the spellpack made my comp crash about 3 min into testing for sum reason... My computer has never crashed beafore...

 

I know its not a real bug, but its more like an error, cause you made the spell to target 'objects' and not 'units'. But if you somehow, did not remove this, then most people would say that i was a 'bugg' therefor: Bug

Also: Hell'a lot of lines. But also pretty neat spells. You should work on:

• Not importing models.
• Less lines

Regards~
TheBlooddancer

 

Ok lets see, for some reason my pc starts to lag like hell when using vjass test map option, dont know why. So please test the spells by default starting your Warcraft III.
Ty!

I guess ill just have to wait for you to find time rating this in your nice rate system.
About globals lets see, I made a lots of em to simple edit spell stile, and I am not using any objects storage systems so I need direct one hell of a variables. But dont worry they do not pass the limit of 8191 so they are fast. And you can cast this spells a lots of time in same time. Game Cache limit if 255 variables at same time, which is lol for me.

Hmm scopes can they do requires and initializer anyway somehow i love keyword library much more I guess it does not cause any trouble to you.
Ty for comment.

Thanks for rating. Ok if you really say that you want that model removed or causes you trouble ill remove it.

Yep blademaster spell is something special as it damages units which are exactly at sword position i did one hell of a trigonometry out there, but anyway at short range it can damage only once and this once it must be at sword position. Last slash it 100% to be target.

Ok about that swords stay this has to do with collision but ill check this right away.

Thank you for your comment!

Yes ofc ty. About models lol if someone really tells me remove it now then I will.
About less lines. Its because i want to make inline functions actually not make functions but when i got idea of Dark Torture i said like hell more then 2000 lines for one spell is kind killing. But you know this spells are so good made that even if you cast then 5x times at same time its gonna be a little slower then 1x times. Every spell has one global timer this timer lives only when there are TimesOfCast > 0 thats how it is.

Thank you for comment!

 

I would like you to remove the custom models, and see if you can get same result. If, then edit this upload.

Oh, yea, and you might wanna merge your double post before Rui see's you.

 

Effects or Icons are not necessary but imo its Ok. Sometimes there is just no matching Icon or Spell look crap with other models (e.g. these swords)
I didnt look if you did but you should credit the creators and make i hint that Mapper which use your Spell should credit them too

But I think a big model for a hero is really not needed

 

He did credit them, atleast @ The hive.

 

Double post? Didn't I click on update?

Both of you i removed the so irritating model
Well anyway now you happy

Thank you for finding about this and telling me out. Its fixed + added swords pathing type to NONE from fly so swords will always move at same height even on terrain. Beautiful to see!!!

Once more thank you for comments and have a nice day!

 

I meant your two post's above my last post. Not the spell post.

 

OMG I live the dark torture! Well done 5/5 +rep

 

Boolexprs do not need to be destroyed unless they will never be used again. They do not leaks as they always return the same object. I think I saw you destroy them in this spell atleast once.

 

Yap the boolexpr i use is only (object exist during spell is cast (only one)), when spell ends the object is not needed to be in game anymore so its destroyed. It does returns same object but its object so when spell ends there is no need to leave that object live. In other way some people just make one object which will live always so they dont destroy it, but i am making object exist only during the spell (one of object per spell). As less object in map the less chance to for lag is possible because the object cause lag in maps. Well that's like location, it always returns same location but we will remove it to cause no leak. Even if we could move location whole the time but we remove it coz there would be one hell of a objects in map and when playing on Battle.net with a lot of players hell game would lag hard. Thats why object methodes (functions) are made.

Once more thank you for comment and approving!
Best regards!

 

HOW AWESOME!!! thats what i call awesomeness... i mostly like the spell with teh swords 10/10

 

Thanks a lot I am glade to hear that you like it!