Blind v1.1.0

[Moderator]

07:45, 13th Jun 2014
BPower:
Changes mentioned are made. Approved.

12:43, 21st May 2014
PurgeandFire: Review:
http://www.hiveworkshop.com/forums/2529843-post17.html

 

[Daffa]

Wow, quite a low size for a spell.
Never thought of that.

 

[BunnyAng]

Ahh you uploaded it at last. Good job on the spell.

 

[ukn0wnD3str0y3r]

Where is my requested spells?

 

[Kazeon]

after reading the configuration, I think I like the concept, code looks perfect, I can't find anything's wrong. Except this:

• Unit - Order BlindDummy to Undead Banshee - Curse TargetUnit

I'm not sure but I think the order need to be stored in variable. Just wait for other's opinion.

Good job ! I haven't checked the object editor data, but seeing from the code, I vote for quick approval

 

[Wrda]

after reading the configuration, I think I like the concept, code looks perfect, I can't find anything's wrong. Except this:

• Unit - Order BlindDummy to Undead Banshee - Curse TargetUnit

I'm not sure but I think the order need to be stored in variable. Just wait for other's opinion.

I don't think its needed a variable for that :b also, it's nearly 2 bytes of a crappy variable.
But I think it should be only a dummy for the debuff, do it at the init trigger .
Also, the spell can get messy if cast constantly (in terms of whether being able to attack or not).
4/5 good work

 

[ILH]

Where is my requested spells?

Lol.

Hey, good job daffa!

 

[Daffa]

Ahh you uploaded it at last. Good job on the spell.

Thanks a lot!

Where is my requested spells?

Which one? I'll take a look at the workshop, I' hope you're aware I was busy with exams.

after reading the configuration, I think I like the concept, code looks perfect, I can't find anything's wrong. Except this:

• Unit - Order BlindDummy to Undead Banshee - Curse TargetUnit

I'm not sure but I think the order need to be stored in variable. Just wait for other's opinion.

Good job ! I haven't checked the object editor data, but seeing from the code, I vote for quick approval

Thanks, I must admit it's not the best actually.
That one shouldn't need to be in a variable, there's no way users can modify the curse orderId.

I don't think its needed a variable for that :b also, it's nearly 2 bytes of a crappy variable.
But I think it should be only a dummy for the debuff, do it at the init trigger .
Also, the spell can get messy if cast constantly (in terms of whether being able to attack or not).
4/5 good work

Yep, it's a crap.
Yeah, perhaps I manipulate it a little so only one dummy used.
For the constant spam, I'm sure it shouldn't be much of an issue.

Lol.

Hey, good job daffa!

Thanks!

 

[Kazeon]

wait, I think the order DOES need to be stored into variable and added to configuration part, in case user has another "Channel" ability with same order id, it will bugged if user can't configure.. please fix it. still haven't check the file though

also every aspect of floating text should be configurable (fading age, lifespan, size, etc.)

 

[Daffa]

The dummy is by default using it.
The only purpose for the dummy is for the buff.

I'll fix the floating text ASAP.

 

[Wrda]

wait, I think the order DOES need to be stored into variable and added to configuration part, in case user has another "Channel" ability with same order id, it will bugged if user can't configure.. please fix it.

The "ability" you are talking about is the dummy's one, it's based on curse, so what you just said doesn't make sense.

 

[Kazeon]

still haven't check the file though

I know you noticed that part so why you deleted it from your quote? I said it because I had reason: I haven't opened the file. your post 10x makes no sense sir.

 

[Wrda]

That is irrelevant, you don't need to check the file to see if it's based on curse or not, and it is a dummy ability, why should it be channel-based?
Anyway, I'm not going to argue about this stupid thing.

 

[IcemanBo]

Why it only can be used on heroes? It didn't work for me when I tried it on a normal unit.

In your trigger "Blind Loop": You store "Picked unit" twice into a variable if the first condition is true.

First you do:

• Set BlindConfuseTargetAttack = False

And then you check a boolean and would also set it to false, that doesnt make sense:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindDisablesAttack == True
  • Then - Actions
    • Set BlindConfuseTargetAttack = False
  • Else - Actions

And anyway don't set it before, if you later check a boolean to possibly set it to an other value. You could take usage of the "Else" here.

Same you do with "ShowNewDamageRateText":

• Set ShowNewDamageRateText = True
• ...
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindIncreasePhysicalDamage == False
    • BlindIncreaseMagicalDamage == False
    • BlindIncreaseTriggeredDamage == False
  • Then - Actions
    • Trigger - Turn off Blind Damage Text <gen>
    • Set ShowNewDamageRateText = False
  • Else - Actions

Personally I prefer indexing instead of UnitGroups, but I think it's ok here.
Anyway I think using a counter for instances is better to check instead of using the function "Number of Units in Group" so often. (to turn trigger on/off)
Using the count function is less efficient.

Furthermore I think throwing a flashbang or something similar would improve the realistic near a lot, instead of casting an instant spell without any projectile graphics.

Else it worked fine. Code is not very complex, but once all works properly it might be useful. (no rating yet)

 

[Daffa]

I'll split your post for easy answer.

Why it only can be used on heroes? It didn't work for me when I tried it on a normal unit.

It was the intention
Maybe I'll make it available for units too

In your trigger "Blind Loop": You store "Picked unit" twice into a variable if the first condition is true.

Thanks for informing, I'll make a check and fix it.

First you do:

• Set BlindConfuseTargetAttack = False

And then you check a boolean and would also set it to false, that doesnt make sense:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindDisablesAttack == True
  • Then - Actions
    • Set BlindConfuseTargetAttack = False
  • Else - Actions

It was a security measure, since if Blind disables attack, there's no need for target to get confused. (He/she already can't attack )

And anyway don't set it before, if you later check a boolean to possibly set it to an other value. You could take usage of the "Else" here.

Same you do with "ShowNewDamageRateText":

• Set ShowNewDamageRateText = True
• ...
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindIncreasePhysicalDamage == False
    • BlindIncreaseMagicalDamage == False
    • BlindIncreaseTriggeredDamage == False
  • Then - Actions
    • Trigger - Turn off Blind Damage Text <gen>
    • Set ShowNewDamageRateText = False
  • Else - Actions

It's also for security measures, I don't want unwanted operations here

Personally I prefer indexing instead of UnitGroups, but I think it's ok here.
Anyway I think using a counter for instances is better to check instead of using the function "Number of Units in Group" so often. (to turn trigger on/off)
Using the count function is less efficient.

I guess you're right, it can help a lot. I haven't remember the inefficiency (haven't been triggering for a while, so forget some of it).

Furthermore I think throwing a flashbang or something similar would improve the realistic near a lot, instead of casting an instant spell without any projectile graphics.

I'll check the Model Section, perhaps some useful model can be found there (else I'll try to make one)

Else it worked fine. Code is not very complex, but once all works properly it might be useful. (no rating yet)

Thanks
I'm not a fan of super hard coding spells, I won't make long codes unless necessary.

 

[IcemanBo]

Just a short statement to the booleans "BlindConfuseTargetAttack" and "ShowNewDamageRateText":

The parser anyway gets to the If/Then/Else part, so it's kind of redundant to set the boolean before. You could only set it in the 'Then' and 'Else' part.

 

[PurgeandFire]

First things first: I like the idea, and it seems to perform quite well in game.

Review:

• Your ability should untick "Disable Other Abilities" in the object editor.
• Set the button position to something other than (2, 0). (if you try casting blind on your own hero, the button will jump to the attack's button position)
• Your variables should be prefixed. e.g. CastingUnit -> B_CastingUnit, or better yet, BL_CastingUnit (it is usually more common to have two letters as a prefix). This will prevent collisions.
• Keep track of the units in the group with a variable instead of using "Number of units in <Group>" (that function will iterate through the entire group to count the units). Whenever you add a unit to the BlindGroup, just increment it. Whenever you remove one, decrement it:
  
  • Unit Group - Add BL_TargetUnit to BL_Group
  • Set BL_GroupCount = BL_GroupCount + 1
  • Unit Group - Remove BL_TargetUnit from BL_Group
  • Set BL_GroupCount = BL_GroupCount - 1
• In the "Blind Cast" trigger, you should check if the unit already has the Blind debuff. That way, you can just update the Blind duration value and then skip remaining actions.
  
  • Set BlindedUnitDuration[TargetValue] = BlindDuration[HeroLevel]
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • BL_TargetUnit has buff BlindDebuff
    • Then - Actions
      • Skip Remaining Actions
    • Else - Actions
  That way, you don't go through a whole bunch of extra steps. I think. You might have to try it out and see if it works. It works in my head, but I can't be sure.

Otherwise, it is a nice spell. I like how compact it is, and it makes great use of the damage modification offered by lfh's damage library, as well as the default wc3 abilities. Nice job! Make those changes, and it should be approvable.

 

[Daffa]

Thanks, these will be applied within this week (hopefully).

 

[GywGod133]

you use 0.03125 sec
hihi

 

[Cherrymage]

What does this spell do (quite lazy to check the codes in detail)? Is this something like Yuri's Revenge "Chaos" and Wc3 "Chaos" combined?

 

[Daffa]

What does this spell do (quite lazy to check the codes in detail)? Is this something like Yuri's Revenge "Chaos" and Wc3 "Chaos" combined?

It's more on making units unable to attack for a period of time. It can be altered to simulate YR's chaos toxin to a degree.

 

[TheFireMage]

looks nice

 

[Daffa]

looks nice

Thanks ^^