Arcane Mage Spellpack 2.0 (working with 1.24)

[Moderator]

22:42, 2nd Jan 2010
TriggerHappy:

Don't use locations.
And one or two of these spells are too simple to be approved, but since they are included with a pack I will go ahead and approve it.

 

[Jack_Sparrow93]

It looks awesome! I really love the Arcane Barrage! +rep

 

[xxdingo93xx]

Ye I liked it to something new at last..

 

[-JonNny]

I like your spellpack, it looks quite good

-but i dislike the Arcane movement cuz it always dives circles with the try to t hit the target (even its already dead)

-The Arcane Barrage movement makes it hard to aim and it looks a bit like the missiles do not really explode near the target, also better use an AOE based spell

-Arcane missiles leak and contain a useless BJ
set x = GetUnitX(hero) set y = GetUnitY(hero) set am = ArcaneMissile.create( x, y, AngleBetweenPoints(GetUnitLoc(hero),GetUnitLoc(tar)) )

change that to
set am = ArcaneMissile.create( x, y, bj_RADTODEG * Atan2(GetLocationY(tar) - y, GetLocationX(tar) - x))

else you got everywhere location leaks, "tarLoc" ect.

but all in all still a funny pack, [7.5/10]

 

[Darkyvm]

x and y are reals, I thought reals didn't leak, I remember reading that somewhere a long time ago.
Fixed the BJ function, just waiting for confirmation if reals leak or not before updating the map.

 

[-JonNny]

The reals do not leak
but the locations do GetUnitLoc(hero)
you got x and y but use the location :/ try to avoid location or atleast do call RemoveLocation(mylocation)

 

[Darkyvm]

Oh, right, didn't even see that, fixed and updated now.

 

[Magissia]

Seriously, arcane barrage pwn =o

 

[Aspard]

Outstanding job! Looks fresh and innovative, keep on doing this way. 5/5

 

[Kingz]

Hmm, the idea reminds me of Neverwinter Nights 2...
I thought of making a spell simmilar to the barrage...
Well downloading...

EDIT:
Wow you used a great number of systems there
I don't say it's bad but it's harder to copy...
Anyway the Arcane Barrage == win
But other spells were of medium quality.

4/5.

 

[Deuterium]

I'm working on a spell which has a missile going in circles like the Arcane Missile

So well, i finally learnt a better way than the one i was using to make the circles!

Btw, nice spells... useful too.

 

[Kingz]

Doesn't TriggerRegisterAnyUnitEventBJ leak 16 objects?
Due to the null used instead of filter.

 

[breebree123]

weeeeee i love this spellpack

 

[Darkyvm]

Why would it leak? I checked the function in JC and all it does is create a local integer, which doesn't leak afaik.

 

[Kingz]

But boolean expresions do and when using TriggerRegisterAnyUnitEventBJ it loops through 16 times for each player and calls:
TriggerRegisterPlayerUnitEvent(trig, Player(index), whichEvent, null)
And it uses a null for a boolexpresion and that is where it leaks.
You should do something like this:

replacing the AnyUnitEvent

function Afilter takes nothing returns boolean
 return true
endfunction

function *Spell init* takes nothing returns nothing
local filterfunc f = Filter(function Afilter)
local integer i = 0
local trigger t = CreateTrigger()
loop
 exitwhen i > bj_MAX_PLAYER_SLOTS
 call TriggerRegisterPlayerUnitEvent(t,Player(i),EVENT_PLAYER_UNIT_SPELL_EFFECT,f)
 set i = i + 1
endloop
call DestroyFilter(f)
set f = null
endfunction

 

[Darkyvm]

After checking Wc3c, i'm safe to say that, even if it does leak boolexpressions (the guys over there aren't very sure about it), it only leaks for the first time the trigger is fired, which means it's pretty much insignificant since it can only leak once per game if the trigger not destroyed and recreated.

Here's the thread from where I got this info:
http://www.wc3c.net/showthread.php?t=103738&highlight=Event+leak

 

[kmde613]

I love all the spells in here. Especially the Barrage.
Though, the hard part is importing it...

This explains the beauty of ribbons and the I suggest all spells that want to look nice should have ribbons

 

[f0rsAk3n]

I really like the concept of these spells.
Cant report leaks though cause i dont know jass.

nice work. 5/5 +rep

 

[Dimetrixdemon]

Nice work man

 

[Darkyvm]

Update:
Spellpack is fixed and now works with patch 1.24, also added one extra spell to it.

 

[CoLd Bon3]

The spells are good, but in WoW the effects are very different!

 

[aider]

gj, the first spell pack where I liked all the spells
But why does it spam: "Double free of type: xecast" every time it damages an enemy?? I cant find the command

 

[KaiZen7th]

Hello there, How can I increase damage that reflected back to attackers from the Mage Armor?