The Arcane Silencer Spellpack v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Moderator: Pharaoh_ Date: 00:55, 11th March 2012 Great presentation, but the spells leak, you make no use of variables and as a spellpack it lacks basic efficiency in coding. They are too simple to create. Unacceptable Useful Links: Things that leak Spell Rules

 

[maddeem]

Displaying damage can conflict with systems that display damage.

• (Unit-type of (Attacked unit)) Equal to |cff995500Spelltester|r

You should make that more configurable

Very simple stuff here, but nothing is wrong with that.
Judging from the triggers I give you 4/5

 

[Adiktuz]

You are leaking lots of locations [Position of blahblah]...

btw, since I cannot test it out yet, why does the arcane bolt spell need the unit to have the silence buff? I'm asking because it wasn't said in the spell description that it can only hit silenced units...

as for GLOBAL SILENCE, why not just make a very huge silence spell and make some dummies cast it? using soul burn can cause annoying things when someone who uses this uses a damage detection system... also, using a very big silence spell can reduce the number of dummies you need to create per cast... if the AOE has a limit, then you can compute the needed number of dummies based on the map's size and position them accordingly...

 

[Magtheridon96]

Ok, Here's a full review:

SilenceBolt Trigger:

• You need to use variables to store things like (Last created unit), (Target unit of ability being cast), etc.. Basically, anything that you repeat. It's more efficient to store them in variables rather than to re-call the same functions again and again and again.
• The presentation is pretty neat.
• You have 1 leak: (Position of (Target unit of ability being cast)). To clear this leak, you need to store it in a variable, use that variable, and call RemoveLocation(udg_LOCATION_VARIABLE_NAME) in Custom script.
• (Last created floating text), (Level of ability ...) and (Triggering unit) could be cached in variables as well.

ArcaneBlast:

• In the beginning of this trigger, you should cache the triggering unit, the level of the ability and the triggering player.
• Inside the loop, you should cache the last created unit.
• You have 0 leaks.

ShockAura:

• ((Unit-type of (Attacked unit)) Equal to |cff995500Spelltester|r) -> You should change this condition to check if the level of the ability for the attacked unit is greater than 0.
• Instead of using Conditions, you could use an If/then/else block. It's more efficient.
• You should cache the Attacking unit, the attacked unit, the level of the ability, etc...
• Inside the loop, you should cache the last created floating text and the last created unit.
• (Position of (Attacking unit)) -> This leaks. You should store it in a point variable and remove it after you're through with it.

GlobalSilence:

• The structure of this trigger is all wrong. You're silencing a unit X number of times where X is the number of units on the map. So if I have 50 units, each unit is going to be silenced 50 times. That's 2500 unit orders to 50 dummies. That's going to cause a lot of lag, and most of those orders might not even run. Warcraft III handles orders really badly; almost as badly as it handles unit pathing.
• (Position of (Picked unit)) leaks. It should be cached and removed afterwards.
• (Owner of (Triggering unit)) should be cached outside of the loop.
• You should use only one dummy for this spell. To achieve that, set the casting time of the silence spell to 0, the manacost to 0, the cooldown to 0, the casting animation time of the dummy to 0, the cast-backswing to 0, etc... This way, you'd have to create one dummy unit, give him the ability, set the level, and do this:
  
  Trigger

  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Matching unit) belongs to an enemy of OwnerTriggerUnit) Equal to True)) and do (Actions)
    • Loop - Actions
      • Unit - Order TempDummy to Neutral Fire Lord - Soul Burn (Picked unit)

  Where TempDummy is a unit variable you set to (Last created unit) after creating the dummy and OwnerTriggerUnit is set to (Triggering player).

Notes
- I would recommend reading this to learn more about leaks.
- I would also recommend making these spells more complex. Right now, they're extremely simple. That's not a bad thing though. If you fix all the problems I mentioned above, this will get a 4/5 from me. I love simple spells and systems.

 

[BieBerFanzz9GaGerS]

wow this spelll is so good imba

Edit: i think i'll use it for my map

 

[Adiktuz]

and maybe put those quotes inside hidden tags coz they make browsing thru the desc a bit long...

 

[BeTaGod-]

Well thank you all for you comments!

@Magtheridon96 Awesome!, i will solve everything you described in a few weeks (i have no internet at home at the moment!)

I will highly recommend not to download my spellpack yet, since it is in betav1.0 and there are a low of things to fix

EDIT: Spell updated. Try testing now guys! Remember it is simple yet usefull! I am still a noob

 

[Matarael]

Tagging because these sound good.

 

[AlienAtSystem]

Ok, Here's a full review:
GlobalSilence:

• You should use only one dummy for this spell. To achieve that, set the casting time of the silence spell to 0, the manacost to 0, the cooldown to 0, the casting animation time of the dummy to 0, the cast-backswing to 0, etc... This way, you'd have to create one dummy unit, give him the ability, set the level, and do this:
  
  Trigger

  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Matching unit) belongs to an enemy of OwnerTriggerUnit) Equal to True)) and do (Actions)
    • Loop - Actions
      • Unit - Order TempDummy to Neutral Fire Lord - Soul Burn (Picked unit)

  Where TempDummy is a unit variable you set to (Last created unit) after creating the dummy and OwnerTriggerUnit is set to (Triggering player).

Actually, that will not work, as the dummy would need sight to his target to do this. The solution mentioned before, using one dummy and the original Silence Ability with infinite AoE, should work best and requires less performance power. (Although the Spell will then still not work on magic immune units as Ultimates usually do, but that can't be corrected with GUI)

And you should mention that the Shock Aura should be used together with a Damage Detection System of choice, as "Unit is Attacked" triggers when the unit begins the Attack Animation, not when someone is actually hit. If someone order his unit to stop during the Animation, and then it attacks again, the effect will trigger anew, which is in this case of course not desirable, but if the Effect would be a life-leech, then it would mean that one can refill his life to full by spamming stop orders.

 

[Magtheridon96]

Then do this:

Trigger

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units in (Playable map area) matching (((Matching unit) belongs to an enemy of OwnerTriggerUnit) Equal to True)) and do (Actions)
  • Loop - Actions
    • Set TempUnit = (Picked unit)
    • Custom script: call SetUnitX(udg_TempDummy, GetUnitX(udg_TempUnit))
    • Custom script: call SetUnitY(udg_TempDummy, GetUnitY(udg_TempUnit))
    • -------- Or, do whatever the hell you want. Soul Burn might fire 0-damage events and shit. --------
    • Unit - Order TempDummy to Neutral Fire Lord - Soul Burn TempUnit

edit
I keep forgetting to mention how "A unit is attacked" is exploitable.
Use this: http://www.hiveworkshop.com/forums/spells-569/gui-damage-engine-201016/
It's an incredible Damage Engine that handles Damage blocking, healing, modifying and type-differentiation and detection.

 

[gorillabull]

why do people make these kinds of spells anymore