Fire Enchanment 1.5

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

Unit - Create 1 Missile | Fire Protes for (Owner of (Triggering unit)) at ((Position of (Triggering unit))

- Leaks a location. Also, use (Triggering player) instead of (Owner of (Triggering unit)) as it saves a step.

You leak 2 locations here:

Unit - Move FE_data_missile[((FE_TempIndex x 5) + (Integer B))] instantly to ((Position of FE_data_caster[FE_TempIndex]) offset by FE_data_distance[FE_TempIndex] towards (FE_data_angle[FE_TempIndex] + ((Real((Integer B))) x 72.00)) degrees)

You need bj_wantDestroyGroup = true before this line:

Unit Group - Pick every unit in (Units within 100.00 of (Position of FE_data_missile[((FE_TempIndex x 5) + (Integer B))]) matching ((((Matching unit) belongs to an enemy of (Owner of FE_data_caster[FE_TempIndex])) Equal to true) and (((Matching unit) is alive) Equal to true))) and do (Actions)

Unit - Create 1 Dummy for (Owner of FE_data_caster[FE_TempIndex]) at (Position of FE_data_missile[((FE_TempIndex x 5) + (Integer B))]) facing 0.00 degrees

- Leaks a location.

Maker, v1.5, 14.07.2011
You have lots of leaks. Point with polar offset uses two points. You must clear them both.

 

[Elvendan]

It is

[HIDDEN][/HIDDEN]

tag.

Use it.

 

[Nightmare Moon]

-your indexing system is kinda big;
-do not use integer A and B use custom variables as they are faster;
-why in a world would you use event like every (1/32)? just use 0.03;
-you really need to add documentation!;
-instead of For each (Integer B) from 0 to 4, do (Actions) use For each (Integer B) from 1 to 4, do (Actions);
-Unit - Create 1 Missile | Fire Protes for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by FE_data_distance[((FE_TempIndex x 5) + (Integer A))] towards (FE_data_angle[FE_TempIndex] + ((Real((Integer A))) x 72.00)) degrees) facing ((FE_data_angle[FE_TempIndex] + 90.00) + ((Real((Integer A))) x 72.00)) degrees - leaks a location;
-why you use this Set FE_TempCount = FE_active_count? it could be done without it;
- Unit - Move FE_data_missile[((FE_TempIndex x 5) + (Integer B))] instantly to ((Position of FE_data_caster[FE_TempIndex]) offset by FE_data_distance[FE_TempIndex] towards (FE_data_angle[FE_TempIndex] + ((Real((Integer B))) x 72.00)) degrees) leaks a location;
-Unitgroup - Pick every unit in (Units within 100.00 of (Position of FE_data_missile[((FE_TempIndex x 5) + (Integer B))]) matching ((((Matching unit) belongs to an enemy of (Owner of FE_data_caster[FE_TempIndex])) equal to True) and (((Matching unit) is alive) equal to True))) and do (Actions) unit group leaks as a point in too;
-in same group you should also check if picked unit isn't a structure and belong to an enemy of caster;
-Unit - Create 1 Dummy for (Owner of FE_data_caster[FE_TempIndex]) at (Position of FE_data_missile[((FE_TempIndex x 5) + (Integer B))]) facing 0.00 degrees leaks a location.

Think that is all... Improve it

 

[SharDamaKa]

@Elvendan... I tested I wrote

Hidden

didn´t work

 

[Nightmare Moon]

It must be like this:

Option

text here[/hіdden]
example:

Option

Text Here

Edit: @Elvendan, it doesn't matter what letters you use, meters the code for BB-Code.
List of [self="http://www.hiveworkshop.com/forums/misc.php?do=bbcode"]BB Codes[/self]

 

[Elvendan]

Use only CAPITAL or only lowercase letters.

 

[SharDamaKa]

OK thanks... I´ve updated it now

 

[Marcos DAB]

Seems pretty good.

 

[SharDamaKa]

Ok guys now I need help... when I want to make the missiles location into a variable I can´t remove the location with a custom script because of the:

Trigger

• Example - (Position of FE_data_missile[((FE_TempIndex x 5) + (Integer B))])

I dont now the part:

Part

• x 5) + (Integer B))])

Thx for help