Apus v.1.5

[Moderator]

IcemanBo: Approved

Older

IcemanBo: http://www.hiveworkshop.com/forums/spells-569/apus-v-1-3-a-259771/index2.html#post2654713

IcemanBo: http://www.hiveworkshop.com/forums/spells-569/apus-v-1-2-a-259771/#post2639396

IcemanBo: http://www.hiveworkshop.com/forums/2639271-post9.html

02:30, 10th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/spells-569/apus-v-1-0-a-259771/#post2638282

 

[axator]

All ideas for improvement are welcome.
Please rate and comment.

 

[Sprite]

Cool spell 5/5

 

[IcemanBo]

• Set A_Group[Index[1]] = (Random 0 units from (Units in (Playable map area)))

^Use custom script and CreateGroup() over this.

The unit's movement looks very unnatural. It should be improved.
It sticks to the hero like a bubble gum, it looks really weird. The following behaviour should be more intuitive.
You should let a tolerance distance for example.
The movement animations looks not smooth.

When the Apus uses spells he should make some animation, that indicates it for example.
At the moment the spell just occurs, but you can't clearly notice that the source is the Apus.

Don't make the Max/Current index variables be an array. It gets unreadable.

Use the normal function in GUI to check if a unit is dead.

Check to turn off loops should be done onDeindex.

A tooltip is needed. Add a decent description.

Reals don't need to be nulled.

It would be cool if the different Apus would have diffent scale/colour for example for each level, so you can differ them.

• ((Execution count of (This trigger)) mod 20) Equal to 0

^I'm sure you can find a smarter way to solve this.

The idea of such a helper creep is good. But it needs some work to do, for example the weird movement.

Needs Fix

 

[ukn0wnD3str0y3r]

Cool ideas *-*

 

[axator]

Wow I didn't expect to receive any feedback after all this time Thanks for that.
Have you got any idea how to copy triggers translated? I'm using Polish version of world editor and I have to translate every GUI action into english. That makes my update really long.

Don't make the Max/Current index variables be an array. It gets unreadable.

Reals don't need to be nulled.

I made them an arrays because I'm making all spells using only 2 Index variables: Index and Loop Index. Every spell has its own array index in index so i don't have to create new variables for indexes.
If I don't null them, when all instances of spell are finished, then new instance has those reals copied from previous instance. Apus created in new instance might have higher movement speed than expected.

 

[IcemanBo]

No, I don't know sorry. You could ask someone with an english editor to open your map and just send you the english code, so you can post it.

I even would do it by myself, but I do not have the english version, too.

 

[axator]

Well, the map file is updated, but not the main post. That may take a while

Edit: Updated

 

[IcemanBo]

Change this:

Custom script: set udg_A_Group[udg_A_Index] = CreateGroup()

into this ->

Custom script: if udg_A_Group[udg_A_Index] == null then Custom script: set udg_A_Group[udg_A_Index] = CreateGroup() Custom script: endif

to prevent leak.

For deindex in loop, just check "caster[index] is dead == ture Or time < 0". Will be enough. And first check won't be needed then if caster is dead.

Remove Apus onDeindex, or set it's death type to "can't raise, won't decay" in object editor.

onDeindex you forgot about the dummy.
onDeindex you forgot all the spell variable arrays. (flame strike variables, stomp)
onDeindex you have to null all units and the group of MaxIndex.

When Apus is close caster you keep forcing to play the stand animation:

Animation - Play A_Apus[A_LoopIndex]'s stand animation

This makes the stand look a bit unnatural. (at least I think so )
You could try following instead, it might look smoother:

Animation - Queue A_Apus[A_LoopIndex]'s stand animation

Set TempPoint4 = (TempPoint3 offset by (300.00 x A_LoopTime) towards (Angle from TempPoint3 to TempPoint2) degrees)

^Why do you makke the offset depend on the looptime?

onAttack "AttackedUnit" and "AttackingUnit" should be stored into temp variables.

Instead of using modulo, you always could reset the counter? Not?

You should try with looptime 0.03 instead of 0.02. It's the recommended time for movement systems.

Needs Fix

Edit:

If you have to translate each single trigger into english, you don't have to bother to keep the code up to date until approval.
It will be ok for me to check the triggers in map. So it saves you some work.
But once it gets approved, there should be the newest code in description.

If you accept this, then please at least mark that the triggers in description are not up to date.

 

[axator]

When Apus is close caster you keep forcing to play the stand animation:

Animation - Play A_Apus[A_LoopIndex]'s stand animation

This makes the stand look a bit unnatural. (at least I think so )
You could try following instead, it might look smoother:

Animation - Queue A_Apus[A_LoopIndex]'s stand animation

That's a good idea Unfortunately it doesn't work for walk animation, becauce in forcing him to walk the same way.

Set TempPoint4 = (TempPoint3 offset by (300.00 x A_LoopTime) towards (Angle from TempPoint3 to TempPoint2) degrees)

^Why do you makke the offset depend on the looptime?

It's easier to see his real movement speed per second. He move 300.00 x 0.05 per 0.05 seconds, so 300 units per second.

Edit:

If you have to translate each single trigger into english, you don't have to bother to keep the code up to date until approval.
It will be ok for me to check the triggers in map. So it saves you some work.
But once it gets approved, there should be the newest code in description.

If you accept this, then please at least mark that the triggers in description are not up to date.

Thank you for that, that is making things easier

Edit:
Updated.
Thank you for your feedback

 

[IcemanBo]

Don't use default peasant as dummy unit. Create a new dummy unit. (You can't ensure user didn't modify the default one.)

Immediatly deindex if caster is dead.
Currently "ApusShadow" must be dead, too. In my understanding this is not wanted, or am I wrong?
If caster is dead, and "ApusShadow" alive, you still want to do further operations?

onDeindex you null now all units and the group. But you use the wrong index.
You have to null the variable[maxIndex] not variable[currentIndex] after you copied the data. Otherwise it doesn't make sense.

Are these imports really needed? It's always better to have as less imports as possible, or none at all.
If you think you can, then you should make them optional. (you still can recommend them here on hive in your description)

Needs Fix

 

[axator]

I found a bug, when ApusShadow is alive and Apus timer expires. Instance is finished but ApusShadow is still alive, not removed. That's just to prevent that bug. Even if caster is dead, spell will last up to 1.4 more seconds before ApusShadow die. Then he dies and instance is finished. Look that ApusShadow not equal to Apus. ApusShadow is the red one while casting FlameStrike.

 

[IcemanBo]

You could check onDeindex if ApusShadow is alive.If true, you can do certain actions like removing it properly.

 

[axator]

But ApusShadow is removed while FlameStrike ends. If I remove him onDeindex FlameStrike will not be finished.
Updated.

 

[IcemanBo]

Hm, have you changed something with the movement behaviour? It does seem to have problems with followting the hero.
It prefers to fight enemies now, instead of staying close next to caster.

When you change the unit's size only the first only the first argument matters. You can let the others "0": SetSize(size, 0, 0)

In demo map my FPS tempory decreased to ~15 when fighting. Is it only me who has problems/lags with it?

Edit: The tooltip seems too long and is not well structured. You should try to keep only the most important.

 

[axator]

I havent noticed and problems with following the hero. Apus now do not go directly towards caster position, it goes to position behind caster. It looks more smooth now. Same as activating, deactivating movement happens while caster is too far from Apus.

I had no FPS drop like you. It was about 60 whole the time.

Have you downloaded the latest version I uploaded?

 

[IcemanBo]

^Yes.
_________

• In main loop don't do any further operations if you deindex.
  You get this done by putting the other block into the "Else - Actions" part. (since deindex is in "Then - Actions" part)
  Else you do the actions twice for one instance. Though it is possible.
• Also in main loop, in your damage part. Only damage, slow, and create the effect above a target if it's not dead and is in range.
  Currently you filter these kind of units and remove them from group, but still do named operations to it.
• I see your point with casting FlameStrike. So you have to find a solution.
  Hm, but definitly ignore further operations that belong to caster or damaging nearby units if caster is dead.
  Still you may wait until the shadow unit finished his spell if you want, until you completly deindex.
  Better way would to make them more independant from each other, but it would take much more restructering.
  

 

[axator]

Updated. Applied your suggestions.

^Yes.
_________

I see your point with casting FlameStrike. So you have to find a solution.
Hm, but definitly ignore further operations that belong to caster or damaging nearby units if caster is dead.
Still you may wait until the shadow unit finished his spell if you want, until you completly deindex.
Better way would to make them more independant from each other, but it would take much more restructering.

Sorry, what solution am I looking for? Is it a bad idea to deindex when Shadow is dead?

 

[IcemanBo]

Is it a bad idea to deindex when Shadow is dead?

No, it's good and correct.

• Custom script: call SetUnitAnimationByIndex(udg_A_ApusShadow[udg_A_LoopIndex], 8)

^Could you put the integer "8" into a variable? If user changes the unit type, he might need change the index as well.

I saw for example "peasant" variable without any prefix. It's tiny work, but please also use the same prefix for all your variables that you need.

 

[axator]

I think this really small updeate doesn't need to be a new version
Temporary variables don't need prefix at all, do they?

 

[IcemanBo]

It might be nitpicking, but if unit type is configurable and animation index is hardcoded it's definitly a mistake in coding.
It's even very quick to fix. Don't be lazy also in small updates.

Well for variables... just use the prefix for all variables that are used by your system. For testmap doesn't matter.

 

[axator]

Should be ok now
Update: removed text message, didn't realise i forgot to remove it

 

[IcemanBo]

I would work on tooltip if I was you. It's too long, and should be reduced to most important.
Please also note to import dummy unit. I know you will do it.

Edit:

I updated your triggers in description. You don't need to bother with translating.
edo494 was so friendly and provided the english bb code for it.

 

[axator]

Thank you both I'm so excited

Test map has a tooltip how to import. Added the same tooltip in the first post.
Description is a little shorter. In my opinion these information are the most important so the user knows how this spell works

 

[jonbon29]

This is completely awesome dude.