Freezing Bow v. 1.5

[Moderator]

08:05, 26th Jul 2013
Magtheridon96: Approved.

 

[Wrda]

Insane spell! The effect should be configurable too. + rep

 

[T. D. W.]

Thanks, for the effects, i thought of making them configurable, but then i thought.. Why hell do people need to change the effects lol, they want the spell or another one?
Any way, i usually upload the basic version, which is not very important, like i plan to add more cool stuff to that one...

 

[Maker]

(Ability being cast) Equal to Freezing Bow
^Use the variable

 

[T. D. W.]

Oh shit, i forgot :/, tomorow cuz it's too late now for me, btw, maker, the pending spells are a bit "too much" now, u should reduce that

 

[deathismyfriend]

switch these around and use the variable for picked unit in the other one.

• Set Key = (Key (Picked unit))
• Set Unit = (Picked unit)

 

[Almia]

@dimf
Just a note.
If you are suggesting that changes, please make sure to notify users to use this:
set udg_SomeKey = GetHandleId(udg_SomeUnit)

 

[deathismyfriend]

@dimf
Just a note.
If you are suggesting that changes, please make sure to notify users to use this:
set udg_SomeKey = GetHandleId(udg_SomeUnit)

the only time they have to use that is if they are using JNGP.

try to copy his triggers into ur JNGP and they will work fine even if u cant edit them without changing it to custom script

 

[Almia]

That's JNGP bro
Some modders doesn't have any JNGP

 

[T. D. W.]

@dimf
:/ u always catch up somethin wrong in my triggers :\ Lol

 

[Almia]

Review:
1) Needs documentation
2) at cast trigger, you must cache Default Flying Height of blah blah and use it in the parameters.
3)Cache Last created unit
4)If you are going to use keys, you can just use this method:

Set MyUnit = someUnit Custom script : set udg_MyKey = GetHandleId(udg_MyUnit)

Because this reduces repetitive calls of functions.
5) The special effect models in the Loop trigger must be configurable.
6) To add readability in filtering units in Unit Group enumerations, you can just put them inside the Pick Every Unit block.

 

[T. D. W.]

2) at cast trigger, you must cache Default Flying Height of blah blah and use it in the parameters.

Why?

6) To add readability in filtering units in Unit Group enumerations, you can just put them inside the Pick Every Unit block.

Explain... i did not understand anything

 

[T. D. W.]

Update
*Fixed the Ability Condition which didn't use the variable ability
*Changed the Key set to GetHandleId()
*Added the Possibility of choosing whether the Spell is Point Target or Unit Target

Hidden

Double Post Reason: Update

 

[Almia]

2) Speed.
6) like this:

Pick every unit in Blah blah Set myUnit = Picked Unit If - Multiple Conditions -- Condition Else - Multiple Actions -- Actions

 

[T. D. W.]

2) Speed.
6) like this:

Pick every unit in Blah blah Set myUnit = Picked Unit If - Multiple Conditions -- Condition Else - Multiple Actions -- Actions

2- yh, possible
6- nah ;p

 

[Almia]

Readability is a must bro. It is in the rules.

 

[T. D. W.]

Update
*Made the Point/Unit Target system automatic instead of being set in the initialization
*Now Point Target spell deals the primary damage in 100 AoE
*Minor trigger lines changes

@Almia
i'll stop arguing after this:

If this kind of thing is very "READABLE" than my name is not Jad

it may seem weird, but there is no real need of splitting all the conditions :/ same result, you want it to be configurable? yh... wait further versions.. there will be booleans that will check if u want dis or dis

and just a little final:
+SWAG Mago

 

[Daffa]

The loop is pretty big :O
Btw, nice one.

 

[Doomlord]

@Almia
i'll stop arguing after this:

If this kind of thing is very "READABLE" than my name is not Jad

it may seem weird, but there is no real need of splitting all the conditions :/ same result, you want it to be configurable? yh... wait further versions.. there will be booleans that will check if u want dis or dis.

Funny how TESH made the sentence really readable

Anyway, Almia is right about this. By splitting the condition, the users can easily configure the type of target they want. The effort spent is minor but the achieved result is commendable. Compare:

Example

• Set TempGroup = (Units within 512.00 of (Center of (Playable map area)) matching ((((Triggering unit) is alive) Equal to True) and ((((Triggering unit) sleeps when unprovoked) Equal to True) and ((((Triggering unit) belongs to an enemy of Player 1 (Red)) Equal to True) and (

and

• Set TempGroup = (Units within 512.00 of (Center of (Playable map area)))
• Unit Group - Pick every unit in TempGroup and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is A structure) Equal to True
        • ((Picked unit) is alive) Equal to True
        • ((Picked unit) is A structure) Equal to False
        • ((Picked unit) sleeps when unprovoked at night) Equal to True
        • ((Picked unit) belongs to an enemy of Player 1 (Red)) Equal to True
      • Then - Actions
      • Else - Actions

Off-topic: O the horrible stretching!

 

[T. D. W.]

@daffa
There are some other spells which trigger (not trigger's') is about 3x the loop trigger here it is a bit big because the system destroys the projectile if the target dies and because the system of the spell supports both unit and ground target

@doomlord
Yh i guess it will be for next time

 

[deathismyfriend]

@Doomlord
u call picked unit a lot in here.
u should store it into a temp variable

• ((Picked unit) is A structure) Equal to True
• ((Picked unit) is alive) Equal to True
• ((Picked unit) is A structure) Equal to False
• ((Picked unit) sleeps when unprovoked at night) Equal to True
• ((Picked unit) belongs to an enemy of Player 1 (Red)) Equal to True

 

[Doomlord]

It is funny how example code have to be judged so harshly.

Yes I am perfectly aware of that. But it is just an example to support Almia' point. I am not even phrasing it as "what you should copy from".

On a side note, I don't even intend to post here. Just feel like dropping by to say a few words. I normally avoid touching GUI spells.

 

[deathismyfriend]

lol i believe any code posted should be efficient as to not confuse ppl.

also can u plz hide the one post above it is stretching my page.

 

[Doomlord]

Thanks. This will serve as a reminder for me not to touch GUI codes again.

Points to be presented:

• The OP is not a GUI newbie.
• I am posting an EXAMPLE code. The obvious purpose of which is to clarify a valid argument made by Almia but valiantly defied by DotCa.
• I didn't include any kind of "Hey please follow my GUI code because I have high rep blah blah blah"

I believe not even the mods post efficient example code unless it is relevant to what they are trying to say.

We should agree to disagree here. Really.

 

[deathismyfriend]

im not sure if they do but at least note that its not efficient lol

 

[T. D. W.]

Update
*Now you can choose whether the arrows will split randomly or not
*Now if an arrow's unit target is dead before the arrow hits him, instead of just killing the arrow, the arrow will split in it's place
*Made the Picking Units more "readable"
*Some Trigger Fixes

 

[Almia]

In the cast trigger, cache first the Target Unit then use it inside the parameters(you are cacheing it after using Target Unit )
Also, create first the dummy, so that you can combine the two ifs.

Also, you didn't view my suggestion about keys. Use GetHandleId instead so you won't call Key Last Created Unit over and over again.

Cache Current Flying Height of Unit inside a variable

 

[T. D. W.]

In the cast trigger, cache first the Target Unit then use it inside the parameters(you are cacheing it after using Target Unit )

Yh, ok

Also, create first the dummy, so that you can combine the two ifs.

ok, too

Also, you didn't view my suggestion about keys. Use GetHandleId instead so you won't call Key Last Created Unit over and over again.

I did, look in the loop trigger
in the cast trigger... it wasn't so necessary :/

Cache Current Flying Height of Unit inside a variable

Hell why, i only use it once... why caching it ://

 

[Almia]

I did, look in the loop trigger
in the cast trigger... it wasn't so necessary :/

Really? Then look at the cast trigger.

Hell why, i only use it once... why caching it ://

Read the Loop trigger again.


Bro, please view your triggers so that you can optimize it more

 

[Maker]

This should not be checked 33 times per second: (FB_Group is empty) Equal to True

 

[T. D. W.]

This should not be checked 33 times per second: (FB_Group is empty) Equal to True

Then what should we do?

EDIT: you mean it should be moved to somewhere else like when i remove a unit from the group?

@Almia
Updated and fixed what u said

 

[Forsaken]

Wow, nice spell, but i have seen that the dark ranger can use the spell in all the map, she just stands there and can shoot the whole map
+ rep

 

[T. D. W.]

Wow, nice spell, but i have seen that the dark ranger can use the spell in all the map, she just stands there and can shoot the whole map
+ rep

Thanks, it's a test spell, you can change the cast range in the ability's data

 

[Oljin]

really nice spell! i like the possibility to change between unit and point target, although i used only one of it (because of balancing for my game). But else, really nice and original!