Mystic Wolf 1.5

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

13:56, 21st Mar 2010
TriggerHappy:

Don't use locations.
Indent!
Waits..?

Basically all the same problems as your other spell(s). I highly suggest getting code help before submitting any spells (or updating them).

 

[krisserz]

function Mana_Timer_Conditions takes nothing returns boolean

Can be constant

exitwhen GetUnitState(x , UNIT_STATE_MANA) <= 0   // if his mana is 0 or less, the unit dies.
exitwhen GetUnitState(y, UNIT_STATE_LIFE) <= 0  // if the unit dies, the spell ends.

Can be split to

exitwhen GetUnitState(y, UNIT_STATE_LIFE) <= 0 or GetUnitState(x , UNIT_STATE_MANA) <= 0

And should be at the beginning of if.

if rnd <= chance and special == true then
set mps = mps + mps_rnd
set y = CreateUnitAtLoc(xo , d4 , l , 0.00)  // We have a chance of 25% to summon a special Wolf.
else
if lvl == 1 then
set y = CreateUnitAtLoc(xo , d1 , l , 0.00)  // we create our unit.
endif
if lvl == 2 then
set y = CreateUnitAtLoc(xo , d2 , l , 0.00)  // we create our unit.
endif
if lvl == 3 then
set y = CreateUnitAtLoc(xo , d3 , l , 0.00)  // we create our unit.
endif
endif

You can put it in other func, which will check the taking integer lvl and return the right RawCode which you will use to create unit.

And don`t use TSA.

Sorry but didn`t have time to write/check more.

 

[Ironside]

Well I'll fix these things, but if I remove TSA then there will be no delay, and the cast would lose all mana instantly...

I can't put it in other function either, because that would ruin my MUI.

 

[krisserz]

The you must find another way to make it MUI like using hashtables in JASS since it`s in JASS and it wouldn`t be good idea to mix it with vJASS codes like TimerUtils.

 

[War_Golum]

good idea, I think it will be approve, with improvements

 

[watermelon_1234]

Note that I have only checked the code.

The spell is rather simple and would have been done better if it was coded in vJass. (It's easier to make it MUI)

Avoid using locations like GetSpellTargetLoc(), use coordinates like GetSpellTargetX() and GetSpellTargetY()

Follow krisserz's suggestion except use GetWidgetLife(y) < 0.405[icode=jass] Name the variables better. (Using x for the caster unit and y for the summoned unit is too confusing.) It would have been much easier and better to make the dummy units' id an array. I also think they should be called Summoned Unit instead of Dummy Unit. You should indent your coding. (It makes it easier to read.) Shouldn't the wolf get killed when the caster dies since it's living off the caster's mana?

 

[Ironside]

Well thanks for the comments:

1st I can't use X and Y because it's to confusing for me, same goes for vJASS MUI making (hashtables and scopes and that stuff)

And how do I make the dummies in a Array? Can locals be arrays?

Well now that I'm home, I'll do my homework, then update this.

EDIT: Fixed/Added all of the suggestions that I knew how to make, the rest I coulden't, since I don't know how...

 

[Catch_ya]

1st I can't use X and Y because it's to confusing for me

Maybe you didn't know this. A Warcraft III map is a big coordinate system. a 32x32 got like 3500x3500 coordinates. You learn about coordinate systems in 7th grade (if I'm not wrong). Also if you still don't want to use coordinates then this should be in GUI.

 

[krisserz]

And how do I make the dummies in a Array? Can locals be arrays?

What he meant is

local integer array d   // We create integer variable with an array
set d[1]='n001'                                      // This one will be created if level==1 (as you see in [])
set d[2]='n000'                                      // This one will be created if level==2 (as you see in [])
set d[3]='n002'                                      // This one will be created if level==3 (as you see in [])
set d[4]='n003'                                      // This is the RawCode of special
// As you see it`s not looking good so far, but later instead of making long if/then/else you can create one simple which will check if the created unit is special then you will do such an action:
set y = CreateUnitAtLoc (xo, d[4], l, 0.)
// If not then you can do just one simple call:
set y = CreateUnitAtLoc (xo, d[lvl], l, 0.)
// This will work for each lvl

And one more thing:
Why lvl is real? Change it to integer.

 

[Ironside]

Yeah I didn't know locals can be arrays, thought only globals can be. Thank you +rep

EDIT: Updated: changed the code to krisserz suggestion

 

[Klingo]

I don't know if this bug was mentionned before but i found a bug , i tried to cast it realy fast in a row and after certain time , wolves was dying right when they are summoned...I was like , why the hell i summoned a dead wolf...

 

[Ironside]

Because you had 0 mana. The more you have, the more mana it drains, so I guess you summoned so much wolves that in the time you summoned them you drained all mana.

If you want to test if it's really a bug, then set the variable mps and mps_rnd to 0.

EDIT: I have a question on which I hope someone can answer:

I'm using this: GetUnitState(y, UNIT_STATE_LIFE) < 0.405
But, I'd like to use IsUnitAlive, but I only have IsUnitAliveBJ? Wasn't there 1 without the BJ?

 

[Lambdadelta]

It's UnitAlive....

native UnitAlive takes unit u returns boolean

(off the top of my head)

 

[Ironside]

Ohh, ok thank you. I'll use it asap

EDIT: Wtf, It doesn't seem to be it, it isn't in the function list :O

 

[Klingo]

Because you had 0 mana. The more you have, the more mana it drains, so I guess you summoned so much wolves that in the time you summoned them you drained all mana.

If you want to test if it's really a bug, then set the variable mps and mps_rnd to 0.

EDIT: I have a question on which I hope someone can answer:

I'm using this: GetUnitState(y, UNIT_STATE_LIFE) < 0.405
But, I'd like to use IsUnitAlive, but I only have IsUnitAliveBJ? Wasn't there 1 without the BJ?

well , my bad then...

 

[Ironside]

As said, it could be a bug, but I guessed that it could have been what I described, so no need to apologize.

 

[watermelon_1234]

It's UnitAlive....

native UnitAlive takes unit u returns boolean

(off the top of my head)

You'll need to declare it like that at the top of your code. You need to have Jass New Gen Pack/jasshelper to use it.

 

[Ironside]

Ok what's wrong with my editor, it still doesn't work :S

 

[watermelon_1234]

Ok what's wrong with my editor, it still doesn't work :S

If you're using the regular World Editor, doing that won't work.
You'll need to use JassHelper which can be easily set up with Jass NewGen Pack

 

[Ironside]

I have JNGP. And I'm using it, with JassHelper enabled.

 

[krisserz]

But do you have lastest jass helper version?

 

[Ironside]

I think I have...

EDIT: Well I got it to work now somehow...

Now I released new version (1.4), now the spell is vJASS, it also uses SimError Library. Now when you cast with 0 mana you get a error saying "Not enough mana" , also added a boolean txt which if true it will debug messeges on how the spell ended (dummy death, caster death or no mana)
Also I put the code in a Scope so all functions are private.

 

[baassee]

dunno if you fixed it with the TSA's but I think you want a timer like check ( didnt check every single comment properly )

but if you need a timer, use Vex's Utils (as it is standard, also if you make your own, mods will be mad)

 

[Ironside]

It's hard, I really can't remove the TSA and use timers, since it will ruin my MUI... If this is MUI it might get approved, if it's not, then it won't...

 

[baassee]

I bet you use the TSA as intervals right? Why not a timer?

 

[Ironside]

Because a timer needs a new function for actions that happen after it, and I'm using locals, and locals can't be used in any function other than the one created...

 

[baassee]

right totally forgot about that soz :/

 

[jms]

Omg !!!!!! AAAAAAA !!! horrible code !!! what are you even doing here ? :O