[JASS] Mystic Storm v1.1i

[Moderator]

A fine spell that performs ok.

Suggested changes:

• Use only one dummy unit type
• Merge the preload trigger with the spell trigger
• You're using a variable named bool. Bool is a keyword, use some other name
• IsUnitEnemy(u, GetOwningPlayer(caster)) == true
  ->
  IsUnitEnemy(u, GetOwningPlayer(caster))
• The lightning's starting point could have a bit less z offset

 

[Almia]

Abilities should be configurable.
values like this
I2R(level1*1+level2*10+level3*100)
should be configurable
functions must have prefixes
Attack Type and Damage type should be configurable.
Indention is wrong

 

[Doomlord]

There may be some misunderstandings here. That function is used to reduce armor so it is non-customizable. And what do you mean by prefixes?

And yeah I forgot to include how to change the Attack and Damage type. I am also at a loss about indention. Can you show me how to do it properly? I will update the spell later.

 

[Almia]

Prefixes?Oh my.
Those are words before their actual names.
Like:
MYPrefix_MyFunction

 

[Doomlord]

Prefixes?Oh my.
Those are words before their actual names.
Like:
MYPrefix_MyFunction

Uhm, what is the point of having those prefixes From my own perspective I reckon that my function names are already obvious enough.

About the indention, how to fix it? I looked around quite a bit but I still can't find anything.

 

[Almia]

Because you are using pure JASS,you must put it.
JASS doesnt have any private members so the only way it wont collide w/ other functions that has the same function names is to put prefixes

 

[Doomlord]

Because you are using pure JASS,you must put it.
JASS doesnt have any private members so the only way it wont collide w/ other functions that has the same function names is to put prefixes

Ah thanks very much for the enlightenment. Spell updated as recommended.

 

[Losam]

By using the vJass?
In My World Edit does not work (mostly).

 

[Doomlord]

I think that pure JASS is more versatile because it can be used in maps and campaigns alike. It is just my idea though.

EDIT: Just realized that my code doesn't follow the JESP standard. Not one single bit that is. I will re-upload the spell later. I see what you mean now Radamantus, thanks.

 

[Losam]

I do not like this type of format (sometimes errors occur on my map), but I think you use the right format you want.

 

[Doomlord]

Spell updated in compliance with the sacred JESP standard. All stats are now customizable too

 

[Almia]

Review #2
1)Use levels for minus armor ability so it wont have too much abilities.
2)you dont need to have a function to represent the hashtable.
3)reduct the function name lengths.
Did you know?It takes time for the computer to interpret the name of a function??so the longer the function name is,the slower it will be interpreted.
4)You can cache this:
IsUnitEnemy(u, GetOwningPlayer(caster)) == true and GetWidgetLife(u) > 0.405 and GetUnitAbilityLevel(u, 'Avul') == 0 and IsUnitType (u, UNIT_TYPE_MAGIC_IMMUNE) == false and IsUnitVisible(u, GetOwningPlayer(caster)) == true
in a local boolean,so you wont write it again.
5)Indention is a bit messy.You have a block w/ 5 spaces,w/c should be 4.
6)call UnitDamageTarget(caster, target, dmg, true, false, Mystic_Storm_AttackType(), Mystic_Storm_DamageType(), Mystic_Storm_WeaponType())
I think the two booleans should be false.Also,we dont need weapontypes.


That's all i can see. Good Job!

 

[Doomlord]

Review #2
1)Use levels for minus armor ability so it wont have too much abilities.
2)you dont need to have a function to represent the hashtable.
3)reduct the function name lengths.
Did you know?It takes time for the computer to interpret the name of a function??so the longer the function name is,the slower it will be interpreted.
4)You can cache this:
IsUnitEnemy(u, GetOwningPlayer(caster)) == true and GetWidgetLife(u) > 0.405 and GetUnitAbilityLevel(u, 'Avul') == 0 and IsUnitType (u, UNIT_TYPE_MAGIC_IMMUNE) == false and IsUnitVisible(u, GetOwningPlayer(caster)) == true
in a local boolean,so you wont write it again.
5)Indention is a bit messy.You have a block w/ 5 spaces,w/c should be 4.
6)call UnitDamageTarget(caster, target, dmg, true, false, Mystic_Storm_AttackType(), Mystic_Storm_DamageType(), Mystic_Storm_WeaponType())
I think the two booleans should be false.Also,we dont need weapontypes.


That's all i can see. Good Job!

Thanks for the nice review. However, allow me to point a few things out

1/ It is a part of the system I learned from iAyanami. I don't know if there is a more effective way to do that and correct me if I am wrong but as far as I know loading a few abilities with 10 levels is still much faster than loading a single ability with 30+ levels or so.

2/ Well it won't hurt to leave it there right? People can just input the variable right there.

3/, 4/ and 5/ Ah yes. All shall be done. Currently I am updating the code

6/ Yeah well both boolean should be false then. And about the weapon type I think that it is just an optional thingy. Maybe some dude will want to have a heavy slice sound FX there =))

 

[iAyanami]

Thanks for the nice review. However, allow me to point a few things out

1/ It is a part of the system I learned from iAyanami. I don't know if there is a more effective way to do that and correct me if I am wrong but as far as I know loading a few abilities with 10 levels is still much faster than loading a single ability with 30+ levels or so.

There is a better way of doing this, which is using binary values. With 8 abilities, you'll can have up to 2^8-1 = 255 min and max armor values. Each ability would have 2 levels, one representing the positive value, and the other representing the negative value. Going with the 8 abilities example, you'll have:

1 2 4 8 16 32 64 128

These are basically binary values which are essentially powers of 2. Add up all that together, gives you maximum of 255 or minimum of -255.

 

[Doomlord]

There is a better way of doing this, which is using binary values. With 8 abilities, you'll can have up to 2^8-1 = 255 min and max armor values. Each ability would have 2 levels, one representing the positive value, and the other representing the negative value. Going with the 8 abilities example, you'll have:

1 2 4 8 16 32 64 128

These are basically binary values which are essentially powers of 2. Add up all that together, gives you maximum of 255 or minimum of -255.

How to do accomplish that then? Can you show me?

And btw thanks for your technique, it is splendid

 

[iAyanami]

How to do accomplish that then? Can you show me?

And btw thanks for your technique, it is splendid

Firstly, you need to know the concept of binaries (kinda). Are you familiar with it?

 

[Doomlord]

Firstly, you need to know the concept of binaries (kinda). Are you familiar with it?

Not one bit Explain it to me and I will try to understand.

 

[iAyanami]

Not one bit Explain it to me and I will try to understand.

Binaries are basically another way of representing numbers. Binaries only consists of 1's and 0's. For example:

1 = 1
2 = 10
4 = 100
8 = 1000
9 = 1001

It basically works with powers of 2. The right most digit is 2^0. Then the power increments by one as you traverse left. If that digit is a 1, you simply add that to the result. If it's a 0, you ignore it.

For example, take 9 (1001). The right most digit would be 2^0. Since the digit value is 1, you add it to the total. Current total would now be 0 + 2^0 = 1. Move on to the next left digit, which would be 2^1. Since the digit value is 0, you ignore it. Move on to the next left digit, which is 2^2. Again, digit value is 0, ignore it. Move on to the next left digit, which is 2^3. Since the digit value is 1 here, add it to the total. Total would be 1 + 2^3 = 8 = 9. Thus, 9 = 1001.

So applying this logic in WC3 is fairly simple. Each ability would represent one digit. Thus, with 8 abilities, the values would be: 1 2 4 8 16 32 64 128.

So let's say you need to apply an armor value of 22 to a unit. Following the 8 abilities example, you'll loop through 8 times, starting from the biggest value which is 128. So it will loop in this sequence 128->64->32->16->8->4->2->1. First, make a comparison so that the value (22) is bigger or equal to the current digit value, which is currently 128. Since 128 > 22, move on to the next digit. Since 64 > 22, move on to the next. Since 32 > 22, move on to the next. Since now the digit value (16) is less than the value (22), add the ability that gives the respective digit value bonus (16) to the unit. Take the value and minus away the digit value (22 - 16 = 4). Move on to the next digit. Digit (8) > value (4), thus move on. Digit (4) == value (4), thus add the ability that gives 4 armor, and perform the reduction (4 - 4 = 0). Since value is now 0, exit the whole loop. So you'll have a total of 16 + 4 armor, which nicely adds up to 22.

Take 71 as another example. Skips all the way until digit value is 64, since 64 < 71. Add ability that provides 64 armor, perform reduction (71 - 64 = 7). Skip all the way until digit value = 4. Add ability that provides 4 armor, perform reduction (7 - 4 = 3). Next digit value = 2, since 2 < 3, add ability that provides 2 armor, perform reduction (3 - 2 = 1). Next digit value = 1, since 1 == 1, add ability that provides 1 armor, perform reduction (1 - 1 = 0). That'll will total up to 64 + 4 + 2 + 1 = 71 armor.

 

[Doomlord]

Binaries are basically another way of representing numbers. Binaries only consists of 1's and 0's. For example:

1 = 1
2 = 10
4 = 100
8 = 1000
9 = 1001

It basically works with powers of 2. The right most digit is 2^0. Then the power increments by one as you traverse left. If that digit is a 1, you simply add that to the result. If it's a 0, you ignore it.

For example, take 9 (1001). The right most digit would be 2^0. Since the digit value is 1, you add it to the total. Current total would now be 0 + 2^0 = 1. Move on to the next left digit, which would be 2^1. Since the digit value is 0, you ignore it. Move on to the next left digit, which is 2^2. Again, digit value is 0, ignore it. Move on to the next left digit, which is 2^3. Since the digit value is 1 here, add it to the total. Total would be 1 + 2^3 = 8 = 9. Thus, 9 = 1001.

So applying this logic in WC3 is fairly simple. Each ability would represent one digit. Thus, with 8 abilities, the values would be: 1 2 4 8 16 32 64 128.

So let's say you need to apply an armor value of 22 to a unit. Following the 8 abilities example, you'll loop through 8 times, starting from the biggest value which is 128. So it will loop in this sequence 128->64->32->16->8->4->2->1. First, make a comparison so that the value (22) is bigger or equal to the current digit value, which is currently 128. Since 128 > 22, move on to the next digit. Since 64 > 22, move on to the next. Since 32 > 22, move on to the next. Since now the digit value (16) is less than the value (22), add the ability that gives the respective digit value bonus (16) to the unit. Take the value and minus away the digit value (22 - 16 = 4). Move on to the next digit. Digit (8) > value (4), thus move on. Digit (4) == value (4), thus add the ability that gives 4 armor, and perform the reduction (4 - 4 = 0). Since value is now 0, exit the whole loop. So you'll have a total of 16 + 4 armor, which nicely adds up to 22.

Take 71 as another example. Skips all the way until digit value is 64, since 64 < 71. Add ability that provides 64 armor, perform reduction (71 - 64 = 7). Skip all the way until digit value = 4. Add ability that provides 4 armor, perform reduction (7 - 4 = 3). Next digit value = 2, since 2 < 3, add ability that provides 2 armor, perform reduction (3 - 2 = 1). Next digit value = 1, since 1 == 1, add ability that provides 1 armor, perform reduction (1 - 1 = 0). That'll will total up to 64 + 4 + 2 + 1 = 71 armor.

Ah thanks very much I understood now. However would you be kind enough to show me an example JASS script on how to do that? I learned stuffs mostly through triggers

 

[doomhammer99]

Congratulations Brother

 

[Furiion52]

Well I reckon its brilliant The spell itself is very op which I don't mind The cloud effect is quite nice, perhaps slightly less flashes would be more realistic. And the effect and the end of the cloud is wow. It's like a star collapsing its soo good. You should probably make it slightly less op by reducing the amount of time it stays.
Very, very good spell.
4.9/5

 

[owwweeennn]

this is...
RAZOR's SPELL!!