Item Cleanup 1.3

[Moderator]

Very useful for getting rid of used tomes for example.

 

[Nestharus]

Good job Bribe =)



I think a Bounty retrieval resource and a Trade Event would also be very useful.

 

[Cihparg]

Ahem, the image does not seem to be correct.

 

[Bribe]

Screenshot updated. Not sure how the Damage Screenshot got there


@Nestharus, I will keep that in mind, if someone asks for a GUI way to detect that I might be more interested, but I'm trying to build the ones that mean the most to me first.

 

[defskull]

(Not even tested yet the map)

Does this map cleans up "leaked" tomes once per interval second ?

Then, what does this do ?

• Removing Tomes Leak
  • Events
    • Unit - A unit Sells an item (from shop)
  • Conditions
    • *Any Tomes Type You Want*
  • Actions
    • Wait 0.00 seconds
    • Item - Remove (Sold Item)

It is simple, yet works perfectly (and it is MUI)
I don't know what does the trigger above is difference between the ones you made it.

Just curious.

 

[Bribe]

Not all tomes come from shops - many are already in the map or are dropped by creeps. You also can't use a "unit uses item" event because then it won't clean up items that were killed some other way.

Waiting 0.00 seconds will not allow the tome's death animation to be displayed. You'd have to wait 1.5 seconds to complete it, but then the wait might be innaccurate and be less than 1.5 seconds. So you have to use a game-time wait (PolledWait) which causes handle leaks and is generally an ugly thing to be avoided.

In summary, this is the most leakless and functional approach.

 

[defskull]

So there is no difference in functionality, only difference in efficiency, just as I suspected
Thank you for clarifying this.

Also, you can pretty much add more Event than "A unit sells item..." Event, LOL
Acquires an item can work with "picking up tomes", is it ?

 

[Bribe]

There is a huge difference in functionality from what you said. Your script will cut off the item's death animation. If you change the wait to a game-time wait of 1.5 seconds you will then just create a leak for using that function at all.

There is no event "any item dies" either. This is the only way to do it properly.

 

[maddeem]

You could just pick all items in map every so often n do a item life comparison... xD

 

[Bribe]

You could just pick all items in map every so often n do a item life comparison... xD

How is that different from what I'm doing here?

 

[Magtheridon96]

Good Job Bribe
I'm changing that BoundSentinel script so that you can disable the system whenever you want ;D

 

[maddeem]

How is that different from what I'm doing here?

Ehh you have custom script in there, don't really understand it. Lol (Fail)

 

[defskull]

Wait, if Bribe is upload his own system who would certify his system to be approved or not ?
Maker ?

 

[Bribe]

Ehh you have custom script in there, don't really understand it. Lol (Fail)

Why do you need to understand it? It's just a simple program.

If you have any concerns about something I can clarify it for you.

Wait, if Bribe is upload his own system who would certify his system to be approved or not ?
Maker ?

Him or The_Reborn_Devil. Moderaters can not moderate their own stuff thankfully.

 

[xorkatoss]

awesome cleanup system dude!! 5/5

 

[defskull]

Him or The_Reborn_Devil. Moderaters can not moderate their own stuff thankfully.

Ohhh the irony, haha.

 

[Aeroblyctos]

Seems useful.

Probably gonna use this. I'll post some feedback after testing.

 

[Aeroblyctos]

Okay back from testing. I improved the testing map of yours and tested a little. I made a trigger that checks every second how many items there are in the map. When I acquire or destroy an item the counter won't decrease.

So, does your system really work?

I'm probably gonna use this system but I want first your explanation.

Map is attached to this post.

 

[Magtheridon96]

The system works perfectly.
It simply removes powerups so they don't leak

 

[.OmG.]

That's exactly what I want!
5/5

 

[Bribe]

Thank you for the testing - Tirlititi was right - you do need to set the item's life to 1
before removing, otherwise it can still be enumerated. What a glitch.

The demo map has been fixed now. I recommend anyone who uses this script to either
re-copy it or to manually change this:

• Item - Remove CleanedItem[Loop]
• Set CleanedItem[Loop] = No item

To this:

• Item - Set life of CleanedItem[Loop] to 1.00
• Item - Remove CleanedItem[Loop]
• Set CleanedItem[Loop] = No item

 

[Aeroblyctos]

Great. Now it seems to work. Thanks for the system, this might solve few problems I've in my project.

Rep + credits.

 

[Orcnet]

Thank you so much for this trigger, this can really help me and for those who uses tomes in game

 

[Bribe]

Updated to 1.2 which is more readable, should have slightly improved performance as well.

 

[aider]

I wasnt aware of this before I saw this thread, awesome! 5/5

 

[Kadabra]

Great system I like the way that the new moderators work here. I hope one day you can go as high in my eyes as My Guru

 

[GywGod133]

OH NC ITS USEFULL for my Map

 

[noob]

I do not remember well if item groups leaked or not but I fear that they leak and are not removable.

 

[tivrkoker]

Hi guys i need 1 little help I need to clean up map from items every X sec if number of items or items of type on map are >= X how can I do it using trigger?

 

[Ralle]

Hi guys i need 1 little help I need to clean up map from items every X sec if number of items or items of type on map are >= X how can I do it using trigger?

You are hijacking somebody else's thread. Please post a new thread in the World Editor Help Zone if you want an answer to this question.

 

[Bribe]

I do not remember well if item groups leaked or not but I fear that they leak and are not removable.

Sorry I did not see this until now. In case you or someone else is reading this, there is no such thing as an "item group". Picking all items/destructables/playing doodad animations does not leak as there are no handles being created to perform those actions.

 

[ILikeMacNCheeze]

This will solve those dead tomes and rumes, especially in Hero Arenas.
I'm about to create an Angel Arena with 24p with it.

 

[Bribe]

Update to 1.3 - this is completely optional to update to. I shortened and simplified the code quite a bit, and made it use two fewer variables. It now runs on one timer, every 15 seconds, but instead of setting a 1.5-second timer to remove those items, it just queues them up so that on the next 15-second interval, the items are cleaned up at that point.

Functionally, and implementation-wise, it works exactly the same as it did before. Users of version 1.3 can delete the variables "ItemCleanupFlag" and "ItemCleanupTimer" from your map.

 

[plumsy460]

Does exactly what it says. I'm using this in all my maps. 5/5

 

[3ICE]

This is great. I simplified it because hundreds of tomes get bought in my map each minute and the occasionally cut off animations don't matter as much to me.

• Remove Tomes
  • Events
    • Time - Every 3.33 seconds of game time
  • Conditions
  • Actions
    • -------- Used tomes' leftover corpses litter the ground... --------
    • -------- (This used to not be necessary in older versions of Warcraft.) --------
    • -------- Typical Blizzard breaking stuff... Now we have to clean up after them. --------
    • Item - Pick every item in (Playable map area) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Current life of (Picked item)) Equal to 0.00
          • Then - Actions
            • Item - Set life of (Picked item) to 1.00
            • Item - Remove (Picked item)

 

[Bribe]

This is great. I simplified it because hundreds of tomes get bought in my map each minute and the occasionally cut off animations don't matter as much to me.

• Remove Tomes
  • Events
    • Time - Every 3.33 seconds of game time
  • Conditions
  • Actions
    • -------- Used tomes' leftover corpses litter the ground... --------
    • -------- (This used to not be necessary in older versions of Warcraft.) --------
    • -------- Typical Blizzard breaking stuff... Now we have to clean up after them. --------
    • Item - Pick every item in (Playable map area) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Current life of (Picked item)) Equal to 0.00
          • Then - Actions
            • Item - Set life of (Picked item) to 1.00
            • Item - Remove (Picked item)

Yeah whatever works best for you. I would however still recommend allowing the animations to play, so in that regard I recommend using my library but only modifying the timer to a value no lower than 1.50 seconds.

 

[Ricola3D]

I had no idea that Power Up items were leaking, thanks dude !!

 

[MasterBlaster]

@Bribe I've recently started exploring some of your systems, dude, and I just want to say that I appreciate all the amazing work you did for this community! Stay awesome!

P.S. Obviously using this for my map experimentations

 

[Gnuoy]

thanks for posting this.

are pawned items considered dead?

 

[Bribe]

thanks for posting this.

are pawned items considered dead?

Those don’t stick around. Tomes were intentionally patched around 15-20 years ago to stick around permanently so as to leave an “indicator” to people exploring cleared creep camps on ladder as to what kind of item the opponent might’ve grabbed (it is why there is a death animation that is played when the fog of war unveils it).

 

[Gnuoy]

Thanks for info. Also, could I increase the periodic time to lessen the amount of triggers running? There are only a few powerups in this map but figured why not add this system.

 

[Bribe]

Thanks for info. Also, could I increase the periodic time to lessen the amount of triggers running? There are only a few powerups in this map but figured why not add this system.

Sure, it’s fine to change the time in the event to any time you want. Every minute or two is probably fine, I think I mainly set it to be this frequent because I wanted to make sure that the demo didn’t keep people too long to see how it works.

 

[hugope]

Hi. I think this system has become obsolete, but I may be wrong.

In the map I attached there are no triggers that remove items from the game, yet, they are removed automatically. The map is automated to do some tests to prove this.

Description of the automated tests the map do:
In the attached map, there is a hero and a goblin merchant. At map initialization, the current gold of the player who is testing the map is set to 1000000000, then the goblin merchant is selected for that player, and after approximately 5 seconds, the goblin merchant is removed from the selection of that player. While the goblin merchant is selected, the hero will buy 100 tomes per second.
There is a trigger that sends a text message every second, stating how many items are there in the playable map area. Some seconds after the last tome is bought, the trigger will state that there are 0 items in the playable map area, and there won't be any sign of leftover of the bought tomes. Afterwards, three items will be created near the hero, then, the hero will be ordered by triggers to attack them. Some seconds after the last item is destroyed, the trigger will state that there are 0 items in the playable map area.

 

[Bribe]

Run the demo map without item cleanup. These tomes are scattered about the map. If their icons linger, the items are still there.

It would be helpful to know which version you tested this on.

 

[hugope]

Hi, thank you for your answer. I tested that map ("Buy100TomesPerSecond.w3m") in version "1.36.1.20719".

I downloaded your map ("Item Cleanup (1).w3x") and deleted the trigger "Item Cleanup", then I clicked "Test Map". I consumed some tomes and pressed the key "ESC", the number 7 was printed. After some seconds I pressed the key ESC again. The number 1 was printed. I did this test in version "1.36.1.20719". I think this means the items are now removed automatically, so, there's no need for triggers to remove them anymore.



The map I attached in this post is your system, but I removed the trigger "Item Cleanup", also, I did some minor changes and added some triggers, to do the automated tests I described in my last post in this thread. In this map I got the same results. There are no triggers that remove items from the game, yet, they are removed automatically, and there's not any sign of leftover of consumed tomes.

 

[Wareditor]

Yeah it seems this is not needed anymore and the cleanup is now correctly handled by the game.

 

[IronBladeClan]

Oh well, still super useful for pre-reforged clients