Simple Item Cleanup System v1.1 [GUI]

[Moderator]

17 August 2012
Bribe: This is redundant. We already have GUI Item Cleanup which does everything this does but with only 1 trigger.

http://www.hiveworkshop.com/forums/spells-569/item-cleanup-1-2-a-201057/

I will reject this now. Feel free to PM me if you disagree.

22:51, 15th Aug 2012
Magtheridon96: Okay, I don't care about the title now.

This is a pretty weird system.
I mean, I could just drop an item on the ground, and it's gone 5 seconds later ._.

No matter, first of all, it would be beneficial if you just set the life of the items stored in the array to 0.41 and remove instead of enumerating over all items on the map and THEN doing that.

What you could do is register a "Unit Acquires Item" event and destroy the instance instead. (If it exists)

 

[defskull]

Reserved.

 

[Magtheridon96]

Item Cleanup systems don't only remove the item.
They set the life of the item to 0.406 or higher, then remove it.

Also, Bribe already made one for GUIers

 

[defskull]

I thought Bribe only made it for Tomes ?

 

[Kingz]

http://www.hiveworkshop.com/forums/spells-569/item-cleanup-1-2-a-201057/?prev=d%3Dlist%26r%3D20%26u%3DBribe

This one looks better and less complex, not to mention uses less triggers.

I see no reason to approve this with a better resource doing the same job present already.

 

[defskull]

That's why I asked, is that only for Tomes ?
Because I can only see Tomes inside that test map, because "cleaning" Tomes is different with cleaning items.

 

[Kingz]

It works for all items, not tomes.
You could read the triggers and understand that you know.

 

[defskull]

Well, you assume that all people knows how to read triggers rather than just a simple implement ?
You have to do minor adjustment to the Bribe's trigger to support clean item from loot from unit or unit drops item.
Now I only see it cleans Tomes (before adjust)

Well, my system is that once you have implement, it supports that features automatically without needing to adjust it (well, for configurables, it's different story).

In short, it will make this system user-friendly.

Also, to compare Bribe's and mine, it's 2 different thing where his system clean Tomes that are leaks upon taking it and mine is cleaning item on the floor dropped by unit or loot.

The systems share the same concept, but different execution of ideas.

 

[Kingz]

What the hell are you talking about?

Bribe's system automatically cleans all dead items every 15 seconds, not just tomes.
And it is easier to implement and use.

However seeing as this does a another thing (the title is missleading a bit), you shouldn't use a 0.03 second timer, it is redundant, no one will want their items removed after 0.03 seconds, put it to a more sensible interval (1.0 seconds for example.)

 

[defskull]

Bribe's does not automatically allow the dropped/loot item to be registered to the system and be removed after X seconds (I'm talking about normal items, not Tomes), as I said you have to adjust it for yourselves, since that is not the point of a "system". A system will keep you as easy as possible, just like my system, you don't need the adjustment, just a simple copy and paste, there, it is installed.

For Bribe, it is heavily focused on Tomes leak (after taking Tomes), whereas my system is focused on Items on the ground.

As I stated earlier, it's 2 different thing, but shared the same concept.

And I think this statement is a total nonsense;

And it is easier to implement and use.

What's so hard about copying the folder and paste it in your Trigger Editor ?

However for the interval, yeah I think change it to 1.00 second per interval would be more sensible.

 

[defskull]

Updated to v1.1, name of the system is still in consideration because it's pretty straightforward, Item Cleanup, wonder why should I change it...

 

[Bribe]

defskull, my Item Cleanup removes all items, just like the previous posters said. Not just tomes. So it does everything yours does, with less code.