[GUI] Simple Stop Regeneration System v1.1 [GUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

05:14, 26th Aug 2012
Magtheridon96: Fix the healing bug by providing an onHeal trigger. The user would just set the healed unit, and you would do the work to fix the stored amount.

By the way, in my maps, i code regeneration from scratch just so I can do these things with no trouble ;p

 

[defskull]

Reserved.

If you guys can help me list out the possibilities of a unit to have a decrease/increase of its HP/MP, I'd be gladful

Currently for HP;
- Takes damage
- Healed by spells
- Using spells that damages Caster (just thought about this, will implement in next version)

Currently for MP (next version);
- Uses spell (that uses Mana)
- Spells that gives Mana

 

[baassee]

Personally, I don't like playing with a unit's HP but this seems fair enough.

As you seem to like to play with custom scripts let me help you on that part.


Save Trigger.

• Unit - Set life of SR_FreezeUnit to ((Life of SR_FreezeUnit) + SR_HealValue)

-->>>>

call SetWidgetLife(udg_FreezeUnit, GetWidgetLife(udg_FreezeUnit) + udg_SR_HealValue)

• Set SR_FreezeHP = (Life of SR_FreezeUnit)

-->>>>

set udg_SR_FreezeHP = GetWidgetLife(udg_SR_FreezeUnit)


Loop Trigger.

• Unit - Set life of SR_FreezeUnit to (Load 1 of SR_Key from SR_Hashtable)

-->>>>

call SetWidgetLife(udg_FreezeUnit, LoadReal(udg_SR_Hashtable, udg_SR_Key, 1))

Damage Taken Trigger.

I personally don't know why you use these locals, they're pretty useless here. You have to understand when storing is good and when it's not good and it's not useful when you only use things once.

You should replace all those actions to just this.

set udg_SR_FreezeHP = GetWidgetLife(udg_GDD_DamagedUnit) - udg_GDD_Damage
set udg_SR_Key = GetHandleId(udg_GDD_DamagedUnit)

• Hashtable - Save SR_FreezeHP as 1 of SR_Key in SR_Hashtable

Ah I remember when you could shadow globals, lovely time.

I guess I could say more things but I mentioned the most important. Playing with HP in GUI is rather slow and these actions does not exist in the GUI table (AFAIK) so I helped you out with the line of codes.

 

[defskull]

So the main code would be WidgetLife function, eh ?
I'll change that !

LOL I forgot that Weep's system already provide those globals, why the hell I created locals for it >.>"

Also, if you're giving me these suggestions (changing it to function in JASS instead BJs converted by GUI), it's better I convert all the function to JASS, does it ?

v1.1 is uploaded.

 

[baassee]

Nah keep it GUI, people tend to not find JASS stuff as interesting.
They're not suggestions - GUI uses GetUnitState (or actually GetUnitStateSwap) - which are slower than GetWidgetLife. Although GetWidgetMana does not exist thus GetUnitState to get mana is the only option when you want to retrive a unit's MP. Lots of these stuff in JASS as GetUnitX > GetWidgetX (where GetUnitX is faster than GetWidgetX) and such.

GUI is just made of BJs thus the coder him/herself must update the code if it is not fast enough.

EDIT:

Maybe you should update the title of the resource - still v1.0 ^^

 

[edo494]

GUI actually uses few natives, KillUnit for instance
as newcomer finding lots of SetWidgetLife custom scripts is just what is that? and GUI is not that slow to drop FPS if you know what you are doing
if speed is all that matters why make GUI system hmmm...(to baassee)
Ill test this later and give you some feedback

 

[defskull]

if speed is all that matters why make GUI system hmmm...(to baassee)

Because it's for GUI-users
That does not want to install JNGP.

But you've got point, if we're so afraid of speed of trigger, why approve GUI Trigger ?

But baassee also got his point, SOME of the function (SOME of it), really needs to change GUI function to JASS ones (because he sees that I play with Custom script very much), then he's thinking "why not you do this if you understand some of JASS functions ?"

Like SetUnitX/Y > SetUnitPositionLoc
AddLightningEx > AddLightningLoc

And so on.

 

[baassee]

Cause GUI will always be GUI. Most BJs can be removed by optimizing map with Vexorian's optimizer to remove the most useless ones (like PauseUnitBJ).

It is slow if you think of the amount of extra calls you can save if you do everything in complete custom script ^^ I just make systems for GUIers, made in all languages anyway.

 

[defskull]

Well if it's fully turned to Custom script, we would not call it GUI any longer eh ?

 

[baassee]

Well if it's fully turned to Custom script, we would not call it GUI any longer eh ?

I would. For me everything is GUI until you convert the trigger to text

 

[defskull]

Custom script is text !
Lol enough >.>"

 

[edo494]

problem with those:
hardcoded heals doesnt work, if I cas heal for instance it will not heal him and it could get changed(checking if the difference is lower then xy(10 for example)) may do the trick

 

[defskull]

Ahhh normal heal such as Holy Light ?
I don't know, pretty much you have to trigger all your healing spells :/

Checking difference (like 10 for example) won't work because what if the unit has regen > CheckingValue ?
It runs the trigger, thus saves new HP for the unit (doesn't work this way).

 

[edo494]

well, I made it that way(in vJass tho) and it works because it loops every 0.005 seconds and checks if the difference is less then 2 which means the unit must have 2500 hp/sec regeneration

 

[defskull]

which means the unit must have 2500 hp/sec regeneration

Which is possible, you understand me ?
I saw some crazy map-makers put their Bosses HP like 100,000,0 so the HP Regen is like 5000/second
And the unit dealing damage like 7000 per hit

Thing is possible.

 

[edo494]

well yes, everything has its limits but this is still nice and works even on 10000 regen(tested it, it flashed his life from 13 to 30 but still reverted to 13)
Nice job

 

[defskull]

flashed his life from 13 to 30 but still reverted to 13

Well this is because the interval < natural HP regen
You said that natural HP regen occurs once every 0.005s, right ?
0.005 is so small compared to 0.03, that's why.

I can of course lower the interval, but I'm afraid it would lag the game while this system is in effect (I want to lower it to 0.01, but that would make it 100 checks per second)

 

[edo494]

well, you can test it
btw the 0.005 may not be exact, its more like interval <0.0045, 0.0055> because when I displayed health of unit every 0.00125 second(crazy ) it showed the same number 4 times, 4*0.00125 is 0.005 but it doesnt need to be that fast really
I think its fine as it is but its good to let people know they have to trigger their heals but its not big deal

 

[Magtheridon96]

When I made GetUnitRegeneration, i coded an entire heal system with events just so it could work.

 

[nedio95]

Reserved.

If you guys can help me list out the possibilities of a unit to have a decrease/increase of its HP/MP, I'd be gladful

Currently for HP;
- Takes damage
- Healed by spells
- Using spells that damages Caster (just thought about this, will implement in next version)

Currently for MP (next version);
- Uses spell (that uses Mana)
- Spells that gives Mana

Spells which destroy mana... Mana burn, Feedback etc.

 

[edo494]

this is primally made to stop units regeneration as the topic name says, the list is only what this is capable off when he updates it(possibly)
I suggest you that you could pre-code to the map the hard coded abilities that heals to give people better example how to do it