Simple Item Bound System v1.1 [GUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

08:52, 17th Aug 2012
Magtheridon96: Okay, the boolean check doesn't actually make it better than the previous version.
You're not supposed to save any boolean of any kind, just the player id.
You would check if the player id has been stored in the hashtable.

 

[defskull]

Reserved.

 

[Magtheridon96]

How about making this function when the player issues a 'smart' order on an item instead?

 

[defskull]

How about making this function when the player issues a 'smart' order on an item instead?

What ?
I don't get it.

You issue a 'smart' order and poof, the item is yours ?

 

[edo494]

no, I guess he means that this system would check whos the item is when you right click it("smart" order) rather then when you pick it up.

 

[defskull]

Well if that's the idea, it is awesome
Might add that feature for the next version.

But that would require a check of order string per order by player, it would lag throughout the game ?
Because the event is Unit - A unit is issued an order targeting an object, that occurs each time the player order unit(s) to move right ?

Player won't move their unit by using the "Move" ability, but instead just 'smart' order.

 

[edo494]

move is a point, object means when you right click some object, unit, tree, building
smart is right clicking however
well, you can check if the target of issued order is item in conditions.

 

[defskull]

move is a point, object means when you right click some object, unit, tree, building
smart is right clicking however
well, you can check if the target of issued order is item in conditions.

Ahhh this could be nice if we can totally prevent the unit to acquire item that is near to them.
Because my plan is to order 'Stop' to a unit that order 'smart' to an item that does not belong to that player owning the unit.
This works well, but, I must put a Wait of 0.00 seconds before I order the unit to stop (if I don't put the Wait of 0.00 seconds, the unit will ignore the 'Stop' order via triggers, because it happens too fast).

Well, even a Wait of 0.00 seconds has its own delay, it has no problem when the item is afar from the unit (let's say the unit is 600 range from the item), it has a small delay like 0.25 seconds before the unit is stopped, therefore the unit succeed to move like 100 ~ 150 range towards the item before it is stopped and the Floating Text appears.

But, when the Unit and the Item is close (minimum pick item range), the unit is too close and the order is too slow, causing the unit to pick that item first before it can be stopped by ordering 'Stop' order via trigger.

It is flawed when near, but works good when afar.

Therefore, I'd like to stick to the current method.

 

[edo494]

do what Bribe(Appologies, again, the b and d are so similar...) did in his GUI friendly DDS(idk if he did it with the timers but he did that ExecuteFunc thingy).

• Events - whatever
• Conditions - whatever
• Actions -
  • Custom script: call ExecuteFunc("ThisFunc")
  • Custom script: endfunction
  • Custom script:
  • Custom script: function TheTimerExpiresHere takes nothing returns nothing
  • Custom script: local timer t = GetExipredTimer()
  • Custom script: call BlaBlaBla...
  • Custom script: call DestroyTimer(t)
  • Custom script: set t = null
  • Custom script: endfunction
  • Custom script:
  • Custom script: function ThisFunc takes nothing returns nothing
  • Custom script: local timer t
  • Custom script: if ... then
  • Custom script: set t = CreateTimer() // this is because we dont want to create timer every time the unit is ordered, if you dont filter it right in the Conditions.
  • Custom script: call TimerStart(t, 0.00, false, function TheTimerExpiresHere)
  • Custom script: endif
  • Custom script: set t = null
  • Custom script: endfunction

of course not every line needs to be custom script but to give you idea how to do it.
However remember that if you start timer and you want it to expire in function inside the trigger then you must have the function ABOVE it.

You can also just create one more trigger with event - thetimer expires with global timer which exires in 0.00 and when it expires do the stop order etc...

 

[Kingz]

Isn't this a bit too simple?
It revolves around you saving data to hashtables using the handle of the item and then just checking the data later.

I guess it could be a good sample, but nothing anyone can't make in about 10 minutes if they know how to use a hashtable.

 

[edo494]

simple is not necessarily useless.
Downloading this takes less then 10 minutes so you still save time

 

[Kingz]

Yes but the spell section should still hold a minimal standard of a resource's use.
Not saying this doesn't meet the minimal requirements, that is up for the moderator to decide, i am just pointing out that it is really simple and easy to make yourself.

 

[defskull]

do what bride did in his GUI friendly DDS(idk if he did it with the timers but he did that ExecuteFunc thingy).

• Events - whatever
• Conditions - whatever
• Actions -
  • Custom script: call ExecuteFunc("ThisFunc")
  • Custom script: endfunction
  • Custom script:
  • Custom script: function TheTimerExpiresHere takes nothing returns nothing
  • Custom script: local timer t = GetExipredTimer()
  • Custom script: call BlaBlaBla...
  • Custom script: call DestroyTimer(t)
  • Custom script: set t = null
  • Custom script: endfunction
  • Custom script:
  • Custom script: function ThisFunc takes nothing returns nothing
  • Custom script: local timer t
  • Custom script: if ... then
  • Custom script: set t = CreateTimer() // this is because we dont want to create timer every time the unit is ordered, if you dont filter it right in the Conditions.
  • Custom script: call TimerStart(t, 0.00, false, function TheTimerExpiresHere)
  • Custom script: endif
  • Custom script: set t = null
  • Custom script: endfunction

of course not every line needs to be custom script but to give you idea how to do it.
However remember that if you start timer and you want it to expire in function inside the trigger then you must have the function ABOVE it.

You can also just create one more trigger with event - thetimer expires with global timer which exires in 0.00 and when it expires do the stop order etc...

By using global timer of expiring time of 0.00, are you sure it will stop the unit instantly ?
Meaning that, even if the unit is in minimum range of item pick, the 0.00 timer, helps ?
I don't think so, but I did not test it yet.

Isn't this a bit too simple?
It revolves around you saving data to hashtables using the handle of the item and then just checking the data later.

I guess it could be a good sample, but nothing anyone can't make in about 10 minutes if they know how to use a hashtable.

And yeah, THW consists of community that knows how to use Hashtable / Indexing.
There are no person at all in this community that don't know how to handle Hashtable / Indexing.
This system is aimed for people like Bribe, Magtheridon, Pharaoh_, yeah, they should use this system, it suits for them.
This system is not suitable at all for person that don't know Hashtable / Indexing, not at all.

i am just pointing out that it is really simple and easy to make yourself.

Like I said, all person in THW knows how to handle data with Hashtable / Indexing, there are no person at all that don't know Hashtable / Indexing, all has the same ability like you, to create this easy system in 10 minutes.

 

[edo494]

There are no person at all in this community that don't know how to handle Hashtable / Indexing.
This system is aimed for people like Bribe, Magtheridon, Pharaoh_, yeah, they should use this system, it suits for them.
This system is not suitable at all for person that don't know Hashtable / Indexing, not at all.

lol at the sarcasm

LOL AT there actually is (sarcasm)

it runs instantly after the last started thread/t/whatever I assume as its 0.00, it runs right after you start turning.
Even Damage detection systems uses it because if you dont use wait and for instance heal the unit you heal him and then he takes damage so you not really heal anything

 

[defskull]

it runs instantly after the last started thread/t/whatever I assume as its 0.00, it runs right after you start turning.

By mean "turning", are you referring to the turning Movement - Turn Rate ?
Well if you are referring to this, it can be done if the item is at the back of the unit (provided that the unit must turn back first before acquiring the item, therefore time can be delayed there).

But what happens if the item is at in front of the unit... ?
I bet it would be instant, meaning that the item is still acquired by the unit, only then the unit is issued stop order (too late)

 

[edo494]

It works, tested this:

globals
    unit u
endglobals

function TehTimer takes nothing returns nothing
    local timer t = GetExpiredTimer()
    call IssueImmediateOrder(u, "stop")
    call BJDebugMsg("This Item Is Not YOURS!!!")
    call DestroyTimer(t)
    set t = null
endfunction

function Trig_Untitled_Trigger_001_Conditions takes nothing returns boolean
    local timer t
    set u = GetTriggerUnit()
    if GetOrderTargetItem() == gg_item_ratf_0010 then
        set t = CreateTimer()
        call TimerStart(t, 0.00, false, function TehTimer)
    endif
    set t = null
    return false
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_001 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_001 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_001, EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER )
    call TriggerAddCondition( gg_trg_Untitled_Trigger_001, Condition( function Trig_Untitled_Trigger_001_Conditions ) )
endfunction

and it fires even before you start turning to pickup item, I was staying right on the item and you still wont pick it up
you just need to loop through the hashtable.
Also Im using Condition as actions because its a lot faster, you can still use actions as normally.

edit: Instead of using Unit - order blabla to stop you can use custom script: call IssueImmediateOrder(whichunit, "stop"), I think its a little bit faster

 

[Maker]

You don't necessarily need the IsOwned boolean, you can check whether the player data exists or not instead.

 

[Kingz]

Like I said, all person in THW knows how to handle data with Hashtable / Indexing, there are no person at all that don't know Hashtable / Indexing, all has the same ability like you, to create this easy system in 10 minutes

And if i were as snappy as you i could say that not everyone knows to open up the trigger editor thus even simple spells should be allowed in the spell section, which is plain dumb.

Your reaction to the plain fact i pointed out doesn't make this system any more useful nor any more better, it just shows you can't take any kind of criticism well.

And to think you actually think other people ruin your "reputation" other than you.

 

[Tank-Commander]

Well, bar the floating text, this system Would/Could be as short as 13 lines. (assuming modified to just check the owners instead of using the pretense checker of it being owned by anybody and see if the data exists as Maker said) The floating text part of this system, is actually longer than the "functioning" part of the system, as it is 16 lines, just thought it'd be worth pointing out.

Additionally, thought it was worth pointing out, that the map makers, whom make "decent" maps, tend to know about leaks/removing leaks and are actually not that code blind. They -probably- would know how to go about creating this, it saves time, but I thought that was worth knowing.

As for my critique, I don't have much to add other than to do as Maker suggests to further compact it.

 

[defskull]

You don't necessarily need the IsOwned boolean, you can check whether the player data exists or not instead.

How to check Player Data... ?

And if i were as snappy as you i could say that not everyone knows to open up the trigger editor thus even simple spells should be allowed in the spell section, which is plain dumb.

You stated that as if all people on THW are a professional triggerer, compared to my current setup trigger, it's easier to configure rather than to do it for yourselves.
Don't think all person has the same capabilities as you.

Your reaction to the plain fact i pointed out doesn't make this system any more useful nor any more better, it just shows you can't take any kind of criticism well.

If you have your opinion, what makes you think that other people can't share their opinions too ?
I just shared my opinion, who said I was flaming and raging about the opinion you stated earlier ?

And to think you actually think other people ruin your "reputation" other than you.

This is getting personal, don't bring other thread's problem to another thread, it looks you're harassing, seriously stop it.

Kingz, I'm afraid I have to ask you to stop further commenting on this thread, I hate to argue with you any further, just drop it.
Just leave if you have nothing to say about the resource itself, your opinion will stay as your opinion, just focus on the resource, not the "idea" of it like "hey diz iz stoopeed sistem me can doo it in liek 5 minit".

 

[Kingz]

You stated that as if all people on THW are a professional triggerer, compared to my current setup trigger, it's easier to configure rather than to do it for yourselves.
Don't think all person has the same capabilities as you.

Don't turn this against me, i didn't start this argument i shared a valid opinion to which you responded with hostility.

On the resource itself:
It is missing a configuration block, all of the following should be configurable:
* Message layout which is shown
* Message color
* Message size
* Texttag velocity
* Texttag duration
* Texttag fade period
* Texttag z offset

And all of it should be present in the map initialization trigger with more documentation since if this is to be a system, hardcoded values shouldn't be present in such a number, you have to make it configurable.

 

[Maker]

How to check Player Data... ?

Boolean -> Hashtable value exists

 

[defskull]

* Message layout which is shown

What other message would it be other than showing that whose item is it ?
I guess the current message is pretty clear for this particular system.

* Message color

I already included message color to vary with Player Color, what's more to it ?
For the basic message, I colored it a bit gold, I think that color pretty much emphasize on the message.

* Message size

Current size is readable, that's good enough.

* Texttag velocity
* Texttag duration
* Texttag fade period
* Texttag z offset

I might or might not include these configurables, since it is not the main focus of this system, also, current setup gives much time for the Player to read it (3 seconds), I think that's good enough.

Boolean -> Hashtable value exists

How do I do this in trigger ?
I'm still quite unsure what you're talking about.

 

[Kingz]

Hardcoded values aren't allowed in most systems, almost all constants have to be configurable for the user to configure at their free will.

 

[defskull]

Make the text tag values configurable

Done

if HaveSavedInteger(udg_hashtable, key1, key2) then
    // the item is owned blabla
    // blablabla
else
    // the item is not owned
    // blablabla
endif

Okay, changed it.
But I wanna know this, what's the difference between using this method and my method ?
Is it just to improve performance ?

 

[Magtheridon96]

It's actually just to reduce script size by a bit.
This way, you get rid of a variable

 

[MortAr]

You can give the unit a "Move" order at its current position instead of "Stop" it will not ignore it, and it works the same as stop.
Also I don't think texttags is the best way to inform a player if the item does not belong to him. You could've used this:

call DisplayTimedTextToPlayer (GetOwningPlayer(GetTriggerUnit), 0.52, 0.96, 2.00, "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nERROR HERE.|r")

It prints a message similar to the basic Warcraft 3 error messages.
And even more, you can add a protection trigger that disables players to destroy (attack) an item which again doesn't belong to them.

 

[defskull]

Ahaha yeah SimError, forgot about it, I'll change it.

 

[defskull]

Okay, the boolean check doesn't actually make it better than the previous version.
You're not supposed to save any boolean of any kind, just the player id.
You would check if the player id has been stored in the hashtable.

Can you show me the most easiest example that you can think of ?
I have no idea what you were trying to say.

 

[Kingz]

HaveSavedPlayer() function i think.

Or save player id in hashtable then use HaveSavedInteger().