whats the best method to use?

[Bond009]

whats the best way to make this group then remove it for leaks

• Set Temp_PlayerGroup = (All players matching (((Name of (Matching player)) Equal to PlayerName) or (((Name of (Matching player)) Equal to PlayerName2) or (((Name of (Matching player)) Equal to PlayerName3) or ((Name of (Matching player)) Equal to PlayerName4)))))

or like this

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • (Name of (Picked player)) Equal to PlayerName
            • (Name of (Picked player)) Equal to PlayerName2
            • (Name of (Picked player)) Equal to PlayerName3
            • (Name of (Picked player)) Equal to PlayerName4
      • Then - Actions
        • Player Group - Add (Picked player) to Temp_PlayerGroup
      • Else - Actions

then at the end of what im doing remove with this
call DestroyForce(udg_Temp_PlayerGroup)

for the sake of it being easier to add names i would like to be able to use the 2nd one but does that work the same way as the first for destroying a player group to clean leaks?
Or if i do it the 2nd way does the group even need to be cleaned if i just use

• Player Group - Remove all players from Temp_PlayerGroup

?

 

[Rheiko]

first of all, it's your choice to use first or second method
if you use the second one.. why you add it to Tempplayergroup?
if you add it to a group for another use, just destroyforce it

Edit: i'm not sure if you must destroy it.. because Ralle said, if you destroy All Players it may cause problem

 

[Maker]

I would use the All Players option since the first one leaks, you can't prevent that in GUI.

 

[IcemanBo]

Second methode is easier to modify, and in first you have to watch carefully if you want to change something.

And in second you could use variable 'P' of type Player, and set P = Picked Player in your loop

 

[Bond009]

good i like the 2nd one better for editing anyway

I would use the All Players option since the first one leaks, you can't prevent that in GUI.

i thought call DestroyForce(udg_Temp_PlayerGroup) removed the leak

also i guess i could just make this a perma player group even thought its not fully needed.. but doesnt a player group leak when you make 1 or add players to it? it will take up that memory that whole game right? i understand how temp groups work but what about perma groups that are made?

 

[Maker]

When you create a player group in GUI, it uses a local variable and doesn't null it. The leak is very tiny, but a leak none the less.

 

[FUJI]

The 2nd is better than 1st, because the 1st will leaving an earth!
It will make the users confuse in 1st

 

[Bond009]

When you create a player group in GUI, it uses a local variable and doesn't null it. The leak is very tiny, but a leak none the less.

so even with the script to remove the leak there is still a leak? does that not null it by destroying the group?

 

[Maker]

so even with the script to remove the leak there is still a leak? does that not null it by destroying the group?

Yes. No.

 

[Bond009]

then couldnt we just use a jass script to null it then destroy it..? just like in jass

 

[TriggerHappy]

then couldnt we just use a jass script to null it then destroy it..? just like in jass

The leak is within the BJ function itself (which we have no access to).

 

[Bond009]

could you use scripts for that group creation then? so there is no leaks and a BJ function isnt used.

 

[Maker]

Custom script : call GroupEnumUnitsInRange(bj_lastCreatedGroup, x, y, radius, null) Unit Group - Pick every unit in (Last created unit group) and do (Actions) Loop - Actions Set unit = (Picked unit) If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (unit is dead) Equal to False (unit is A structure) Equal to False Then - Actions Else - Actions

 

[Cokemonkey11]

People didn't even know that not nulling variables leaked until fairly recently. If you're using GUI and you're destroying the group, it's probably good enough for now.